207388 2020-02-07 09:34:08 -0800 [Win] Two FileSystem API tests fail 2020-02-07 14:30:19 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned benjamin bfulgham cdumez cmarcelo commit-queue dbates don.olmstead ews-watchlist webkit-bug-importer oldest_to_newest 1616187 0 stephan.szabo 2020-02-07 09:34:08 -0800 FileSystemTest.UnicodeDirectoryName fails because directoryName takes off \ but not / from the ends of paths causing a mismatch with the expected result. As PathFindFileName appears to stop at either, we probably should remove either from the end. FileSystemTest.GetFileMetadataSymlink has two issues. * First, creating a symlink appears to be returning the wrong truth value for success because CreateSymbolicLinkW returns zero on failure and non-zero on success (https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createsymboliclinkw). * Second, GetFinalPathNameByHandleW with VOLUME_NAME_NT appears to return a path that FindFirstFileW fails to open (I get paths starting with something like "\Device\HarddiskVolume6\"). 1616199 1 390092 stephan.szabo 2020-02-07 09:46:38 -0800 Created attachment 390092 Patch 1616369 2 390092 commit-queue 2020-02-07 14:29:22 -0800 Comment on attachment 390092 Patch Clearing flags on attachment: 390092 Committed r256063: <https://trac.webkit.org/changeset/256063> 1616370 3 commit-queue 2020-02-07 14:29:23 -0800 All reviewed patches have been landed. Closing bug. 1616371 4 webkit-bug-importer 2020-02-07 14:30:19 -0800 <rdar://problem/59273901> 390092 2020-02-07 09:46:38 -0800 2020-02-07 14:29:22 -0800 Patch 207388.1.diff text/plain 2521 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYjcxYTM5NDM1N2UuLjUzMWQwYzJhNTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIw LTAyLTA3ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAg ICBbV2luXSBUd28gRmlsZVN5c3RlbSBBUEkgdGVzdHMgZmFpbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3Mzg4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvd2luL0ZpbGVTeXN0ZW1XaW4uY3Bw OgorICAgICAgICBNYWtlIGdldEZpbmFsUGF0aE5hbWUgcmV0dXJuIGRvcyBwYXRoIHJhdGhlciB0 aGFuIG50IHZvbHVtZSBwYXRoLgorICAgICAgICBDaGFuZ2UgY3JlYXRlU3ltYm9saWNMaW5rIHJl dHVybiB0byBtYXRjaCBDcmVhdGVTeW1ib2xpY0xpbmtXCisgICAgICAgIEhhdmUgZGlyZWN0b3J5 TmFtZSBzdHJpcCB0cmFpbGluZyBzbGFzaGVzLgorCiAyMDIwLTAyLTA0ICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSW50cm9kdWNlIFVubGlua2Vk Q29kZUJsb2NrR2VuZXJhdG9yIGFuZCByZWR1Y2Ugc2l6ZW9mKFVubGlua2VkQ29kZUJsb2NrKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvd2luL0ZpbGVTeXN0ZW1XaW4uY3BwIGIvU291cmNl L1dURi93dGYvd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCmluZGV4IDU4NTQwZGI3OGM4Li45MzM0YWMw MjlkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCisr KyBiL1NvdXJjZS9XVEYvd3RmL3dpbi9GaWxlU3lzdGVtV2luLmNwcApAQCAtMTUxLDggKzE1MSw5 IEBAIHN0YXRpYyBTdHJpbmcgZ2V0RmluYWxQYXRoTmFtZShjb25zdCBTdHJpbmcmIHBhdGgpCiAg ICAgaWYgKCFpc0hhbmRsZVZhbGlkKGhhbmRsZSkpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsK IAotICAgIFZlY3RvcjxVQ2hhcj4gYnVmZmVyKE1BWF9QQVRIKTsKLSAgICBpZiAoOjpHZXRGaW5h bFBhdGhOYW1lQnlIYW5kbGVXKGhhbmRsZSwgd2NoYXJGcm9tKGJ1ZmZlci5kYXRhKCkpLCBidWZm ZXIuc2l6ZSgpLCBWT0xVTUVfTkFNRV9OVCkgPj0gTUFYX1BBVEgpIHsKKyAgICAvLyBWT0xVTUVf TkFNRV9ET1MgY2FuIHJldHVybiBhIFxcP1wgcHJlZml4ZWQgcGF0aCwgc28gaXQgY2FuIGJlIGxv bmdlciB0aGFuIE1BWF9QQVRICisgICAgVmVjdG9yPFVDaGFyPiBidWZmZXIoMzI3NjgpOworICAg IGlmICg6OkdldEZpbmFsUGF0aE5hbWVCeUhhbmRsZVcoaGFuZGxlLCB3Y2hhckZyb20oYnVmZmVy LmRhdGEoKSksIGJ1ZmZlci5zaXplKCksIFZPTFVNRV9OQU1FX0RPUykgPj0gMzI3NjgpIHsKICAg ICAgICAgY2xvc2VGaWxlKGhhbmRsZSk7CiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKICAgICB9 CkBAIC0yMjEsNyArMjIyLDcgQEAgT3B0aW9uYWw8RmlsZU1ldGFkYXRhPiBmaWxlTWV0YWRhdGFG b2xsb3dpbmdTeW1saW5rcyhjb25zdCBTdHJpbmcmIHBhdGgpCiAKIGJvb2wgY3JlYXRlU3ltYm9s aWNMaW5rKGNvbnN0IFN0cmluZyYgdGFyZ2V0UGF0aCwgY29uc3QgU3RyaW5nJiBzeW1ib2xpY0xp bmtQYXRoKQogewotICAgIHJldHVybiAhOjpDcmVhdGVTeW1ib2xpY0xpbmtXKHN5bWJvbGljTGlu a1BhdGgud2lkZUNoYXJhY3RlcnMoKS5kYXRhKCksIHRhcmdldFBhdGgud2lkZUNoYXJhY3RlcnMo KS5kYXRhKCksIDApOworICAgIHJldHVybiA6OkNyZWF0ZVN5bWJvbGljTGlua1coc3ltYm9saWNM aW5rUGF0aC53aWRlQ2hhcmFjdGVycygpLmRhdGEoKSwgdGFyZ2V0UGF0aC53aWRlQ2hhcmFjdGVy cygpLmRhdGEoKSwgMCk7CiB9CiAKIGJvb2wgZmlsZUV4aXN0cyhjb25zdCBTdHJpbmcmIHBhdGgp CkBAIC0zMTYsOCArMzE3LDkgQEAgU3RyaW5nIHBhdGhHZXRGaWxlTmFtZShjb25zdCBTdHJpbmcm IHBhdGgpCiBTdHJpbmcgZGlyZWN0b3J5TmFtZShjb25zdCBTdHJpbmcmIHBhdGgpCiB7CiAgICAg U3RyaW5nIG5hbWUgPSBwYXRoLmxlZnQocGF0aC5sZW5ndGgoKSAtIHBhdGhHZXRGaWxlTmFtZShw YXRoKS5sZW5ndGgoKSk7Ci0gICAgaWYgKG5hbWUuY2hhcmFjdGVyU3RhcnRpbmdBdChuYW1lLmxl bmd0aCgpIC0gMSkgPT0gJ1xcJykgewotICAgICAgICAvLyBSZW1vdmUgYW55IHRyYWlsaW5nICJc Ii4KKyAgICBpZiAobmFtZS5jaGFyYWN0ZXJTdGFydGluZ0F0KG5hbWUubGVuZ3RoKCkgLSAxKSA9 PSAnXFwnCisgICAgICAgIHx8IG5hbWUuY2hhcmFjdGVyU3RhcnRpbmdBdChuYW1lLmxlbmd0aCgp IC0gMSkgPT0gJy8nKSB7CisgICAgICAgIC8vIFJlbW92ZSBhbnkgdHJhaWxpbmcgIlwiIG9yICIv IgogICAgICAgICBuYW1lLnRydW5jYXRlKG5hbWUubGVuZ3RoKCkgLSAxKTsKICAgICB9CiAgICAg cmV0dXJuIG5hbWU7Cg==