207385 2020-02-07 08:33:10 -0800 http/tests/paymentrequest/page-cache-completed-payment-response.https.html is flaky failing. 2020-04-23 10:26:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j cdumez aestes cdumez webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1616156 0 Lawrence.j 2020-02-07 08:33:10 -0800 http/tests/paymentrequest/page-cache-completed-payment-response.https.html Description: This test is flaky failing on Mac wk2. History: https://results.webkit.org/?platform=ios&platform=mac&suite=layout-tests&test=http%2Ftests%2Fpaymentrequest%2Fpage-cache-completed-payment-response.https.html Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/http/tests/paymentrequest/page-cache-completed-payment-response.https-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/http/tests/paymentrequest/page-cache-completed-payment-response.https-actual.txt @@ -9,9 +9,10 @@ pageshow - from cache PASS Page did enter and was restored from the back/forward cache Testing that PaymentResponse remains in the Completed state. -PASS response.complete() rejected promise with InvalidStateError: The object is in an invalid state.. -PASS response.retry() rejected promise with InvalidStateError: The object is in an invalid state.. +FAIL response.complete() should reject promise with InvalidStateError. Rejected with AbortError instead. +FAIL response.retry() should reject promise with InvalidStateError. Rejected with AbortError instead. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1616161 1 Lawrence.j 2020-02-07 08:36:11 -0800 I was able to reproduce this issue with the following command: run-webkit-tests http/tests/paymentrequest/page-cache-completed-payment-response.https.html --iterations 5000 260 tests ran as expected, 13 didn't (4727 didn't run): 1616162 2 webkit-bug-importer 2020-02-07 08:36:37 -0800 <rdar://problem/59260167> 1616185 3 Lawrence.j 2020-02-07 09:32:01 -0800 I have adjusted the expectations for this test, so it will now pass on failure while this is being investigated. https://trac.webkit.org/changeset/256025/webkit 1616617 4 ap 2020-02-08 14:42:17 -0800 This is a test for "PaymentRequest / PaymentResponse should not prevent entering the back/forward cache". 1629418 5 cdumez 2020-03-12 16:55:15 -0700 Committed r258373: <https://trac.webkit.org/changeset/258373> 1633393 6 Lawrence.j 2020-03-24 11:17:15 -0700 It looks like this issue is still occurring on Mac wk2 Debug. The diff has changed slightly. History: https://results.webkit.org/?platform=mac&suite=layout-tests&test=http%2Ftests%2Fpaymentrequest%2Fpage-cache-completed-payment-response.https.html&style=debug Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/tests/paymentrequest/page-cache-completed-payment-response.https-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/tests/paymentrequest/page-cache-completed-payment-response.https-actual.txt @@ -9,8 +9,8 @@ pageshow - from cache PASS Page did enter and was restored from the back/forward cache Testing that PaymentResponse remains in the Completed state. -PASS response.complete() rejected promise with InvalidStateError: The object is in an invalid state.. -PASS response.retry() rejected promise with InvalidStateError: The object is in an invalid state.. +PASS response.complete() rejected promise with AbortError: The operation was aborted.. +PASS response.retry() rejected promise with AbortError: The operation was aborted.. PASS successfullyParsed is true TEST COMPLETE 1644809 7 397351 cdumez 2020-04-23 09:56:32 -0700 Created attachment 397351 Patch 1644838 8 ews-feeder 2020-04-23 10:26:19 -0700 Committed r260579: <https://trac.webkit.org/changeset/260579> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397351. 397351 2020-04-23 09:56:32 -0700 2020-04-23 10:26:19 -0700 Patch bug-207385-20200423095632.patch text/plain 2916 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNTY5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2ViZjAzNjg0ZDYzMjU3YjM5MDYz MTcwMWY5Yzc4ZTBlMjMzOTA1NS4uNzM4NDMwNWEyNDRkZTJiZWE2Y2IzZTU0NTIzMTZiNmUwNGNj ZTcyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTIzICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cC90ZXN0cy9wYXltZW50cmVxdWVzdC9wYWdl LWNhY2hlLWNvbXBsZXRlZC1wYXltZW50LXJlc3BvbnNlLmh0dHBzLmh0bWwgaXMgZmxha3kgZmFp bGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NzM4NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkyNjAxNjc+CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgZm9sbG93LXVwIHRvIHIyNTgzNzMgdG8gc2lsZW5jZSB0aGUgZXJyb3IgbmFtZSB3aGVu IHVzaW5nIHNob3VsZFJlamVjdCgpIGFuZAorICAgICAgICBhY3R1YWxseSBmaXggdGhlIGZsYWtp bmVzcy4KKworICAgICAgICAqIGh0dHAvdGVzdHMvcGF5bWVudHJlcXVlc3QvcGFnZS1jYWNoZS1j b21wbGV0ZWQtcGF5bWVudC1yZXNwb25zZS5odHRwcy1leHBlY3RlZC50eHQ6CisgICAgICAgICog cmVzb3VyY2VzL2pzLXRlc3QuanM6CisgICAgICAgIChzaG91bGRSZWplY3RXaXRoRXJyb3JOYW1l KToKKwogMjAyMC0wNC0yMyAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIEdhcmRlbmluZywgdXBkYXRlIGV4cGVjdGF0aW9ucyBhZnRlciByMjU5 NzA1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BheW1lbnRyZXF1ZXN0L3Bh Z2UtY2FjaGUtY29tcGxldGVkLXBheW1lbnQtcmVzcG9uc2UuaHR0cHMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9wYXltZW50cmVxdWVzdC9wYWdlLWNhY2hlLWNvbXBsZXRl ZC1wYXltZW50LXJlc3BvbnNlLmh0dHBzLWV4cGVjdGVkLnR4dAppbmRleCAyYjZkYzY2MzY0OWNm Y2FjN2U3NWI5NzdlMGU1NjlhNWNlODc0MTk0Li5hOTkxZjcxNDI3MTljZjM1ZTY3Njk1YTUwYjA1 NmUyYjk1ZmIxY2I1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BheW1lbnRy ZXF1ZXN0L3BhZ2UtY2FjaGUtY29tcGxldGVkLXBheW1lbnQtcmVzcG9uc2UuaHR0cHMtZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcGF5bWVudHJlcXVlc3QvcGFnZS1j YWNoZS1jb21wbGV0ZWQtcGF5bWVudC1yZXNwb25zZS5odHRwcy1leHBlY3RlZC50eHQKQEAgLTks OCArOSw4IEBAIHBhZ2VoaWRlIC0gZW50ZXJpbmcgY2FjaGUKIHBhZ2VzaG93IC0gZnJvbSBjYWNo ZQogUEFTUyBQYWdlIGRpZCBlbnRlciBhbmQgd2FzIHJlc3RvcmVkIGZyb20gdGhlIGJhY2svZm9y d2FyZCBjYWNoZQogVGVzdGluZyB0aGF0IFBheW1lbnRSZXNwb25zZSByZW1haW5zIGluIHRoZSBD b21wbGV0ZWQgc3RhdGUuCi1QQVNTIHJlc3BvbnNlLmNvbXBsZXRlKCkgcmVqZWN0ZWQgcHJvbWlz ZSAgd2l0aCBJbnZhbGlkU3RhdGVFcnJvcjogVGhlIG9iamVjdCBpcyBpbiBhbiBpbnZhbGlkIHN0 YXRlLi4KLVBBU1MgcmVzcG9uc2UucmV0cnkoKSByZWplY3RlZCBwcm9taXNlICB3aXRoIEludmFs aWRTdGF0ZUVycm9yOiBUaGUgb2JqZWN0IGlzIGluIGFuIGludmFsaWQgc3RhdGUuLgorUEFTUyBy ZXNwb25zZS5jb21wbGV0ZSgpIHJlamVjdGVkIHByb21pc2UuCitQQVNTIHJlc3BvbnNlLnJldHJ5 KCkgcmVqZWN0ZWQgcHJvbWlzZS4KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAog VEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL2pzLXRlc3Qu anMgYi9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvanMtdGVzdC5qcwppbmRleCAxYWIyMTU1NDJlN2Fj NmVhMzAwYjZhNGNjYmRiODdhN2ZkYjUyYzU2Li45ZTRmMzQ4MDlmNGRiNzM0NGYxNjI1NmFlYjA0 ZTMyMDlhYzliMmUwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvanMtdGVzdC5q cworKysgYi9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvanMtdGVzdC5qcwpAQCAtNzMwLDcgKzczMCw5 IEBAIGZ1bmN0aW9uIHNob3VsZFJlamVjdFdpdGhFcnJvck5hbWUoX2EsIF9uYW1lLCBfbWVzc2Fn ZSkKICAgICByZXR1cm4gX2F2LnRoZW4oZnVuY3Rpb24ocmVzdWx0KSB7CiAgICAgICAgIHRlc3RG YWlsZWQoKF9tZXNzYWdlID8gX21lc3NhZ2UgOiBfYSkgKyAiIHNob3VsZCByZWplY3QgcHJvbWlz ZS4gUmVzb2x2ZWQgd2l0aCAiICsgcmVzdWx0ICsgIi4iKTsKICAgICB9LCBmdW5jdGlvbihlcnJv cikgewotICAgICAgICBpZiAoX25hbWUgPT09IHVuZGVmaW5lZCB8fCBlcnJvclsnbmFtZSddID09 PSBfbmFtZSkgeworICAgICAgICBpZiAoX25hbWUgPT09IHVuZGVmaW5lZCkgeworICAgICAgICAg ICAgdGVzdFBhc3NlZCgoX21lc3NhZ2UgPyBfbWVzc2FnZSA6IF9hKSArICIgcmVqZWN0ZWQgcHJv bWlzZS4iKTsKKyAgICAgICAgfSBlbHNlIGlmIChlcnJvclsnbmFtZSddID09PSBfbmFtZSkgewog ICAgICAgICAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGUgZXh0cmEgc3BhY2UgYW5kICcuJyAoRE9N RXhjZXB0aW9uIGRlc2NyaXB0aW9ucyBhbHJlYWR5IGVuZCB3aXRoIHBlcmlvZHMpIHRoZW4gcmVi YXNlIHRlc3RzLgogICAgICAgICAgICAgdGVzdFBhc3NlZCgoX21lc3NhZ2UgPyBfbWVzc2FnZSA6 IF9hKSArICIgcmVqZWN0ZWQgcHJvbWlzZSAgd2l0aCAiICsgZXJyb3IgKyAiLiIpOwogICAgICAg ICB9IGVsc2UK