207383 2020-02-07 06:52:08 -0800 Add release logging for the case of libwebrtc being not available 2020-02-07 10:27:14 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1616132 0 youennf 2020-02-07 06:52:08 -0800 Add release logging for the case of libwebrtc being not available 1616133 1 390080 youennf 2020-02-07 06:53:38 -0800 Created attachment 390080 Patch 1616134 2 390081 youennf 2020-02-07 07:00:58 -0800 Created attachment 390081 Patch 1616224 3 390081 commit-queue 2020-02-07 10:26:14 -0800 Comment on attachment 390081 Patch Clearing flags on attachment: 390081 Committed r256032: <https://trac.webkit.org/changeset/256032> 1616225 4 commit-queue 2020-02-07 10:26:16 -0800 All reviewed patches have been landed. Closing bug. 1616227 5 webkit-bug-importer 2020-02-07 10:27:14 -0800 <rdar://problem/59263914> 390080 2020-02-07 06:53:38 -0800 2020-02-07 07:00:53 -0800 Patch bug-207383-20200207155336.patch text/plain 2768 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYxNDU3MGJmZmNlNjgx ZjcwN2U5YTQ5MDg2NGJjN2RhYzRiYzQ0ZC4uNGVjZjQyM2Q0NmFhNDU0ZjIzNWIwYzgyMDg3ZmE5 Yjk0OWE4MWJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTA3ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgcmVsZWFzZSBsb2dn aW5nIGZvciB0aGUgY2FzZSBvZiBsaWJ3ZWJydGMgYmVpbmcgbm90IGF2YWlsYWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzgzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGxvZ2dpbmcgaW4g Y2FzZSBvZiBubyBsaWJ3ZWJydGMgZHlsaWIsIGluIGNhc2Ugd2UgdHJ5IHRvIGNyZWF0ZSBhIHBl ZXIgY29ubmVjdGlvbiBvciBhIGxpYndlYnJ0YyBmYWN0b3J5LgorICAgICAgICBObyBjaGFuZ2Ug b2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3Jl YXRlTGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kKToKKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TGliV2ViUlRDUHJvdmlkZXI6OmZhY3RvcnkpOgorCiAyMDIwLTAyLTA3ICB5b3Vlbm4g ZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaWx0ZXIgb3V0IFRVUk4vU1RV TiAubG9jYWwgVVJMcyBmcm9tIGEgUlRDUGVlckNvbm5lY3Rpb24gaWNlU2VydmVycyBsaXN0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kLmNw cAppbmRleCBkMjU0YjM5MDhiOGY2NjMzNjI1N2Q1MzlmMjhkZWEyMWQ5NWUxZDMyLi4zYTBlYTM4 OWY2YTY1ZGNmNmY0ZGIwY2FjMzVkYzczY2ExN2I0NzcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQZWVyQ29ubmVjdGlv bkJhY2tlbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGli d2VicnRjL0xpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHAKQEAgLTUxLDggKzUxLDEw IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxQZWVyQ29u bmVjdGlvbkJhY2tlbmQ+IGNyZWF0ZUxpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZChSVENQ ZWVyQ29ubmVjdGlvbiYgcGVlckNvbm5lY3Rpb24pCiB7Ci0gICAgaWYgKCFMaWJXZWJSVENQcm92 aWRlcjo6d2ViUlRDQXZhaWxhYmxlKCkpCisgICAgaWYgKCFMaWJXZWJSVENQcm92aWRlcjo6d2Vi UlRDQXZhaWxhYmxlKCkpIHsKKyAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoV2ViUlRDLCAiTGli V2ViUlRDIGlzIG5vdCBhdmFpbGFibGUgdG8gY3JlYXRlIGEgYmFja2VuZCIpOwogICAgICAgICBy ZXR1cm4gbnVsbHB0cjsKKyAgICB9CiAKICAgICBhdXRvKiBwYWdlID0gZG93bmNhc3Q8RG9jdW1l bnQ+KCpwZWVyQ29ubmVjdGlvbi5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpLnBhZ2UoKTsKICAg ICBpZiAoIXBhZ2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyLmNwcAppbmRleCBm NWQ0NDNkN2YwMDcyMDJmOTA4NGVjNGM1ZjQ1ZDFiYjUyOWFkZDk4Li5mZmE5NmU4N2MxYjc0NTAz ZTNiZThhZDAyMjE5NTRjM2QwZGYyYWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92 aWRlci5jcHAKQEAgLTI0Nyw4ICsyNDcsMTAgQEAgd2VicnRjOjpQZWVyQ29ubmVjdGlvbkZhY3Rv cnlJbnRlcmZhY2UqIExpYldlYlJUQ1Byb3ZpZGVyOjpmYWN0b3J5KCkKICAgICBpZiAobV9mYWN0 b3J5KQogICAgICAgICByZXR1cm4gbV9mYWN0b3J5LmdldCgpOwogCi0gICAgaWYgKCF3ZWJSVENB dmFpbGFibGUoKSkKKyAgICBpZiAoIXdlYlJUQ0F2YWlsYWJsZSgpKSB7CisgICAgICAgIFJFTEVB U0VfTE9HX0VSUk9SKFdlYlJUQywgIkxpYldlYlJUQyBpcyBub3QgYXZhaWxhYmxlIHRvIGNyZWF0 ZSBhIGZhY3RvcnkiKTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgfQogCiAgICAgYXV0 byYgZmFjdG9yeUFuZFRocmVhZHMgPSBnZXRTdGF0aWNGYWN0b3J5QW5kVGhyZWFkcyhtX3VzZU5l dHdvcmtUaHJlYWRXaXRoU29ja2V0U2VydmVyKTsKIAo= 390081 2020-02-07 07:00:58 -0800 2020-02-07 10:26:14 -0800 Patch bug-207383-20200207160057.patch text/plain 3025 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYxNDU3MGJmZmNlNjgx ZjcwN2U5YTQ5MDg2NGJjN2RhYzRiYzQ0ZC4uNGVjZjQyM2Q0NmFhNDU0ZjIzNWIwYzgyMDg3ZmE5 Yjk0OWE4MWJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTA3ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgcmVsZWFzZSBsb2dn aW5nIGZvciB0aGUgY2FzZSBvZiBsaWJ3ZWJydGMgYmVpbmcgbm90IGF2YWlsYWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzgzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGxvZ2dpbmcgaW4g Y2FzZSBvZiBubyBsaWJ3ZWJydGMgZHlsaWIsIGluIGNhc2Ugd2UgdHJ5IHRvIGNyZWF0ZSBhIHBl ZXIgY29ubmVjdGlvbiBvciBhIGxpYndlYnJ0YyBmYWN0b3J5LgorICAgICAgICBObyBjaGFuZ2Ug b2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3Jl YXRlTGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kKToKKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TGliV2ViUlRDUHJvdmlkZXI6OmZhY3RvcnkpOgorCiAyMDIwLTAyLTA3ICB5b3Vlbm4g ZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBGaWx0ZXIgb3V0IFRVUk4vU1RV TiAubG9jYWwgVVJMcyBmcm9tIGEgUlRDUGVlckNvbm5lY3Rpb24gaWNlU2VydmVycyBsaXN0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kLmNw cAppbmRleCBkMjU0YjM5MDhiOGY2NjMzNjI1N2Q1MzlmMjhkZWEyMWQ5NWUxZDMyLi5mMGVjM2E5 YTFkNjYxZTIxNjhmNjEwZDM4MTZlMjFlZjk4NDgyODExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQZWVyQ29ubmVjdGlv bkJhY2tlbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGli d2VicnRjL0xpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHAKQEAgLTM0LDYgKzM0LDcg QEAKICNpbmNsdWRlICJMaWJXZWJSVENSdHBSZWNlaXZlckJhY2tlbmQuaCIKICNpbmNsdWRlICJM aWJXZWJSVENSdHBTZW5kZXJCYWNrZW5kLmgiCiAjaW5jbHVkZSAiTGliV2ViUlRDUnRwVHJhbnNj ZWl2ZXJCYWNrZW5kLmgiCisjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIk1lZGlhRW5k cG9pbnRDb25maWd1cmF0aW9uLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlJUQ0lj ZUNhbmRpZGF0ZS5oIgpAQCAtNTEsOCArNTIsMTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBz dGF0aWMgc3RkOjp1bmlxdWVfcHRyPFBlZXJDb25uZWN0aW9uQmFja2VuZD4gY3JlYXRlTGliV2Vi UlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kKFJUQ1BlZXJDb25uZWN0aW9uJiBwZWVyQ29ubmVjdGlv bikKIHsKLSAgICBpZiAoIUxpYldlYlJUQ1Byb3ZpZGVyOjp3ZWJSVENBdmFpbGFibGUoKSkKKyAg ICBpZiAoIUxpYldlYlJUQ1Byb3ZpZGVyOjp3ZWJSVENBdmFpbGFibGUoKSkgeworICAgICAgICBS RUxFQVNFX0xPR19FUlJPUihXZWJSVEMsICJMaWJXZWJSVEMgaXMgbm90IGF2YWlsYWJsZSB0byBj cmVhdGUgYSBiYWNrZW5kIik7CiAgICAgICAgIHJldHVybiBudWxscHRyOworICAgIH0KIAogICAg IGF1dG8qIHBhZ2UgPSBkb3duY2FzdDxEb2N1bWVudD4oKnBlZXJDb25uZWN0aW9uLnNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoKSkucGFnZSgpOwogICAgIGlmICghcGFnZSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92 aWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMv TGliV2ViUlRDUHJvdmlkZXIuY3BwCmluZGV4IGY1ZDQ0M2Q3ZjAwNzIwMmY5MDg0ZWM0YzVmNDVk MWJiNTI5YWRkOTguLmZmYTk2ZTg3YzFiNzQ1MDNlM2JlOGFkMDIyMTk1NGMzZDBkZjJhYzEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyLmNwcApAQCAtMjQ3LDggKzI0NywxMCBA QCB3ZWJydGM6OlBlZXJDb25uZWN0aW9uRmFjdG9yeUludGVyZmFjZSogTGliV2ViUlRDUHJvdmlk ZXI6OmZhY3RvcnkoKQogICAgIGlmIChtX2ZhY3RvcnkpCiAgICAgICAgIHJldHVybiBtX2ZhY3Rv cnkuZ2V0KCk7CiAKLSAgICBpZiAoIXdlYlJUQ0F2YWlsYWJsZSgpKQorICAgIGlmICghd2ViUlRD QXZhaWxhYmxlKCkpIHsKKyAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoV2ViUlRDLCAiTGliV2Vi UlRDIGlzIG5vdCBhdmFpbGFibGUgdG8gY3JlYXRlIGEgZmFjdG9yeSIpOwogICAgICAgICByZXR1 cm4gbnVsbHB0cjsKKyAgICB9CiAKICAgICBhdXRvJiBmYWN0b3J5QW5kVGhyZWFkcyA9IGdldFN0 YXRpY0ZhY3RvcnlBbmRUaHJlYWRzKG1fdXNlTmV0d29ya1RocmVhZFdpdGhTb2NrZXRTZXJ2ZXIp OwogCg==