207370 2020-02-06 17:27:00 -0800 macCatalyst: Unnecessary I-beam over images in editable areas 2020-02-07 12:14:03 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton cdumez commit-queue darin dbates esprehn+autocc ews-watchlist kangil.han webkit-bug-importer wenson_hsieh oldest_to_newest 1615949 0 thorton 2020-02-06 17:27:00 -0800 macCatalyst: Unnecessary I-beam over images in editable areas 1615950 1 390034 thorton 2020-02-06 17:27:36 -0800 Created attachment 390034 Patch 1615951 2 thorton 2020-02-06 17:27:38 -0800 <rdar://problem/59235429> 1616022 3 390034 commit-queue 2020-02-06 19:30:47 -0800 Comment on attachment 390034 Patch Clearing flags on attachment: 390034 Committed r256005: <https://trac.webkit.org/changeset/256005> 1616023 4 commit-queue 2020-02-06 19:30:49 -0800 All reviewed patches have been landed. Closing bug. 1616293 5 390034 darin 2020-02-07 12:14:03 -0800 Comment on attachment 390034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390034&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2844 > + if (!node) > + return false; > + RenderObject *renderer = node->renderer(); > + if (!renderer) > + return false; > + return is<RenderReplaced>(*renderer); I’d replace these six lines with this one-liner: return node && is<RenderReplaced>(node->renderer()); Fixes the position of the "*" in "RenderObject *" by deleting it, takes advantage of the null checking already built into is<>, and I think is still easy to read and reason about. 390034 2020-02-06 17:27:36 -0800 2020-02-06 19:30:47 -0800 Patch bug-207370-20200206172735.patch text/plain 5332 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1OTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTc4ZTc2ZjQzYzhlNWMw MjY5N2E4M2QyM2Y1NjVhMDgzYzIxZWM1Mi4uZTNjMmNmYzc0NjgwZDNhMmM1NGZiN2JlYmVlNzdk OGIzNDQ0MDQ3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAyLTA2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIG1hY0NhdGFseXN0 OiBVbm5lY2Vzc2FyeSBJLWJlYW0gb3ZlciBpbWFnZXMgaW4gZWRpdGFibGUgYXJlYXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzM3MAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTkyMzU0Mjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBkb20vUG9zaXRpb24uaDoKKwogMjAyMC0wMi0wNiAgQnJl bnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBQcmV2ZW50IG5hdmln YXRpbmcgdG9wIGxldmVsIGZyYW1lcyB0byBEYXRhIFVSTHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggNmY1ZTdlYTU0 MjE1MzAxZmQ0Yzc0YWJkZGIxNWE0ZjZmYjllMzVlMS4uYmFhZDRmMTc4ZWRiNTBlNzRiN2Q5ZDI1 YTIyOTcyNDc2ODUyNDAyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAyMC0wMi0wNiAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBtYWNDYXRh bHlzdDogVW5uZWNlc3NhcnkgSS1iZWFtIG92ZXIgaW1hZ2VzIGluIGVkaXRhYmxlIGFyZWFzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDczNzAKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5MjM1NDI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0 aW9uQXRQb3NpdGlvbi5oOgorICAgICAgICAqIFNoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1h dGlvbkF0UG9zaXRpb24ubW06CisgICAgICAgIChXZWJLaXQ6OkludGVyYWN0aW9uSW5mb3JtYXRp b25BdFBvc2l0aW9uOjplbmNvZGUgY29uc3QpOgorICAgICAgICAoV2ViS2l0OjpJbnRlcmFjdGlv bkluZm9ybWF0aW9uQXRQb3NpdGlvbjo6ZGVjb2RlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OnBvcHVsYXRlQ2FyZXRD b250ZXh0KToKKyAgICAgICAgQWRkIGEgYml0IGluZGljYXRpbmcgd2hldGhlciB0aGUgZm9yY2Vk IEktYmVhbSBmb3IgZWRpdGFibGUgY29udGV4dHMKKyAgICAgICAgc2hvdWxkIGJlIHVzZWQgb3Ig bm90LCBiYXNlZCBvbiB3aGV0aGVyIGl0IGlzIGFkamFjZW50IHRvIChvciBpbW1lZGlhdGVseQor ICAgICAgICBvdmVyKSBhIHJlcGxhY2VkIGVsZW1lbnQuCisKIDIwMjAtMDItMDYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUHJldmVudCBuYXZpZ2F0aW5n IHRvcCBsZXZlbCBmcmFtZXMgdG8gRGF0YSBVUkxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vUG9zaXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5oCmluZGV4IDkw OWFkMTM5NGEwNWNlZjk1ZTc3ZTM5MTQ2MDFiY2NlNWQyYTFjZDIuLjIxN2I0MWQ4MDA3MjFjMjYz OWUzZjFlNjMyNzEwODNkNThjZTAyMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Q b3NpdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5oCkBAIC0xMDYsOCAr MTA2LDggQEAgcHVibGljOgogICAgIFJlZlB0cjxOb2RlPiBmaXJzdE5vZGUoKSBjb25zdDsKIAog ICAgIC8vIFRoZXNlIGFyZSBjb252ZW5pZW5jZSBtZXRob2RzIHdoaWNoIGFyZSBzbWFydCBhYm91 dCB3aGV0aGVyIHRoZSBwb3NpdGlvbiBpcyBuZWlnaGJvciBhbmNob3JlZCBvciBwYXJlbnQgYW5j aG9yZWQKLSAgICBOb2RlKiBjb21wdXRlTm9kZUJlZm9yZVBvc2l0aW9uKCkgY29uc3Q7Ci0gICAg Tm9kZSogY29tcHV0ZU5vZGVBZnRlclBvc2l0aW9uKCkgY29uc3Q7CisgICAgV0VCQ09SRV9FWFBP UlQgTm9kZSogY29tcHV0ZU5vZGVCZWZvcmVQb3NpdGlvbigpIGNvbnN0OworICAgIFdFQkNPUkVf RVhQT1JUIE5vZGUqIGNvbXB1dGVOb2RlQWZ0ZXJQb3NpdGlvbigpIGNvbnN0OwogCiAgICAgTm9k ZSogYW5jaG9yTm9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fYW5jaG9yTm9kZS5nZXQoKTsgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlv bkF0UG9zaXRpb24uaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9y bWF0aW9uQXRQb3NpdGlvbi5oCmluZGV4IDJlNGQzMGI1Y2MzNTNmYjQzMzcwMTkzMDk4M2I5Mzc1 ZGYxYTE1Y2MuLmUyZGQxNzUyMmVkNTA4NmI1ZDUyOWEyZjRjYWMzYzAwNGFjZWJmZTkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQ b3NpdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9y bWF0aW9uQXRQb3NpdGlvbi5oCkBAIC02OSw2ICs2OSw3IEBAIHN0cnVjdCBJbnRlcmFjdGlvbklu Zm9ybWF0aW9uQXRQb3NpdGlvbiB7CiAjaWYgRU5BQkxFKERBVEFMSVNUX0VMRU1FTlQpCiAgICAg Ym9vbCBwcmV2ZW50VGV4dEludGVyYWN0aW9uIHsgZmFsc2UgfTsKICNlbmRpZgorICAgIGJvb2wg c2hvdWxkTm90VXNlSUJlYW1JbkVkaXRhYmxlQ29udGVudCB7IGZhbHNlIH07CiAgICAgV2ViQ29y ZTo6RmxvYXRQb2ludCBhZGp1c3RlZFBvaW50Rm9yTm9kZVJlc3BvbmRpbmdUb0NsaWNrRXZlbnRz OwogICAgIFVSTCB1cmw7CiAgICAgVVJMIGltYWdlVVJMOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9TaGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLm1tIGIvU291 cmNlL1dlYktpdC9TaGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uLm1t CmluZGV4IDgyODFlMTM3MDg0MzU1ZDUxODM2MzM0ZDZhMGQ1ZTM4Yjg4MzMyNDUuLjk1MTEzOWE4 ZjdkNmQ1ZDNlYzU1YjlmNWUwMjk1OGEwYTNhNTY1ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5tbQorKysgYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24u bW0KQEAgLTg0LDYgKzg0LDcgQEAgdm9pZCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlv bjo6ZW5jb2RlKElQQzo6RW5jb2RlciYgZW5jb2RlcikgY29uc3QKICNpZiBFTkFCTEUoREFUQUxJ U1RfRUxFTUVOVCkKICAgICBlbmNvZGVyIDw8IHByZXZlbnRUZXh0SW50ZXJhY3Rpb247CiAjZW5k aWYKKyAgICBlbmNvZGVyIDw8IHNob3VsZE5vdFVzZUlCZWFtSW5FZGl0YWJsZUNvbnRlbnQ7CiAg ICAgZW5jb2RlciA8PCBlbGVtZW50Q29udGV4dDsKIH0KIApAQCAtMjAwLDYgKzIwMSw5IEBAIGJv b2wgSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb246OmRlY29kZShJUEM6OkRlY29kZXIm IGRlY29kZXIsIEludGVyYWN0aW9uCiAgICAgICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogCisg ICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuc2hvdWxkTm90VXNlSUJlYW1JbkVkaXRhYmxl Q29udGVudCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIGlmICghZGVjb2Rlci5kZWNv ZGUocmVzdWx0LmVsZW1lbnRDb250ZXh0KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmlu ZGV4IDIwZGRlOTdiNzVmYzIyNjhhYjdmYjFmYjU4Y2I2MmI3ODZkYzYyNjMuLmUzNGNkMzA5YzY5 YzFlMjU5YzNjMTc2NzFlMjBmZDM3NjRlZTdjZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0yODM0LDYgKzI4MzQsMTgg QEAgc3RhdGljIHZvaWQgcG9wdWxhdGVDYXJldENvbnRleHQoY29uc3QgSGl0VGVzdFJlc3VsdCYg aGl0VGVzdFJlc3VsdCwgY29uc3QgSW50ZXIKICAgICAgICAgICAgIGluZm8ubGluZUNhcmV0RXh0 ZW50LnNldFkocmVxdWVzdC5wb2ludC55KCkgLSBpbmZvLmxpbmVDYXJldEV4dGVudC5oZWlnaHQo KSAvIDIpOwogICAgICAgICBpbmZvLmNhcmV0SGVpZ2h0ID0gaW5mby5saW5lQ2FyZXRFeHRlbnQu aGVpZ2h0KCk7CiAgICAgfQorCisgICAgYXV0byBub2RlU2hvdWxkTm90VXNlSUJlYW0gPSBeKE5v ZGUqIG5vZGUpIHsKKyAgICAgICAgaWYgKCFub2RlKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNl OworICAgICAgICBSZW5kZXJPYmplY3QgKnJlbmRlcmVyID0gbm9kZS0+cmVuZGVyZXIoKTsKKyAg ICAgICAgaWYgKCFyZW5kZXJlcikKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAg cmV0dXJuIGlzPFJlbmRlclJlcGxhY2VkPigqcmVuZGVyZXIpOworICAgIH07CisKKyAgICBjb25z dCBhdXRvJiBkZWVwUG9zaXRpb24gPSBwb3NpdGlvbi5kZWVwRXF1aXZhbGVudCgpOworICAgIGlu Zm8uc2hvdWxkTm90VXNlSUJlYW1JbkVkaXRhYmxlQ29udGVudCA9IG5vZGVTaG91bGROb3RVc2VJ QmVhbShub2RlKSB8fCBub2RlU2hvdWxkTm90VXNlSUJlYW0oZGVlcFBvc2l0aW9uLmNvbXB1dGVO b2RlQmVmb3JlUG9zaXRpb24oKSkgfHwgbm9kZVNob3VsZE5vdFVzZUlCZWFtKGRlZXBQb3NpdGlv bi5jb21wdXRlTm9kZUFmdGVyUG9zaXRpb24oKSk7CiB9CiAKIEludGVyYWN0aW9uSW5mb3JtYXRp b25BdFBvc2l0aW9uIFdlYlBhZ2U6OnBvc2l0aW9uSW5mb3JtYXRpb24oY29uc3QgSW50ZXJhY3Rp b25JbmZvcm1hdGlvblJlcXVlc3QmIHJlcXVlc3QpCg==