207368 2020-02-06 16:48:31 -0800 Add a comment in StringView::setUnderlyingString(const StringView&) for clarification. 2020-02-06 17:00:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo dbates ews-watchlist keith_miller webkit-bug-importer oldest_to_newest 1615933 0 mark.lam 2020-02-06 16:48:31 -0800 <rdar://problem/59211075> 1615935 1 390029 mark.lam 2020-02-06 16:52:12 -0800 Created attachment 390029 proposed patch. 1615936 2 390029 keith_miller 2020-02-06 16:54:28 -0800 Comment on attachment 390029 proposed patch. r=me. 1615941 3 mark.lam 2020-02-06 17:00:33 -0800 Thanks for the review. Landed in r255993: <http://trac.webkit.org/r255993>. 390029 2020-02-06 16:52:12 -0800 2020-02-06 16:54:28 -0800 proposed patch. bug-207368.patch text/plain 1758 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNTU5OTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTA2ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBjb21tZW50IGluIFN0cmluZ1ZpZXc6OnNldFVu ZGVybHlpbmdTdHJpbmcoY29uc3QgU3RyaW5nVmlldyYpIGZvciBjbGFyaWZpY2F0aW9uLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzY4CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81OTIxMTA3NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFdmVyeSB0aW1lIEkgcmVhZCB0aGlzIGNvZGUsIEkgaGF2 ZSB0byByZS1kZWR1Y2Ugd2h5IHRoaXMgY29kZSBpcyB0aHJlYWQgc2FmZS4KKyAgICAgICAgU28s IEknbSBqdXN0IGdvaW5nIHRvIGFkZCBhIGNvbW1lbnQgdG8gZG9jdW1lbnQgaXQuCisKKyAgICAg ICAgKiB3dGYvdGV4dC9TdHJpbmdWaWV3LmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nVmlldzo6 c2V0VW5kZXJseWluZ1N0cmluZyk6CisKIDIwMjAtMDItMDYgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNTQ1MzQpOiAxLTMl IHJlZ3Jlc3Npb24gb24gUExUCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ1ZpZXcu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nVmlldy5jcHAJKHJl dmlzaW9uIDI1NTk5MSkKKysrIFNvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nVmlldy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM1Niw4ICszNTYsMTQgQEAgdm9pZCBTdHJpbmdWaWV3OjpzZXRVbmRl cmx5aW5nU3RyaW5nKGNvbgogdm9pZCBTdHJpbmdWaWV3OjpzZXRVbmRlcmx5aW5nU3RyaW5nKGNv bnN0IFN0cmluZ1ZpZXcmIG90aGVyU3RyaW5nKQogewogICAgIFVuZGVybHlpbmdTdHJpbmcqIHVu ZGVybHlpbmdTdHJpbmcgPSBvdGhlclN0cmluZy5tX3VuZGVybHlpbmdTdHJpbmc7Ci0gICAgaWYg KHVuZGVybHlpbmdTdHJpbmcpCisgICAgaWYgKHVuZGVybHlpbmdTdHJpbmcpIHsKKyAgICAgICAg Ly8gSXQncyBzYWZlIHRvIGluYyB0aGUgcmVmQ291bnQgaGVyZSB3aXRob3V0IGxvY2tpbmcgdW5k ZXJseWluZ1N0cmluZ3NNdXRleAorICAgICAgICAvLyBiZWNhdXNlIFVuZGVybHlpbmdTdHJpbmc6 OnJlZkNvdW50IGlzIGEgc3RkOjphdG9taWNfdWludCwgYW5kIHdlJ3JlCisgICAgICAgIC8vIGd1 YXJhbnRlZWQgdGhhdCB0aGUgU3RyaW5nVmlldyB3ZSdyZSBjb3B5aW5nIGl0IGZyb20gd2lsbCBh dCBsZWFzdAorICAgICAgICAvLyBoYXZlIDEgcmVmIG9uIGl0LCB0aGVyZWJ5IGtlZXBpbmcgaXQg YWxpdmUgcmVnYXJkbGVzcyBvZiB3aGF0IG90aGVyCisgICAgICAgIC8vIHRocmVhZHMgbWF5IGJl IGRvaW5nLgogICAgICAgICArK3VuZGVybHlpbmdTdHJpbmctPnJlZkNvdW50OworICAgIH0KICAg ICBhZG9wdFVuZGVybHlpbmdTdHJpbmcodW5kZXJseWluZ1N0cmluZyk7CiB9CiAK