207365 2020-02-06 15:44:39 -0800 Multiple GCC 10 build failures in ANGLE 2020-02-12 16:32:16 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build PC Linux RESOLVED FIXED https://bugzilla.redhat.com/show_bug.cgi?id=1800249 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply clopez commit-queue dino ews-watchlist graouts kloczko.tomasz kondapallykalyan mcatanzaro webkit-bug-importer oldest_to_newest 1615899 0 mcatanzaro 2020-02-06 15:44:39 -0800 WebKitGTK 2.27.4 FTBFS with GCC 10: In file included from ../Source/ThirdParty/ANGLE/src/common/event_tracer.h:9, from ../Source/ThirdParty/ANGLE/src/common/event_tracer.cpp:5: ../Source/ThirdParty/ANGLE/include/platform/Platform.h:239:35: error: 'size_t' has not been declared 239 | size_t programSize, | ^~~~~~ ../Source/ThirdParty/ANGLE/include/platform/Platform.h:243:33: error: 'size_t' has not been declared 243 | size_t programSize, | ^~~~~~ Problem is ANGLE's Platform.h only #includes <stdint.h> and <array>. size_t is declared in a bunch of different stdlib headers [1], but stdint.h is not one of them. stdlib.h seems like the nicest one to use here. [1] https://en.cppreference.com/w/c/types/size_t 1616918 1 mcatanzaro 2020-02-10 09:48:02 -0800 In addition to the missing include, there is one more build failure: ../Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp In file included from ../Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:13, from ../Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10: ../Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h:427:2: in 'constexpr' expansion of 'angle::PackedEnumMap<gl::ComponentType, unsigned int>(std::initializer_list<std::pair<gl::ComponentType, unsigned int> >{((const std::pair<gl::ComponentType, unsigned int>*)(& const std::pair<gl::ComponentType, unsigned int> [3]{std::pair<gl::ComponentType, unsigned int>{gl::ComponentType::Float, 65537}, std::pair<gl::ComponentType, unsigned int>{gl::ComponentType::Int, 1}, std::pair<gl::ComponentType, unsigned int>{gl::ComponentType::UnsignedInt, 65536}})), 3})' ../Source/ThirdParty/ANGLE/src/common/PackedEnums.h:89:72: error: modifying a const object '(unsigned int&)(&(&(const Storage&)(&((angle::PackedEnumMap<gl::ComponentType, unsigned int>*)this)->angle::PackedEnumMap<gl::ComponentType, unsigned int>::mPrivateData))->std::array<unsigned int, 4>::operator[](((std::array<unsigned int, 4>::size_type)((angle::PackedEnumMap<gl::ComponentType, unsigned int>::UnderlyingType)it->std::pair<gl::ComponentType, unsigned int>::first))))' is not allowed in a constant expression 88 | const_cast<T &>(const_cast<const Storage &>( | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 89 | mPrivateData)[static_cast<UnderlyingType>(it->first)]) = it->second; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ In file included from ../Source/ThirdParty/ANGLE/src/libANGLE/Caps.h:12, from ../Source/ThirdParty/ANGLE/src/libANGLE/Context.h:20, from ../Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:14, from ../Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10: ../Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h:427:2: note: originally declared 'const' here 427 | }}; | ^ Which is easy to fix by removing the casts. The source code has a comment saying the casts are required until C++17, but in WebKit this file is guaranteed to be built using C++17. Not sure about upstreamability of this one. 1616929 2 390259 mcatanzaro 2020-02-10 10:04:38 -0800 Created attachment 390259 Patch 1616930 3 ews-watchlist 2020-02-10 10:05:39 -0800 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1616939 4 390260 mcatanzaro 2020-02-10 10:13:53 -0800 Created attachment 390260 Patch 1616945 5 mcatanzaro 2020-02-10 10:22:24 -0800 Reported upstream: https://bugs.chromium.org/p/angleproject/issues/detail?id=4389 https://bugs.chromium.org/p/angleproject/issues/detail?id=4390 1617304 6 cgarcia 2020-02-11 01:15:15 -0800 *** Bug 207511 has been marked as a duplicate of this bug. *** 1618033 7 clopez 2020-02-12 09:05:55 -0800 its 2.26.x also affected by this? should we backport this to 2.26.x? 1618077 8 mcatanzaro 2020-02-12 10:12:19 -0800 (In reply to Carlos Alberto Lopez Perez from comment #7) > its 2.26.x also affected by this? should we backport this to 2.26.x? It's probably affected, yes. I doubt any Linux distros will ever use GCC 10 to build 2.26.x, so a backport is probably not very important, but it might be useful for developers to check if bugs exist in 2.26 without having to manually apply the patch. 1618094 9 390260 commit-queue 2020-02-12 10:40:57 -0800 Comment on attachment 390260 Patch Rejecting attachment 390260 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 390260, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=390260&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=207365&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 390260 from bug 207365. Fetching: https://bugs.webkit.org/attachment.cgi?id=390260 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file Source/ThirdParty/ANGLE/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/ThirdParty/ANGLE/changes.diff Hunk #1 FAILED at 138. 1 out of 1 hunk FAILED -- saving rejects to file Source/ThirdParty/ANGLE/changes.diff.rej patching file Source/ThirdParty/ANGLE/include/platform/Platform.h patching file Source/ThirdParty/ANGLE/src/common/PackedEnums.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Alberto Lopez Perez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13321487 1618110 10 mcatanzaro 2020-02-12 10:51:52 -0800 Conflict is r256443 1618260 11 390571 mcatanzaro 2020-02-12 15:33:09 -0800 Created attachment 390571 Patch 1618298 12 commit-queue 2020-02-12 16:31:11 -0800 The commit-queue encountered the following flaky tests while processing attachment 390571: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1618300 13 390571 commit-queue 2020-02-12 16:31:46 -0800 Comment on attachment 390571 Patch Clearing flags on attachment: 390571 Committed r256491: <https://trac.webkit.org/changeset/256491> 1618301 14 commit-queue 2020-02-12 16:31:48 -0800 All reviewed patches have been landed. Closing bug. 1618303 15 webkit-bug-importer 2020-02-12 16:32:16 -0800 <rdar://problem/59406353> 390259 2020-02-10 10:04:38 -0800 2020-02-10 10:13:50 -0800 Patch bug-207365-20200210120437.patch text/plain 3740 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZjYzZmIzZTk5ZGQ5YWI5Njg5OGU0MzUzODhkYmIyOTYxNWUzYWIxMi4uZmFhOWFhYzk4MTU2 OTcyNWI3ZjBjZjExMzA2NjE4MDI0ZmNlMDMzMyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAyLTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIE11bHRpcGxlIEdDQyAxMCBidWlsZCBmYWlsdXJl cyBpbiBBTkdMRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA3MzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBjaGFuZ2VzLmRpZmY6IFVwZGF0ZWQuCisgICAgICAgICogaW5jbHVkZS9wbGF0Zm9ybS9Q bGF0Zm9ybS5oOiBBZGQgbWlzc2luZyAjaW5jbHVkZSB0byBnZXQgc2l6ZV90LgorICAgICAgICAq IHNyYy9jb21tb24vUGFja2VkRW51bXMuaDogUmVtb3ZlIHByb2JsZW1hdGljIGNvbnN0X2Nhc3Rz LgorCiAyMDIwLTAyLTA5ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZS1lbmFibGUgTFRPIGZvciBBUk0gYnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9jaGFuZ2VzLmRpZmYgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9jaGFu Z2VzLmRpZmYKaW5kZXggNzg3MzBjODgzNmM3ZmJjMjY3ZmVmYWMxYmMzNmYzZTliMDhjNjkxYy4u MTE2M2M2ODJmYjAzY2U4OTc0MjYwMDcyNDVkYWZkMzNmNjEwZjdlNyAxMDA2NDQKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvY2hhbmdlcy5kaWZmCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL2NoYW5nZXMuZGlmZgpAQCAtMTM4LDMgKzEzOCwzMSBAQCBpbmRleCBjYjQ4MmQwNWIu LjZjZWY3ZDNkZCAxMDA2NDQKICAgICAgICAgIG1Td2FwTGF5ZXIgPSBuaWw7CiAgICAgIH0KICAK K2RpZmYgLS1naXQgYS9pbmNsdWRlL3BsYXRmb3JtL1BsYXRmb3JtLmggYi9pbmNsdWRlL3BsYXRm b3JtL1BsYXRmb3JtLmgKK2luZGV4IGI2MDNmZjliYWQyLi5mNGVjNGY4ODM3YyAxMDA2NDQKKy0t LSBhL2luY2x1ZGUvcGxhdGZvcm0vUGxhdGZvcm0uaAorKysrIGIvaW5jbHVkZS9wbGF0Zm9ybS9Q bGF0Zm9ybS5oCitAQCAtOSw2ICs5LDcgQEAKKyAjaWZuZGVmIEFOR0xFX1BMQVRGT1JNX0gKKyAj ZGVmaW5lIEFOR0xFX1BMQVRGT1JNX0gKKyAKKysjaW5jbHVkZSA8c3RkbGliLmg+CisgI2luY2x1 ZGUgPHN0ZGludC5oPgorICNpbmNsdWRlIDxhcnJheT4KKyAKK2RpZmYgLS1naXQgYS9zcmMvY29t bW9uL1BhY2tlZEVudW1zLmggYi9zcmMvY29tbW9uL1BhY2tlZEVudW1zLmgKK2luZGV4IGJkNWZj MzQwZGNjLi42MzM2OGUyNWRmZSAxMDA2NDQKKy0tLSBhL3NyYy9jb21tb24vUGFja2VkRW51bXMu aAorKysrIGIvc3JjL2NvbW1vbi9QYWNrZWRFbnVtcy5oCitAQCAtODMsMTAgKzgzLDcgQEAgY2xh c3MgUGFja2VkRW51bU1hcAorICAgICAgICAgLy8gV2UgdXNlIGEgZm9yIGxvb3AgaW5zdGVhZCBv ZiByYW5nZS1mb3IgdG8gd29yayBhcm91bmQgYSBsaW1pdGF0aW9uIGluIE1TVkMuCisgICAgICAg ICBmb3IgKGNvbnN0IEluaXRQYWlyICppdCA9IGluaXQuYmVnaW4oKTsgaXQgIT0gaW5pdC5lbmQo KTsgKytpdCkKKyAgICAgICAgIHsKKy0gICAgICAgICAgICAvLyBUaGlzIGhvcnJpYmxlIGNvbnN0 X2Nhc3QgcGF0dGVybiBpcyBuZWNlc3NhcnkgdG8gd29yayBhcm91bmQgYSBjb25zdGV4cHIgbGlt aXRhdGlvbi4KKy0gICAgICAgICAgICAvLyBTZWUgaHR0cHM6Ly9zdGFja292ZXJmbG93LmNvbS9x LzM0MTk5Nzc0LyAuIE5vdGUgdGhhdCBpdCBzaG91bGQgYmUgZml4ZWQgd2l0aCBDKysxNy4KKy0g ICAgICAgICAgICBjb25zdF9jYXN0PFQgJj4oY29uc3RfY2FzdDxjb25zdCBTdG9yYWdlICY+KAor LSAgICAgICAgICAgICAgICBtUHJpdmF0ZURhdGEpW3N0YXRpY19jYXN0PFVuZGVybHlpbmdUeXBl PihpdC0+Zmlyc3QpXSkgPSBpdC0+c2Vjb25kOworKyAgICAgICAgICAgIG1Qcml2YXRlRGF0YVtz dGF0aWNfY2FzdDxVbmRlcmx5aW5nVHlwZT4oaXQtPmZpcnN0KV0pID0gaXQtPnNlY29uZDsKKyAg ICAgICAgIH0KKyAgICAgfQorIApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv aW5jbHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybS5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5j bHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybS5oCmluZGV4IGI2MDNmZjliYWQyNjY4MjhiNTUxZTNiYmQx MWEzYjNmYTM2YTFiOTcuLmY0ZWM0Zjg4MzdjOGU2MWYwNDYyM2QxYTRkYjcwNTUyMDkzNWViNzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvcGxhdGZvcm0vUGxh dGZvcm0uaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL3BsYXRmb3JtL1Bs YXRmb3JtLmgKQEAgLTksNiArOSw3IEBACiAjaWZuZGVmIEFOR0xFX1BMQVRGT1JNX0gKICNkZWZp bmUgQU5HTEVfUExBVEZPUk1fSAogCisjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3Rk aW50Lmg+CiAjaW5jbHVkZSA8YXJyYXk+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9jb21tb24vUGFja2VkRW51bXMuaCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9jb21tb24vUGFja2VkRW51bXMuaAppbmRleCBiZDVmYzM0MGRjY2ZjMzliYjk5MTgyNzE5 NDE5ZTk5YzZmY2VkZTk4Li42MzM2OGUyNWRmZWU0YTFlOGEzZWFjNTMyMTE5MDY5ZmMwMDQ4ZjJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL1BhY2tlZEVu dW1zLmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi9QYWNrZWRFbnVt cy5oCkBAIC04MywxMCArODMsNyBAQCBjbGFzcyBQYWNrZWRFbnVtTWFwCiAgICAgICAgIC8vIFdl IHVzZSBhIGZvciBsb29wIGluc3RlYWQgb2YgcmFuZ2UtZm9yIHRvIHdvcmsgYXJvdW5kIGEgbGlt aXRhdGlvbiBpbiBNU1ZDLgogICAgICAgICBmb3IgKGNvbnN0IEluaXRQYWlyICppdCA9IGluaXQu YmVnaW4oKTsgaXQgIT0gaW5pdC5lbmQoKTsgKytpdCkKICAgICAgICAgewotICAgICAgICAgICAg Ly8gVGhpcyBob3JyaWJsZSBjb25zdF9jYXN0IHBhdHRlcm4gaXMgbmVjZXNzYXJ5IHRvIHdvcmsg YXJvdW5kIGEgY29uc3RleHByIGxpbWl0YXRpb24uCi0gICAgICAgICAgICAvLyBTZWUgaHR0cHM6 Ly9zdGFja292ZXJmbG93LmNvbS9xLzM0MTk5Nzc0LyAuIE5vdGUgdGhhdCBpdCBzaG91bGQgYmUg Zml4ZWQgd2l0aCBDKysxNy4KLSAgICAgICAgICAgIGNvbnN0X2Nhc3Q8VCAmPihjb25zdF9jYXN0 PGNvbnN0IFN0b3JhZ2UgJj4oCi0gICAgICAgICAgICAgICAgbVByaXZhdGVEYXRhKVtzdGF0aWNf Y2FzdDxVbmRlcmx5aW5nVHlwZT4oaXQtPmZpcnN0KV0pID0gaXQtPnNlY29uZDsKKyAgICAgICAg ICAgIG1Qcml2YXRlRGF0YVtzdGF0aWNfY2FzdDxVbmRlcmx5aW5nVHlwZT4oaXQtPmZpcnN0KV0p ID0gaXQtPnNlY29uZDsKICAgICAgICAgfQogICAgIH0KIAo= 390260 2020-02-10 10:13:53 -0800 2020-02-12 15:33:07 -0800 Patch bug-207365-20200210121352.patch text/plain 3738 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZjYzZmIzZTk5ZGQ5YWI5Njg5OGU0MzUzODhkYmIyOTYxNWUzYWIxMi4uZmFhOWFhYzk4MTU2 OTcyNWI3ZjBjZjExMzA2NjE4MDI0ZmNlMDMzMyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAyLTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIE11bHRpcGxlIEdDQyAxMCBidWlsZCBmYWlsdXJl cyBpbiBBTkdMRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA3MzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBjaGFuZ2VzLmRpZmY6IFVwZGF0ZWQuCisgICAgICAgICogaW5jbHVkZS9wbGF0Zm9ybS9Q bGF0Zm9ybS5oOiBBZGQgbWlzc2luZyAjaW5jbHVkZSB0byBnZXQgc2l6ZV90LgorICAgICAgICAq IHNyYy9jb21tb24vUGFja2VkRW51bXMuaDogUmVtb3ZlIHByb2JsZW1hdGljIGNvbnN0X2Nhc3Rz LgorCiAyMDIwLTAyLTA5ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZS1lbmFibGUgTFRPIGZvciBBUk0gYnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9jaGFuZ2VzLmRpZmYgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9jaGFu Z2VzLmRpZmYKaW5kZXggNzg3MzBjODgzNmM3ZmJjMjY3ZmVmYWMxYmMzNmYzZTliMDhjNjkxYy4u NjVlOTRlNzI3NmU0ZDZmNmIyMWU1YmVlNjdmNDk0MDU0ZTMwOGJhZSAxMDA2NDQKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvY2hhbmdlcy5kaWZmCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL2NoYW5nZXMuZGlmZgpAQCAtMTM4LDMgKzEzOCwzMSBAQCBpbmRleCBjYjQ4MmQwNWIu LjZjZWY3ZDNkZCAxMDA2NDQKICAgICAgICAgIG1Td2FwTGF5ZXIgPSBuaWw7CiAgICAgIH0KICAK K2RpZmYgLS1naXQgYS9pbmNsdWRlL3BsYXRmb3JtL1BsYXRmb3JtLmggYi9pbmNsdWRlL3BsYXRm b3JtL1BsYXRmb3JtLmgKK2luZGV4IGI2MDNmZjliYWQyLi5mNGVjNGY4ODM3YyAxMDA2NDQKKy0t LSBhL2luY2x1ZGUvcGxhdGZvcm0vUGxhdGZvcm0uaAorKysrIGIvaW5jbHVkZS9wbGF0Zm9ybS9Q bGF0Zm9ybS5oCitAQCAtOSw2ICs5LDcgQEAKKyAjaWZuZGVmIEFOR0xFX1BMQVRGT1JNX0gKKyAj ZGVmaW5lIEFOR0xFX1BMQVRGT1JNX0gKKyAKKysjaW5jbHVkZSA8c3RkbGliLmg+CisgI2luY2x1 ZGUgPHN0ZGludC5oPgorICNpbmNsdWRlIDxhcnJheT4KKyAKK2RpZmYgLS1naXQgYS9zcmMvY29t bW9uL1BhY2tlZEVudW1zLmggYi9zcmMvY29tbW9uL1BhY2tlZEVudW1zLmgKK2luZGV4IGJkNWZj MzQwZGNjLi42MzM2OGUyNWRmZSAxMDA2NDQKKy0tLSBhL3NyYy9jb21tb24vUGFja2VkRW51bXMu aAorKysrIGIvc3JjL2NvbW1vbi9QYWNrZWRFbnVtcy5oCitAQCAtODMsMTAgKzgzLDcgQEAgY2xh c3MgUGFja2VkRW51bU1hcAorICAgICAgICAgLy8gV2UgdXNlIGEgZm9yIGxvb3AgaW5zdGVhZCBv ZiByYW5nZS1mb3IgdG8gd29yayBhcm91bmQgYSBsaW1pdGF0aW9uIGluIE1TVkMuCisgICAgICAg ICBmb3IgKGNvbnN0IEluaXRQYWlyICppdCA9IGluaXQuYmVnaW4oKTsgaXQgIT0gaW5pdC5lbmQo KTsgKytpdCkKKyAgICAgICAgIHsKKy0gICAgICAgICAgICAvLyBUaGlzIGhvcnJpYmxlIGNvbnN0 X2Nhc3QgcGF0dGVybiBpcyBuZWNlc3NhcnkgdG8gd29yayBhcm91bmQgYSBjb25zdGV4cHIgbGlt aXRhdGlvbi4KKy0gICAgICAgICAgICAvLyBTZWUgaHR0cHM6Ly9zdGFja292ZXJmbG93LmNvbS9x LzM0MTk5Nzc0LyAuIE5vdGUgdGhhdCBpdCBzaG91bGQgYmUgZml4ZWQgd2l0aCBDKysxNy4KKy0g ICAgICAgICAgICBjb25zdF9jYXN0PFQgJj4oY29uc3RfY2FzdDxjb25zdCBTdG9yYWdlICY+KAor LSAgICAgICAgICAgICAgICBtUHJpdmF0ZURhdGEpW3N0YXRpY19jYXN0PFVuZGVybHlpbmdUeXBl PihpdC0+Zmlyc3QpXSkgPSBpdC0+c2Vjb25kOworKyAgICAgICAgICAgIG1Qcml2YXRlRGF0YVtz dGF0aWNfY2FzdDxVbmRlcmx5aW5nVHlwZT4oaXQtPmZpcnN0KV0gPSBpdC0+c2Vjb25kOworICAg ICAgICAgfQorICAgICB9CisgCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9p bmNsdWRlL3BsYXRmb3JtL1BsYXRmb3JtLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNs dWRlL3BsYXRmb3JtL1BsYXRmb3JtLmgKaW5kZXggYjYwM2ZmOWJhZDI2NjgyOGI1NTFlM2JiZDEx YTNiM2ZhMzZhMWI5Ny4uZjRlYzRmODgzN2M4ZTYxZjA0NjIzZDFhNGRiNzA1NTIwOTM1ZWI3NyAx MDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9QbGF0 Zm9ybS5oCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvcGxhdGZvcm0vUGxh dGZvcm0uaApAQCAtOSw2ICs5LDcgQEAKICNpZm5kZWYgQU5HTEVfUExBVEZPUk1fSAogI2RlZmlu ZSBBTkdMRV9QTEFURk9STV9ICiAKKyNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDxzdGRp bnQuaD4KICNpbmNsdWRlIDxhcnJheT4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2NvbW1vbi9QYWNrZWRFbnVtcy5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2NvbW1vbi9QYWNrZWRFbnVtcy5oCmluZGV4IGJkNWZjMzQwZGNjZmMzOWJiOTkxODI3MTk0 MTllOTljNmZjZWRlOTguLjZmY2ZjZTU4YTg1MGVlY2U5MTA5Nzg5NDNlYzdiZTNhZWUxZWVjZjAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21tb24vUGFja2VkRW51 bXMuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9uL1BhY2tlZEVudW1z LmgKQEAgLTgzLDEwICs4Myw3IEBAIGNsYXNzIFBhY2tlZEVudW1NYXAKICAgICAgICAgLy8gV2Ug dXNlIGEgZm9yIGxvb3AgaW5zdGVhZCBvZiByYW5nZS1mb3IgdG8gd29yayBhcm91bmQgYSBsaW1p dGF0aW9uIGluIE1TVkMuCiAgICAgICAgIGZvciAoY29uc3QgSW5pdFBhaXIgKml0ID0gaW5pdC5i ZWdpbigpOyBpdCAhPSBpbml0LmVuZCgpOyArK2l0KQogICAgICAgICB7Ci0gICAgICAgICAgICAv LyBUaGlzIGhvcnJpYmxlIGNvbnN0X2Nhc3QgcGF0dGVybiBpcyBuZWNlc3NhcnkgdG8gd29yayBh cm91bmQgYSBjb25zdGV4cHIgbGltaXRhdGlvbi4KLSAgICAgICAgICAgIC8vIFNlZSBodHRwczov L3N0YWNrb3ZlcmZsb3cuY29tL3EvMzQxOTk3NzQvIC4gTm90ZSB0aGF0IGl0IHNob3VsZCBiZSBm aXhlZCB3aXRoIEMrKzE3LgotICAgICAgICAgICAgY29uc3RfY2FzdDxUICY+KGNvbnN0X2Nhc3Q8 Y29uc3QgU3RvcmFnZSAmPigKLSAgICAgICAgICAgICAgICBtUHJpdmF0ZURhdGEpW3N0YXRpY19j YXN0PFVuZGVybHlpbmdUeXBlPihpdC0+Zmlyc3QpXSkgPSBpdC0+c2Vjb25kOworICAgICAgICAg ICAgbVByaXZhdGVEYXRhW3N0YXRpY19jYXN0PFVuZGVybHlpbmdUeXBlPihpdC0+Zmlyc3QpXSA9 IGl0LT5zZWNvbmQ7CiAgICAgICAgIH0KICAgICB9CiAK 390571 2020-02-12 15:33:09 -0800 2020-02-12 16:31:46 -0800 Patch bug-207365-20200212173308.patch text/plain 3805 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggYzA4YjZjODlhY2YzMTk0MjA2MzdlMGRlZjUyYWYzMTVjMzI3NmUzZi4uMjZiMDc3YjNhZWJh NDg2OTQ3NGZjOGVkMzc1MGJhZDVjZjFjM2NkNSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAyLTEwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIE11bHRpcGxlIEdDQyAxMCBidWlsZCBmYWlsdXJl cyBpbiBBTkdMRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA3MzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVy ZXouCisKKyAgICAgICAgKiBjaGFuZ2VzLmRpZmY6IFVwZGF0ZWQuCisgICAgICAgICogaW5jbHVk ZS9wbGF0Zm9ybS9QbGF0Zm9ybS5oOiBBZGQgbWlzc2luZyAjaW5jbHVkZSB0byBnZXQgc2l6ZV90 LgorICAgICAgICAqIHNyYy9jb21tb24vUGFja2VkRW51bXMuaDogUmVtb3ZlIHByb2JsZW1hdGlj IGNvbnN0X2Nhc3RzLgorCiAyMDIwLTAyLTEyICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNv bT4KIAogICAgICAgICBBTkdMRSBoYXMgdW51c2VkIGJpc29uIGFuZCBnbG1hcmsyIGNvZGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2NoYW5nZXMuZGlmZiBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL2NoYW5nZXMuZGlmZgppbmRleCA2ODc1YmU4MDQ0ZGYxOTU5YzlmMjkw ZGZiZTgzMmQwZmNhNTljMjU1Li45NjU1Zjc1MjE0NzY5YTc1YzVmODdiMWE1ZTg3NDk3NWQ3MmFh ZWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9jaGFuZ2VzLmRpZmYKKysr IGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvY2hhbmdlcy5kaWZmCkBAIC05OTA4LDMgKzk5MDgs MzEgQEAgaW5kZXggYTczNTkyMTEzZjEuLjAwMDAwMDAwMDAwCiBAQCAtMSArMCwwIEBACiAtMjEy YTllZjkwZTIxYTk4ZmY1N2NhMzAxYTYwYzg0Y2JlY2E3YmUyOAogXCBObyBuZXdsaW5lIGF0IGVu ZCBvZiBmaWxlCitkaWZmIC0tZ2l0IGEvaW5jbHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybS5oIGIvaW5j bHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybS5oCitpbmRleCBiNjAzZmY5YmFkMi4uZjRlYzRmODgzN2Mg MTAwNjQ0CistLS0gYS9pbmNsdWRlL3BsYXRmb3JtL1BsYXRmb3JtLmgKKysrKyBiL2luY2x1ZGUv cGxhdGZvcm0vUGxhdGZvcm0uaAorQEAgLTksNiArOSw3IEBACisgI2lmbmRlZiBBTkdMRV9QTEFU Rk9STV9ICisgI2RlZmluZSBBTkdMRV9QTEFURk9STV9ICisgCisrI2luY2x1ZGUgPHN0ZGxpYi5o PgorICNpbmNsdWRlIDxzdGRpbnQuaD4KKyAjaW5jbHVkZSA8YXJyYXk+CisgCitkaWZmIC0tZ2l0 IGEvc3JjL2NvbW1vbi9QYWNrZWRFbnVtcy5oIGIvc3JjL2NvbW1vbi9QYWNrZWRFbnVtcy5oCitp bmRleCBiZDVmYzM0MGRjYy4uNjMzNjhlMjVkZmUgMTAwNjQ0CistLS0gYS9zcmMvY29tbW9uL1Bh Y2tlZEVudW1zLmgKKysrKyBiL3NyYy9jb21tb24vUGFja2VkRW51bXMuaAorQEAgLTgzLDEwICs4 Myw3IEBAIGNsYXNzIFBhY2tlZEVudW1NYXAKKyAgICAgICAgIC8vIFdlIHVzZSBhIGZvciBsb29w IGluc3RlYWQgb2YgcmFuZ2UtZm9yIHRvIHdvcmsgYXJvdW5kIGEgbGltaXRhdGlvbiBpbiBNU1ZD LgorICAgICAgICAgZm9yIChjb25zdCBJbml0UGFpciAqaXQgPSBpbml0LmJlZ2luKCk7IGl0ICE9 IGluaXQuZW5kKCk7ICsraXQpCisgICAgICAgICB7CistICAgICAgICAgICAgLy8gVGhpcyBob3Jy aWJsZSBjb25zdF9jYXN0IHBhdHRlcm4gaXMgbmVjZXNzYXJ5IHRvIHdvcmsgYXJvdW5kIGEgY29u c3RleHByIGxpbWl0YXRpb24uCistICAgICAgICAgICAgLy8gU2VlIGh0dHBzOi8vc3RhY2tvdmVy Zmxvdy5jb20vcS8zNDE5OTc3NC8gLiBOb3RlIHRoYXQgaXQgc2hvdWxkIGJlIGZpeGVkIHdpdGgg QysrMTcuCistICAgICAgICAgICAgY29uc3RfY2FzdDxUICY+KGNvbnN0X2Nhc3Q8Y29uc3QgU3Rv cmFnZSAmPigKKy0gICAgICAgICAgICAgICAgbVByaXZhdGVEYXRhKVtzdGF0aWNfY2FzdDxVbmRl cmx5aW5nVHlwZT4oaXQtPmZpcnN0KV0pID0gaXQtPnNlY29uZDsKKysgICAgICAgICAgICBtUHJp dmF0ZURhdGFbc3RhdGljX2Nhc3Q8VW5kZXJseWluZ1R5cGU+KGl0LT5maXJzdCldID0gaXQtPnNl Y29uZDsKKyAgICAgICAgIH0KKyAgICAgfQorIApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybS5oIGIvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9QbGF0Zm9ybS5oCmluZGV4IGI2MDNmZjliYWQyNjY4Mjhi NTUxZTNiYmQxMWEzYjNmYTM2YTFiOTcuLmY0ZWM0Zjg4MzdjOGU2MWYwNDYyM2QxYTRkYjcwNTUy MDkzNWViNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvcGxh dGZvcm0vUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL3Bs YXRmb3JtL1BsYXRmb3JtLmgKQEAgLTksNiArOSw3IEBACiAjaWZuZGVmIEFOR0xFX1BMQVRGT1JN X0gKICNkZWZpbmUgQU5HTEVfUExBVEZPUk1fSAogCisjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5j bHVkZSA8c3RkaW50Lmg+CiAjaW5jbHVkZSA8YXJyYXk+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21tb24vUGFja2VkRW51bXMuaCBiL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL3NyYy9jb21tb24vUGFja2VkRW51bXMuaAppbmRleCBiZDVmYzM0MGRjY2ZjMzli Yjk5MTgyNzE5NDE5ZTk5YzZmY2VkZTk4Li42ZmNmY2U1OGE4NTBlZWNlOTEwOTc4OTQzZWM3YmUz YWVlMWVlY2YwIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tbW9u L1BhY2tlZEVudW1zLmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi9Q YWNrZWRFbnVtcy5oCkBAIC04MywxMCArODMsNyBAQCBjbGFzcyBQYWNrZWRFbnVtTWFwCiAgICAg ICAgIC8vIFdlIHVzZSBhIGZvciBsb29wIGluc3RlYWQgb2YgcmFuZ2UtZm9yIHRvIHdvcmsgYXJv dW5kIGEgbGltaXRhdGlvbiBpbiBNU1ZDLgogICAgICAgICBmb3IgKGNvbnN0IEluaXRQYWlyICpp dCA9IGluaXQuYmVnaW4oKTsgaXQgIT0gaW5pdC5lbmQoKTsgKytpdCkKICAgICAgICAgewotICAg ICAgICAgICAgLy8gVGhpcyBob3JyaWJsZSBjb25zdF9jYXN0IHBhdHRlcm4gaXMgbmVjZXNzYXJ5 IHRvIHdvcmsgYXJvdW5kIGEgY29uc3RleHByIGxpbWl0YXRpb24uCi0gICAgICAgICAgICAvLyBT ZWUgaHR0cHM6Ly9zdGFja292ZXJmbG93LmNvbS9xLzM0MTk5Nzc0LyAuIE5vdGUgdGhhdCBpdCBz aG91bGQgYmUgZml4ZWQgd2l0aCBDKysxNy4KLSAgICAgICAgICAgIGNvbnN0X2Nhc3Q8VCAmPihj b25zdF9jYXN0PGNvbnN0IFN0b3JhZ2UgJj4oCi0gICAgICAgICAgICAgICAgbVByaXZhdGVEYXRh KVtzdGF0aWNfY2FzdDxVbmRlcmx5aW5nVHlwZT4oaXQtPmZpcnN0KV0pID0gaXQtPnNlY29uZDsK KyAgICAgICAgICAgIG1Qcml2YXRlRGF0YVtzdGF0aWNfY2FzdDxVbmRlcmx5aW5nVHlwZT4oaXQt PmZpcnN0KV0gPSBpdC0+c2Vjb25kOwogICAgICAgICB9CiAgICAgfQogCg==