207359 2020-02-06 14:50:52 -0800 Add slot based test for the accelerated animations freezing bug (201048) 2020-02-06 18:08:13 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204805 https://bugs.webkit.org/show_bug.cgi?id=201048 InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue dino graouts rniwa webkit-bug-importer oldest_to_newest 1615842 0 koivisto 2020-02-06 14:50:52 -0800 Fix had a simpler test case but it is good to add one for the original problem too. 1615844 1 390004 koivisto 2020-02-06 14:58:27 -0800 Created attachment 390004 patch 1615858 2 390004 rniwa 2020-02-06 15:02:45 -0800 Comment on attachment 390004 patch View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:52 > + // Put a named slot and assign an element to it. These comments seem unnecessary? I can see that from the code. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:60 > + // Create another named slot and assign another element to it. Ditto. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:64 > + // Start animation in the seconds slot. Ditto. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:79 > + // Wait until animation has progressed some before snapshotting the test result. Whereas this explanation is kind of useful. 1615863 3 koivisto 2020-02-06 15:10:03 -0800 > These comments seem unnecessary? I can see that from the code. They were in the original test, I suppose the author found them helpful. 1615870 4 rniwa 2020-02-06 15:17:55 -0800 (In reply to Antti Koivisto from comment #3) > > These comments seem unnecessary? I can see that from the code. > > They were in the original test, I suppose the author found them helpful. Was it imported from somewhere?? If so, we need to give a credit. 1615872 5 390004 rniwa 2020-02-06 15:18:21 -0800 Comment on attachment 390004 patch View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review > LayoutTests/ChangeLog:10 > + Based on the original test by Tim Guan-tin Chien. Ah, I missed this line. 1615969 6 390004 commit-queue 2020-02-06 18:07:29 -0800 Comment on attachment 390004 patch Clearing flags on attachment: 390004 Committed r255996: <https://trac.webkit.org/changeset/255996> 1615970 7 commit-queue 2020-02-06 18:07:31 -0800 All reviewed patches have been landed. Closing bug. 1615971 8 webkit-bug-importer 2020-02-06 18:08:13 -0800 <rdar://problem/59246972> 390004 2020-02-06 14:58:27 -0800 2020-02-06 18:07:29 -0800 patch accelerated-animation-slot-test.patch text/plain 3845 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMTFiMjc0ZmI2ZS4uZTg2MDE1YTU0MjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAyMC0wMi0wNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAg QWRkIHNsb3QgYmFzZWQgdGVzdCBmb3IgdGhlIGFjY2VsZXJhdGVkIGFuaW1hdGlvbnMgZnJlZXpp bmcgYnVnICgyMDEwNDgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDczNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAyMDEwNDggaGFkIGEgc2ltcGxlciB0ZXN0IGNhc2UgYnV0IGl0IGlzIGdvb2QgdG8g YWRkIG9uZSBmb3IgdGhlIG9yaWdpbmFsIHByb2JsZW0gdG9vLgorCisgICAgICAgIEJhc2VkIG9u IHRoZSBvcmlnaW5hbCB0ZXN0IGJ5IFRpbSBHdWFuLXRpbiBDaGllbi4KKworICAgICAgICAqIHdl YmFuaW1hdGlvbnMvYWNjZWxlcmF0ZWQtYW5pbWF0aW9uLXNsb3QtaW52YWxpZGF0aW9uLWV4cGVj dGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHdlYmFuaW1hdGlvbnMvYWNjZWxlcmF0ZWQtYW5p bWF0aW9uLXNsb3QtaW52YWxpZGF0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAyLTA2ICBKYWNv YiBVcGhvZmYgIDxqYWNvYl91cGhvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046 IFsgbWFjT1Mgd2sxIF0gQVNTRVJUSU9OIEZBSUxFRDogX25vdGlmaWNhdGlvbnMuY29udGFpbnMo bm90aWZpY2F0aW9uSUQpIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbm90aWZpY2F0 aW9ucy9jb25zdHJ1Y3Rvci1iYXNpYy5odG1sIGlzIGZsYWt5IGNyYXNoaW5nCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy93ZWJhbmltYXRpb25zL2FjY2VsZXJhdGVkLWFuaW1hdGlvbi1zbG90LWlu dmFsaWRhdGlvbi1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvd2ViYW5pbWF0aW9ucy9hY2Nl bGVyYXRlZC1hbmltYXRpb24tc2xvdC1pbnZhbGlkYXRpb24tZXhwZWN0ZWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uN2EwZTA3OGVhZTAKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy93ZWJhbmltYXRpb25zL2FjY2VsZXJhdGVkLWFuaW1hdGlvbi1z bG90LWludmFsaWRhdGlvbi1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMTUgQEAKKzxzdHlsZT4K K2RpdiB7CisgICAgYmFja2dyb3VuZC1jb2xvcjogcmViZWNjYXB1cnBsZTsKKyAgICB3aWR0aDog MTAwcHg7CisgICAgaGVpZ2h0OiAxMDBweDsKK30KKworI3Rlc3R7CisgICAgcG9zaXRpb246IGFi c29sdXRlOworICAgIHRvcDogMjAwcHg7CisgICAgbGVmdDogMjAwcHg7Cit9CisKKzwvc3R5bGU+ Cis8ZGl2IGlkPXRlc3Q+PC9kaXY+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhbmltYXRp b25zL2FjY2VsZXJhdGVkLWFuaW1hdGlvbi1zbG90LWludmFsaWRhdGlvbi5odG1sIGIvTGF5b3V0 VGVzdHMvd2ViYW5pbWF0aW9ucy9hY2NlbGVyYXRlZC1hbmltYXRpb24tc2xvdC1pbnZhbGlkYXRp b24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uMzdkODJmZTA4 ZWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy93ZWJhbmltYXRpb25zL2FjY2VsZXJh dGVkLWFuaW1hdGlvbi1zbG90LWludmFsaWRhdGlvbi5odG1sCkBAIC0wLDAgKzEsODggQEAKKzxz dHlsZT4KKworZGl2IHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWJlY2NhcHVycGxlOworICAg IHdpZHRoOiAxMDBweDsKKyAgICBoZWlnaHQ6IDEwMHB4OworfQorCisjZmlyc3QgeworICAgIHBv c2l0aW9uOiBhYnNvbHV0ZTsKKyAgICB0b3A6IDEwcHg7CisgICAgbGVmdDogMTBweDsKK30KKwor I3NlY29uZCB7CisgICAgcG9zaXRpb246IGFic29sdXRlOworICAgIHRvcDogMjAwcHg7CisgICAg bGVmdDogMjAwcHg7Cit9CisKKy5hbmltYXRlLWNsYXNzIHsKKyAgICBhbmltYXRpb246IDFzIGxp bmVhciAwcyAxIG5vcm1hbCBzY2FsZTsKK30KKworLmZpcnN0LWxldHRlcjo6Zmlyc3QtbGV0dGVy IHsKKyAgICBjb2xvcjpyZWQ7Cit9CisKK0BrZXlmcmFtZXMgc2NhbGUgeworICAgIDAlIHsKKyAg ICAgICAgdHJhbnNmb3JtOiBzY2FsZSgwKTsKKyAgICB9CisKKyAgICAxMCUgeworICAgICAgICB0 cmFuc2Zvcm06IHNjYWxlKDEpOworICAgIH0KKworICAgIDEwMCUgeworICAgICAgICB0cmFuc2Zv cm06IHNjYWxlKDEpOworICAgIH0KK30KKworPC9zdHlsZT4KKzxzY3JpcHQ+CisKK2lmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKword2luZG93 Lm9ubG9hZCA9IGFzeW5jIGZ1bmN0aW9uKCkgeworICAgIGxldCBzaGFkb3dSb290ID0gZG9jdW1l bnQuYm9keS5hdHRhY2hTaGFkb3coeyBtb2RlOiAib3BlbiIgfSk7CisKKyAgICAvLyBQdXQgYSBu YW1lZCBzbG90IGFuZCBhc3NpZ24gYW4gZWxlbWVudCB0byBpdC4KKyAgICBzaGFkb3dSb290Lmlu bmVySFRNTCA9IGA8c2xvdCBuYW1lPSJmaXJzdCI+PC9zbG90PmA7CisgICAgbGV0IGZpcnN0RWxl bWVudCA9IGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi ZGl2IikpOworICAgIGZpcnN0RWxlbWVudC5zbG90ID0gImZpcnN0IjsKKyAgICBmaXJzdEVsZW1l bnQuaWQgPSAiZmlyc3QiOworCisgICAgYXdhaXQgbmV3IFByb21pc2UocmVzb2x2ZSA9PiByZXF1 ZXN0QW5pbWF0aW9uRnJhbWUocmVzb2x2ZSkpOworCisgICAgLy8gQ3JlYXRlIGFub3RoZXIgbmFt ZWQgc2xvdCBhbmQgYXNzaWduIGFub3RoZXIgZWxlbWVudCB0byBpdC4KKyAgICBsZXQgc2Vjb25k U2xvdCA9IHNoYWRvd1Jvb3QuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic2xv dCIpKTsKKyAgICBzZWNvbmRTbG90Lm5hbWUgPSAic2Vjb25kIjsKKworICAgIC8vIFN0YXJ0IGFu aW1hdGlvbiBpbiB0aGUgc2Vjb25kcyBzbG90LgorICAgIGxldCBzZWNvbmRFbGVtZW50ID0gZG9j dW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKSk7Cisg ICAgc2Vjb25kRWxlbWVudC5zbG90ID0gInNlY29uZCI7CisgICAgc2Vjb25kRWxlbWVudC5jbGFz c05hbWUgPSAiYW5pbWF0ZS1jbGFzcyI7CisgICAgc2Vjb25kRWxlbWVudC5pZCA9ICJzZWNvbmQi OworCisgICAgY29uc3QgYW5pbWF0aW9uID0gc2Vjb25kRWxlbWVudC5nZXRBbmltYXRpb25zKClb MF07CisKKyAgICBhd2FpdCBhbmltYXRpb24ucmVhZHk7CisKKyAgICBhd2FpdCBuZXcgUHJvbWlz ZShyZXNvbHZlID0+IHJlcXVlc3RBbmltYXRpb25GcmFtZShyZXNvbHZlKSk7CisgICAgYXdhaXQg bmV3IFByb21pc2UocmVzb2x2ZSA9PiByZXF1ZXN0QW5pbWF0aW9uRnJhbWUocmVzb2x2ZSkpOwor CisgICAgZmlyc3RFbGVtZW50LnJlbW92ZSgpOworCisgICAgLy8gV2FpdCB1bnRpbCBhbmltYXRp b24gaGFzIHByb2dyZXNzZWQgc29tZSBiZWZvcmUgc25hcHNob3R0aW5nIHRoZSB0ZXN0IHJlc3Vs dC4KKyAgICB3aGlsZSAoYW5pbWF0aW9uLmN1cnJlbnRUaW1lIDwgMTAwKQorICAgICAgICBhd2Fp dCBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHJlcXVlc3RBbmltYXRpb25GcmFtZShyZXNvbHZlKSk7 CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5 RG9uZSgpOworfQorCis8L3NjcmlwdD4KKwo=