207328 2020-02-06 05:27:45 -0800 Search cancel button becomes visible when there's a hover effect in CSS 2020-02-17 01:38:14 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207379 InRadar P2 Normal --- 1 cgarcia webkit-unassigned aperez cdumez dbates esprehn+autocc ews-watchlist gyuyoung.kim koivisto mifenton webkit-bug-importer oldest_to_newest 1615590 0 389942 cgarcia 2020-02-06 05:27:45 -0800 Created attachment 389942 Test case See the attached test case. To reproduce: 1. Click on the search cancel button to clear the text. The button is now hidden 2. Move the mouse and the button is visible again Clicking again in the search field, or any other part of the document makes the button hide permanently. So, when the search field value is emptied the button visibility is correctly set to hidden in RenderSearchField::updateCancelButtonVisibility(), but as soon as the mouse is moved, the style visibility is changed to visible again (I couldn't find where). If we remove the hover effect from the style then the button is correctly hidden, so it has to do with that somehow. 1615605 1 389949 cgarcia 2020-02-06 06:41:36 -0800 Created attachment 389949 WIP: update the style when a new renderer is created It's the render tree updater that creates a new renderer for the search cancel button element in RenderTreeUpdater::updateRenderTree(). In that case, the input element doesn't know about it and RenderSearchField::updateCancelButtonVisibility() is not called. This patch fixes the problem by updating the style when the new renderer is created. I'll try to convert the attached test case into a proper layout test. 1616096 2 390068 cgarcia 2020-02-07 02:08:02 -0800 Created attachment 390068 Patch 1616785 3 cgarcia 2020-02-10 00:26:50 -0800 hmm, the test doesn't pass in iOS for some reason. I will need some help there, I don't have a way to test in iOS. 1616804 4 cgarcia 2020-02-10 01:50:34 -0800 Ah, I always forget iOS doesn't support eventSender.mouseDown/Up/MoveTo, I'll just skip this test in iOS. 1616847 5 390249 cgarcia 2020-02-10 07:05:45 -0800 Created attachment 390249 Patch 1619602 6 cgarcia 2020-02-17 01:37:22 -0800 Committed r256725: <https://trac.webkit.org/changeset/256725> 1619603 7 webkit-bug-importer 2020-02-17 01:38:14 -0800 <rdar://problem/59504132> 389942 2020-02-06 05:27:45 -0800 2020-02-06 05:27:45 -0800 Test case test.html text/html 410 cgarcia PGh0bWw+CiAgPGhlYWQ+CiAgICA8c3R5bGU+CiAgICAgIGlucHV0W3R5cGU9InNlYXJjaCJdOjot d2Via2l0LXNlYXJjaC1jYW5jZWwtYnV0dG9uIHsKICAgICAgICAgIC13ZWJraXQtYXBwZWFyYW5j ZTogbm9uZTsKICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7CiAgICAgICAgICBoZWln aHQ6IDFlbTsKICAgICAgICAgIHdpZHRoOiAxZW07CiAgICAgIH0KCiAgICAgIGlucHV0W3R5cGU9 InNlYXJjaCJdOjotd2Via2l0LXNlYXJjaC1jYW5jZWwtYnV0dG9uOmhvdmVyIHsKICAgICAgICAg IGJhY2tncm91bmQtY29sb3I6IHJlZDsKICAgICAgfQoKICAgIDwvc3R5bGU+CiAgPC9oZWFkPgog IDxib2R5PgogICAgPGlucHV0IHR5cGU9InNlYXJjaCIgdmFsdWU9IlNlYXJjaCIvPgogIDwvYm9k eT4KPC9odG1sPgo= 389949 2020-02-06 06:41:36 -0800 2020-02-07 02:08:02 -0800 WIP: update the style when a new renderer is created wip-search-cancel-button.diff text/plain 1642 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJF bGVtZW50cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVy RWxlbWVudHMuY3BwCmluZGV4IDU1YzBjMzNiYmQzLi44ZWM5ZjMzMTQ3MiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMu Y3BwCkBAIC0yNjQsNiArMjY0LDE0IEBAIFJlZjxTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1l bnQ+IFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uRWxlbWVudDo6Y3JlYXRlKERvY3VtCiAgICAgcmV0 dXJuIGFkb3B0UmVmKCpuZXcgU2VhcmNoRmllbGRDYW5jZWxCdXR0b25FbGVtZW50KGRvY3VtZW50 KSk7CiB9CiAKK1JlbmRlclB0cjxSZW5kZXJFbGVtZW50PiBTZWFyY2hGaWVsZENhbmNlbEJ1dHRv bkVsZW1lbnQ6OmNyZWF0ZUVsZW1lbnRSZW5kZXJlcihSZW5kZXJTdHlsZSYmIHN0eWxlLCBjb25z dCBSZW5kZXJUcmVlUG9zaXRpb24mIHBvc2l0aW9uKQoreworICAgIFJlZlB0cjxIVE1MSW5wdXRF bGVtZW50PiBpbnB1dChkb3duY2FzdDxIVE1MSW5wdXRFbGVtZW50PihzaGFkb3dIb3N0KCkpKTsK KyAgICBpZiAoaW5wdXQpCisgICAgICAgIHN0eWxlLnNldFZpc2liaWxpdHkoc3R5bGUudmlzaWJp bGl0eSgpID09IFZpc2liaWxpdHk6OkhpZGRlbiB8fCBpbnB1dC0+dmFsdWUoKS5pc0VtcHR5KCkg PyBWaXNpYmlsaXR5OjpIaWRkZW4gOiBWaXNpYmlsaXR5OjpWaXNpYmxlKTsKKyAgICByZXR1cm4g SFRNTERpdkVsZW1lbnQ6OmNyZWF0ZUVsZW1lbnRSZW5kZXJlcihXVEZNb3ZlKHN0eWxlKSwgcG9z aXRpb24pOworfQorCiB2b2lkIFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uRWxlbWVudDo6ZGVmYXVs dEV2ZW50SGFuZGxlcihFdmVudCYgZXZlbnQpCiB7CiAgICAgUmVmUHRyPEhUTUxJbnB1dEVsZW1l bnQ+IGlucHV0KGRvd25jYXN0PEhUTUxJbnB1dEVsZW1lbnQ+KHNoYWRvd0hvc3QoKSkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJbm5lckVsZW1l bnRzLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVu dHMuaAppbmRleCA5NjYyOTU5Yjc5NC4uMzgxMTMzMDIwMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oCkBAIC0xMTIs NiArMTEyLDcgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBTZWFyY2hGaWVsZENhbmNlbEJ1dHRv bkVsZW1lbnQoRG9jdW1lbnQmKTsKICAgICBib29sIGlzTW91c2VGb2N1c2FibGUoKSBjb25zdCBv dmVycmlkZSB7IHJldHVybiBmYWxzZTsgfQorICAgIFJlbmRlclB0cjxSZW5kZXJFbGVtZW50PiBj cmVhdGVFbGVtZW50UmVuZGVyZXIoUmVuZGVyU3R5bGUmJiwgY29uc3QgUmVuZGVyVHJlZVBvc2l0 aW9uJikgb3ZlcnJpZGU7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 390068 2020-02-07 02:08:02 -0800 2020-02-10 07:05:45 -0800 Patch wcore-search-cancel-button.diff text/plain 5709 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0OTE1YjIzNGEwNS4uYTkxY2I1ZTMwMTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAyMC0wMi0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgU2VhcmNoIGNhbmNlbCBidXR0b24gYmVjb21lcyB2aXNpYmxlIHdoZW4gdGhlcmUn cyBhIGhvdmVyIGVmZmVjdCBpbiBDU1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzMyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1dHRvbi1ob3Zlci1l eHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwt YnV0dG9uLWhvdmVyLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAyLTA1ICBZdXN1a2UgU3V6dWtpICA8 eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dURl0gVHJ5IHVzaW5nIDc1JSBsb2FkIGZh Y3RvciBmb3IgSGFzaFRhYmxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Nl YXJjaC1jYW5jZWwtYnV0dG9uLWhvdmVyLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL3NlYXJjaC1jYW5jZWwtYnV0dG9uLWhvdmVyLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmFmYjUzNTliNjJlCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1dHRvbi1ob3Zlci1l eHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMjMgQEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+Citp bnB1dFt0eXBlPSJzZWFyY2giXSB7CisgICAgY29sb3I6IHRyYW5zcGFyZW50OworfQorCitpbnB1 dFt0eXBlPSJzZWFyY2giXTo6LXdlYmtpdC1zZWFyY2gtY2FuY2VsLWJ1dHRvbiB7CisgICAgLXdl YmtpdC1hcHBlYXJhbmNlOiBub25lOworICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7CisgICAg aGVpZ2h0OiAxZW07CisgICAgd2lkdGg6IDFlbTsKK30KKworaW5wdXRbdHlwZT0ic2VhcmNoIl06 Oi13ZWJraXQtc2VhcmNoLWNhbmNlbC1idXR0b246aG92ZXIgeworICAgIGJhY2tncm91bmQtY29s b3I6IHJlZDsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxpbnB1dCB0eXBlPSJzZWFy Y2giIGlkPSJzZWFyY2giIGF1dG9mb2N1cy8+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwtYnV0dG9uLWhvdmVyLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwtYnV0dG9uLWhvdmVyLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmMxYjBkMTlmNWJlCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1dHRv bi1ob3Zlci5odG1sCkBAIC0wLDAgKzEsMzQgQEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+Citp bnB1dFt0eXBlPSJzZWFyY2giXSB7CisgICAgY29sb3I6IHRyYW5zcGFyZW50OworfQorCitpbnB1 dFt0eXBlPSJzZWFyY2giXTo6LXdlYmtpdC1zZWFyY2gtY2FuY2VsLWJ1dHRvbiB7CisgICAgLXdl YmtpdC1hcHBlYXJhbmNlOiBub25lOworICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7CisgICAg aGVpZ2h0OiAxZW07CisgICAgd2lkdGg6IDFlbTsKK30KKworaW5wdXRbdHlwZT0ic2VhcmNoIl06 Oi13ZWJraXQtc2VhcmNoLWNhbmNlbC1idXR0b246aG92ZXIgeworICAgIGJhY2tncm91bmQtY29s b3I6IHJlZDsKK30KKzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2NvbW1vbi5qcyI+ PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxpbnB1dCB0eXBlPSJzZWFyY2giIGlkPSJzZWFy Y2giIHZhbHVlPSJmb28iLz4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAg ICB2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic2VhcmNoIik7CisgICAgdmFy IHBvc2l0aW9uID0gc2VhcmNoQ2FuY2VsQnV0dG9uUG9zaXRpb24oaW5wdXQpOworICAgIGV2ZW50 U2VuZGVyLm1vdXNlTW92ZVRvKHBvc2l0aW9uLngsIHBvc2l0aW9uLnkpOworICAgIGV2ZW50U2Vu ZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKyAgICBldmVudFNl bmRlci5tb3VzZU1vdmVUbyhwb3NpdGlvbi54ICsgMSwgcG9zaXRpb24ueSk7Cit9Cis8L3Njcmlw dD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ZTUzYTU2ZjA5MC4uMGRjNWM5Mjdl YTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAyMC0wMi0wNyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgU2VhcmNoIGNhbmNlbCBi dXR0b24gYmVjb21lcyB2aXNpYmxlIHdoZW4gdGhlcmUncyBhIGhvdmVyIGVmZmVjdCBpbiBDU1MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzMyOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBhIGN1 c3RvbSBzdHlsZSByZXNvbHZlciBmb3Igc2VhcmNoIGNhbmNlbCBidXR0b24gZWxlbWVudCB0byBl bnN1cmUgaXQncyBhbHdheXMgaGlkZGVuIHdoZW4gdGhlIGlucHV0IGVsZW1lbnQKKyAgICAgICAg aXMgZW1wdHkuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1dHRv bi1ob3Zlci5odG1sCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxl bWVudHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VhcmNoRmllbGRDYW5jZWxCdXR0b25FbGVt ZW50OjpTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQpOiBDYWxsIHNldEhhc0N1c3RvbVN0 eWxlUmVzb2x2ZUNhbGxiYWNrcygpLgorICAgICAgICAoV2ViQ29yZTo6U2VhcmNoRmllbGRDYW5j ZWxCdXR0b25FbGVtZW50OjpyZXNvbHZlQ3VzdG9tU3R5bGUpOiBTZXQgdGhlIHJlbmRlciBzdHls ZSB2aXNpYmlsaXR5IGRlcGVuZGluZyBvbgorICAgICAgICBpbnB1dCBjdXJyZW50IHZhbHVlLgor ICAgICAgICAqIGh0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oOgorCiAyMDIw LTAyLTA2ICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXJ2 aWNlV29ya2VyUHJvdmlkZXI6OnJlZ2lzdGVyU2VydmljZVdvcmtlckNsaWVudHMgaXMgbm8gbG9u Z2VyIG5lZWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENv bnRyb2xJbm5lckVsZW1lbnRzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRD b250cm9sSW5uZXJFbGVtZW50cy5jcHAKaW5kZXggNTVjMGMzM2JiZDMuLjNiMmIwZGIzNmUyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxl bWVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5u ZXJFbGVtZW50cy5jcHAKQEAgLTI1Miw2ICsyNTIsOCBAQCBib29sIFNlYXJjaEZpZWxkUmVzdWx0 c0J1dHRvbkVsZW1lbnQ6OndpbGxSZXNwb25kVG9Nb3VzZUNsaWNrRXZlbnRzKCkKIGlubGluZSBT ZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OlNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uRWxl bWVudChEb2N1bWVudCYgZG9jdW1lbnQpCiAgICAgOiBIVE1MRGl2RWxlbWVudChkaXZUYWcsIGRv Y3VtZW50KQogeworICAgIHNldEhhc0N1c3RvbVN0eWxlUmVzb2x2ZUNhbGxiYWNrcygpOworCiAg ICAgc2V0UHNldWRvKEF0b21TdHJpbmcoIi13ZWJraXQtc2VhcmNoLWNhbmNlbC1idXR0b24iLCBB dG9tU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwogI2lmICFQTEFURk9STShJT1NfRkFN SUxZKQogICAgIHNldEF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oYXJpYV9sYWJlbEF0 dHIsIEFYU2VhcmNoRmllbGRDYW5jZWxCdXR0b25UZXh0KCkpOwpAQCAtMjY0LDYgKzI2NiwxNCBA QCBSZWY8U2VhcmNoRmllbGRDYW5jZWxCdXR0b25FbGVtZW50PiBTZWFyY2hGaWVsZENhbmNlbEJ1 dHRvbkVsZW1lbnQ6OmNyZWF0ZShEb2N1bQogICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFNlYXJj aEZpZWxkQ2FuY2VsQnV0dG9uRWxlbWVudChkb2N1bWVudCkpOwogfQogCitPcHRpb25hbDxTdHls ZTo6RWxlbWVudFN0eWxlPiBTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OnJlc29sdmVD dXN0b21TdHlsZShjb25zdCBSZW5kZXJTdHlsZSYgcGFyZW50U3R5bGUsIGNvbnN0IFJlbmRlclN0 eWxlKikKK3sKKyAgICBhdXRvIGVsZW1lbnRTdHlsZSA9IHJlc29sdmVTdHlsZSgmcGFyZW50U3R5 bGUpOworICAgIGF1dG8mIGlucHV0RWxlbWVudCA9IGRvd25jYXN0PEhUTUxJbnB1dEVsZW1lbnQ+ KCpzaGFkb3dIb3N0KCkpOworICAgIGVsZW1lbnRTdHlsZS5yZW5kZXJTdHlsZS0+c2V0VmlzaWJp bGl0eShlbGVtZW50U3R5bGUucmVuZGVyU3R5bGUtPnZpc2liaWxpdHkoKSA9PSBWaXNpYmlsaXR5 OjpIaWRkZW4gfHwgaW5wdXRFbGVtZW50LnZhbHVlKCkuaXNFbXB0eSgpID8gVmlzaWJpbGl0eTo6 SGlkZGVuIDogVmlzaWJpbGl0eTo6VmlzaWJsZSk7CisgICAgcmV0dXJuIGVsZW1lbnRTdHlsZTsK K30KKwogdm9pZCBTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhh bmRsZXIoRXZlbnQmIGV2ZW50KQogewogICAgIFJlZlB0cjxIVE1MSW5wdXRFbGVtZW50PiBpbnB1 dChkb3duY2FzdDxIVE1MSW5wdXRFbGVtZW50PihzaGFkb3dIb3N0KCkpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oIGIv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmgKaW5k ZXggOTY2Mjk1OWI3OTQuLjZlMWNiNWZkNDEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuaApAQCAtMTEyLDYgKzExMiw3 IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgU2VhcmNoRmllbGRDYW5jZWxCdXR0b25FbGVtZW50 KERvY3VtZW50Jik7CiAgICAgYm9vbCBpc01vdXNlRm9jdXNhYmxlKCkgY29uc3Qgb3ZlcnJpZGUg eyByZXR1cm4gZmFsc2U7IH0KKyAgICBPcHRpb25hbDxTdHlsZTo6RWxlbWVudFN0eWxlPiByZXNv bHZlQ3VzdG9tU3R5bGUoY29uc3QgUmVuZGVyU3R5bGUmIHBhcmVudFN0eWxlLCBjb25zdCBSZW5k ZXJTdHlsZSogc2hhZG93SG9zdFN0eWxlKSBvdmVycmlkZTsKIH07CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUK 390249 2020-02-10 07:05:45 -0800 2020-02-17 01:26:59 -0800 Patch wcore-search-cancel-hover.diff text/plain 6396 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMzMxNTJjNWQ0ZC4uOTcwM2M4NzBjZmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAyMC0wMi0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgU2VhcmNoIGNhbmNlbCBidXR0b24gYmVjb21lcyB2aXNpYmxlIHdoZW4gdGhlcmUn cyBhIGhvdmVyIGVmZmVjdCBpbiBDU1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwNzMyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1dHRvbi1ob3Zlci1l eHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwt YnV0dG9uLWhvdmVyLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAyLTEwICBEaWVnbyBQaW5vIEdhcmNp YSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gR2FyZGVuaW5nLCB1cGRhdGUg YmFzZWxpbmVzIGFuZCBzeW5jaHJvbml6ZSB3aXRoIEdUSwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1dHRvbi1ob3Zlci1leHBlY3RlZC5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1dHRvbi1ob3Zlci1leHBlY3Rl ZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi5hZmI1MzU5YjYy ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLWNhbmNl bC1idXR0b24taG92ZXItZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDIzIEBACis8aHRtbD4KKzxo ZWFkPgorPHN0eWxlPgoraW5wdXRbdHlwZT0ic2VhcmNoIl0geworICAgIGNvbG9yOiB0cmFuc3Bh cmVudDsKK30KKworaW5wdXRbdHlwZT0ic2VhcmNoIl06Oi13ZWJraXQtc2VhcmNoLWNhbmNlbC1i dXR0b24geworICAgIC13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsKKyAgICBiYWNrZ3JvdW5kLWNv bG9yOiBibHVlOworICAgIGhlaWdodDogMWVtOworICAgIHdpZHRoOiAxZW07Cit9CisKK2lucHV0 W3R5cGU9InNlYXJjaCJdOjotd2Via2l0LXNlYXJjaC1jYW5jZWwtYnV0dG9uOmhvdmVyIHsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8 aW5wdXQgdHlwZT0ic2VhcmNoIiBpZD0ic2VhcmNoIiBhdXRvZm9jdXMvPgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1 dHRvbi1ob3Zlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWJ1 dHRvbi1ob3Zlci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi5j MWIwZDE5ZjViZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2Vh cmNoLWNhbmNlbC1idXR0b24taG92ZXIuaHRtbApAQCAtMCwwICsxLDM0IEBACis8aHRtbD4KKzxo ZWFkPgorPHN0eWxlPgoraW5wdXRbdHlwZT0ic2VhcmNoIl0geworICAgIGNvbG9yOiB0cmFuc3Bh cmVudDsKK30KKworaW5wdXRbdHlwZT0ic2VhcmNoIl06Oi13ZWJraXQtc2VhcmNoLWNhbmNlbC1i dXR0b24geworICAgIC13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsKKyAgICBiYWNrZ3JvdW5kLWNv bG9yOiBibHVlOworICAgIGhlaWdodDogMWVtOworICAgIHdpZHRoOiAxZW07Cit9CisKK2lucHV0 W3R5cGU9InNlYXJjaCJdOjotd2Via2l0LXNlYXJjaC1jYW5jZWwtYnV0dG9uOmhvdmVyIHsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Cit9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9InJlc291 cmNlcy9jb21tb24uanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8aW5wdXQgdHlwZT0i c2VhcmNoIiBpZD0ic2VhcmNoIiB2YWx1ZT0iZm9vIi8+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50 ZXN0UnVubmVyKSB7CisgICAgdmFyIGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNl YXJjaCIpOworICAgIHZhciBwb3NpdGlvbiA9IHNlYXJjaENhbmNlbEJ1dHRvblBvc2l0aW9uKGlu cHV0KTsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhwb3NpdGlvbi54LCBwb3NpdGlvbi55 KTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVw KCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8ocG9zaXRpb24ueCArIDEsIHBvc2l0aW9u LnkpOworfQorPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZDc4NjY0ZWZlNmEuLmExNzg3Zjli ZmVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3Rh dGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25z CkBAIC0xMDI3LDYgKzEwMjcsNyBAQCBmYXN0L3NoYWRvdy1kb20vZnVsbHNjcmVlbi1pbi1zaGFk b3ctd2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50Lmh0bWwgWyBTa2lwCiBmYXN0L3NoYWRv dy1kb20vZnVsbHNjcmVlbi1pbi1zbG90LWZ1bGxzY3JlZW5FbGVtZW50Lmh0bWwgWyBTa2lwIF0K IGZhc3Qvc2hhZG93LWRvbS9mdWxsc2NyZWVuLWluLXNsb3Qtd2Via2l0Q3VycmVudEZ1bGxTY3Jl ZW5FbGVtZW50Lmh0bWwgWyBTa2lwIF0KIGZhc3QvZXZlbnRzL2ZvY3VzLWxhYmVsLWxlZ2VuZC1l bGVtZW50cy13aXRoLXRhYi5odG1sIFsgU2tpcCBdCitmYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwt YnV0dG9uLWhvdmVyLmh0bWwgWyBTa2lwIF0KIAogIyBObyB0b3VjaCBldmVudHMKIGZhc3Qvdmlz dWFsLXZpZXdwb3J0L2lvcy9ib3R0b20tYmFyLXdpdGgta2V5Ym9hcmQuaHRtbCBbIFNraXAgXQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDJhNzEyNTNiZWIxLi45NDFkOWJhMjJhMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIxIEBACisyMDIwLTAyLTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KKworICAgICAgICBTZWFyY2ggY2FuY2VsIGJ1dHRvbiBiZWNvbWVzIHZpc2libGUg d2hlbiB0aGVyZSdzIGEgaG92ZXIgZWZmZWN0IGluIENTUworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGEgY3VzdG9tIHN0eWxlIHJlc29sdmVyIGZv ciBzZWFyY2ggY2FuY2VsIGJ1dHRvbiBlbGVtZW50IHRvIGVuc3VyZSBpdCdzIGFsd2F5cyBoaWRk ZW4gd2hlbiB0aGUgaW5wdXQgZWxlbWVudAorICAgICAgICBpcyBlbXB0eS4KKworICAgICAgICBU ZXN0OiBmYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwtYnV0dG9uLWhvdmVyLmh0bWwKKworICAgICAg ICAqIGh0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OlNlYXJjaEZpZWxkQ2FuY2Vs QnV0dG9uRWxlbWVudCk6IENhbGwgc2V0SGFzQ3VzdG9tU3R5bGVSZXNvbHZlQ2FsbGJhY2tzKCku CisgICAgICAgIChXZWJDb3JlOjpTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OnJlc29s dmVDdXN0b21TdHlsZSk6IFNldCB0aGUgcmVuZGVyIHN0eWxlIHZpc2liaWxpdHkgZGVwZW5kaW5n IG9uCisgICAgICAgIGlucHV0IGN1cnJlbnQgdmFsdWUuCisgICAgICAgICogaHRtbC9zaGFkb3cv VGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmg6CisKIDIwMjAtMDItMTAgIFJvYiBCdWlzICA8cmJ1 aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgc2V0SFRUUEFjY2VwdCBjYWxsIGZvciBt YWluIHJlc291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4 dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1Rl eHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHAKaW5kZXggNTVjMGMzM2JiZDMuLjNiMmIwZGIzNmUy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVy RWxlbWVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9s SW5uZXJFbGVtZW50cy5jcHAKQEAgLTI1Miw2ICsyNTIsOCBAQCBib29sIFNlYXJjaEZpZWxkUmVz dWx0c0J1dHRvbkVsZW1lbnQ6OndpbGxSZXNwb25kVG9Nb3VzZUNsaWNrRXZlbnRzKCkKIGlubGlu ZSBTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OlNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9u RWxlbWVudChEb2N1bWVudCYgZG9jdW1lbnQpCiAgICAgOiBIVE1MRGl2RWxlbWVudChkaXZUYWcs IGRvY3VtZW50KQogeworICAgIHNldEhhc0N1c3RvbVN0eWxlUmVzb2x2ZUNhbGxiYWNrcygpOwor CiAgICAgc2V0UHNldWRvKEF0b21TdHJpbmcoIi13ZWJraXQtc2VhcmNoLWNhbmNlbC1idXR0b24i LCBBdG9tU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwogI2lmICFQTEFURk9STShJT1Nf RkFNSUxZKQogICAgIHNldEF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oYXJpYV9sYWJl bEF0dHIsIEFYU2VhcmNoRmllbGRDYW5jZWxCdXR0b25UZXh0KCkpOwpAQCAtMjY0LDYgKzI2Niwx NCBAQCBSZWY8U2VhcmNoRmllbGRDYW5jZWxCdXR0b25FbGVtZW50PiBTZWFyY2hGaWVsZENhbmNl bEJ1dHRvbkVsZW1lbnQ6OmNyZWF0ZShEb2N1bQogICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFNl YXJjaEZpZWxkQ2FuY2VsQnV0dG9uRWxlbWVudChkb2N1bWVudCkpOwogfQogCitPcHRpb25hbDxT dHlsZTo6RWxlbWVudFN0eWxlPiBTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OnJlc29s dmVDdXN0b21TdHlsZShjb25zdCBSZW5kZXJTdHlsZSYgcGFyZW50U3R5bGUsIGNvbnN0IFJlbmRl clN0eWxlKikKK3sKKyAgICBhdXRvIGVsZW1lbnRTdHlsZSA9IHJlc29sdmVTdHlsZSgmcGFyZW50 U3R5bGUpOworICAgIGF1dG8mIGlucHV0RWxlbWVudCA9IGRvd25jYXN0PEhUTUxJbnB1dEVsZW1l bnQ+KCpzaGFkb3dIb3N0KCkpOworICAgIGVsZW1lbnRTdHlsZS5yZW5kZXJTdHlsZS0+c2V0Vmlz aWJpbGl0eShlbGVtZW50U3R5bGUucmVuZGVyU3R5bGUtPnZpc2liaWxpdHkoKSA9PSBWaXNpYmls aXR5OjpIaWRkZW4gfHwgaW5wdXRFbGVtZW50LnZhbHVlKCkuaXNFbXB0eSgpID8gVmlzaWJpbGl0 eTo6SGlkZGVuIDogVmlzaWJpbGl0eTo6VmlzaWJsZSk7CisgICAgcmV0dXJuIGVsZW1lbnRTdHls ZTsKK30KKwogdm9pZCBTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIoRXZlbnQmIGV2ZW50KQogewogICAgIFJlZlB0cjxIVE1MSW5wdXRFbGVtZW50PiBp bnB1dChkb3duY2FzdDxIVE1MSW5wdXRFbGVtZW50PihzaGFkb3dIb3N0KCkpKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5o IGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmgK aW5kZXggOTY2Mjk1OWI3OTQuLjZlMWNiNWZkNDEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuaApAQCAtMTEyLDYgKzEx Miw3IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgU2VhcmNoRmllbGRDYW5jZWxCdXR0b25FbGVt ZW50KERvY3VtZW50Jik7CiAgICAgYm9vbCBpc01vdXNlRm9jdXNhYmxlKCkgY29uc3Qgb3ZlcnJp ZGUgeyByZXR1cm4gZmFsc2U7IH0KKyAgICBPcHRpb25hbDxTdHlsZTo6RWxlbWVudFN0eWxlPiBy ZXNvbHZlQ3VzdG9tU3R5bGUoY29uc3QgUmVuZGVyU3R5bGUmIHBhcmVudFN0eWxlLCBjb25zdCBS ZW5kZXJTdHlsZSogc2hhZG93SG9zdFN0eWxlKSBvdmVycmlkZTsKIH07CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUK