207325 2020-02-06 04:16:44 -0800 Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h) 2020-02-11 14:53:15 -0800 1 1 1 Unclassified WebKit WebRTC Safari 13 iPhone / iPad iOS 13 RESOLVED FIXED InRadar P2 Normal --- 1 daginge youennf commit-queue eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1615585 0 daginge 2020-02-06 04:16:44 -0800 If you call RTCRtpSender.getCapabilities("video") on iOS 13.4, it returns null. Previously this returned an object with available codecs. Repro steps: 1. Go to https://codepen.io/daginge/full/XWbWeWN on iOS 13.4 2. Accept camera permissions (unsure if this is actually neccessary, but included it anyway) 3. See that "Available codecs" in the log is null. If you test this on 13.3 it returns as expected. Impact: We use this to determine if some legacy devices support H264 on Chrome. This falsely triggered an error message on iOS that H264 is not supported. Workaround: Just assume that iOS 13.4 supports H264 and VP8. 1615661 1 webkit-bug-importer 2020-02-06 08:48:21 -0800 <rdar://problem/59224810> 1615665 2 youennf 2020-02-06 08:49:27 -0800 Seems bad, reproed it for both audio and video. 1616056 3 youennf 2020-02-06 23:38:01 -0800 Hum, the current workaround is to instantiate a peer connection and then to call getCapabilities. 1617536 4 390401 youennf 2020-02-11 11:48:10 -0800 Created attachment 390401 Patch 1617664 5 390401 commit-queue 2020-02-11 14:53:14 -0800 Comment on attachment 390401 Patch Clearing flags on attachment: 390401 Committed r256377: <https://trac.webkit.org/changeset/256377> 1617665 6 commit-queue 2020-02-11 14:53:15 -0800 All reviewed patches have been landed. Closing bug. 390401 2020-02-11 11:48:10 -0800 2020-02-11 14:53:14 -0800 Patch bug-207325-20200211114809.patch text/plain 4977 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2VmY2Y1YzNkMzY4NzAx OThjMWQyNzMzNTdlYzZhM2M1ODM2OWZjZi4uNGYzZjg2YzI3MDg3NjJmODJmMDliZGFiYTlhNTJl OGM0MWE4OTFlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAyLTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uOiBSVENS dHBTZW5kZXIuZ2V0Q2FwYWJpbGl0aWVzKCJ2aWRlbyIpIHJldHVybnMgbnVsbCBvbiBpT1MgMTMu NCAoMTdFNTIyM2gpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDczMjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5MjI0ODEwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnVhbGx5IHRlc3RlZCBh bmQgY292ZXJlZCBieSBBUEkgdGVzdC4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFt L2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckNvY29hLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxpYldlYlJUQ1Byb3ZpZGVyOjp3ZWJSVENBdmFpbGFibGUpOgorICAgICAgICBSZXR1cm4gdHJ1 ZSB1bmNvbmRpdGlvbmFsbHkgb24gaU9TIHNpbmNlIGxpYndlYnJ0Yy5keWxpYiBpcyBhbHdheXMg YXZhaWxhYmxlLgorCiAyMDIwLTAyLTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBQYXJlbnQgc2VydmljZSB3b3JrZXIgY29udHJvbGxlciBzaG91bGQgYmUg dXNlZCBmb3IgY2hpbGQgaWZyYW1lIGFzIHBlciBodHRwczovL3czYy5naXRodWIuaW8vU2Vydmlj ZVdvcmtlci8jY29udHJvbC1hbmQtdXNlLXdpbmRvdy1jbGllbnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRl ckNvY29hLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0 Yy9MaWJXZWJSVENQcm92aWRlckNvY29hLmNwcAppbmRleCA3NDg3YmQxMjE0MzFlYzk4ODVmMTEz Y2E4NTI0MDMzZWEwMzk4NDQ5Li40ZTU1Mzg4ZWFkZTEwOThhZTkxYmZiNDk2NmRhNDRmODk2Yzhh MzQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3 ZWJydGMvTGliV2ViUlRDUHJvdmlkZXJDb2NvYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyQ29jb2EuY3BwCkBA IC03Myw3ICs3MywxMSBAQCB2b2lkIExpYldlYlJUQ1Byb3ZpZGVyQ29jb2E6OnNldEFjdGl2ZShi b29sIHZhbHVlKQogCiBib29sIExpYldlYlJUQ1Byb3ZpZGVyOjp3ZWJSVENBdmFpbGFibGUoKQog eworI2lmIFBMQVRGT1JNKElPUykKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCiAgICAgcmV0dXJu ICFpc051bGxGdW5jdGlvblBvaW50ZXIocnRjOjpMb2dNZXNzYWdlOjpMb2dUb0RlYnVnKTsKKyNl bmRpZgogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTk0ZDk0OGVkMmEwMDE3YWM3M2NlNDhjNWZl NTI5YTQ1ODhkZjNlZS4uNWM3MmFiNjNkMGY4Nzc4OTQxZmE1Y2YyOTFjZjczMzYwMjRiZjI2ZiAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAyLTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K KworICAgICAgICBSZWdyZXNzaW9uOiBSVENSdHBTZW5kZXIuZ2V0Q2FwYWJpbGl0aWVzKCJ2aWRl byIpIHJldHVybnMgbnVsbCBvbiBpT1MgMTMuNCAoMTdFNTIyM2gpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDczMjUKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzU5MjI0ODEwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvR2V0VXNlck1lZGlhLm1tOgor ICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisgICAgICAgIEFkZCBhIHRlc3QgdmFsaWRh dGluZyB0aGF0IFJUQ1J0cFNlbmRlci5nZXRDYXBhYmlsaXRpZXMgZG9lcyBub3QgcmV0dXJuIG51 bGwuCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvZ2V0VXNlck1lZGlhLmh0 bWw6CisKIDIwMjAtMDItMTEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYlNXU2VydmVyQ29ubmVjdGlvbjo6cmVnaXN0ZXJTZXJ2aWNlV29ya2VyQ2xpZW50 IGlzIG5vdCBzZW5kaW5nIElQQyBtZXNzYWdlIHRvIFVJUHJvY2VzcyB3aGVuIGl0IHNob3VsZApk aWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvR2V0VXNlck1lZGlh Lm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvR2V0VXNlck1lZGlhLm1tCmlu ZGV4IDRkZWVlZjVlOWRlN2VjNGUxNDE1ZTQ5YjU1ZDgzY2FhYzJlNjYzNDguLmRmNTRmOTEwZjkw NDJiNmM2NTMzODZjN2Q2NDU3MzU3MGYzM2M1MTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0L0dldFVzZXJNZWRpYS5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdC9HZXRVc2VyTWVkaWEubW0KQEAgLTIwMSw2ICsyMDEsMzUgQEAgVEVT VChXZWJLaXQyLCBDYXB0dXJlU3RvcCkKICAgICB3YXNQcm9tcHRlZCA9IGZhbHNlOwogfQogCitU RVNUKFdlYktpdDIsIEdldENhcGFiaWxpdGllcykKK3sKKyAgICBhdXRvIGNvbmZpZ3VyYXRpb24g PSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0pOworICAgIGF1 dG8gcHJvY2Vzc1Bvb2xDb25maWcgPSBhZG9wdE5TKFtbX1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0 aW9uIGFsbG9jXSBpbml0XSk7CisgICAgYXV0byBwcmVmZXJlbmNlcyA9IFtjb25maWd1cmF0aW9u IHByZWZlcmVuY2VzXTsKKyAgICBwcmVmZXJlbmNlcy5fbWVkaWFDYXB0dXJlUmVxdWlyZXNTZWN1 cmVDb25uZWN0aW9uID0gTk87CisgICAgcHJlZmVyZW5jZXMuX21lZGlhRGV2aWNlc0VuYWJsZWQg PSBZRVM7CisgICAgcHJlZmVyZW5jZXMuX21vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQgPSBZRVM7 CisKKyAgICBhdXRvIG1lc3NhZ2VIYW5kbGVyID0gYWRvcHROUyhbW0dVTU1lc3NhZ2VIYW5kbGVy IGFsbG9jXSBpbml0XSk7CisgICAgW1tjb25maWd1cmF0aW9uLmdldCgpIHVzZXJDb250ZW50Q29u dHJvbGxlcl0gYWRkU2NyaXB0TWVzc2FnZUhhbmRsZXI6bWVzc2FnZUhhbmRsZXIuZ2V0KCkgbmFt ZTpAImd1bSJdOworCisgICAgYXV0byB3ZWJWaWV3ID0gW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBp bml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApIGNvbmZpZ3VyYXRpb246Y29u ZmlndXJhdGlvbi5nZXQoKSBwcm9jZXNzUG9vbENvbmZpZ3VyYXRpb246cHJvY2Vzc1Bvb2xDb25m aWcuZ2V0KCldOworICAgIGF1dG8gZGVsZWdhdGUgPSBhZG9wdE5TKFtbR2V0VXNlck1lZGlhQ2Fw dHVyZVVJRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICB3ZWJWaWV3LlVJRGVsZWdhdGUgPSBk ZWxlZ2F0ZS5nZXQoKTsKKworICAgIHdhc1Byb21wdGVkID0gZmFsc2U7CisKKyAgICBbd2ViVmll dyBsb2FkVGVzdFBhZ2VOYW1lZDpAImdldFVzZXJNZWRpYSJdOworICAgIEVYUEVDVF9UUlVFKHdh aXRVbnRpbENhcHR1cmVTdGF0ZSh3ZWJWaWV3LCBfV0tNZWRpYUNhcHR1cmVTdGF0ZUFjdGl2ZUNh bWVyYSkpOworCisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZ3YXNQcm9tcHRlZCk7CisK KyAgICBkb25lID0gZmFsc2U7CisgICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNj cmlwdDpAImNoZWNrR2V0Q2FwYWJpbGl0aWVzKCkiXTsKKworICAgIFRlc3RXZWJLaXRBUEk6OlV0 aWw6OnJ1bigmZG9uZSk7Cit9CisKICNpZiBXS19IQVZFX0NfU1BJCiBURVNUKFdlYktpdCwgV2Vi QXVkaW9BbmRHZXRVc2VyTWVkaWEpCiB7CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdC9nZXRVc2VyTWVkaWEuaHRtbCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0L2dldFVzZXJNZWRpYS5odG1sCmluZGV4IDEyOGVjMzAzM2VlY2FmYWMxODE3NDJh YWMzNmNiZjhmN2QyZmRkNGMuLmE2M2Y1MDI1MDU2MDViNDBmNTBmNmY2NjQ2ZWY5ZjVmMWIwYzA2 NGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L2dldFVzZXJN ZWRpYS5odG1sCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L2dldFVzZXJN ZWRpYS5odG1sCkBAIC04Nyw2ICs4NywxMSBAQAogICAgICAgICAgICAgICAgICAgICB3aW5kb3cu d2Via2l0Lm1lc3NhZ2VIYW5kbGVycy5ndW0ucG9zdE1lc3NhZ2UoIkRpZCBub3QgcmVjZWl2ZSBh biBlbmRlZCBldmVudCBhZnRlciA1IHNlY29uZHMiKTsKICAgICAgICAgICAgICAgICB9LCA1MDAw KTsKICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gY2hlY2tHZXRDYXBhYmls aXRpZXMoKSB7CisgICAgICAgICAgICAgICAgd2luZG93LndlYmtpdC5tZXNzYWdlSGFuZGxlcnMu Z3VtLnBvc3RNZXNzYWdlKFJUQ1J0cFNlbmRlci5nZXRDYXBhYmlsaXRpZXMoJ3ZpZGVvJykgIT0g bnVsbCA/ICJQQVNTIiA6ICJGQUlMIik7CisgICAgICAgICAgICB9CisKICAgICAgICAgPC9zY3Jp cHQ+CiAgICAgPGhlYWQ+CiAK