207322 2020-02-05 20:30:20 -0800 Web Inspector: REGRESSION(?): Search: selecting a DOM node search result switches to the Elements Tab 2020-03-02 16:54:58 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED MOVED https://bugs.webkit.org/show_bug.cgi?id=207422 InRadar P2 Normal --- 1 hi hi bburg commit-queue hi inspector-bugzilla-changes jonlee timothy webkit-bug-importer oldest_to_newest 1615520 0 hi 2020-02-05 20:30:20 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. search for "div" via the Search Tab => as soon as results start appearing in the Search Tab, Web Inspector will instantly switch to the Elements Tab and select the node that matches the search result 1615521 1 389934 hi 2020-02-05 20:33:39 -0800 Created attachment 389934 Patch 1615760 2 389934 bburg 2020-02-06 13:35:16 -0800 Comment on attachment 389934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review r=me > Source/WebInspectorUI/ChangeLog:14 > + such, we should update it's position in the `_recentTabContentViews` list so that we can use So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ? 1615773 3 389934 hi 2020-02-06 13:43:28 -0800 Comment on attachment 389934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review >> Source/WebInspectorUI/ChangeLog:14 >> + such, we should update it's position in the `_recentTabContentViews` list so that we can use > > So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ? Yup! 1615801 4 389934 commit-queue 2020-02-06 14:15:40 -0800 Comment on attachment 389934 Patch Clearing flags on attachment: 389934 Committed r255980: <https://trac.webkit.org/changeset/255980> 1615802 5 commit-queue 2020-02-06 14:15:41 -0800 All reviewed patches have been landed. Closing bug. 1615804 6 webkit-bug-importer 2020-02-06 14:16:15 -0800 <rdar://problem/59236869> 1616522 7 jonlee 2020-02-07 20:23:31 -0800 Reopening. This was reverted by https://trac.webkit.org/changeset/256086/webkit in b207422. 1624833 8 hi 2020-03-02 16:54:58 -0800 This will be resolved by <https://webkit.org/b/207317>. 389934 2020-02-05 20:33:39 -0800 2020-02-06 14:15:40 -0800 Patch bug-207322-20200205203338.patch text/plain 2333 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNlZGE4NTFmYjcwYmIwMDNmMzc5YmU3MWFjYzlm OWZmZjhlMjI2NGEuLjZlMGQzNDJhYzIyNjcwMTE2MDc2ZTcyZjY2NWE5YjhhMTU3YjI1ZmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAyLTA1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKD8pOiBTZWFyY2g6IHNlbGVjdGluZyBhIERPTSBub2RlIHNlYXJjaCByZXN1bHQg c3dpdGNoZXMgdG8gdGhlIEVsZW1lbnRzIFRhYgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJyb3dzZXIuanM6 CisgICAgICAgIChXSS5UYWJCcm93c2VyLnByb3RvdHlwZS5fdGFiQmFySXRlbVNlbGVjdGVkKToK KyAgICAgICAgVGhlIFNlYXJjaCBUYWIgaXMgbWFya2VkIHN1Y2ggdGhhdCBpdCBpc24ndCBzYXZl ZCB0byBgV0kuX29wZW5UYWJzU2V0dGluZ2AsIGFzIG90aGVyd2lzZQorICAgICAgICBtb3JlIHRo YW4gb25lIFNlYXJjaCBUYWIgY291bGQgYmUgYWRkZWQgdG8gdGhlIHRhYiBiYXIgKG9uZSBmcm9t IHRoZSBzZXR0aW5nIGFuZCBvbmUgZnJvbQorICAgICAgICB0aGUgZGVmYXVsdCBwaW5uZWQgdGFi KS4gSXQgaXMgYWxzbyBtYXJrZWQgYXMgYmVpbmcgcGlubmVkLCBob3dldmVyLCBtZWFuaW5nIHRo YXQgd2Uga25vdyBpdAorICAgICAgICB3aWxsIGFsd2F5cyBiZSBpbiB0aGUgdGFiIGJhciwgZXZl biBpZiB3ZSBhbHNvIGtub3cgaXQgd29uJ3QgYmUgaW4gYFdJLl9vcGVuVGFic1NldHRpbmdgLiBB cworICAgICAgICBzdWNoLCB3ZSBzaG91bGQgdXBkYXRlIGl0J3MgcG9zaXRpb24gaW4gdGhlIGBf cmVjZW50VGFiQ29udGVudFZpZXdzYCBsaXN0IHNvIHRoYXQgd2UgY2FuIHVzZQorICAgICAgICBp dCB3aGVuIHNob3dpbmcgcmVwcmVzZW50ZWQgb2JqZWN0cyAoaWYgYWJsZSkgdmlhIGBiZXN0VGFi Q29udGVudFZpZXdGb3JSZXByZXNlbnRlZE9iamVjdGAuCisKIDIwMjAtMDItMDUgIE5pa2l0YSBW YXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog U29tZSBjb29raWUgdGFibGUgY29sdW1uIGhlYWRlcnMgc2hvdWxkIG5vdCBiZSBsb2NhbGl6YWJs ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGFiQnJvd3Nlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RhYkJyb3dzZXIuanMKaW5kZXggMmUwN2Y4YWQ5OGY5NGUyYjg5YzYyYTFkZDlhMjAyZmE1MjFm ZGQ4OC4uNWNlNzcxM2VkNzFlN2RlMjVjNjM5NTk4MDMzMjBlZTllYjA0MjUzNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQnJvd3Nlci5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCcm93 c2VyLmpzCkBAIC0yMzEsNyArMjMxLDggQEAgV0kuVGFiQnJvd3NlciA9IGNsYXNzIFRhYkJyb3dz ZXIgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIGxldCB0YWJDb250ZW50VmlldyA9IHRoaXMuX3Rh YkJhci5zZWxlY3RlZFRhYkJhckl0ZW0gPyB0aGlzLl90YWJCYXIuc2VsZWN0ZWRUYWJCYXJJdGVt LnJlcHJlc2VudGVkT2JqZWN0IDogbnVsbDsKIAogICAgICAgICBpZiAodGFiQ29udGVudFZpZXcp IHsKLSAgICAgICAgICAgIGxldCBzaG91bGRTYXZlVGFiID0gdGFiQ29udGVudFZpZXcuY29uc3Ry dWN0b3Iuc2hvdWxkU2F2ZVRhYigpOworICAgICAgICAgICAgbGV0IHRhYkNsYXNzID0gdGFiQ29u dGVudFZpZXcuY29uc3RydWN0b3I7CisgICAgICAgICAgICBsZXQgc2hvdWxkU2F2ZVRhYiA9IHRh YkNsYXNzLnNob3VsZFNhdmVUYWIoKSB8fCB0YWJDbGFzcy5zaG91bGRQaW5UYWIoKTsKICAgICAg ICAgICAgIGlmIChzaG91bGRTYXZlVGFiKSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fcmVjZW50 VGFiQ29udGVudFZpZXdzLnJlbW92ZSh0YWJDb250ZW50Vmlldyk7CiAgICAgICAgICAgICAgICAg dGhpcy5fcmVjZW50VGFiQ29udGVudFZpZXdzLnVuc2hpZnQodGFiQ29udGVudFZpZXcpOwo=