207309 2020-02-05 16:36:10 -0800 [Cairo] Do not use old-style GNU field initializers 2020-02-06 00:48:13 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen cgarcia clopez commit-queue simon.fraser webkit-bug-importer zan oldest_to_newest 1615391 0 aperez 2020-02-05 16:36:10 -0800 Clang is already warning about using struct foo value = { member: 42 }; instead the standard syntax for field initializers should be used: struct foo value = { .member = 42 }; Log of warnings generated by Clang follows. --- ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:120:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleStart)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:121:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleStart)) ^~ .y = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:124:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleStart)) - f * (r * sin(angleStart)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:125:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleStart)) + f * (r * cos(angleStart)) ^~ .y = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:128:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleEnd)) + f * (r * sin(angleEnd)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:129:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleEnd)) - f * (r * cos(angleEnd)) ^~ .y = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:132:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleEnd)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:133:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleEnd)) ^~ .y = 8 warnings generated. 1615393 1 389899 aperez 2020-02-05 16:38:57 -0800 Created attachment 389899 Patch 1615567 2 389899 commit-queue 2020-02-06 00:47:43 -0800 Comment on attachment 389899 Patch Clearing flags on attachment: 389899 Committed r255911: <https://trac.webkit.org/changeset/255911> 1615568 3 commit-queue 2020-02-06 00:47:45 -0800 All reviewed patches have been landed. Closing bug. 1615569 4 webkit-bug-importer 2020-02-06 00:48:13 -0800 <rdar://problem/59216924> 389899 2020-02-05 16:38:57 -0800 2020-02-06 00:47:43 -0800 Patch bug-207309-20200206023855.patch text/plain 2412 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdkM2QxN2I5N2VhMGI0 OThiZWI5MTg5ZGQyYTAwMjVjMGNmNjgyMC4uZDU0MDExNmQ4NDg4NmU5ZDU3MTM5ZGFkYmFhZDA2 NjRkMjE4ODdhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAyLTA1ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NhaXJv XSBEbyBub3QgdXNlIG9sZC1zdHlsZSBHTlUgZmllbGQgaW5pdGlhbGl6ZXJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDczMDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVk LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhZGllbnRDYWlyby5jcHA6 CisgICAgICAgIChXZWJDb3JlOjphZGRDb25pY1NlY3Rvcik6IFVzZSB0aGUgc3RhbmRhcmQgbmFt ZWQgZmllbGQgaW5pdGlhbGl6ZXIgc3ludGF4IGluc3RlYWQuCisKIDIwMjAtMDItMDUgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbSVBDIGhhcmRlbmluZ10gRmFp bCBJUEMgZGVjb2Rpbmcgb2YgaW52YWxpZCBDbGllbnRPcmlnaW4gb2JqZWN0cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhZGllbnRDYWlyby5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFkaWVudENhaXJv LmNwcAppbmRleCBkZDE1ZTNjM2ZlZDU0YWU0YjhjNmMwNWRlOTYzZTIyZTAyMjcyZWI2Li5kY2Uz N2M2YmNmNGRlNzI0YmY1NDM4YjgzOWQ4Yjk5OWE3YTFhMTdkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFkaWVudENhaXJvLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFkaWVudENhaXJvLmNwcApA QCAtMTE3LDIwICsxMTcsMjAgQEAgc3RhdGljIHZvaWQgYWRkQ29uaWNTZWN0b3IoY2Fpcm9fcGF0 dGVybl90ICpncmFkaWVudCwgZmxvYXQgY3gsIGZsb2F0IGN5LCBmbG9hdAogICAgIC8vIENhbGN1 bGF0ZSBzdGFydGluZyBwb2ludCwgZW5kaW5nIHBvaW50IGFuZCBjb250cm9sIHBvaW50cyBvZiBC ZXppZXIgY3VydmUuCiAgICAgZG91YmxlIGYgPSA0ICogdGFuKChhbmdsZUVuZCAtIGFuZ2xlU3Rh cnQpIC8gNCkgLyAzOwogICAgIHBvaW50X3QgcDAgPSB7Ci0gICAgICAgIHg6IGN4ICsgKHIgKiBj b3MoYW5nbGVTdGFydCkpLAotICAgICAgICB5OiBjeSArIChyICogc2luKGFuZ2xlU3RhcnQpKQor ICAgICAgICAueCA9IGN4ICsgKHIgKiBjb3MoYW5nbGVTdGFydCkpLAorICAgICAgICAueSA9IGN5 ICsgKHIgKiBzaW4oYW5nbGVTdGFydCkpLAogICAgIH07CiAgICAgcG9pbnRfdCBwMSA9IHsKLSAg ICAgICAgeDogY3ggKyAociAqIGNvcyhhbmdsZVN0YXJ0KSkgLSBmICogKHIgKiBzaW4oYW5nbGVT dGFydCkpLAotICAgICAgICB5OiBjeSArIChyICogc2luKGFuZ2xlU3RhcnQpKSArIGYgKiAociAq IGNvcyhhbmdsZVN0YXJ0KSkKKyAgICAgICAgLnggPSBjeCArIChyICogY29zKGFuZ2xlU3RhcnQp KSAtIGYgKiAociAqIHNpbihhbmdsZVN0YXJ0KSksCisgICAgICAgIC55ID0gY3kgKyAociAqIHNp bihhbmdsZVN0YXJ0KSkgKyBmICogKHIgKiBjb3MoYW5nbGVTdGFydCkpLAogICAgIH07CiAgICAg cG9pbnRfdCBwMiA9IHsKLSAgICAgICAgeDogY3ggKyAociAqIGNvcyhhbmdsZUVuZCkpICsgZiAq IChyICogc2luKGFuZ2xlRW5kKSksCi0gICAgICAgIHk6IGN5ICsgKHIgKiBzaW4oYW5nbGVFbmQp KSAtIGYgKiAociAqIGNvcyhhbmdsZUVuZCkpCisgICAgICAgIC54ID0gY3ggKyAociAqIGNvcyhh bmdsZUVuZCkpICsgZiAqIChyICogc2luKGFuZ2xlRW5kKSksCisgICAgICAgIC55ID0gY3kgKyAo ciAqIHNpbihhbmdsZUVuZCkpIC0gZiAqIChyICogY29zKGFuZ2xlRW5kKSksCiAgICAgfTsKICAg ICBwb2ludF90IHAzID0gewotICAgICAgICB4OiBjeCArIChyICogY29zKGFuZ2xlRW5kKSksCi0g ICAgICAgIHk6IGN5ICsgKHIgKiBzaW4oYW5nbGVFbmQpKQorICAgICAgICAueCA9IGN4ICsgKHIg KiBjb3MoYW5nbGVFbmQpKSwKKyAgICAgICAgLnkgPSBjeSArIChyICogc2luKGFuZ2xlRW5kKSks CiAgICAgfTsKIAogICAgIC8vIEFkZCBwYXRjaCB3aXRoIHNoYXBlIG9mIHRoZSBzZWN0b3IgYW5k IGdyYWRpZW50IGNvbG9ycy4K