20729 2008-09-08 10:52:03 -0700 [Qt] Canvas gradients don't work as expected 2008-09-11 00:37:54 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED http://developer.mozilla.org/samples/canvas-tutorial/4_10_canvas_radialgradient.html Qt P2 Normal --- 1 krit webkit-unassigned hausmann oldest_to_newest 90561 0 krit 2008-09-08 10:52:03 -0700 Radial gradients are broken on Qt. Center and focal point are mixed up and the radius of the start circle is not supported by Qt. 90562 1 23266 krit 2008-09-08 10:53:01 -0700 Created attachment 23266 Qt radial gradients fixed radial gradients on Qt 90739 2 23314 krit 2008-09-10 00:06:22 -0700 Created attachment 23314 Qt gradients reused old canvas-code to get multiple color-stops with the same offset to work: http://developer.mozilla.org/samples/canvas-tutorial/4_9_canvas_lineargradient.html and added the code above to support the inner radius as well as the outer radius on Canvas: http://developer.mozilla.org/samples/canvas-tutorial/4_10_canvas_radialgradient.html -> gradients fixed 90787 3 23314 hausmann 2008-09-10 12:52:12 -0700 Comment on attachment 23314 Qt gradients Looks good, but there's a small coding style nitpick: If (qFuzzyCompare(...)) { one line of code } else another line of code There's no need for braces in one-liners 90791 4 23326 krit 2008-09-10 13:09:31 -0700 Created attachment 23326 Qt gradients deleted braces :-) 90830 5 23326 hausmann 2008-09-11 00:30:44 -0700 Comment on attachment 23326 Qt gradients Thanks! 90833 6 hausmann 2008-09-11 00:37:54 -0700 Landed in r36330 23266 2008-09-08 10:53:01 -0700 2008-09-10 00:06:22 -0700 Qt radial gradients Qt-radial-gradients.patch text/plain 1739 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjI2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMDktMDggIERpcmsgU2NodWx6ZSAgPHZiczg1QGdteC5kZT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBy YWRpYWwgZ3JhZGllbnRzIG9uIFF0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQv R3JhZGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFkaWVudDo6cGxhdGZvcm1HcmFk aWVudCk6CisKIDIwMDgtMDktMDggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9HcmFkaWVudFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0dyYWRpZW50UXQuY3BwCShyZXZpc2lvbiAzNjI1NCkKKysrIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ2LDcgKzQ2LDcgQEAgUUdyYWRpZW50KiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgp CiAgICAgICAgIHJldHVybiBtX2dyYWRpZW50OwogCiAgICAgaWYgKG1fcmFkaWFsKQotICAgICAg ICBtX2dyYWRpZW50ID0gbmV3IFFSYWRpYWxHcmFkaWVudChtX3AwLngoKSwgbV9wMC55KCksIG1f cjAsIG1fcDEueCgpLCBtX3AxLnkoKSk7CisgICAgICAgIG1fZ3JhZGllbnQgPSBuZXcgUVJhZGlh bEdyYWRpZW50KG1fcDEueCgpLCBtX3AxLnkoKSwgbV9yMSwgbV9wMC54KCksIG1fcDAueSgpKTsK ICAgICBlbHNlCiAgICAgICAgIG1fZ3JhZGllbnQgPSBuZXcgUUxpbmVhckdyYWRpZW50KG1fcDAu eCgpLCBtX3AwLnkoKSwgbV9wMS54KCksIG1fcDEueSgpKTsKIApAQCAtNTQsNyArNTQsMTIgQEAg UUdyYWRpZW50KiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgpCiAgICAgVmVjdG9yPENvbG9y U3RvcD46Oml0ZXJhdG9yIHN0b3BJdGVyYXRvciA9IG1fc3RvcHMuYmVnaW4oKTs7CiAgICAgd2hp bGUgKHN0b3BJdGVyYXRvciAhPSBtX3N0b3BzLmVuZCgpKSB7CiAgICAgICAgIHN0b3BDb2xvci5z ZXRSZ2JGKHN0b3BJdGVyYXRvci0+cmVkLCBzdG9wSXRlcmF0b3ItPmdyZWVuLCBzdG9wSXRlcmF0 b3ItPmJsdWUsIHN0b3BJdGVyYXRvci0+YWxwaGEpOwotICAgICAgICBtX2dyYWRpZW50LT5zZXRD b2xvckF0KHN0b3BJdGVyYXRvci0+c3RvcCwgc3RvcENvbG9yKTsKKyAgICAgICAgZmxvYXQgb2Zm c2V0OworICAgICAgICBpZiAobV9yYWRpYWwgJiYgbV9yMCkKKyAgICAgICAgICAgIG9mZnNldCA9 IG1fcjAgLyBtX3IxICsgc3RvcEl0ZXJhdG9yLT5zdG9wICogKDEuMGYgLSBtX3IwIC8gbV9yMSk7 CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIG9mZnNldCA9IHN0b3BJdGVyYXRvci0+c3RvcDsK KyAgICAgICAgbV9ncmFkaWVudC0+c2V0Q29sb3JBdChvZmZzZXQsIHN0b3BDb2xvcik7CiAgICAg ICAgICsrc3RvcEl0ZXJhdG9yOwogICAgIH0KIAo= 23314 2008-09-10 00:06:22 -0700 2008-09-10 13:09:31 -0700 Qt gradients Qt-gradients.patch text/plain 1982 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjMxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDktMDkgIERpcmsgU2NodWx6ZSAgPHZiczg1QGdteC5kZT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBj YW52YXMgZ3JhZGllbnRzIGZvciBRdAorCisgICAgICAgIFtRdF0gQ2FudmFzIGdyYWRpZW50cyBk b24ndCB3b3JrIGFzIGV4cGVjdGVkCisgICAgICAgIFtodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA3MjldCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9H cmFkaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0Zm9ybUdyYWRp ZW50KToKKwogMjAwOC0wOS0wOSAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbQogCiAgICAg ICAgIFJlc3VycmVjdCBQbGF0Zm9ybVNjcm9sbGJhcldpbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9HcmFkaWVudFF0LmNwcAkocmV2aXNpb24gMzYyNTQpCisrKyBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYWRpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00NiwxNSArNDYsMjMgQEAgUUdyYWRpZW50KiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgp CiAgICAgICAgIHJldHVybiBtX2dyYWRpZW50OwogCiAgICAgaWYgKG1fcmFkaWFsKQotICAgICAg ICBtX2dyYWRpZW50ID0gbmV3IFFSYWRpYWxHcmFkaWVudChtX3AwLngoKSwgbV9wMC55KCksIG1f cjAsIG1fcDEueCgpLCBtX3AxLnkoKSk7CisgICAgICAgIG1fZ3JhZGllbnQgPSBuZXcgUVJhZGlh bEdyYWRpZW50KG1fcDEueCgpLCBtX3AxLnkoKSwgbV9yMSwgbV9wMC54KCksIG1fcDAueSgpKTsK ICAgICBlbHNlCiAgICAgICAgIG1fZ3JhZGllbnQgPSBuZXcgUUxpbmVhckdyYWRpZW50KG1fcDAu eCgpLCBtX3AwLnkoKSwgbV9wMS54KCksIG1fcDEueSgpKTsKIAogICAgIFFDb2xvciBzdG9wQ29s b3I7CiAgICAgVmVjdG9yPENvbG9yU3RvcD46Oml0ZXJhdG9yIHN0b3BJdGVyYXRvciA9IG1fc3Rv cHMuYmVnaW4oKTs7CisgICAgcXJlYWwgbGFzdFN0b3A7CisgICAgY29uc3QgcXJlYWwgbGFzdFN0 b3BEaWZmID0gMC4wMDAwMDAxOwogICAgIHdoaWxlIChzdG9wSXRlcmF0b3IgIT0gbV9zdG9wcy5l bmQoKSkgewogICAgICAgICBzdG9wQ29sb3Iuc2V0UmdiRihzdG9wSXRlcmF0b3ItPnJlZCwgc3Rv cEl0ZXJhdG9yLT5ncmVlbiwgc3RvcEl0ZXJhdG9yLT5ibHVlLCBzdG9wSXRlcmF0b3ItPmFscGhh KTsKLSAgICAgICAgbV9ncmFkaWVudC0+c2V0Q29sb3JBdChzdG9wSXRlcmF0b3ItPnN0b3AsIHN0 b3BDb2xvcik7CisgICAgICAgIGlmIChxRnV6enlDb21wYXJlKGxhc3RTdG9wLCBxcmVhbChzdG9w SXRlcmF0b3ItPnN0b3ApKSkgeworICAgICAgICAgICAgbGFzdFN0b3AgPSBzdG9wSXRlcmF0b3It PnN0b3AgKyBsYXN0U3RvcERpZmY7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgbGFzdFN0 b3AgPSBzdG9wSXRlcmF0b3ItPnN0b3A7CisgICAgICAgIGlmIChtX3JhZGlhbCAmJiBtX3IwKQor ICAgICAgICAgICAgbGFzdFN0b3AgPSBtX3IwIC8gbV9yMSArIGxhc3RTdG9wICogKDEuMGYgLSBt X3IwIC8gbV9yMSk7CisgICAgICAgIG1fZ3JhZGllbnQtPnNldENvbG9yQXQobGFzdFN0b3AsIHN0 b3BDb2xvcik7CiAgICAgICAgICsrc3RvcEl0ZXJhdG9yOwogICAgIH0KIAo= 23326 2008-09-10 13:09:31 -0700 2008-09-11 00:30:44 -0700 Qt gradients Qt-gradients.patch text/plain 1978 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjMxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDktMTAgIERpcmsgU2NodWx6ZSAgPHZiczg1QGdteC5kZT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBj YW52YXMgZ3JhZGllbnRzIGZvciBRdAorCisgICAgICAgIFtRdF0gQ2FudmFzIGdyYWRpZW50cyBk b24ndCB3b3JrIGFzIGV4cGVjdGVkCisgICAgICAgIFtodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA3MjldCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9H cmFkaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0Zm9ybUdyYWRp ZW50KToKKwogMjAwOC0wOS0wOSAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbQogCiAgICAg ICAgIFJlc3VycmVjdCBQbGF0Zm9ybVNjcm9sbGJhcldpbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9HcmFkaWVudFF0LmNwcAkocmV2aXNpb24gMzYyNTQpCisrKyBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYWRpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00NiwxNSArNDYsMjMgQEAgUUdyYWRpZW50KiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgp CiAgICAgICAgIHJldHVybiBtX2dyYWRpZW50OwogCiAgICAgaWYgKG1fcmFkaWFsKQotICAgICAg ICBtX2dyYWRpZW50ID0gbmV3IFFSYWRpYWxHcmFkaWVudChtX3AwLngoKSwgbV9wMC55KCksIG1f cjAsIG1fcDEueCgpLCBtX3AxLnkoKSk7CisgICAgICAgIG1fZ3JhZGllbnQgPSBuZXcgUVJhZGlh bEdyYWRpZW50KG1fcDEueCgpLCBtX3AxLnkoKSwgbV9yMSwgbV9wMC54KCksIG1fcDAueSgpKTsK ICAgICBlbHNlCiAgICAgICAgIG1fZ3JhZGllbnQgPSBuZXcgUUxpbmVhckdyYWRpZW50KG1fcDAu eCgpLCBtX3AwLnkoKSwgbV9wMS54KCksIG1fcDEueSgpKTsKIAogICAgIFFDb2xvciBzdG9wQ29s b3I7CiAgICAgVmVjdG9yPENvbG9yU3RvcD46Oml0ZXJhdG9yIHN0b3BJdGVyYXRvciA9IG1fc3Rv cHMuYmVnaW4oKTs7CisgICAgcXJlYWwgbGFzdFN0b3A7CisgICAgY29uc3QgcXJlYWwgbGFzdFN0 b3BEaWZmID0gMC4wMDAwMDAxOwogICAgIHdoaWxlIChzdG9wSXRlcmF0b3IgIT0gbV9zdG9wcy5l bmQoKSkgewogICAgICAgICBzdG9wQ29sb3Iuc2V0UmdiRihzdG9wSXRlcmF0b3ItPnJlZCwgc3Rv cEl0ZXJhdG9yLT5ncmVlbiwgc3RvcEl0ZXJhdG9yLT5ibHVlLCBzdG9wSXRlcmF0b3ItPmFscGhh KTsKLSAgICAgICAgbV9ncmFkaWVudC0+c2V0Q29sb3JBdChzdG9wSXRlcmF0b3ItPnN0b3AsIHN0 b3BDb2xvcik7CisgICAgICAgIGlmIChxRnV6enlDb21wYXJlKGxhc3RTdG9wLCBxcmVhbChzdG9w SXRlcmF0b3ItPnN0b3ApKSkKKyAgICAgICAgICAgIGxhc3RTdG9wID0gc3RvcEl0ZXJhdG9yLT5z dG9wICsgbGFzdFN0b3BEaWZmOworICAgICAgICBlbHNlCisgICAgICAgICAgICBsYXN0U3RvcCA9 IHN0b3BJdGVyYXRvci0+c3RvcDsKKyAgICAgICAgaWYgKG1fcmFkaWFsICYmIG1fcjApCisgICAg ICAgICAgICBsYXN0U3RvcCA9IG1fcjAgLyBtX3IxICsgbGFzdFN0b3AgKiAoMS4wZiAtIG1fcjAg LyBtX3IxKTsKKyAgICAgICAgbV9ncmFkaWVudC0+c2V0Q29sb3JBdChsYXN0U3RvcCwgc3RvcENv bG9yKTsKICAgICAgICAgKytzdG9wSXRlcmF0b3I7CiAgICAgfQogCg==