207276 2020-02-05 10:12:46 -0800 Update sandbox to allow communication with dnssd service 2020-02-05 13:42:35 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1615109 0 bfulgham 2020-02-05 10:12:46 -0800 Testing and telemetry indicates that we need access to the DNSSD mach service in our Network Process. 1615111 1 bfulgham 2020-02-05 10:15:49 -0800 <rdar://problem/59158405> 1615113 2 389827 bfulgham 2020-02-05 10:16:44 -0800 Created attachment 389827 Patch 1615142 3 389827 pvollan 2020-02-05 11:17:52 -0800 Comment on attachment 389827 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389827&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:95 > + (allow network-outbound (literal "/private/var/run/mDNSResponder")) > + (allow mach-lookup (global-name "com.apple.dnssd.service"))) ;; <rdar://problem/55562091> > + (begin > + (allow network-outbound (literal "/private/var/run/mDNSResponder")) > + (allow mach-lookup (global-name "com.apple.dnssd.service")))) ;; <rdar://problem/55562091> Should this be outside 'if gizmo?'? 1615181 4 389827 bfulgham 2020-02-05 12:14:36 -0800 Comment on attachment 389827 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389827&action=review >> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:95 >> + (allow mach-lookup (global-name "com.apple.dnssd.service")))) ;; <rdar://problem/55562091> > > Should this be outside 'if gizmo?'? It is in the 'else' of the 'if gizmo?' clause, so it's correct. 1615207 5 389827 pvollan 2020-02-05 12:59:01 -0800 Comment on attachment 389827 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389827&action=review R=me. >>> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:95 >>> + (allow mach-lookup (global-name "com.apple.dnssd.service")))) ;; <rdar://problem/55562091> >> >> Should this be outside 'if gizmo?'? > > It is in the 'else' of the 'if gizmo?' clause, so it's correct. Ah, I see! 1615250 6 389827 commit-queue 2020-02-05 13:42:33 -0800 Comment on attachment 389827 Patch Clearing flags on attachment: 389827 Committed r255852: <https://trac.webkit.org/changeset/255852> 1615251 7 commit-queue 2020-02-05 13:42:35 -0800 All reviewed patches have been landed. Closing bug. 389827 2020-02-05 10:16:44 -0800 2020-02-05 13:42:33 -0800 Patch bug-207276-20200205101643.patch text/plain 3510 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBlNzcwNzMxMGM4ODg0ZDk2 OTRlZjIwN2U3MjA0YzhiZjIwNzlkMDAuLjcxOGU2Zjk5MjQzNzMyNWM3MTc2N2ZjNWQzNGYyODA5 YjNkOWY1NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDItMDUgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIHNhbmRib3ggdG8g YWxsb3cgY29tbXVuaWNhdGlvbiB3aXRoIGRuc3NkIHNlcnZpY2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzI3NgorICAgICAgICA8cmRhcjovL3By b2JsZW0vNTkxNTg0MDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdGluZyBhbmQgdGVsZW1ldHJ5IGluZGljYXRlcyB0aGF0IHdlIG5lZWQgYWNj ZXNzIHRvIHRoZSBETlNTRCBtYWNoIHNlcnZpY2UgaW4gb3VyIE5ldHdvcmsgUHJvY2VzcworCisg ICAgICAgICogTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nl c3Muc2IuaW46CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFw cGxlLldlYktpdC5OZXR3b3JraW5nLnNiOgorCiAyMDIwLTAyLTA0ICB5b3Vlbm4gZmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBOZXR3b3JrUHJvY2VzcyBzaG91bGQgYmUgbm90 aWZpZWQgYnkgVUlQcm9jZXNzIHdoZW4gaXRzIHNlcnZpY2Ugd29ya2VyIHByb2Nlc3MgY29ubmVj dGlvbiBzaG91bGQgYmUgb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtQcm9jZXNzLnNi LmluCmluZGV4IDk2YjA3ODA4YWVmNDI3NWZlYjMyYWZhMjk1NjY1NTIwNzViNDkwOTYuLjY1ODJj MWE5N2RjNDRjOTdlODlmZGJhN2RmZTNlNDI2OTM5N2YxMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Mu c2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldl YktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbgpAQCAtMSw0ICsxLDQgQEAKLTsgQ29weXJpZ2h0IChD KSAyMDEzLTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorOyBDb3B5cmlnaHQg KEMpIDIwMTMtMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiA7CiA7IFJlZGlz dHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0 aG91dAogOyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKQEAgLTEzOSw2ICsxMzksNyBAQAogICAgIChhbGxvdyBtYWNoLWxv b2t1cAogICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuU3lzdGVtQ29uZmlndXJhdGlv bi5QUFBDb250cm9sbGVyIikKICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlN5c3Rl bUNvbmZpZ3VyYXRpb24uU0NOZXR3b3JrUmVhY2hhYmlsaXR5IikKKyAgICAgICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLmRuc3NkLnNlcnZpY2UiKQogICAgICAgICAgKGdsb2JhbC1uYW1lICJj b20uYXBwbGUubmVoZWxwZXIiKQogICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubmVz ZXNzaW9ubWFuYWdlciIpCiAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5uZXR3b3Jr ZCIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMv aW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYiBiL1NvdXJjZS9XZWJLaXQvUmVzb3Vy Y2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCmlu ZGV4IDhjMDEzNDA5ZDg5NmUwMWM4NDg0YjY0ZDMzMzI0MGY5OTg2N2NmZjIuLmRkNGJjZjJlNWQ4 NGFkY2RiMzg1MWJiZWNiYmQ2NzQ0Mzc3NjY5MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5n LnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29t LmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCkBAIC0xLDQgKzEsNCBAQAotOyBDb3B5cmlnaHQg KEMpIDIwMTQtMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCis7IENvcHlyaWdo dCAoQykgMjAxNC0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KIDsKIDsgUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CiA7IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtODgsOCArODgsMTEgQEAKICAgICAgICAgICAgIChyZXF1 aXJlLWFueQogICAgICAgICAgICAgICAgIChyZXF1aXJlLWVudGl0bGVtZW50ICJjb20uYXBwbGUu c2VjdXJpdHkubmV0d29yay5jbGllbnQiKQogICAgICAgICAgICAgICAgIChyZXF1aXJlLWVudGl0 bGVtZW50ICJjb20uYXBwbGUuc2VjdXJpdHkubmV0d29yay5zZXJ2ZXIiKSkKLSAgICAgICAgICAg IChhbGxvdyBuZXR3b3JrLW91dGJvdW5kIChsaXRlcmFsICIvcHJpdmF0ZS92YXIvcnVuL21ETlNS ZXNwb25kZXIiKSkpCi0gICAgICAgIChhbGxvdyBuZXR3b3JrLW91dGJvdW5kIChsaXRlcmFsICIv cHJpdmF0ZS92YXIvcnVuL21ETlNSZXNwb25kZXIiKSkpCisgICAgICAgICAgICAoYWxsb3cgbmV0 d29yay1vdXRib3VuZCAobGl0ZXJhbCAiL3ByaXZhdGUvdmFyL3J1bi9tRE5TUmVzcG9uZGVyIikp CisgICAgICAgICAgICAoYWxsb3cgbWFjaC1sb29rdXAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUu ZG5zc2Quc2VydmljZSIpKSkgOzsgPHJkYXI6Ly9wcm9ibGVtLzU1NTYyMDkxPgorICAgICAgICAo YmVnaW4KKyAgICAgICAgICAgIChhbGxvdyBuZXR3b3JrLW91dGJvdW5kIChsaXRlcmFsICIvcHJp dmF0ZS92YXIvcnVuL21ETlNSZXNwb25kZXIiKSkKKyAgICAgICAgICAgIChhbGxvdyBtYWNoLWxv b2t1cCAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5kbnNzZC5zZXJ2aWNlIikpKSkgOzsgPHJkYXI6 Ly9wcm9ibGVtLzU1NTYyMDkxPgogCiAgICAgOzsgPHJkYXI6Ly9wcm9ibGVtLzEwOTYyODAzPgog ICAgIDs7IDxyZGFyOi8vcHJvYmxlbS8xMzIzODczMD4K