20725 2008-09-08 07:20:18 -0700 GTK_WINDOW_HWND not GTK_WINDOWING_HWND 2013-09-11 00:31:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 lkcl webkit-unassigned oldest_to_newest 90531 0 lkcl 2008-09-08 07:20:18 -0700 Index: WebCore/plugins/gtk/PluginViewGtk.cpp =================================================================== --- WebCore/plugins/gtk/PluginViewGtk.cpp (revision 36129) +++ WebCore/plugins/gtk/PluginViewGtk.cpp (working copy) @@ -447,7 +447,7 @@ *((XID *)w) = GDK_WINDOW_XWINDOW(containingWindow()->window); #endif #ifdef GDK_WINDOWING_WIN32 - *((HWND *)w) = GDK_WINDOWING_HWND(containingWindow()->window); + *((HWND *)w) = GDK_WINDOW_HWND(containingWindow()->window); #endif return NPERR_NO_ERROR; } 90533 1 lkcl 2008-09-08 07:25:10 -0700 actually there's a compile error with that: ebCore/plugins/gtk/PluginViewGtk.cpp: In member function ‘NPError WebCore::PluginView::getValue(NPNVariable, void*)’: WebCore/plugins/gtk/PluginViewGtk.cpp:450: error: invalid conversion from ‘void*’ to ‘HWND__*’ ./JavaScriptCore/wtf/OwnPtr.h: In function ‘void WTF::deleteOwnedPtr(T*) [with T = WebCore::PluginMessageThrottlerWin]’: ./JavaScriptCore/wtf/OwnPtr.h:69: instantiated from ‘WTF::OwnPtr<T>::~OwnPtr() [with T = WebCore::PluginMessageThrottlerWin]’ WebCore/plugins/gtk/PluginViewGtk.cpp:479: instantiated from here ./JavaScriptCore/wtf/OwnPtr.h:49: error: invalid application of ‘sizeof’ to incomplete type ‘WebCore::PluginMessageThrottlerWin’ ./JavaScriptCore/wtf/OwnPtr.h:49: error: creating array with negative size (‘-0x00000000000000001’) ./JavaScriptCore/wtf/OwnPtr.h:50: error: invalid application of ‘sizeof’ to incomplete type ‘WebCore::PluginMessageThrottlerWin’ ./JavaScriptCore/wtf/OwnPtr.h:50: error: creating array with negative size (‘-0x00000000000000001’) ./JavaScriptCore/wtf/OwnPtr.h:51: warning: possible problem detected in invocation of delete operator: ./JavaScriptCore/wtf/OwnPtr.h:47: warning: ‘ptr’ has incomplete type ./WebCore/plugins/PluginView.h:67: warning: forward declaration of ‘struct WebCore::PluginMessageThrottlerWin’ ./JavaScriptCore/wtf/OwnPtr.h:51: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined. WebCore/plugins/gtk/PluginViewGtk.cpp: At global scope: WebCore/plugins/gtk/PluginViewGtk.cpp:495: warning: ‘gboolean WebCore::plug_removed_cb(GtkSocket*, void*)’ defined but not used 90540 2 23260 lkcl 2008-09-08 07:59:10 -0700 Created attachment 23260 HWND issue got a compile - no idea if it works (will find out soon enough...) 92015 3 23260 darin 2008-09-21 13:48:06 -0700 Comment on attachment 23260 HWND issue This patch includes no ChangeLog. The code change looks fine. I'm going to say review- to get this out of the review queue, since it does need a ChangeLog. 94175 4 24103 jmalonzo 2008-10-05 14:41:04 -0700 Created attachment 24103 ChangeLog and updated to ToT ChangeLog added as requested by Darin. Also updated the patch to match ToT. 94176 5 24103 hyatt 2008-10-05 14:46:06 -0700 Comment on attachment 24103 ChangeLog and updated to ToT r=me 94178 6 jmalonzo 2008-10-05 14:57:24 -0700 Thanks for the review. Landed in r37319 94218 7 lkcl 2008-10-06 02:38:41 -0700 there are quite a few like this. little things that got caught with cross-compilation under mingw32, which were a bit lairy. 927669 8 berto 2013-09-11 00:31:25 -0700 *** Bug 20727 has been marked as a duplicate of this bug. *** 23260 2008-09-08 07:59:10 -0700 2008-10-05 14:41:04 -0700 HWND issue f text/plain 955 lkcl SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAkocmV2aXNpb24gMzYxMjkp CisrKyBXZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02Niw2ICs2Niw3IEBACiAjZW5kaWYKICNpZmRlZiBHREtfV0lORE9XSU5HX1dJTjMyCiAj aW5jbHVkZSA8Z2RrL2dka3dpbjMyLmg+CisjaW5jbHVkZSAiUGx1Z2luTWVzc2FnZVRocm90dGxl cldpbi5oIgogI2VuZGlmCiAKIHVzaW5nIEtKUzo6RXhlY1N0YXRlOwpAQCAtNDQxLDEzICs0NDIs MTQgQEAKICNlbmRpZgogCiAgICAgICAgIGNhc2UgTlBOVm5ldHNjYXBlV2luZG93OiB7Ci0gICAg ICAgICAgICB2b2lkKiB3ID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4odmFsdWUpOwogCiAjaWZk ZWYgR0RLX1dJTkRPV0lOR19YMTEKKyAgICAgICAgICAgIHZvaWQqIHcgPSByZWludGVycHJldF9j YXN0PHZvaWQqPih2YWx1ZSk7CiAgICAgICAgICAgICAqKChYSUQgKil3KSA9IEdES19XSU5ET1df WFdJTkRPVyhjb250YWluaW5nV2luZG93KCktPndpbmRvdyk7CiAjZW5kaWYKICNpZmRlZiBHREtf V0lORE9XSU5HX1dJTjMyCi0gICAgICAgICAgICAqKChIV05EICopdykgPSBHREtfV0lORE9XSU5H X0hXTkQoY29udGFpbmluZ1dpbmRvdygpLT53aW5kb3cpOworICAgICAgICAgICAgSEdESU9CSiog dyA9IHJlaW50ZXJwcmV0X2Nhc3Q8SEdESU9CSio+KHZhbHVlKTsKKyAgICAgICAgICAgICp3ID0g R0RLX1dJTkRPV19IV05EKGNvbnRhaW5pbmdXaW5kb3coKS0+d2luZG93KTsKICNlbmRpZgogICAg ICAgICAgICAgcmV0dXJuIE5QRVJSX05PX0VSUk9SOwogICAgICAgICB9Cg== 24103 2008-10-05 14:41:04 -0700 2008-10-05 14:46:06 -0700 ChangeLog and updated to ToT gdkwindowhwnd.patch text/plain 1707 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTg1OGQ3ZS4uOWRmMWQ1MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOC0xMC0wNSAgTHVrZSBLZW5uZXRo IENhc3NvbiBMZWlnaHRvbiAgPGxrY2xAbGtjbC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBP UiBDSEFOR0VECisKKyAgICAgICAgR1RLX1dJTkRPV19IV05EIG5vdCBHVEtfV0lORE9XSU5HX0hX TkQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzI1 CisKKyAgICAgICAgVXBkYXRlZCB0byBUb1QgYnkgSmFuIEFsb256by4KKworICAgICAgICAqIHBs dWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmll dzo6Z2V0VmFsdWUpOgorCiAyMDA4LTEwLTA1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWxkZXIuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL2d0ay9Q bHVnaW5WaWV3R3RrLmNwcAppbmRleCBiYzI5Mjg4Li43OWEzZmE1IDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9n dGsvUGx1Z2luVmlld0d0ay5jcHAKQEAgLTY1LDYgKzY1LDcgQEAKICNpbmNsdWRlIDxnZGsvZ2Rr eC5oPgogI2VuZGlmCiAjaWZkZWYgR0RLX1dJTkRPV0lOR19XSU4zMgorI2luY2x1ZGUgIlBsdWdp bk1lc3NhZ2VUaHJvdHRsZXJXaW4uaCIKICNpbmNsdWRlIDxnZGsvZ2Rrd2luMzIuaD4KICNlbmRp ZgogCkBAIC00MzYsMTMgKzQzNywxMyBAQCBOUEVycm9yIFBsdWdpblZpZXc6OmdldFZhbHVlKE5Q TlZhcmlhYmxlIHZhcmlhYmxlLCB2b2lkKiB2YWx1ZSkKICNlbmRpZgogCiAgICAgICAgIGNhc2Ug TlBOVm5ldHNjYXBlV2luZG93OiB7Ci0gICAgICAgICAgICB2b2lkKiB3ID0gcmVpbnRlcnByZXRf Y2FzdDx2b2lkKj4odmFsdWUpOwotCiAjaWYgUExBVEZPUk0oWDExKQorICAgICAgICAgICAgdm9p ZCogdyA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHZhbHVlKTsKICAgICAgICAgICAgICooKFhJ RCAqKXcpID0gR0RLX1dJTkRPV19YV0lORE9XKG1fcGFyZW50RnJhbWUtPnZpZXcoKS0+aG9zdFdp bmRvdygpLT5wbGF0Zm9ybVdpbmRvdygpLT53aW5kb3cpOwogI2VuZGlmCiAjaWZkZWYgR0RLX1dJ TkRPV0lOR19XSU4zMgotICAgICAgICAgICAgKigoSFdORCAqKXcpID0gR0RLX1dJTkRPV0lOR19I V05EKG1fcGFyZW50RnJhbWUtPnZpZXcoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVdpbmRvdygp LT53aW5kb3cpOworICAgICAgICAgICAgSEdESU9CSiogdyA9IHJlaW50ZXJwcmV0X2Nhc3Q8SEdE SU9CSio+KHZhbHVlKTsKKyAgICAgICAgICAgICp3ID0gR0RLX1dJTkRPV19IV05EKG1fcGFyZW50 RnJhbWUtPnZpZXcoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVdpbmRvdygpLT53aW5kb3cpOwog I2VuZGlmCiAgICAgICAgICAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7CiAgICAgICAgIH0K