207242 2020-02-04 17:26:18 -0800 AX: replaceTextInRange should handle when called on the WebArea element 2020-02-05 11:48:32 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach webkit-unassigned aboxhall apinheiro commit-queue dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer zalan oldest_to_newest 1614868 0 cfleizach 2020-02-04 17:26:18 -0800 To get the direct text API to work for Mail, we need to be able to support calling replaceInTextRange on the web area. That's because the <body> element is not in the AX tree, so VoiceOver ends up calling the HTMLDocument to replace the text 1614869 1 webkit-bug-importer 2020-02-04 17:26:29 -0800 <rdar://problem/59173196> 1614870 2 cfleizach 2020-02-04 17:26:32 -0800 <rdar://problem/58967407> 1614957 3 389776 cfleizach 2020-02-04 23:41:20 -0800 Created attachment 389776 Patch 1615163 4 389776 commit-queue 2020-02-05 11:48:30 -0800 Comment on attachment 389776 Patch Clearing flags on attachment: 389776 Committed r255839: <https://trac.webkit.org/changeset/255839> 1615164 5 commit-queue 2020-02-05 11:48:32 -0800 All reviewed patches have been landed. Closing bug. 389776 2020-02-04 23:41:20 -0800 2020-02-05 11:48:30 -0800 Patch file_207242.txt text/plain 4626 cfleizach ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv Zw0KaW5kZXggNDFlNTdlYmMxZWMuLjJmNmMzMWFjNmU0IDEwMDY0NA0KLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nDQorKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cNCkBAIC0xLDMgKzEsMTQg QEANCisyMDIwLTAyLTA0ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+DQor DQorICAgICAgICBBWDogcmVwbGFjZVRleHRJblJhbmdlIHNob3VsZCBoYW5kbGUgd2hlbiBjYWxs ZWQgb24gdGhlIFdlYkFyZWEgZWxlbWVudA0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwNzI0Mg0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5MTcz MTk2Pg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvbWFjL3JlcGxhY2UtdGV4dC13aXRoLXJhbmdlLW9uLXdlYmFyZWEt ZWxlbWVudC1leHBlY3RlZC50eHQ6IEFkZGVkLg0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21h Yy9yZXBsYWNlLXRleHQtd2l0aC1yYW5nZS1vbi13ZWJhcmVhLWVsZW1lbnQuaHRtbDogQWRkZWQu DQorDQogMjAyMC0wMS0yOCAgUGlua2kgR3lhbmNoYW5kYW5pICA8cGd5YW5jaGFuZGFuaUBhcHBs ZS5jb20+DQogDQogICAgICAgICBOdWxsIGRlcmVmIGNyYXNoIGluIERPTVdpbmRvdzo6c2Nyb2xs QnkgYWZ0ZXIgZXZva2luZyB1cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKQ0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL3JlcGxhY2UtdGV4dC13 aXRoLXJhbmdlLW9uLXdlYmFyZWEtZWxlbWVudC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L21hYy9yZXBsYWNlLXRleHQtd2l0aC1yYW5nZS1vbi13ZWJhcmVhLWVsZW1l bnQtZXhwZWN0ZWQudHh0DQpuZXcgZmlsZSBtb2RlIDEwMDY0NA0KaW5kZXggMDAwMDAwMDAwMDAu LmQxYzlmMDVmOWVmDQotLS0gL2Rldi9udWxsDQorKysgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L21hYy9yZXBsYWNlLXRleHQtd2l0aC1yYW5nZS1vbi13ZWJhcmVhLWVsZW1lbnQtZXhwZWN0 ZWQudHh0DQpAQCAtMCwwICsxLDEyIEBADQord29ybGQNCitUaGlzIHRlc3RzIHRoYXQgdGhlIHJl cGxhY2Ugd2l0aCByYW5nZSBBUEkgZnVuY3Rpb25zIGFzIGV4cGVjdGVkIHdoZW4gY2FsbGVkIG9u IHRoZSB3ZWIgYXJlYSBlbGVtZW50Lg0KKw0KK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4NCisN CisNCitQQVNTIHdlYkFyZWEucmVwbGFjZVRleHRJblJhbmdlKCJ3b3JsZCIsIDAsIDUpIGlzIHRy dWUNCitQQVNTIHdlYkFyZWEuY2hpbGRBdEluZGV4KDApLnN0cmluZ1ZhbHVlLnN1YnN0cmluZyg5 LCAxNCkgaXMgJ3dvcmxkJw0KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUNCisNCitU RVNUIENPTVBMRVRFDQorDQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9t YWMvcmVwbGFjZS10ZXh0LXdpdGgtcmFuZ2Utb24td2ViYXJlYS1lbGVtZW50Lmh0bWwgYi9MYXlv dXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9yZXBsYWNlLXRleHQtd2l0aC1yYW5nZS1vbi13ZWJh cmVhLWVsZW1lbnQuaHRtbA0KbmV3IGZpbGUgbW9kZSAxMDA2NDQNCmluZGV4IDAwMDAwMDAwMDAw Li5lODU2MDg4ZjlhNA0KLS0tIC9kZXYvbnVsbA0KKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9tYWMvcmVwbGFjZS10ZXh0LXdpdGgtcmFuZ2Utb24td2ViYXJlYS1lbGVtZW50Lmh0bWwN CkBAIC0wLDAgKzEsMjMgQEANCis8IURPQ1RZUEUgaHRtbD4NCis8aHRtbD4NCis8aGVhZD4NCis8 c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0Pg0KKzwvaGVh ZD4NCis8Ym9keSBpZD0iYm9keSIgY29udGVudGVkaXRhYmxlPSJ0cnVlIiByb2xlPSJ0ZXh0Ym94 Ij4NCitoZWxsbw0KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPg0KKzxkaXYgaWQ9ImNvbnNvbGUi PjwvZGl2Pg0KKw0KKzxzY3JpcHQ+DQorICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQg dGhlIHJlcGxhY2Ugd2l0aCByYW5nZSBBUEkgZnVuY3Rpb25zIGFzIGV4cGVjdGVkIHdoZW4gY2Fs bGVkIG9uIHRoZSB3ZWIgYXJlYSBlbGVtZW50LiIpOw0KKw0KKyAgICBpZiAod2luZG93LmFjY2Vz c2liaWxpdHlDb250cm9sbGVyKSB7DQorICAgICAgICB2YXIgd2ViQXJlYSA9IGFjY2Vzc2liaWxp dHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgiYm9keSIpLnBhcmVudEVsZW1lbnQo KTsNCisgICAgICAgIHNob3VsZEJlVHJ1ZSgnd2ViQXJlYS5yZXBsYWNlVGV4dEluUmFuZ2UoIndv cmxkIiwgMCwgNSknKTsNCisgICAgICAgIHNob3VsZEJlKCJ3ZWJBcmVhLmNoaWxkQXRJbmRleCgw KS5zdHJpbmdWYWx1ZS5zdWJzdHJpbmcoOSwgMTQpIiwgIid3b3JsZCciKTsNCisgICAgfQ0KKw0K Kzwvc2NyaXB0Pg0KKw0KKzwvYm9keT4NCis8L2h0bWw+DQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQppbmRleCA2YWY5MGU1 Njc3OS4uZGIwMmM1Mzc5YTggMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cN CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KQEAgLTEsMyArMSwxNiBAQA0KKzIwMjAt MDItMDQgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4NCisNCisgICAgICAg IEFYOiByZXBsYWNlVGV4dEluUmFuZ2Ugc2hvdWxkIGhhbmRsZSB3aGVuIGNhbGxlZCBvbiB0aGUg V2ViQXJlYSBlbGVtZW50DQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA3MjQyDQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkxNzMxOTY+DQorDQor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAgICAgIFRlc3Q6IGFj Y2Vzc2liaWxpdHkvbWFjL3JlcGxhY2UtdGV4dC13aXRoLXJhbmdlLW9uLXdlYmFyZWEtZWxlbWVu dC5odG1sDQorDQorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5j cHA6DQorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdDo6cmVwbGFjZVRleHRJ blJhbmdlKToNCisNCiAyMDIwLTAxLTI4ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUu Y29tPg0KIA0KICAgICAgICAgUkVHUkVTU0lPTiAocjI1NTE1OCk6IGh0dHAvdGVzdHMvZnJhbWUt dGhyb3R0bGluZy9yYWYtdGhyb3R0bGUtaW4tY3Jvc3Mtb3JpZ2luLXN1YmZyYW1lLmh0bWwgaXMg YSBmbGFreSBmYWlsdXJlDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdC5jcHANCmluZGV4IGQyYjYxZmYwMzQ2Li5iMDQwZTI5ZmNjOCAx MDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9i amVjdC5jcHANCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHANCkBAIC00OCw2ICs0OCw3IEBADQogI2luY2x1ZGUgIkZyYW1lLmgiDQogI2lu Y2x1ZGUgIkZyYW1lTG9hZGVyLmgiDQogI2luY2x1ZGUgIkZyYW1lU2VsZWN0aW9uLmgiDQorI2lu Y2x1ZGUgIkhUTUxCb2R5RWxlbWVudC5oIg0KICNpbmNsdWRlICJIVE1MRGF0YUxpc3RFbGVtZW50 LmgiDQogI2luY2x1ZGUgIkhUTUxEZXRhaWxzRWxlbWVudC5oIg0KICNpbmNsdWRlICJIVE1MRm9y bUNvbnRyb2xFbGVtZW50LmgiDQpAQCAtMjA1Myw2ICsyMDU0LDEzIEBAIGNvbnN0IEF0b21TdHJp bmcmIEFjY2Vzc2liaWxpdHlPYmplY3Q6OmdldEF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1l JiBhdHRyaWJ1DQogDQogYm9vbCBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpyZXBsYWNlVGV4dEluUmFu Z2UoY29uc3QgU3RyaW5nJiByZXBsYWNlbWVudFN0cmluZywgY29uc3QgUGxhaW5UZXh0UmFuZ2Um IHJhbmdlKQ0KIHsNCisgICAgLy8gSWYgdGhpcyBpcyBiZWluZyBjYWxsZWQgb24gdGhlIHdlYiBh cmVhLCByZWRpcmVjdCBpdCB0byBiZSBvbiB0aGUgYm9keSwgd2hpY2ggd2lsbCBoYXZlIGEgcmVu ZGVyZXIgYXNzb2NpYXRlZCB3aXRoIGl0Lg0KKyAgICBpZiAoaXM8RG9jdW1lbnQ+KG5vZGUoKSkp IHsNCisgICAgICAgIGlmIChhdXRvIGJvZHlPYmplY3QgPSBheE9iamVjdENhY2hlKCktPmdldE9y Q3JlYXRlKGRvd25jYXN0PERvY3VtZW50Pihub2RlKCkpLT5ib2R5KCkpKQ0KKyAgICAgICAgICAg IHJldHVybiBib2R5T2JqZWN0LT5yZXBsYWNlVGV4dEluUmFuZ2UocmVwbGFjZW1lbnRTdHJpbmcs IHJhbmdlKTsNCisgICAgICAgIHJldHVybiBmYWxzZTsNCisgICAgfQ0KKyAgICANCiAgICAgaWYg KCFyZW5kZXJlcigpIHx8ICFpczxFbGVtZW50Pihub2RlKCkpKQ0KICAgICAgICAgcmV0dXJuIGZh bHNlOw0KIA0K