207234 2020-02-04 15:13:33 -0800 macCatalyst: Shouldn't get text cursor on checkboxes 2020-02-04 15:44:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue webkit-bug-importer wenson_hsieh oldest_to_newest 1614777 0 thorton 2020-02-04 15:13:33 -0800 macCatalyst: Shouldn't get text cursor on checkboxes 1614779 1 389721 thorton 2020-02-04 15:14:48 -0800 Created attachment 389721 Patch 1614790 2 389721 wenson_hsieh 2020-02-04 15:27:02 -0800 Comment on attachment 389721 Patch r=me with the merge conflict fix 1614803 3 thorton 2020-02-04 15:44:00 -0800 https://trac.webkit.org/changeset/255710/webkit 1614804 4 webkit-bug-importer 2020-02-04 15:44:18 -0800 <rdar://problem/59168916> 389721 2020-02-04 15:14:48 -0800 2020-02-04 15:40:06 -0800 Patch bug-207234-20200204151447.patch text/plain 4286 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBlNzcwNzMxMGM4ODg0ZDk2 OTRlZjIwN2U3MjA0YzhiZjIwNzlkMDAuLjhlNmY4NWFiYTcyY2M2ZGFiYTIyMTA2ZmIwZGUxY2Zk ZWJmOTExNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDItMDQgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgbWFjQ2F0YWx5c3Q6IFNo b3VsZG4ndCBnZXQgdGV4dCBjdXJzb3Igb24gY2hlY2tib3hlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MjM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OmNhbkZvcmNlQ2FyZXRGb3JQb3NpdGlvbik6 CisgICAgICAgIChXZWJLaXQ6OnBvcHVsYXRlQ2FyZXRDb250ZXh0KToKKyAgICAgICAgKFdlYktp dDo6bGluZUNhcmV0RXh0ZW50KTogRGVsZXRlZC4KKyAgICAgICAgVGhlIEktYmVhbSBmb3JjaW5n IGNvZGUgd2FzIGEgYml0IHRvbyBhZ2dyZXNzaXZlOyBpdCBzaG91bGQgY29uc2lkZXIKKyAgICAg ICAgdGhlIHN0eWxlIG9mIHRoZSBub2RlIHRoYXQgaXQgZW5kcyB1cCBmaW5kaW5nIGFmdGVyIHNl YXJjaGluZywgbm90IGp1c3QKKyAgICAgICAgYXNzdW1lIGl0IHdhbnRzIGFuIEktYmVhbSBiZWNh dXNlIGl0J3MgInRleHR5Ii4KKwogMjAyMC0wMi0wNCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgTmV0d29ya1Byb2Nlc3Mgc2hvdWxkIGJlIG5vdGlmaWVkIGJ5 IFVJUHJvY2VzcyB3aGVuIGl0cyBzZXJ2aWNlIHdvcmtlciBwcm9jZXNzIGNvbm5lY3Rpb24gc2hv dWxkIGJlIG9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9p b3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9X ZWJQYWdlSU9TLm1tCmluZGV4IDg1MTdhMmZjOGEwM2Y3NjRkMzE2NGUyMzg2M2ZiMzgzNDU0Y2I1 YmUuLmNmODA3OTIxNDc4ODk1MDFlN2M0Y2U4NzJhODAwNTZjN2E1ODM2NjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0y NzYyLDIxICsyNzYyLDUwIEBAIFJlZlB0cjxTaGFyZWFibGVCaXRtYXA+IFdlYlBhZ2U6OnNoYXJl YWJsZUJpdG1hcFNuYXBzaG90Rm9yTm9kZShFbGVtZW50JiBlbGVtZW50CiAgICAgcmV0dXJuIG51 bGxwdHI7CiB9CiAKLXN0YXRpYyBGbG9hdFJlY3QgbGluZUNhcmV0RXh0ZW50KGNvbnN0IEludGVy YWN0aW9uSW5mb3JtYXRpb25SZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBIaXRUZXN0UmVzdWx0JiBo aXRUZXN0UmVzdWx0KQorc3RhdGljIGJvb2wgY2FuRm9yY2VDYXJldEZvclBvc2l0aW9uKGNvbnN0 IFZpc2libGVQb3NpdGlvbiYgcG9zaXRpb24pCit7CisgICAgYXV0byogbm9kZSA9IHBvc2l0aW9u LmRlZXBFcXVpdmFsZW50KCkuYW5jaG9yTm9kZSgpOworICAgIGlmICghbm9kZSkKKyAgICAgICAg cmV0dXJuIGZhbHNlOworCisgICAgYXV0byogcmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigpOwor ICAgIGF1dG8qIHN0eWxlID0gcmVuZGVyZXIgPyAmcmVuZGVyZXItPnN0eWxlKCkgOiBudWxscHRy OworICAgIGF1dG8gY3Vyc29yVHlwZSA9IHN0eWxlID8gc3R5bGUtPmN1cnNvcigpIDogQ3Vyc29y VHlwZTo6QXV0bzsKKworICAgIGlmIChjdXJzb3JUeXBlID09IEN1cnNvclR5cGU6OlRleHQpCisg ICAgICAgIHJldHVybiB0cnVlOworCisgICAgaWYgKGN1cnNvclR5cGUgIT0gQ3Vyc29yVHlwZTo6 QXV0bykKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKG5vZGUtPmhhc0VkaXRhYmxl U3R5bGUoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICBpZiAoIXJlbmRlcmVyKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1cm4gcmVuZGVyZXItPmlzVGV4dCgpICYmIG5v ZGUtPmNhblN0YXJ0U2VsZWN0aW9uKCk7Cit9CisKK3N0YXRpYyB2b2lkIHBvcHVsYXRlQ2FyZXRD b250ZXh0KGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhpdFRlc3RSZXN1bHQsIGNvbnN0IEludGVyYWN0 aW9uSW5mb3JtYXRpb25SZXF1ZXN0JiByZXF1ZXN0LCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQ b3NpdGlvbiYgaW5mbykKIHsKICAgICBhdXRvKiBmcmFtZSA9IGhpdFRlc3RSZXN1bHQuaW5uZXJO b2RlRnJhbWUoKTsKICAgICBpZiAoIWZyYW1lKQotICAgICAgICByZXR1cm4geyB9OworICAgICAg ICByZXR1cm47CisKKyAgICBhdXRvKiBmcmFtZVZpZXcgPSBmcmFtZS0+dmlldygpOworICAgIGlm ICghZnJhbWVWaWV3KQorICAgICAgICByZXR1cm47CiAKICAgICBhdXRvKiByZW5kZXJlciA9IGhp dFRlc3RSZXN1bHQuaW5uZXJOb2RlKCktPnJlbmRlcmVyKCk7CiAgICAgaWYgKCFyZW5kZXJlcikK LSAgICAgICAgcmV0dXJuIHsgfTsKKyAgICAgICAgcmV0dXJuOwogCiAgICAgd2hpbGUgKHJlbmRl cmVyICYmICFpczxSZW5kZXJCbG9ja0Zsb3c+KCpyZW5kZXJlcikpCiAgICAgICAgIHJlbmRlcmVy ID0gcmVuZGVyZXItPnBhcmVudCgpOwogCiAgICAgaWYgKCFyZW5kZXJlcikKLSAgICAgICAgcmV0 dXJuIHsgfTsKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBiZSBh YmxlIHRvIHJldHJpZXZlIHRoaXMgZ2VvbWV0cnkgaW5mb3JtYXRpb24gd2l0aG91dAogICAgIC8v IGZvcmNpbmcgdGhlIHRleHQgdG8gZmFsbCBvdXQgb2YgU2ltcGxlIExpbmUgTGF5b3V0LgpAQCAt Mjc4NCwyNCArMjgxMywxMiBAQCBzdGF0aWMgRmxvYXRSZWN0IGxpbmVDYXJldEV4dGVudChjb25z dCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVzdCYgcmVxdWVzdCwgYwogICAgIFZpc2libGVQ b3NpdGlvbiBwb3NpdGlvbiA9IGZyYW1lLT52aXNpYmxlUG9zaXRpb25Gb3JQb2ludChyZXF1ZXN0 LnBvaW50KTsKICAgICBhdXRvIGxpbmVSZWN0ID0gcG9zaXRpb24uYWJzb2x1dGVTZWxlY3Rpb25C b3VuZHNGb3JMaW5lKCk7CiAgICAgbGluZVJlY3Quc2V0V2lkdGgoYmxvY2tGbG93LmNvbnRlbnRX aWR0aCgpKTsKLSAgICByZXR1cm4gbGluZVJlY3Q7Ci19Ci0KLXN0YXRpYyB2b2lkIHBvcHVsYXRl Q2FyZXRDb250ZXh0KGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhpdFRlc3RSZXN1bHQsIGNvbnN0IElu dGVyYWN0aW9uSW5mb3JtYXRpb25SZXF1ZXN0JiByZXF1ZXN0LCBJbnRlcmFjdGlvbkluZm9ybWF0 aW9uQXRQb3NpdGlvbiYgaW5mbykKLXsKLSAgICBhdXRvKiBmcmFtZSA9IGhpdFRlc3RSZXN1bHQu aW5uZXJOb2RlRnJhbWUoKTsKLSAgICBpZiAoIWZyYW1lKQotICAgICAgICByZXR1cm47Ci0KLSAg ICBhdXRvKiBmcmFtZVZpZXcgPSBmcmFtZS0+dmlldygpOwotICAgIGlmICghZnJhbWVWaWV3KQot ICAgICAgICByZXR1cm47CiAKLSAgICBpbmZvLmxpbmVDYXJldEV4dGVudCA9IGZyYW1lVmlldy0+ Y29udGVudHNUb1Jvb3RWaWV3KGxpbmVDYXJldEV4dGVudChyZXF1ZXN0LCBoaXRUZXN0UmVzdWx0 KSk7CisgICAgaW5mby5saW5lQ2FyZXRFeHRlbnQgPSBmcmFtZVZpZXctPmNvbnRlbnRzVG9Sb290 VmlldyhsaW5lUmVjdCk7CiAgICAgaW5mby5jYXJldEhlaWdodCA9IGluZm8ubGluZUNhcmV0RXh0 ZW50LmhlaWdodCgpOwogCiAgICAgLy8gRm9yY2UgYW4gSS1iZWFtIGN1cnNvciBpZiB0aGUgcGFn ZSBkaWRuJ3QgcmVxdWVzdCBhIGhhbmQsIGFuZCB3ZSdyZSBpbnNpZGUgdGhlIGJvdW5kcyBvZiB0 aGUgbGluZS4KLSAgICBpZiAoaW5mby5saW5lQ2FyZXRFeHRlbnQuY29udGFpbnMocmVxdWVzdC5w b2ludCkgJiYgaW5mby5jdXJzb3ItPnR5cGUoKSAhPSBDdXJzb3I6OkhhbmQpCisgICAgaWYgKGlu Zm8ubGluZUNhcmV0RXh0ZW50LmNvbnRhaW5zKHJlcXVlc3QucG9pbnQpICYmIGluZm8uY3Vyc29y LT50eXBlKCkgIT0gQ3Vyc29yOjpIYW5kICYmIGNhbkZvcmNlQ2FyZXRGb3JQb3NpdGlvbihwb3Np dGlvbikpCiAgICAgICAgIGluZm8uY3Vyc29yID0gQ3Vyc29yOjpmcm9tVHlwZShDdXJzb3I6OklC ZWFtKTsKIH0KIAo=