207229 2020-02-04 14:46:00 -0800 [JSC] Use PackedRefPtr in UnlinkedCodeBlock 2020-02-04 14:55:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1614753 0 ysuzuki 2020-02-04 14:46:00 -0800 [JSC] Use PackedRefPtr in UnlinkedCodeBlock 1614754 1 389712 ysuzuki 2020-02-04 14:46:55 -0800 Created attachment 389712 Patch 1614756 2 389712 mark.lam 2020-02-04 14:49:05 -0800 Comment on attachment 389712 Patch r=me 1614760 3 ysuzuki 2020-02-04 14:54:27 -0800 Committed r255703: <https://trac.webkit.org/changeset/255703> 1614762 4 webkit-bug-importer 2020-02-04 14:55:17 -0800 <rdar://problem/59166705> 389712 2020-02-04 14:46:55 -0800 2020-02-04 14:49:05 -0800 Patch bug-207229-20200204144654.patch text/plain 6744 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ODRjYTM0MDg2MmY3NTVmZjM0Njc5NjliY2JiNDlmOThlNzdkY2UzLi41MWEzMDdmZjc1NzVhZDkz MTg3MTIxNDMxNmQ3NDExY2NiOTJkNjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAyMC0wMi0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFVzZSBQYWNrZWRSZWZQdHIgaW4gVW5saW5rZWRDb2RlQmxvY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzIyOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBQYWNr ZWRSZWZQdHIgaW4gVW5saW5rZWRDb2RlQmxvY2sgdG8gY29tcGFjdCBpdCBmcm9tIDE2OCB0byAx NjAsIHdoaWNoIHNhdmVzIDE2IGJ5dGVzICgxMCUpIHBlciBVbmxpbmtlZENvZGVCbG9jayBzaW5j ZQorICAgICAgICB3ZSBoYXZlIDE2IGJ5dGVzIGFsaWdubWVudCBmb3IgR0MgY2VsbHMuCisKKyAg ICAgICAgKiBieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oOgorICAgICAgICAoSlNDOjpVbmxp bmtlZENvZGVCbG9jazo6c291cmNlVVJMRGlyZWN0aXZlIGNvbnN0KToKKyAgICAgICAgKEpTQzo6 VW5saW5rZWRDb2RlQmxvY2s6OnNvdXJjZU1hcHBpbmdVUkxEaXJlY3RpdmUgY29uc3QpOgorICAg ICAgICAoSlNDOjpVbmxpbmtlZENvZGVCbG9jazo6c2V0U291cmNlVVJMRGlyZWN0aXZlKToKKyAg ICAgICAgKEpTQzo6VW5saW5rZWRDb2RlQmxvY2s6OnNldFNvdXJjZU1hcHBpbmdVUkxEaXJlY3Rp dmUpOgorICAgICAgICAqIHJ1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwOgorICAgICAgICAoSlNDOjpD YWNoZWRDb2RlQmxvY2s6OnNvdXJjZVVSTERpcmVjdGl2ZSBjb25zdCk6CisgICAgICAgIChKU0M6 OkNhY2hlZENvZGVCbG9jazo6c291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZSBjb25zdCk6CisgICAg ICAgIChKU0M6OkNhY2hlZENvZGVCbG9jazxDb2RlQmxvY2tUeXBlPjo6ZW5jb2RlKToKKyAgICAg ICAgKiBydW50aW1lL0NvZGVDYWNoZS5jcHA6CisgICAgICAgIChKU0M6OkNvZGVDYWNoZTo6Z2V0 VW5saW5rZWRHbG9iYWxDb2RlQmxvY2spOgorCiAyMDIwLTAyLTA0ICBBbGV4ZXkgU2h2YXlrYSAg PHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBRdWFudGlmaWVycyBhZnRlciBsb29r YWhlYWQgYXNzZXJ0aW9ucyBzaG91bGQgYmUgc3ludGF4IGVycm9ycyBpbiBVbmljb2RlIHBhdHRl cm5zIG9ubHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Vbmxp bmtlZENvZGVCbG9jay5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2Vk Q29kZUJsb2NrLmgKaW5kZXggNjBkMzYyMGI4ZTVjNmNhMDM1YmE5NTExYjVjMGQ0NzllNjc0OGYw Mi4uZGQyMTdiN2ZkNGZlZjU2ZGY4ZDgxYzM1YzI4MTMzZDVjODdhMWE5YyAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmgKQEAgLTIy NCwxMCArMjI0LDEwIEBAIGNsYXNzIFVubGlua2VkQ29kZUJsb2NrIDogcHVibGljIEpTQ2VsbCB7 CiAgICAgICAgIG1fZW5kQ29sdW1uID0gZW5kQ29sdW1uOwogICAgIH0KIAotICAgIGNvbnN0IFN0 cmluZyYgc291cmNlVVJMRGlyZWN0aXZlKCkgY29uc3QgeyByZXR1cm4gbV9zb3VyY2VVUkxEaXJl Y3RpdmU7IH0KLSAgICBjb25zdCBTdHJpbmcmIHNvdXJjZU1hcHBpbmdVUkxEaXJlY3RpdmUoKSBj b25zdCB7IHJldHVybiBtX3NvdXJjZU1hcHBpbmdVUkxEaXJlY3RpdmU7IH0KLSAgICB2b2lkIHNl dFNvdXJjZVVSTERpcmVjdGl2ZShjb25zdCBTdHJpbmcmIHNvdXJjZVVSTCkgeyBtX3NvdXJjZVVS TERpcmVjdGl2ZSA9IHNvdXJjZVVSTDsgfQotICAgIHZvaWQgc2V0U291cmNlTWFwcGluZ1VSTERp cmVjdGl2ZShjb25zdCBTdHJpbmcmIHNvdXJjZU1hcHBpbmdVUkwpIHsgbV9zb3VyY2VNYXBwaW5n VVJMRGlyZWN0aXZlID0gc291cmNlTWFwcGluZ1VSTDsgfQorICAgIFN0cmluZ0ltcGwqIHNvdXJj ZVVSTERpcmVjdGl2ZSgpIGNvbnN0IHsgcmV0dXJuIG1fc291cmNlVVJMRGlyZWN0aXZlLmdldCgp OyB9CisgICAgU3RyaW5nSW1wbCogc291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZSgpIGNvbnN0IHsg cmV0dXJuIG1fc291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZS5nZXQoKTsgfQorICAgIHZvaWQgc2V0 U291cmNlVVJMRGlyZWN0aXZlKGNvbnN0IFN0cmluZyYgc291cmNlVVJMKSB7IG1fc291cmNlVVJM RGlyZWN0aXZlID0gc291cmNlVVJMLmltcGwoKTsgfQorICAgIHZvaWQgc2V0U291cmNlTWFwcGlu Z1VSTERpcmVjdGl2ZShjb25zdCBTdHJpbmcmIHNvdXJjZU1hcHBpbmdVUkwpIHsgbV9zb3VyY2VN YXBwaW5nVVJMRGlyZWN0aXZlID0gc291cmNlTWFwcGluZ1VSTC5pbXBsKCk7IH0KIAogICAgIENv ZGVGZWF0dXJlcyBjb2RlRmVhdHVyZXMoKSBjb25zdCB7IHJldHVybiBtX2ZlYXR1cmVzOyB9CiAg ICAgYm9vbCBoYXNDYXB0dXJlZFZhcmlhYmxlcygpIGNvbnN0IHsgcmV0dXJuIG1faGFzQ2FwdHVy ZWRWYXJpYWJsZXM7IH0KQEAgLTM2Niw4ICszNjYsOCBAQCBjbGFzcyBVbmxpbmtlZENvZGVCbG9j ayA6IHB1YmxpYyBKU0NlbGwgewogICAgIGludCBtX251bUNhbGxlZUxvY2FscyB7IDAgfTsKICAg ICBpbnQgbV9udW1QYXJhbWV0ZXJzIHsgMCB9OwogCi0gICAgU3RyaW5nIG1fc291cmNlVVJMRGly ZWN0aXZlOwotICAgIFN0cmluZyBtX3NvdXJjZU1hcHBpbmdVUkxEaXJlY3RpdmU7CisgICAgUGFj a2VkUmVmUHRyPFN0cmluZ0ltcGw+IG1fc291cmNlVVJMRGlyZWN0aXZlOworICAgIFBhY2tlZFJl ZlB0cjxTdHJpbmdJbXBsPiBtX3NvdXJjZU1hcHBpbmdVUkxEaXJlY3RpdmU7CiAKICAgICBSZWZD b3VudGVkQXJyYXk8SW5zdHJ1Y3Rpb25TdHJlYW06Ok9mZnNldD4gbV9qdW1wVGFyZ2V0czsKICAg ICBSZWY8VW5saW5rZWRNZXRhZGF0YVRhYmxlPiBtX21ldGFkYXRhOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCmluZGV4IGJiNWU4NTJiNDFjNTQ3MGMx ZWU3YzVhODc4YWMzYTNlM2VkMWE0ZjAuLmJhYjZkNDdhMGE0YTM3MGE3Nzc3ODFmMTk0OTJkMmU4 MTU1NDcwYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hl ZFR5cGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBl cy5jcHAKQEAgLTE3OTgsOCArMTc5OCw4IEBAIGNsYXNzIENhY2hlZENvZGVCbG9jayA6IHB1Ymxp YyBDYWNoZWRPYmplY3Q8Q29kZUJsb2NrVHlwZT4gewogICAgIFZpcnR1YWxSZWdpc3RlciB0aGlz UmVnaXN0ZXIoKSBjb25zdCB7IHJldHVybiBtX3RoaXNSZWdpc3RlcjsgfQogICAgIFZpcnR1YWxS ZWdpc3RlciBzY29wZVJlZ2lzdGVyKCkgY29uc3QgeyByZXR1cm4gbV9zY29wZVJlZ2lzdGVyOyB9 CiAKLSAgICBTdHJpbmcgc291cmNlVVJMRGlyZWN0aXZlKERlY29kZXImIGRlY29kZXIpIGNvbnN0 IHsgcmV0dXJuIG1fc291cmNlVVJMRGlyZWN0aXZlLmRlY29kZShkZWNvZGVyKTsgfQotICAgIFN0 cmluZyBzb3VyY2VNYXBwaW5nVVJMRGlyZWN0aXZlKERlY29kZXImIGRlY29kZXIpIGNvbnN0IHsg cmV0dXJuIG1fc291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZS5kZWNvZGUoZGVjb2Rlcik7IH0KKyAg ICBSZWZQdHI8U3RyaW5nSW1wbD4gc291cmNlVVJMRGlyZWN0aXZlKERlY29kZXImIGRlY29kZXIp IGNvbnN0IHsgcmV0dXJuIG1fc291cmNlVVJMRGlyZWN0aXZlLmRlY29kZShkZWNvZGVyKTsgfQor ICAgIFJlZlB0cjxTdHJpbmdJbXBsPiBzb3VyY2VNYXBwaW5nVVJMRGlyZWN0aXZlKERlY29kZXIm IGRlY29kZXIpIGNvbnN0IHsgcmV0dXJuIG1fc291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZS5kZWNv ZGUoZGVjb2Rlcik7IH0KIAogICAgIFJlZjxVbmxpbmtlZE1ldGFkYXRhVGFibGU+IG1ldGFkYXRh KERlY29kZXImIGRlY29kZXIpIGNvbnN0IHsgcmV0dXJuIG1fbWV0YWRhdGEuZGVjb2RlKGRlY29k ZXIpOyB9CiAKQEAgLTE4NjgsOCArMTg2OCw4IEBAIGNsYXNzIENhY2hlZENvZGVCbG9jayA6IHB1 YmxpYyBDYWNoZWRPYmplY3Q8Q29kZUJsb2NrVHlwZT4gewogCiAgICAgQ2FjaGVkUHRyPENhY2hl ZENvZGVCbG9ja1JhcmVEYXRhPiBtX3JhcmVEYXRhOwogCi0gICAgQ2FjaGVkU3RyaW5nIG1fc291 cmNlVVJMRGlyZWN0aXZlOwotICAgIENhY2hlZFN0cmluZyBtX3NvdXJjZU1hcHBpbmdVUkxEaXJl Y3RpdmU7CisgICAgQ2FjaGVkUmVmUHRyPENhY2hlZFN0cmluZ0ltcGw+IG1fc291cmNlVVJMRGly ZWN0aXZlOworICAgIENhY2hlZFJlZlB0cjxDYWNoZWRTdHJpbmdJbXBsPiBtX3NvdXJjZU1hcHBp bmdVUkxEaXJlY3RpdmU7CiAKICAgICBDYWNoZWRQdHI8Q2FjaGVkSW5zdHJ1Y3Rpb25TdHJlYW0+ IG1faW5zdHJ1Y3Rpb25zOwogICAgIENhY2hlZFZlY3RvcjxJbnN0cnVjdGlvblN0cmVhbTo6T2Zm c2V0PiBtX2p1bXBUYXJnZXRzOwpAQCAtMjI0Niw4ICsyMjQ2LDggQEAgQUxXQVlTX0lOTElORSB2 b2lkIENhY2hlZENvZGVCbG9jazxDb2RlQmxvY2tUeXBlPjo6ZW5jb2RlKEVuY29kZXImIGVuY29k ZXIsIGNvbnMKICAgICBtX21ldGFkYXRhLmVuY29kZShlbmNvZGVyLCBjb2RlQmxvY2subV9tZXRh ZGF0YS5nZXQoKSk7CiAgICAgbV9yYXJlRGF0YS5lbmNvZGUoZW5jb2RlciwgY29kZUJsb2NrLm1f cmFyZURhdGEuZ2V0KCkpOwogCi0gICAgbV9zb3VyY2VVUkxEaXJlY3RpdmUuZW5jb2RlKGVuY29k ZXIsIGNvZGVCbG9jay5tX3NvdXJjZVVSTERpcmVjdGl2ZS5pbXBsKCkpOwotICAgIG1fc291cmNl TWFwcGluZ1VSTERpcmVjdGl2ZS5lbmNvZGUoZW5jb2RlciwgY29kZUJsb2NrLm1fc291cmNlVVJM RGlyZWN0aXZlLmltcGwoKSk7CisgICAgbV9zb3VyY2VVUkxEaXJlY3RpdmUuZW5jb2RlKGVuY29k ZXIsIGNvZGVCbG9jay5tX3NvdXJjZVVSTERpcmVjdGl2ZS5nZXQoKSk7CisgICAgbV9zb3VyY2VN YXBwaW5nVVJMRGlyZWN0aXZlLmVuY29kZShlbmNvZGVyLCBjb2RlQmxvY2subV9zb3VyY2VVUkxE aXJlY3RpdmUuZ2V0KCkpOwogCiAgICAgbV9pbnN0cnVjdGlvbnMuZW5jb2RlKGVuY29kZXIsIGNv ZGVCbG9jay5tX2luc3RydWN0aW9ucy5nZXQoKSk7CiAgICAgbV9jb25zdGFudFJlZ2lzdGVycy5l bmNvZGUoZW5jb2RlciwgY29kZUJsb2NrLm1fY29uc3RhbnRSZWdpc3RlcnMpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvZGVDYWNoZS5jcHAKaW5kZXggYjdjNzk3ODQ0ZTcwYTEz YWZiZGIwYjFiYWIwOTlmMzBmNGEzZDkxNi4uMzBiNThiNmFjZGVjZDU4YjAzMDdiZDUyODQ2ZWE0 NjU4MmI5YjA5ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29k ZUNhY2hlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUu Y3BwCkBAIC0xNjEsOSArMTYxLDkgQEAgVW5saW5rZWRDb2RlQmxvY2tUeXBlKiBDb2RlQ2FjaGU6 OmdldFVubGlua2VkR2xvYmFsQ29kZUJsb2NrKFZNJiB2bSwgRXhlY3V0YWJsZVQKICAgICAgICAg Ym9vbCBlbmRDb2x1bW5Jc09uU3RhcnRMaW5lID0gIWxpbmVDb3VudDsKICAgICAgICAgdW5zaWdu ZWQgZW5kQ29sdW1uID0gdW5saW5rZWRDb2RlQmxvY2stPmVuZENvbHVtbigpICsgKGVuZENvbHVt bklzT25TdGFydExpbmUgPyBzdGFydENvbHVtbiA6IDEpOwogICAgICAgICBleGVjdXRhYmxlLT5y ZWNvcmRQYXJzZSh1bmxpbmtlZENvZGVCbG9jay0+Y29kZUZlYXR1cmVzKCksIHVubGlua2VkQ29k ZUJsb2NrLT5oYXNDYXB0dXJlZFZhcmlhYmxlcygpLCBzb3VyY2UuZmlyc3RMaW5lKCkub25lQmFz ZWRJbnQoKSArIGxpbmVDb3VudCwgZW5kQ29sdW1uKTsKLSAgICAgICAgaWYgKCF1bmxpbmtlZENv ZGVCbG9jay0+c291cmNlVVJMRGlyZWN0aXZlKCkuaXNOdWxsKCkpCisgICAgICAgIGlmICh1bmxp bmtlZENvZGVCbG9jay0+c291cmNlVVJMRGlyZWN0aXZlKCkpCiAgICAgICAgICAgICBzb3VyY2Uu cHJvdmlkZXIoKS0+c2V0U291cmNlVVJMRGlyZWN0aXZlKHVubGlua2VkQ29kZUJsb2NrLT5zb3Vy Y2VVUkxEaXJlY3RpdmUoKSk7Ci0gICAgICAgIGlmICghdW5saW5rZWRDb2RlQmxvY2stPnNvdXJj ZU1hcHBpbmdVUkxEaXJlY3RpdmUoKS5pc051bGwoKSkKKyAgICAgICAgaWYgKHVubGlua2VkQ29k ZUJsb2NrLT5zb3VyY2VNYXBwaW5nVVJMRGlyZWN0aXZlKCkpCiAgICAgICAgICAgICBzb3VyY2Uu cHJvdmlkZXIoKS0+c2V0U291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZSh1bmxpbmtlZENvZGVCbG9j ay0+c291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZSgpKTsKICAgICAgICAgcmV0dXJuIHVubGlua2Vk Q29kZUJsb2NrOwogICAgIH0K