207228 2020-02-04 14:25:56 -0800 Web Inspector: the height of the undocked title area shouldn't change when zoomed 2020-03-02 16:54:45 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED MOVED https://bugs.webkit.org/show_bug.cgi?id=207422 InRadar P2 Normal --- 204627 1 hi hi cgarcia commit-queue hi inspector-bugzilla-changes jonlee timothy webkit-bug-importer oldest_to_newest 1614742 0 hi 2020-02-04 14:25:56 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. detach web inspector 3. zoom in/out (⌘+ or ⌘-) => the height of the title area increases 1614744 1 389709 hi 2020-02-04 14:28:36 -0800 Created attachment 389709 Patch 1615434 2 389709 timothy 2020-02-05 17:30:11 -0800 Comment on attachment 389709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389709&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:548 > + } > + WI.settings.zoomFactor.addEventListener(WI.Setting.Event.Changed, updateZoomFactorCSSVariable); Blank line between. Or move the function inline as a arrow function in addEventListener. 1615513 3 389933 hi 2020-02-05 20:10:24 -0800 Created attachment 389933 Patch 1615531 4 commit-queue 2020-02-05 21:06:39 -0800 The commit-queue encountered the following flaky tests while processing attachment 389933: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch. 1615532 5 389933 commit-queue 2020-02-05 21:07:17 -0800 Comment on attachment 389933 Patch Clearing flags on attachment: 389933 Committed r255901: <https://trac.webkit.org/changeset/255901> 1615533 6 commit-queue 2020-02-05 21:07:19 -0800 All reviewed patches have been landed. Closing bug. 1615534 7 webkit-bug-importer 2020-02-05 21:08:14 -0800 <rdar://problem/59213469> 1616521 8 jonlee 2020-02-07 20:23:27 -0800 Reopening. This was reverted by https://trac.webkit.org/changeset/256086/webkit in b207422. 1624832 9 hi 2020-03-02 16:54:45 -0800 This will be resolved by <https://webkit.org/b/207317>. 389709 2020-02-04 14:28:36 -0800 2020-02-05 20:10:23 -0800 Patch bug-207228-20200204142836.patch text/plain 2876 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEzZWFiMjk4MjE1ZjQ5MWM2ZGRhNjg2NDEyYjcw ZGEwYWRkMGEzNDguLmEyODU4M2YwMzM3MWU3ODdjNTBmOGU5NmNkYjcxMGU5MjliMTMwMWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAyLTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB0 aGUgaGVpZ2h0IG9mIHRoZSB1bmRvY2tlZCB0aXRsZSBhcmVhIHNob3VsZG4ndCBjaGFuZ2Ugd2hl biB6b29tZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNzIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXSS5jb250ZW50TG9hZGVk KToKKyAgICAgICAgKFdJLmNvbnRlbnRMb2FkZWQudXBkYXRlWm9vbUZhY3RvckNTU1ZhcmlhYmxl KTogQWRkZWQuCisgICAgICAgIFNhdmUgdGhlIHpvb20gZmFjdG9yIGFzIGEgbnVtYmVyIGluIGEg Q1NTIHZhcmlhYmxlIG9uIHRoZSBgPGJvZHk+YC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvVmFyaWFibGVzLmNzczoKKyAgICAgICAgKGJvZHkubWFjLXBsYXRmb3JtOm5vdCguZG9j a2VkKSk6IEFkZGVkLgorICAgICAgICAoYm9keTpub3QoLmRvY2tlZCkpOiBEZWxldGVkLgorICAg ICAgICBEaXZpZGUgdGhlIGRlZmF1bHQgYDIycHhgIGJ5IHRoZSBjdXJyZW50IHpvb20gZmFjdG9y IHNvIHRoYXQgaXQgY2FuY2VscyBvdXQgd2hlbiByZW5kZXJlZC4KKyAgICAgICAgTWFrZSBpdCBz byB0aGF0IHRoZSB1bmRvY2tlZCB0aXRsZSBhcmVhIGlzIG9ubHkgc2hvd24gb24gbWFjT1MgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzIwNDYyNyNjNDc+CisKIDIwMjAtMDItMDMgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZp eCB0aGUgaW5zcGVjdG9yIGZpbGVzIGNvbWJpbmF0aW9uIGFmdGVyIHIyNTU1NDcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCBjNzBh MDBiMTBlOWViZjhlMTAzNDIxOTExM2I5YWJmOTk2YzFiYzY3Li4xNTQyZmJhNmUwNjE2NjgzNmFi YTQyYWIxMTNiNWRhYTg5NjJkZmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC01NDIsNiArNTQyLDEyIEBAIFdJLmNvbnRlbnRM b2FkZWQgPSBmdW5jdGlvbigpCiAgICAgV0kuc2V0dGluZ3MuY29uc29sZVNhdmVkUmVzdWx0QWxp YXMuYWRkRXZlbnRMaXN0ZW5lcihXSS5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHVwZGF0ZUNvbnNv bGVTYXZlZFJlc3VsdFByZWZpeENTU1ZhcmlhYmxlKTsKICAgICB1cGRhdGVDb25zb2xlU2F2ZWRS ZXN1bHRQcmVmaXhDU1NWYXJpYWJsZSgpOwogCisgICAgZnVuY3Rpb24gdXBkYXRlWm9vbUZhY3Rv ckNTU1ZhcmlhYmxlKCkgeworICAgICAgICBkb2N1bWVudC5ib2R5LnN0eWxlLnNldFByb3BlcnR5 KCItLXpvb20tZmFjdG9yIiwgV0kuc2V0dGluZ3Muem9vbUZhY3Rvci52YWx1ZSk7CisgICAgfQor ICAgIFdJLnNldHRpbmdzLnpvb21GYWN0b3IuYWRkRXZlbnRMaXN0ZW5lcihXSS5TZXR0aW5nLkV2 ZW50LkNoYW5nZWQsIHVwZGF0ZVpvb21GYWN0b3JDU1NWYXJpYWJsZSk7CisgICAgdXBkYXRlWm9v bUZhY3RvckNTU1ZhcmlhYmxlKCk7CisKICAgICAvLyBTaWduYWwgdGhhdCB0aGUgZnJvbnRlbmQg aXMgbm93IHJlYWR5IHRvIHJlY2VpdmUgbWVzc2FnZXMuCiAgICAgV0kuX2JhY2tlbmRUYXJnZXRB dmFpbGFibGVQcm9taXNlLnByb21pc2UudGhlbigoKSA9PiB7CiAgICAgICAgIEluc3BlY3RvckZy b250ZW5kQVBJLmxvYWRDb21wbGV0ZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1ZhcmlhYmxlcy5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WYXJpYWJsZXMuY3NzCmluZGV4IGM2ZGI5NWM4MWVk NzM4ZGZjZjE4NTYzZGI1M2JkNDUzNDc1Zjk0YmIuLmRkN2NhZTUyYTYzNDU3OGFiYmZiZjM1NjM5 YWI1YWM1MzNmOTA1ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1ZhcmlhYmxlcy5jc3MKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVmFyaWFibGVzLmNzcwpAQCAtMjA5LDggKzIwOSw4IEBAIGJvZHk6 bWF0Y2hlcygud2luZG93LWluYWN0aXZlLCAud2luZG93LWRvY2tlZC1pbmFjdGl2ZSkgKiB7CiAg ICAgLS1ib3JkZXItY29sb3ItZGFyazogaHNsKDAsIDAlLCA3MiUpOwogfQogCi1ib2R5Om5vdCgu ZG9ja2VkKSB7Ci0gICAgLS11bmRvY2tlZC10aXRsZS1hcmVhLWhlaWdodDogMjJweDsKK2JvZHku bWFjLXBsYXRmb3JtOm5vdCguZG9ja2VkKSB7CisgICAgLS11bmRvY2tlZC10aXRsZS1hcmVhLWhl aWdodDogY2FsYygyMnB4IC8gdmFyKC0tem9vbS1mYWN0b3IpKTsKIH0KIAogQG1lZGlhIChwcmVm ZXJzLWNvbG9yLXNjaGVtZTogZGFyaykgewo= 389933 2020-02-05 20:10:24 -0800 2020-02-05 21:07:17 -0800 Patch bug-207228-20200205201024.patch text/plain 3247 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNlZGE4NTFmYjcwYmIwMDNmMzc5YmU3MWFjYzlm OWZmZjhlMjI2NGEuLmJiZGE4YjhlMTA1MjkxMTg5MjFlNWIxNWRkOTFkN2JhOTlhN2QzMDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAyLTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB0 aGUgaGVpZ2h0IG9mIHRoZSB1bmRvY2tlZCB0aXRsZSBhcmVhIHNob3VsZG4ndCBjaGFuZ2Ugd2hl biB6b29tZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNzIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kuY29udGVudExvYWRl ZCk6CisgICAgICAgIChXSS5jb250ZW50TG9hZGVkLnVwZGF0ZVpvb21GYWN0b3JDU1NWYXJpYWJs ZSk6IEFkZGVkLgorICAgICAgICBTYXZlIHRoZSB6b29tIGZhY3RvciBhcyBhIG51bWJlciBpbiBh IENTUyB2YXJpYWJsZSBvbiB0aGUgYDxib2R5PmAuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1ZhcmlhYmxlcy5jc3M6CisgICAgICAgIChib2R5Lm1hYy1wbGF0Zm9ybTpub3QoLmRv Y2tlZCkpOiBBZGRlZC4KKyAgICAgICAgKGJvZHk6bm90KC5kb2NrZWQpKTogRGVsZXRlZC4KKyAg ICAgICAgRGl2aWRlIHRoZSBkZWZhdWx0IGAyMnB4YCBieSB0aGUgY3VycmVudCB6b29tIGZhY3Rv ciBzbyB0aGF0IGl0IGNhbmNlbHMgb3V0IHdoZW4gcmVuZGVyZWQuCisgICAgICAgIE1ha2UgaXQg c28gdGhhdCB0aGUgdW5kb2NrZWQgdGl0bGUgYXJlYSBpcyBvbmx5IHNob3duIG9uIG1hY09TIDxo dHRwczovL3dlYmtpdC5vcmcvYi8yMDQ2MjcjYzQ3PgorCiAyMDIwLTAyLTA1ICBOaWtpdGEgVmFz aWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNv bWUgY29va2llIHRhYmxlIGNvbHVtbiBoZWFkZXJzIHNob3VsZCBub3QgYmUgbG9jYWxpemFibGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpp bmRleCA0MjQ4MDhjY2FkZDQ3MzRiYTQzNWIyMjg0NGI2ODJmNjkzNDNhNzk5Li45OTM1ZTBlNmYx Njk5ZmI1MTM2ZjhjZDE0ODUxMmI0ODc5NDVhYWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC01NDIsOSArNTQyLDE3IEBAIFdJ LmNvbnRlbnRMb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgZnVuY3Rpb24gdXBkYXRlQ29uc29sZVNh dmVkUmVzdWx0UHJlZml4Q1NTVmFyaWFibGUoKSB7CiAgICAgICAgIGRvY3VtZW50LmJvZHkuc3R5 bGUuc2V0UHJvcGVydHkoIi0tY29uc29sZS1zYXZlZC1yZXN1bHQtcHJlZml4IiwgIlwiIiArIFdJ LlJ1bnRpbWVNYW5hZ2VyLnByZWZlcnJlZFNhdmVkUmVzdWx0UHJlZml4KCkgKyAiXCIiKTsKICAg ICB9Ci0gICAgV0kuc2V0dGluZ3MuY29uc29sZVNhdmVkUmVzdWx0QWxpYXMuYWRkRXZlbnRMaXN0 ZW5lcihXSS5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHVwZGF0ZUNvbnNvbGVTYXZlZFJlc3VsdFBy ZWZpeENTU1ZhcmlhYmxlKTsKKworICAgIFdJLnNldHRpbmdzLmNvbnNvbGVTYXZlZFJlc3VsdEFs aWFzLmFkZEV2ZW50TGlzdGVuZXIoV0kuU2V0dGluZy5FdmVudC5DaGFuZ2VkLCB1cGRhdGVDb25z b2xlU2F2ZWRSZXN1bHRQcmVmaXhDU1NWYXJpYWJsZSwgV0kuc2V0dGluZ3MpOwogICAgIHVwZGF0 ZUNvbnNvbGVTYXZlZFJlc3VsdFByZWZpeENTU1ZhcmlhYmxlKCk7CiAKKyAgICBmdW5jdGlvbiB1 cGRhdGVab29tRmFjdG9yQ1NTVmFyaWFibGUoKSB7CisgICAgICAgIGRvY3VtZW50LmJvZHkuc3R5 bGUuc2V0UHJvcGVydHkoIi0tem9vbS1mYWN0b3IiLCBXSS5zZXR0aW5ncy56b29tRmFjdG9yLnZh bHVlKTsKKyAgICB9CisKKyAgICBXSS5zZXR0aW5ncy56b29tRmFjdG9yLmFkZEV2ZW50TGlzdGVu ZXIoV0kuU2V0dGluZy5FdmVudC5DaGFuZ2VkLCB1cGRhdGVab29tRmFjdG9yQ1NTVmFyaWFibGUs IFdJLnNldHRpbmdzKTsKKyAgICB1cGRhdGVab29tRmFjdG9yQ1NTVmFyaWFibGUoKTsKKwogICAg IC8vIFNpZ25hbCB0aGF0IHRoZSBmcm9udGVuZCBpcyBub3cgcmVhZHkgdG8gcmVjZWl2ZSBtZXNz YWdlcy4KICAgICBXSS5fYmFja2VuZFRhcmdldEF2YWlsYWJsZVByb21pc2UucHJvbWlzZS50aGVu KCgpID0+IHsKICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRBUEkubG9hZENvbXBsZXRlZCgpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmFy aWFibGVzLmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zh cmlhYmxlcy5jc3MKaW5kZXggMzU5MThhN2NhNDZmMmFiZGExYWNkZDEwMGFjZDY1NTUxNTlhNGVm Zi4uNGEzMDhlZWU3MmMwMTM5M2M3ZDIwNjE0YTc3ZmQ2ZmZhMjkwNTRhZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmFyaWFibGVzLmNzcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WYXJpYWJsZXMu Y3NzCkBAIC0yMTIsOCArMjEyLDggQEAgYm9keTptYXRjaGVzKC53aW5kb3ctaW5hY3RpdmUsIC53 aW5kb3ctZG9ja2VkLWluYWN0aXZlKSAqIHsKICAgICAtLWJvcmRlci1jb2xvci1kYXJrOiBoc2wo MCwgMCUsIDcyJSk7CiB9CiAKLWJvZHk6bm90KC5kb2NrZWQpIHsKLSAgICAtLXVuZG9ja2VkLXRp dGxlLWFyZWEtaGVpZ2h0OiAyMnB4OworYm9keS5tYWMtcGxhdGZvcm06bm90KC5kb2NrZWQpIHsK KyAgICAtLXVuZG9ja2VkLXRpdGxlLWFyZWEtaGVpZ2h0OiBjYWxjKDIycHggLyB2YXIoLS16b29t LWZhY3RvcikpOwogfQogCiBAbWVkaWEgKHByZWZlcnMtY29sb3Itc2NoZW1lOiBkYXJrKSB7Cg==