207219 2020-02-04 12:44:22 -0800 results.webkit.org: Better order upload callbacks 2020-02-04 14:09:11 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap commit-queue webkit-bug-importer oldest_to_newest 1614683 0 jbedard 2020-02-04 12:44:22 -0800 Our upload callbacks should be ordered based on how users will interact with the data and how long the callback tasks take. 1614684 1 jbedard 2020-02-04 12:50:46 -0800 Alexey brought a bug to my attention where he was getting a 404 when trying to investigate a link to Buildbot. I couldn't reproduce the issue a few hours later, but it occurred to me what was likely happening. Our callback tasks are executed in order, but some callback tasks are nearly instant while others may take minutes. If you look, the callback which generates links to Buildbot is executed after the one generating test results, which is the most expensive callback and the callback that tends to generate the data users most often use to discover a test run. While I can't be certain, I'm pretty sure that that what was happening to Alexey was that he followed a Buildbot link for a test run where the results had been processed (or at least, the result he was interested in) but the Buildbot links had not yet been generated. 1614685 2 389693 jbedard 2020-02-04 12:59:06 -0800 Created attachment 389693 Patch 1614715 3 389693 commit-queue 2020-02-04 14:02:12 -0800 Comment on attachment 389693 Patch Clearing flags on attachment: 389693 Committed r255694: <https://trac.webkit.org/changeset/255694> 1614716 4 commit-queue 2020-02-04 14:02:14 -0800 All reviewed patches have been landed. Closing bug. 1614719 5 webkit-bug-importer 2020-02-04 14:04:42 -0800 <rdar://problem/59163912> 1614728 6 jbedard 2020-02-04 14:09:11 -0800 While this definitely was a theoretical issue, it wasn't what Alexey was encountering. He showed me his reproduction steps, it's a different bug. 389693 2020-02-04 12:59:06 -0800 2020-02-04 14:02:12 -0800 Patch bug-207219-20200204125906.patch text/plain 1648 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTY5MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIwLTAyLTA0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IEJldHRlciBvcmRlciB1cGxvYWQgY2Fs bGJhY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDcyMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBP cmRlciB1cGxvYWQgY2FsbGJhY2tzIG1vcmUgZGVsaWJlcmF0ZWx5IHNvIHRoYXQgdGhlIHF1aWNr ZXN0IGNhbGxiYWNrcworICAgICAgICB0aGF0IGFyZSBsZWFzdCBsaWtlbHkgdG8gbGluayB0byBp bmZvcm1hdGlvbiBmcm9tIHVuZmluaXNoZWQgY2FsbGJhY2tzIGFyZQorICAgICAgICBleGVjdXRl ZCBmaXJzdC4KKworICAgICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL21vZGVs LnB5OgorICAgICAgICAoTW9kZWwuX19pbml0X18pOiBHZW5lcmF0ZSBidWlsZGJvdCBsaW5rcyBm aXJzdCwgdGhlbiBnZW5lcmF0ZSBhIGZhaWx1cmUKKyAgICAgICAgbGlzdCwgdGhlbiBnZW5lcmF0 ZSB0aGUgY29sbGVjdGl2ZSBzdWl0ZSByZXN1bHRzIGFuZCBmaW5hbGx5LCBpbmRpdmlkdWFsCisg ICAgICAgIHRlc3QgcmVzdWx0cy4KKwogMjAyMC0wMi0wNCAgQWFrYXNoIEphaW4gIDxhYWthc2hf amFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0VXU10gRG8gbm90IHJlbW92ZSBUZXN0V2ViS2l0 QVBJIHByZWZpeCBmcm9tIGFwaSB0ZXN0IGZhaWx1cmVzCkluZGV4OiBUb29scy9yZXN1bHRzZGJw eS9yZXN1bHRzZGJweS9tb2RlbC9tb2RlbC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS9tb2RlbC9tb2RlbC5weQkocmV2aXNpb24gMjU1NjkwKQorKysgVG9v bHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvbW9kZWwvbW9kZWwucHkJKHdvcmtpbmcgY29weSkK QEAgLTgxLDcgKzgxLDcgQEAgY2xhc3MgTW9kZWwob2JqZWN0KToKICAgICAgICAgICAgIHR0bF9z ZWNvbmRzPXNlbGYuZGVmYXVsdF90dGxfc2Vjb25kcywKICAgICAgICAgKQogCi0gICAgICAgIGZv ciBjb250ZXh0IGluIFtzZWxmLnN1aXRlX2NvbnRleHQsIHNlbGYudGVzdF9jb250ZXh0LCBzZWxm LmNpX2NvbnRleHQsIHNlbGYuZmFpbHVyZV9jb250ZXh0XToKKyAgICAgICAgZm9yIGNvbnRleHQg aW4gW3NlbGYuY2lfY29udGV4dCwgc2VsZi5mYWlsdXJlX2NvbnRleHQsIHNlbGYuc3VpdGVfY29u dGV4dCwgc2VsZi50ZXN0X2NvbnRleHRdOgogICAgICAgICAgICAgc2VsZi51cGxvYWRfY29udGV4 dC5yZWdpc3Rlcl91cGxvYWRfY2FsbGJhY2soY29udGV4dC5uYW1lLCBjb250ZXh0LnJlZ2lzdGVy KQogCiAgICAgICAgIHNlbGYuYXJjaGl2ZV9jb250ZXh0ID0gQXJjaGl2ZUNvbnRleHQoCg==