207209 2020-02-04 09:59:13 -0800 Regression (~r252261): [ Mac wk2 ] inspector/heap/getPreview.html is flaky failing 2020-02-10 08:20:57 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Mac Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=155312 InRadar P2 Normal --- 1 Lawrence.j webkit-unassigned inspector-bugzilla-changes jacob_uphoff joepeck tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1614609 0 Lawrence.j 2020-02-04 09:59:13 -0800 inspector/heap/getPreview.html Description: This test is flaky failing on Mac wk2. It appears to show a regression at 252273. History: https://results.webkit.org/?suite=layout-tests&test=inspector%2Fheap%2FgetPreview.html&platform=mac&limit=50000 Diff: I was not able to gather a diff. 1614610 1 webkit-bug-importer 2020-02-04 09:59:36 -0800 <rdar://problem/59152840> 1614662 2 389685 Lawrence.j 2020-02-04 11:46:40 -0800 Created attachment 389685 Update Test Expectations 1614663 3 Lawrence.j 2020-02-04 11:47:14 -0800 Here's a diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getPreview-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getPreview-actual.txt @@ -29,23 +29,12 @@ OBJECT PREVIEW: { "type": "object", "description": "Map", - "lossless": true, - "subtype": "map", - "overflow": false, - "properties": [], - "size": 1, - "entries": [ + "lossless": false, + "properties": [ { - "key": { - "type": "string", - "description": "key", - "lossless": true - }, - "value": { - "type": "string", - "description": "value", - "lossless": true - } + "name": "Symbol(Symbol.toStringTag)", + "type": "string", + "value": "Map" } ] } 1614671 4 389687 Lawrence.j 2020-02-04 12:00:50 -0800 Created attachment 389687 Update Test Expectations 1614674 5 389687 tsavell 2020-02-04 12:01:47 -0800 Comment on attachment 389687 Update Test Expectations Clearing flags on attachment: 389687 Committed r255690: <https://trac.webkit.org/changeset/255690> 1614729 6 jacob_uphoff 2020-02-04 14:12:17 -0800 I ran this test in iterations x5000 and did not reproduce a failure. 1615372 7 Lawrence.j 2020-02-05 16:15:43 -0800 I was able to reproduce this issue with 255856 using the following command. run-webkit-tests --root xxx inspector/heap/getPreview.html --iterations 5000 -f --exit-after-n-failures 5 -g --force --time-out-ms 10000 [15/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [17/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [18/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [22/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [23/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) Exiting early after 5 failures. 20 tests run. 15 tests ran as expected, 5 didn't (4980 didn't run): 1615386 8 joepeck 2020-02-05 16:26:29 -0800 Hmm, I don't like the idea of papering over this potential issue. It sounds like a (In reply to Jason Lawrence from comment #3) > Here's a diff: > > --- > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > inspector/heap/getPreview-expected.txt > +++ > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > inspector/heap/getPreview-actual.txt > @@ -29,23 +29,12 @@ > OBJECT PREVIEW: { > "type": "object", > "description": "Map", > - "lossless": true, > - "subtype": "map", > - "overflow": false, > - "properties": [], > - "size": 1, > - "entries": [ > + "lossless": false, > + "properties": [ > { > - "key": { > - "type": "string", > - "description": "key", > - "lossless": true > - }, > - "value": { > - "type": "string", > - "description": "value", > - "lossless": true > - } > + "name": "Symbol(Symbol.toStringTag)", > + "type": "string", > + "value": "Map" > } > ] > } Does this always fail this way? Can we just rebaseline? 1615554 9 ap 2020-02-05 23:35:46 -0800 > 15 tests ran as expected, 5 didn't (4980 didn't run): This suggests that no, we cannot rebaseline. 1615555 10 ap 2020-02-05 23:41:42 -0800 I don't see any failures at all before early November (roughly r252261), although there were always many timeouts. 1616869 11 jacob_uphoff 2020-02-10 08:20:57 -0800 Corrected test expectations on r256174 389685 2020-02-04 11:46:40 -0800 2020-02-04 12:00:48 -0800 Update Test Expectations bug-207209-20200204114639.patch text/plain 1950 Lawrence.j U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NjgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODQzNTA0NjU3YjBiYTRiYmU3MjBm ZGJlYTM5ZjRjZjI0NjkwZTE4Ny4uY2Q3NDQ5ODcwY2Q5NjgzMTM1MGZhZDU3ZWY0ZWE2MWE4NzBk M2QxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAyLTA0ICBKYXNvbiBMYXdyZW5jZSAg PGxhd3JlbmNlLmpAYXBwbGUuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb246ICgyNTIyNzMpIFsg TWFjIHdrMiBdIGluc3BlY3Rvci9oZWFwL2dldFByZXZpZXcuaHRtbCBpcyBmbGFreSBmYWlsaW5n LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MjA5 CisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZy4KKworICAgICAgICAqIHBsYXRm b3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wMi0wNCAgSmFzb24gTGF3cmVu Y2UgIDxsYXdyZW5jZS5qQGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hYyB3azIgXSB3ZWJncHUv d2hsc2wvdGV4dHVyZXMtc2FtcGxlLWdyYWQuaHRtbCBpcyBmbGFreSBmYWlsaW5nLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDhlMTU3OWQy MGYzM2RiM2ZlOGNkODI0NWUyZTc2NmUxYWMwZGVhODEuLjRlMWIyMDg0MjRhNWIwZDFhODA0YmM2 YzE2MTczMTNkZWQxYTBjYTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13 azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rl c3RFeHBlY3RhdGlvbnMKQEAgLTM2Miw3ICszNjIsNyBAQCB3ZWJraXQub3JnL2IvMTUwNTQyIGZh c3QvZm9ybXMvc3RhdGUtcmVzdG9yZS1wZXItZm9ybS5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAog d2Via2l0Lm9yZy9iLzE1MTcwOSBbIFJlbGVhc2UgXSBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L3dvcmtlcnMvbWV0aG9kcy5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAotd2Via2l0Lm9yZy9iLzE1 NTMxMiBpbnNwZWN0b3IvaGVhcC9nZXRQcmV2aWV3Lmh0bWwgWyBQYXNzIFRpbWVvdXQgXQord2Vi a2l0Lm9yZy9iLzE1NTMxMiBbIERlYnVnIF0gaW5zcGVjdG9yL2hlYXAvZ2V0UHJldmlldy5odG1s IFsgUGFzcyBUaW1lb3V0IEZhaWx1cmUgXQogCiAjIFZpZGVvIGZ1bGxzY3JlZW4gaXMgbm90IGlt cGxlbWVudGVkIGZvciBtYWMgd2syIGluIHdlYmtpdHRlc3RydW5uZXIKIG1lZGlhL21lZGlhLWZ1 bGxzY3JlZW4tbG9vcC1pbmxpbmUuaHRtbCBbIFNraXAgXQpAQCAtOTgyLDQgKzk4Miw2IEBAIHdl YmtpdC5vcmcvYi8yMDcxOTkgd2ViZ3B1L3dobHNsL2xvb3BzLmh0bWwgWyBQYXNzIEltYWdlT25s eUZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMjA3MjAwIHdlYmdwdS93aGxzbC93aGlsZS1sb29w LWNvbnRpbnVlLmh0bWwgWyBQYXNzIEltYWdlT25seUZhaWx1cmUgXQogCi13ZWJraXQub3JnL2Iv MjA3MjAyIHdlYmdwdS93aGxzbC90ZXh0dXJlcy1zYW1wbGUtZ3JhZC5odG1sIFsgUGFzcyBJbWFn ZU9ubHlGYWlsdXJlIF0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCit3ZWJraXQub3JnL2Iv MjA3MjAyIHdlYmdwdS93aGxzbC90ZXh0dXJlcy1zYW1wbGUtZ3JhZC5odG1sIFsgUGFzcyBJbWFn ZU9ubHlGYWlsdXJlIF0KKword2Via2l0Lm9yZy9iLzIwNzIwOSBbIFJlbGVhc2UgXSBpbnNwZWN0 b3IvaGVhcC9nZXRQcmV2aWV3Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQpcIE5vIG5ld2xpbmUgYXQg ZW5kIG9mIGZpbGUK 389687 2020-02-04 12:00:50 -0800 2020-02-04 12:01:47 -0800 Update Test Expectations bug-207209-20200204120049.patch text/plain 1979 Lawrence.j U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1Njg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTE3MmM1NDhmNzUwYzk3MDA1YzVh YmVhYzFmOWZlZTU2NGQ5NjE5ZC4uMmVlODM2YjFmNGEzNThlZWRhODJhMDU5YTA0OWZhNTRlOGIw ZjVlZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAyLTA0ICBKYXNvbiBMYXdyZW5jZSAg PGxhd3JlbmNlLmpAYXBwbGUuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb246ICgyNTIyNzMpIFsg TWFjIHdrMiBdIGluc3BlY3Rvci9oZWFwL2dldFByZXZpZXcuaHRtbCBpcyBmbGFreSBmYWlsaW5n LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MjA5 CisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZy4KKworICAgICAgICAqIHBsYXRm b3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wMi0wNCAgSmFzb24gTGF3cmVu Y2UgIDxsYXdyZW5jZS5qQGFwcGxlLmNvbT4KIAogICAgICAgICBbIG1hY09TIHdrMiBdIGluc3Bl Y3Rvci9jYW52YXMvc2hhZGVyUHJvZ3JhbS1hZGQtcmVtb3ZlLXdlYmdsMi5odG1sIGlzIGZsYWt5 IGNyYXNoaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggODA1YzFmZThkNjc1YThjMGVjNjk4Mjg0OTQ0NDU3MTVmMTIzNzYwNC4uZDQzNDhh OGZkYTBjNzZmNjQxZWNiNjFhZjA0OTgwNWQ0MzYyZjRjNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzYyLDcgKzM2Miw3IEBAIHdlYmtp dC5vcmcvYi8xNTA1NDIgZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXBlci1mb3JtLmh0bWwgWyBQ YXNzIFRpbWVvdXQgXQogCiB3ZWJraXQub3JnL2IvMTUxNzA5IFsgUmVsZWFzZSBdIGh0dHAvdGVz dHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9tZXRob2RzLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQog Ci13ZWJraXQub3JnL2IvMTU1MzEyIGluc3BlY3Rvci9oZWFwL2dldFByZXZpZXcuaHRtbCBbIFBh c3MgVGltZW91dCBdCit3ZWJraXQub3JnL2IvMTU1MzEyIFsgRGVidWcgXSBpbnNwZWN0b3IvaGVh cC9nZXRQcmV2aWV3Lmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogCiAjIFZpZGVvIGZ1bGxzY3JlZW4g aXMgbm90IGltcGxlbWVudGVkIGZvciBtYWMgd2syIGluIHdlYmtpdHRlc3RydW5uZXIKIG1lZGlh L21lZGlhLWZ1bGxzY3JlZW4tbG9vcC1pbmxpbmUuaHRtbCBbIFNraXAgXQpAQCAtOTg0LDQgKzk4 NCw2IEBAIHdlYmtpdC5vcmcvYi8yMDcyMDAgd2ViZ3B1L3dobHNsL3doaWxlLWxvb3AtY29udGlu dWUuaHRtbCBbIFBhc3MgSW1hZ2VPbmx5RmFpbHVyCiAKIHdlYmtpdC5vcmcvYi8yMDcyMDIgd2Vi Z3B1L3dobHNsL3RleHR1cmVzLXNhbXBsZS1ncmFkLmh0bWwgWyBQYXNzIEltYWdlT25seUZhaWx1 cmUgXQogCi13ZWJraXQub3JnL2IvMjA2NzE4IGluc3BlY3Rvci9jYW52YXMvc2hhZGVyUHJvZ3Jh bS1hZGQtcmVtb3ZlLXdlYmdsMi5odG1sIFsgUGFzcyBDcmFzaCBdClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQord2Via2l0Lm9yZy9iLzIwNjcxOCBpbnNwZWN0b3IvY2FudmFzL3NoYWRlclBy b2dyYW0tYWRkLXJlbW92ZS13ZWJnbDIuaHRtbCBbIFBhc3MgQ3Jhc2ggXQorCit3ZWJraXQub3Jn L2IvMjA3MjA5IFsgUmVsZWFzZSBdIGluc3BlY3Rvci9oZWFwL2dldFByZXZpZXcuaHRtbCBbIFBh c3MgRmFpbHVyZSBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=