207197 2020-02-04 07:28:45 -0800 Regression(?): [ iOS wk2 ] http/tests/resourceLoadStatistics/cookie-deletion.html is flaky failing and crashing. 2020-05-26 15:03:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 Lawrence.j webkit-unassigned tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1614519 0 Lawrence.j 2020-02-04 07:28:45 -0800 http/tests/resourceLoadStatistics/cookie-deletion.html Description: This test is flaky failing and crashing on iOS wk2. History: https://results.webkit.org/?platform=ios&suite=layout-tests&test=http%2Ftests%2FresourceLoadStatistics%2Fcookie-deletion.html&limit=50000 Diff: --- /Volumes/Data/slave/ipados-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/cookie-deletion-expected.txt +++ /Volumes/Data/slave/ipados-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/cookie-deletion-actual.txt @@ -1,73 +1,5 @@ CONSOLE MESSAGE: line 117: Test is beginning. document.location.hash is empty. CONSOLE MESSAGE: line 123: About to call runTest() for the first time. CONSOLE MESSAGE: line 62: step1. About to set a cookie -CONSOLE MESSAGE: line 127: About to call runTest() after cookie was set. document hash is #step2 -CONSOLE MESSAGE: line 67: step2. About to open an iFrame to test for third party cookie access (should be successful) -CONSOLE MESSAGE: line 73: step3. About to classify localhost as prevalent -CONSOLE MESSAGE: line 77: step3. In the callback for testRunner.setStatisticsPrevalentResource -CONSOLE MESSAGE: line 84: step4. About to open an iFrame to test for third party cookie access (should not be successful) -CONSOLE MESSAGE: line 90: step5. About to open an iFrame to try to set a cookie as a third party (should fail) -CONSOLE MESSAGE: line 96: step6. About to open an iFrame and fireDataModificationHandlerAndContinue -CONSOLE MESSAGE: line 40: In fireDataModificationHandlerAndContinue -CONSOLE MESSAGE: line 45: Calling statisticsProcessStatisticsAndDataRecords -CONSOLE MESSAGE: line 42: In callback function for installStatisticsDidScanDataRecordsCallback -CONSOLE MESSAGE: line 102: step7. About to open an iFrame and setAsNonPrevalentAndContinue -CONSOLE MESSAGE: line 50: In setAsNonPrevalentAndContinue -CONSOLE MESSAGE: line 52: In callback function for setStatisticsPrevalentResource -CONSOLE MESSAGE: line 108: step8. About to open an iFrame and confirm third party has no cookie access -CONSOLE MESSAGE: line 25: in finishTest -Test for partitioned and unpartitioned cookie deletion. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS successfullyParsed is true - -TEST COMPLETE - - --------- -Frame: '' --------- -Should receive first-party cookie. -Received cookie named 'firstPartyCookie'. -Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: firstPartyCookie=value - --------- -Frame: '' --------- -Should receive no cookies. -Did not receive cookie named 'firstPartyCookie'. -Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: - --------- -Frame: '' --------- -Try to set third party cookie. - - --------- -Frame: '' --------- -Should receive no cookies. -Did not receive cookie named 'firstPartyCookie'. -Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: - --------- -Frame: '' --------- -After removal, should receive no cookies. -Did not receive cookie named 'firstPartyCookie'. -Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: - --------- -Frame: '' --------- -After declassified, should receive no cookies. -Did not receive cookie named 'firstPartyCookie'. -Did not receive cookie named 'thirdPartyCookie'. -Client-side document.cookie: 1614520 1 webkit-bug-importer 2020-02-04 07:29:05 -0800 <rdar://problem/59148643> 1614528 2 Lawrence.j 2020-02-04 07:46:18 -0800 I am not able to reproduce this issue with run-webkit-tests after 2500 iterations. 1614538 3 389660 Lawrence.j 2020-02-04 08:01:27 -0800 Created attachment 389660 Update Test Expectations 1614541 4 389660 tsavell 2020-02-04 08:09:04 -0800 Comment on attachment 389660 Update Test Expectations Clearing flags on attachment: 389660 Committed r255676: <https://trac.webkit.org/changeset/255676> 1614542 5 Lawrence.j 2020-02-04 08:09:52 -0800 This appears to only be flaky crashing in debug. It is flaky failing otherwise. 1614666 6 ap 2020-02-04 11:52:03 -0800 I see failures in mid-September (from 11th to 19th), then a long green streak, and then failures, timeouts and assertion failures begin on November 6th. Hard to tell how real this is, but results definitely got worse. The assertion failure is this, which we've been seeing for a long time on other tests: ASSERTION FAILED: m_uncommittedState.state == State::Committed /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/UIProcess/PageLoadState.cpp(322) : void WebKit::PageLoadState::didFinishLoad(const Transaction::Token &) 1 0x10c353309 WTFCrash 2 0x11ab4da6b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11b59b140 WebKit::PageLoadState::didFinishLoad(WebKit::PageLoadState::Transaction::Token const&) 4 0x11b6fe4b4 WebKit::WebPageProxy::didFinishLoadForFrame(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData const&) 5 0x11c1e5782 void IPC::callMemberFunctionImpl<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData const&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData>, 0ul, 1ul, 2ul>(WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData const&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul>) 6 0x11c1e4ab0 void IPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData const&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul> >(std::__1::tuple<WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData>&&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData const&)) 7 0x11c1b30bd void IPC::handleMessage<Messages::WebPageProxy::DidFinishLoadForFrame, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData const&)>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WTF::ObjectIdentifier<WebCore::FrameIdentifierType>, unsigned long long, WebKit::UserData const&)) 1656197 7 Lawrence.j 2020-05-26 15:03:12 -0700 I have removed the expectation because the test appears to be passing consistently now. https://trac.webkit.org/changeset/262164/webkit 389660 2020-02-04 08:01:27 -0800 2020-02-04 08:09:04 -0800 Update Test Expectations bug-207197-20200204080126.patch text/plain 1562 Lawrence.j U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1Njc0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjRkYWFkYTJhNDc3OGU2M2Y3ZTZh M2NkNzVlZGY0ZTFlNTc0NTRlOS4uMzdlMmQ0YWU2NTk0NmMwYjliYWVhZGQwMzUxMzU1MzRlOGFj N2RiNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAyLTA0ICBKYXNvbiBMYXdyZW5jZSAg PGxhd3JlbmNlLmpAYXBwbGUuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb246ICgyNTIzMzQ/KSBb IGlPUyB3azIgXSBodHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvY29va2llLWRlbGV0 aW9uLmh0bWwgaXMgZmxha3kgZmFpbGluZyBhbmQgY3Jhc2hpbmcuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcxOTcKKworICAgICAgICBVbnJldmll d2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhw ZWN0YXRpb25zOgorCiAyMDIwLTAyLTA0ICBKYWNvYiBVcGhvZmYgIDxqYWNvYl91cGhvZmZAYXBw bGUuY29tPgogCiAgICAgICAgIFsgbWFjT1Mgd2syIF0gd2ViZ3B1L3dobHNsL2xvb3BzLmh0bWwg aXMgZmxha3kgZmFpbGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdr Mi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IDM1YTM0Njc1OGRjMjI3OTM0YmJmMTFlMmYwZGE2MWMzNTczYjQzYWYu LjJlZTQ3NWVjZTE5MWU1N2FlNzdjYzM3MTEwOTJmMTZiMmY1ZWI4NjUgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEzNzQsNCArMTM3NCw2 IEBAIHdlYmtpdC5vcmcvYi8yMDcxNjEgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy8y ZGNvbnRleHQvaW1hZ2ViaXRtYXAvY3JlYXRlCiAKIHdlYmtpdC5vcmcvYi8yMDcxNjQgWyBEZWJ1 ZyBdIGxlZ2FjeS1hbmltYXRpb24tZW5naW5lL2FuaW1hdGlvbnMvcGxheS1zdGF0ZS1pbi1zaG9y dGhhbmQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8yMDcxOTQgZmFzdC9z Y3JvbGxpbmcvaW9zL3Njcm9sbC1ldmVudHMtYmFjay1mb3J3YXJkLmh0bWwgWyBQYXNzIEZhaWx1 cmUgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKK3dlYmtpdC5vcmcvYi8yMDcxOTQgZmFz dC9zY3JvbGxpbmcvaW9zL3Njcm9sbC1ldmVudHMtYmFjay1mb3J3YXJkLmh0bWwgWyBQYXNzIEZh aWx1cmUgXQorCit3ZWJraXQub3JnL2IvMjA3MTk3IGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3Rh dGlzdGljcy9jb29raWUtZGVsZXRpb24uaHRtbCBbIFBhc3MgRmFpbHVyZSBDcmFzaCBdClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=