207192 2020-02-04 02:06:56 -0800 Check for callback being null in Notification.requestPermission 2020-02-04 08:55:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue webkit-bug-importer oldest_to_newest 1614466 0 youennf 2020-02-04 02:06:56 -0800 Check for callback being null in Notification.requestPermission 1614467 1 youennf 2020-02-04 02:07:26 -0800 <rdar://problem/59130804> 1614468 2 389644 youennf 2020-02-04 02:09:25 -0800 Created attachment 389644 Patch 1614539 3 389644 cdumez 2020-02-04 08:07:59 -0800 Comment on attachment 389644 Patch r=me. Not in this patch but it would be good to update this method to return a Promise as well. 1614570 4 389644 commit-queue 2020-02-04 08:55:20 -0800 Comment on attachment 389644 Patch Clearing flags on attachment: 389644 Committed r255680: <https://trac.webkit.org/changeset/255680> 1614571 5 commit-queue 2020-02-04 08:55:22 -0800 All reviewed patches have been landed. Closing bug. 389644 2020-02-04 02:09:25 -0800 2020-02-04 08:55:20 -0800 Patch bug-207192-20200204110924.patch text/plain 3319 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc4OWEzNGZlMThjN2E2 YWI4NmUzMzRhNjM5N2EyMmEwMzQ1MGI4MC4uNTg4MGI3MjBjOTUzMGE1NWUxYTBjMGZhNzMyMGFi MzhmMWYxMGQ1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAyLTA0ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDaGVjayBmb3IgY2FsbGJh Y2sgYmVpbmcgbnVsbCBpbiBOb3RpZmljYXRpb24ucmVxdWVzdFBlcm1pc3Npb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzE5MgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNTkxMzA4MDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSB1cGRhdGVkIHRlc3QuCisKKyAgICAgICAgKiBN b2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok5vdGlmaWNhdGlvbjo6cmVxdWVzdFBlcm1pc3Npb24pOgorICAgICAgICBDYWxsYmFjayBjYW4g YmUgbnVsbCBpZiBubyBmdW5jdGlvbiBpcyBnaXZlbiB0byByZXF1ZXN0UGVybWlzc2lvbi4KKyAg ICAgICAgQ2hlY2sgdGhpcyBiZWZvcmUgY2FsbGluZyB0aGUgY2FsbGJhY2suCisKIDIwMjAtMDIt MDQgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0g VXNlIEFWQXNzZXRXcml0ZXJEZWxlZ2F0ZSB0byBpbXBsZW1lbnQgTWVkaWFSZWNvcmRlcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlv bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9u LmNwcAppbmRleCBjYTAyMjVjMDBiYTVhM2FiNzZmMmVjMGE3ZTJkY2FjNjBlYTNhMjIxLi41NDg0 ZDU0NjQzMzdlOWU4OWYzNWVkMWVhYjRmNTRkYzlkYzc1YjU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmNwcApAQCAtMjA0 LDkgKzIwNCwxMSBAQCB2b2lkIE5vdGlmaWNhdGlvbjo6cmVxdWVzdFBlcm1pc3Npb24oRG9jdW1l bnQmIGRvY3VtZW50LCBSZWZQdHI8Tm90aWZpY2F0aW9uUGVybQogICAgICAgICByZXR1cm47CiAK ICAgICBpZiAoIWRvY3VtZW50LmlzU2VjdXJlQ29udGV4dCgpKSB7Ci0gICAgICAgIGRvY3VtZW50 LmV2ZW50TG9vcCgpLnF1ZXVlVGFzayhUYXNrU291cmNlOjpET01NYW5pcHVsYXRpb24sIFtjYWxs YmFjayA9IFdURk1vdmUoY2FsbGJhY2spXSgpIG11dGFibGUgewotICAgICAgICAgICAgY2FsbGJh Y2stPmhhbmRsZUV2ZW50KFBlcm1pc3Npb246OkRlbmllZCk7Ci0gICAgICAgIH0pOworICAgICAg ICBpZiAoY2FsbGJhY2spIHsKKyAgICAgICAgICAgIGRvY3VtZW50LmV2ZW50TG9vcCgpLnF1ZXVl VGFzayhUYXNrU291cmNlOjpET01NYW5pcHVsYXRpb24sIFtjYWxsYmFjayA9IFdURk1vdmUoY2Fs bGJhY2spXSgpIG11dGFibGUgeworICAgICAgICAgICAgICAgIGNhbGxiYWNrLT5oYW5kbGVFdmVu dChQZXJtaXNzaW9uOjpEZW5pZWQpOworICAgICAgICAgICAgfSk7CisgICAgICAgIH0KICAgICAg ICAgcmV0dXJuOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUzYjEzZWJjZWMwOTVjNTU0MjlmMzg3ZTVlMjM3 OThiZmQ5MTFiZjUuLjAyOTI0OTBmZjg0YWYxNTAxOGNmN2UwOTYwMzYyODZhYmFjYmFmNDAgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wMi0wNCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgZm9yIGNhbGxiYWNrIGJlaW5nIG51bGwgaW4gTm90 aWZpY2F0aW9uLnJlcXVlc3RQZXJtaXNzaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcxOTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5MTMw ODA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aHR0cC90ZXN0cy9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbi1pbi1ub24tc2VjdXJlLWNvbnRl eHQuaHRtbDoKKwogMjAyMC0wMi0wNCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CiAKICAgICAgICAgW0NvY29hXSBVc2UgQVZBc3NldFdyaXRlckRlbGVnYXRlIHRvIGltcGxlbWVu dCBNZWRpYVJlY29yZGVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25vdGlm aWNhdGlvbnMvbm90aWZpY2F0aW9uLWluLW5vbi1zZWN1cmUtY29udGV4dC5odG1sIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbi1pbi1ub24tc2VjdXJl LWNvbnRleHQuaHRtbAppbmRleCBiYzNlZmI2MGQ1YTZhYzc4MDg4MTZjYzFjNmViYjA2NDliZDFj ZmE2Li43YjY1MjE4NGRkMTUwYjRjYzUwMTdhNGI0YjliZDFjZTU0YjE5NTg5IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9uLWluLW5v bi1zZWN1cmUtY29udGV4dC5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbm90aWZp Y2F0aW9ucy9ub3RpZmljYXRpb24taW4tbm9uLXNlY3VyZS1jb250ZXh0Lmh0bWwKQEAgLTEwLDYg KzEwLDggQEAgdmFyIHRlc3QgPSBhc3luY190ZXN0KCJOb3RpZmljYXRpb24gcGVybWlzc2lvbiBp biBpbnNlY3VyZSBjb250ZXh0Iik7CiBpZiAod2luZG93LmludGVybmFscykKICAgICBpbnRlcm5h bHMubWFya0NvbnRleHRBc0luc2VjdXJlKCk7CiAKK05vdGlmaWNhdGlvbi5yZXF1ZXN0UGVybWlz c2lvbigpOworCiBOb3RpZmljYXRpb24ucmVxdWVzdFBlcm1pc3Npb24odGVzdC5zdGVwX2Z1bmMo KHJlc3VsdCkgPT4gewogICAgIGFzc2VydF9lcXVhbHMocmVzdWx0LCAiZGVuaWVkIiwgInJlc3Vs dCIpOwogICAgIGFzc2VydF9lcXVhbHMoTm90aWZpY2F0aW9uLnBlcm1pc3Npb24sICJkZW5pZWQi LCAiZ2V0dGVyIik7Cg==