207172 2020-02-03 17:53:18 -0800 [JSC] Use PackedPtr for VariableEnvironment 2020-02-03 20:23:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1614325 0 ysuzuki 2020-02-03 17:53:18 -0800 [JSC] Use PackedCellPtr for VariableEnvironment 1614326 1 389608 ysuzuki 2020-02-03 17:54:10 -0800 Created attachment 389608 Patch 1614332 2 389608 mark.lam 2020-02-03 18:05:47 -0800 Comment on attachment 389608 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + * runtime/CachedTypes.cpp: > + (JSC::CachedRefPtr::encode): > + (JSC::CachedRefPtr::decode const): Your ChangeLog and title doesn't seem to include changes in CachedTypes. Is this intended to be part of this patch? If so, can you add a small blurb in the ChangeLog or update the title? 1614368 3 389608 ysuzuki 2020-02-03 20:16:59 -0800 Comment on attachment 389608 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + (JSC::CachedRefPtr::decode const): > > Your ChangeLog and title doesn't seem to include changes in CachedTypes. Is this intended to be part of this patch? If so, can you add a small blurb in the ChangeLog or update the title? Fixed. This is just because CachedTypes should handle PackedPtr since changed data structures are encoded. 1614371 4 ysuzuki 2020-02-03 20:22:36 -0800 Committed r255659: <https://trac.webkit.org/changeset/255659> 1614372 5 webkit-bug-importer 2020-02-03 20:23:15 -0800 <rdar://problem/59137576> 389608 2020-02-03 17:54:10 -0800 2020-02-03 18:05:47 -0800 Patch bug-207172-20200203175409.patch text/plain 5414 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NjZlODlmZGU3NGUxNjE2ODMyMTJhNWRmY2JiMTY5YzI2YjYzZDNhLi4yZmJkMWY0YzFkNDk1Y2M4 NzFkODNhMWFlMjdmOGUxN2JkMDZkMGRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wMi0wMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFVzZSBQYWNrZWRDZWxsUHRyIGZvciBWYXJpYWJsZUVudmlyb25t ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcx NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5j ZSBWYXJpYWJsZUVudmlyb25tZW50J3MgS2V5VmFsdWUgaXMga2V5OiBwb2ludGVyICsgdmFsdWU6 IDIgYnl0ZSwgdXNpbmcgUGFja2VkQ2VsbFB0ciBjYW4gbWFrZSBpdCA4IGJ5dGVzLCA1MCUgcmVk dWN0aW9uLgorCisgICAgICAgICogcGFyc2VyL1ZhcmlhYmxlRW52aXJvbm1lbnQuaDoKKyAgICAg ICAgKiBydW50aW1lL0NhY2hlZFR5cGVzLmNwcDoKKyAgICAgICAgKEpTQzo6Q2FjaGVkUmVmUHRy OjplbmNvZGUpOgorICAgICAgICAoSlNDOjpDYWNoZWRSZWZQdHI6OmRlY29kZSBjb25zdCk6CisK IDIwMjAtMDItMDMgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAg ICAgICAgIFwwIGlkZW50aXR5IGVzY2FwZXMgc2hvdWxkIGJlIHN5bnRheCBlcnJvcnMgaW4gVW5p Y29kZSBwYXR0ZXJucyBvbmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFy c2VyL1ZhcmlhYmxlRW52aXJvbm1lbnQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv VmFyaWFibGVFbnZpcm9ubWVudC5oCmluZGV4IDdhZGM3ZTEzODc5MDA0ZDRkN2M5MzMwY2ZlNWM3 YTdhZTliZGEzYmIuLjUzMmQxNDZlZmQxZmNhZTUzMjY5ZTc1ZGY2ZjVmZGJlYTE5OTJjNTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvVmFyaWFibGVFbnZpcm9ubWVu dC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvVmFyaWFibGVFbnZpcm9ubWVu dC5oCkBAIC04NSw3ICs4NSw3IEBAIHN0cnVjdCBWYXJpYWJsZUVudmlyb25tZW50RW50cnlIYXNo VHJhaXRzIDogSGFzaFRyYWl0czxWYXJpYWJsZUVudmlyb25tZW50RW50cnk+CiAKIGNsYXNzIFZh cmlhYmxlRW52aXJvbm1lbnQgewogcHJpdmF0ZToKLSAgICB0eXBlZGVmIEhhc2hNYXA8UmVmUHRy PFVuaXF1ZWRTdHJpbmdJbXBsPiwgVmFyaWFibGVFbnZpcm9ubWVudEVudHJ5LCBJZGVudGlmaWVy UmVwSGFzaCwgSGFzaFRyYWl0czxSZWZQdHI8VW5pcXVlZFN0cmluZ0ltcGw+PiwgVmFyaWFibGVF bnZpcm9ubWVudEVudHJ5SGFzaFRyYWl0cz4gTWFwOworICAgIHR5cGVkZWYgSGFzaE1hcDxQYWNr ZWRSZWZQdHI8VW5pcXVlZFN0cmluZ0ltcGw+LCBWYXJpYWJsZUVudmlyb25tZW50RW50cnksIElk ZW50aWZpZXJSZXBIYXNoLCBIYXNoVHJhaXRzPFJlZlB0cjxVbmlxdWVkU3RyaW5nSW1wbD4+LCBW YXJpYWJsZUVudmlyb25tZW50RW50cnlIYXNoVHJhaXRzPiBNYXA7CiBwdWJsaWM6CiAgICAgVmFy aWFibGVFbnZpcm9ubWVudCgpID0gZGVmYXVsdDsKICAgICBWYXJpYWJsZUVudmlyb25tZW50KFZh cmlhYmxlRW52aXJvbm1lbnQmJiBvdGhlcikgPSBkZWZhdWx0OwpAQCAtMTM5LDcgKzEzOSw3IEBA IGNsYXNzIENvbXBhY3RWYXJpYWJsZUVudmlyb25tZW50IHsKIHByaXZhdGU6CiAgICAgQ29tcGFj dFZhcmlhYmxlRW52aXJvbm1lbnQoKSA9IGRlZmF1bHQ7CiAKLSAgICBWZWN0b3I8UmVmUHRyPFVu aXF1ZWRTdHJpbmdJbXBsPj4gbV92YXJpYWJsZXM7CisgICAgVmVjdG9yPFBhY2tlZFJlZlB0cjxV bmlxdWVkU3RyaW5nSW1wbD4+IG1fdmFyaWFibGVzOwogICAgIFZlY3RvcjxWYXJpYWJsZUVudmly b25tZW50RW50cnk+IG1fdmFyaWFibGVNZXRhZGF0YTsKICAgICB1bnNpZ25lZCBtX2hhc2g7CiAg ICAgYm9vbCBtX2lzRXZlcnl0aGluZ0NhcHR1cmVkOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCmluZGV4IGE4MjY2MWEwNmI1OTI0NjFmZjJhNjdmNmNm NDBlMmIxOTZmNTAxOGYuLjI3NDUxMjI0MDI0MzdlYzM1NDg5YWEyNDlkZTNhYmIyNmExMjFhOTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKQEAg LTQyLDYgKzQyLDcgQEAKICNpbmNsdWRlIDx3dGYvRmFzdE1hbGxvYy5oPgogI2luY2x1ZGUgPHd0 Zi9NYWxsb2NQdHIuaD4KICNpbmNsdWRlIDx3dGYvT3B0aW9uYWwuaD4KKyNpbmNsdWRlIDx3dGYv UGFja2VkLmg+CiAjaW5jbHVkZSA8d3RmL1VVSUQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9BdG9t U3RyaW5nSW1wbC5oPgogCkBAIC00NjksNyArNDcwLDcgQEAgY2xhc3MgVmFyaWFibGVMZW5ndGhP YmplY3QgOiBwdWJsaWMgQ2FjaGVkT2JqZWN0PFNvdXJjZT4sIFZhcmlhYmxlTGVuZ3RoT2JqZWN0 QmEKIAogdGVtcGxhdGU8dHlwZW5hbWUgVCwgdHlwZW5hbWUgU291cmNlID0gU291cmNlVHlwZTxU Pj4KIGNsYXNzIENhY2hlZFB0ciA6IHB1YmxpYyBWYXJpYWJsZUxlbmd0aE9iamVjdDxTb3VyY2Uq PiB7Ci0gICAgdGVtcGxhdGU8dHlwZW5hbWUsIHR5cGVuYW1lPgorICAgIHRlbXBsYXRlPHR5cGVu YW1lLCB0eXBlbmFtZSwgdHlwZW5hbWU+CiAgICAgZnJpZW5kIGNsYXNzIENhY2hlZFJlZlB0cjsK IAogICAgIGZyaWVuZCBzdHJ1Y3QgQ2FjaGVkUHRyT2Zmc2V0czsKQEAgLTUzMiwyMCArNTMzLDIw IEBAIHB0cmRpZmZfdCBDYWNoZWRQdHJPZmZzZXRzOjpvZmZzZXRPZmZzZXQoKQogICAgIHJldHVy biBPQkpFQ1RfT0ZGU0VUT0YoQ2FjaGVkUHRyPHZvaWQ+LCBtX29mZnNldCk7CiB9CiAKLXRlbXBs YXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFNvdXJjZSA9IFNvdXJjZVR5cGU8VD4+Ci1jbGFzcyBD YWNoZWRSZWZQdHIgOiBwdWJsaWMgQ2FjaGVkT2JqZWN0PFJlZlB0cjxTb3VyY2U+PiB7Cit0ZW1w bGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBTb3VyY2UgPSBTb3VyY2VUeXBlPFQ+LCB0eXBlbmFt ZSBQdHJUcmFpdHMgPSBEdW1iUHRyVHJhaXRzPFNvdXJjZT4+CitjbGFzcyBDYWNoZWRSZWZQdHIg OiBwdWJsaWMgQ2FjaGVkT2JqZWN0PFJlZlB0cjxTb3VyY2UsIFB0clRyYWl0cz4+IHsKIHB1Ymxp YzoKICAgICB2b2lkIGVuY29kZShFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBTb3VyY2UqIHNyYykK ICAgICB7CiAgICAgICAgIG1fcHRyLmVuY29kZShlbmNvZGVyLCBzcmMpOwogICAgIH0KIAotICAg IHZvaWQgZW5jb2RlKEVuY29kZXImIGVuY29kZXIsIGNvbnN0IFJlZlB0cjxTb3VyY2U+IHNyYykK KyAgICB2b2lkIGVuY29kZShFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBSZWZQdHI8U291cmNlLCBQ dHJUcmFpdHM+IHNyYykKICAgICB7CiAgICAgICAgIGVuY29kZShlbmNvZGVyLCBzcmMuZ2V0KCkp OwogICAgIH0KIAotICAgIFJlZlB0cjxTb3VyY2U+IGRlY29kZShEZWNvZGVyJiBkZWNvZGVyKSBj b25zdAorICAgIFJlZlB0cjxTb3VyY2UsIFB0clRyYWl0cz4gZGVjb2RlKERlY29kZXImIGRlY29k ZXIpIGNvbnN0CiAgICAgewogICAgICAgICBib29sIGlzTmV3QWxsb2NhdGlvbjsKICAgICAgICAg U291cmNlKiBkZWNvZGVkUHRyID0gbV9wdHIuZGVjb2RlKGRlY29kZXIsIGlzTmV3QWxsb2NhdGlv bik7CkBAIC01NjAsNyArNTYxLDcgQEAgY2xhc3MgQ2FjaGVkUmVmUHRyIDogcHVibGljIENhY2hl ZE9iamVjdDxSZWZQdHI8U291cmNlPj4gewogICAgICAgICByZXR1cm4gYWRvcHRSZWYoZGVjb2Rl ZFB0cik7CiAgICAgfQogCi0gICAgdm9pZCBkZWNvZGUoRGVjb2RlciYgZGVjb2RlciwgUmVmUHRy PFNvdXJjZT4mIHNyYykgY29uc3QKKyAgICB2b2lkIGRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBS ZWZQdHI8U291cmNlLCBQdHJUcmFpdHM+JiBzcmMpIGNvbnN0CiAgICAgewogICAgICAgICBzcmMg PSBkZWNvZGUoZGVjb2Rlcik7CiAgICAgfQpAQCAtOTgzLDcgKzk4NCw3IEBAIGNsYXNzIENhY2hl ZFZhcmlhYmxlRW52aXJvbm1lbnQgOiBwdWJsaWMgQ2FjaGVkT2JqZWN0PFZhcmlhYmxlRW52aXJv bm1lbnQ+IHsKIAogcHJpdmF0ZToKICAgICBib29sIG1faXNFdmVyeXRoaW5nQ2FwdHVyZWQ7Ci0g ICAgQ2FjaGVkSGFzaE1hcDxDYWNoZWRSZWZQdHI8Q2FjaGVkVW5pcXVlZFN0cmluZ0ltcGw+LCBW YXJpYWJsZUVudmlyb25tZW50RW50cnksIElkZW50aWZpZXJSZXBIYXNoLCBIYXNoVHJhaXRzPFJl ZlB0cjxVbmlxdWVkU3RyaW5nSW1wbD4+LCBWYXJpYWJsZUVudmlyb25tZW50RW50cnlIYXNoVHJh aXRzPiBtX21hcDsKKyAgICBDYWNoZWRIYXNoTWFwPENhY2hlZFJlZlB0cjxDYWNoZWRVbmlxdWVk U3RyaW5nSW1wbCwgVW5pcXVlZFN0cmluZ0ltcGwsIFdURjo6UGFja2VkUHRyVHJhaXRzPFVuaXF1 ZWRTdHJpbmdJbXBsPj4sIFZhcmlhYmxlRW52aXJvbm1lbnRFbnRyeSwgSWRlbnRpZmllclJlcEhh c2gsIEhhc2hUcmFpdHM8UmVmUHRyPFVuaXF1ZWRTdHJpbmdJbXBsPj4sIFZhcmlhYmxlRW52aXJv bm1lbnRFbnRyeUhhc2hUcmFpdHM+IG1fbWFwOwogfTsKIAogY2xhc3MgQ2FjaGVkQ29tcGFjdFZh cmlhYmxlRW52aXJvbm1lbnQgOiBwdWJsaWMgQ2FjaGVkT2JqZWN0PENvbXBhY3RWYXJpYWJsZUVu dmlyb25tZW50PiB7CkBAIC0xMDEyLDcgKzEwMTMsNyBAQCBjbGFzcyBDYWNoZWRDb21wYWN0VmFy aWFibGVFbnZpcm9ubWVudCA6IHB1YmxpYyBDYWNoZWRPYmplY3Q8Q29tcGFjdFZhcmlhYmxlRW52 aQogICAgIH0KIAogcHJpdmF0ZToKLSAgICBDYWNoZWRWZWN0b3I8Q2FjaGVkUmVmUHRyPENhY2hl ZFVuaXF1ZWRTdHJpbmdJbXBsPj4gbV92YXJpYWJsZXM7CisgICAgQ2FjaGVkVmVjdG9yPENhY2hl ZFJlZlB0cjxDYWNoZWRVbmlxdWVkU3RyaW5nSW1wbCwgVW5pcXVlZFN0cmluZ0ltcGwsIFdURjo6 UGFja2VkUHRyVHJhaXRzPFVuaXF1ZWRTdHJpbmdJbXBsPj4+IG1fdmFyaWFibGVzOwogICAgIENh Y2hlZFZlY3RvcjxWYXJpYWJsZUVudmlyb25tZW50RW50cnk+IG1fdmFyaWFibGVNZXRhZGF0YTsK ICAgICB1bnNpZ25lZCBtX2hhc2g7CiAgICAgYm9vbCBtX2lzRXZlcnl0aGluZ0NhcHR1cmVkOwo=