207170 2020-02-03 17:39:14 -0800 [iOS] Deny mach lookup to 'com.apple.webinspector' in the WebContent process. 2020-03-26 13:33:42 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203214 1 bfulgham bfulgham bfulgham pvollan webkit-bug-importer oldest_to_newest 1614313 0 bfulgham 2020-02-03 17:39:14 -0800 After Bug 203214 is complete, update the sandbox to remove the access. 1614314 1 webkit-bug-importer 2020-02-03 17:39:33 -0800 <rdar://problem/59134038> 1631811 2 394018 bfulgham 2020-03-19 13:57:49 -0700 Created attachment 394018 Patch 1631836 3 394018 pvollan 2020-03-19 14:40:21 -0700 Comment on attachment 394018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394018&action=review R=me. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-641 > -;; Remote Web Inspector > -(allow mach-lookup > - (global-name "com.apple.webinspector")) > - I don't believe we can remove it on macOS just yet. 1632389 4 394018 bfulgham 2020-03-20 17:16:40 -0700 Comment on attachment 394018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394018&action=review >> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-641 >> - > > I don't believe we can remove it on macOS just yet. Really? The connection seems to be vended on macOS, too. What's missing? 1632404 5 394018 pvollan 2020-03-20 17:45:52 -0700 Comment on attachment 394018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394018&action=review >>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-641 >>> - >> >> I don't believe we can remove it on macOS just yet. > > Really? The connection seems to be vended on macOS, too. What's missing? The code is enabled for macOS, but the method WebProcessProxy::enableRemoteInspectorIfNeeded() checks a preference which only exist on iOS, I believe. 1634512 6 394648 bfulgham 2020-03-26 13:09:58 -0700 Created attachment 394648 Patch for landing 1634542 7 ews-feeder 2020-03-26 13:33:42 -0700 Committed r259072: <https://trac.webkit.org/changeset/259072> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394648. 394018 2020-03-19 13:57:49 -0700 2020-03-26 13:09:56 -0700 Patch bug-207170-20200319135748.patch text/plain 3776 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk1YWFlNjE2YTc1NmEyYTUx MGNkYWM0MWJjMzFiMmMwMmY3ODY2NTAuLmFmZjE0MGJiOWI5NmMxODFkNDZkOGFkNjU4Y2NjZmY4 NzBhZDE4YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDMtMTkgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgRGVueSBtYWNoIGxvb2t1cCB0 byAnY29tLmFwcGxlLndlYmluc3BlY3RvcicgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzE3MAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNTkxMzQwMzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugbm93IGR5bmFtaWNhbGx5IGFkZCBhY2Nlc3MgdG8g dGhlICdjb20uYXBwbGUud2ViaW5zcGVjdG9yJyBzZXJ2aWNlLCBzbyB3ZSBzaG91bGQgcmVtb3Zl IHRoZSBibGFua2V0CisgICAgICAgIGFsbG93IHJ1bGUgZnJvbSB0aGUgc2FuZGJveC4KKworICAg ICAgICAqIEdQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbjoK KyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0 LkdQVS5zYjoKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBw bGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUu V2ViUHJvY2Vzcy5zYi5pbjoKKwogMjAyMC0wMy0xOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9y dG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgc3VwcG9ydCBmb3IgY3Vyc29yIGlu dGVyYWN0aW9ucyBvbiBpUGFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mv bWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9XZWJLaXQvR1BV UHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCmluZGV4IDU1ZDZk OWUyNDBjMzc2MmY3NzFhNTQ0MDhmMTk4NzQwZjk1YmQ5NWEuLjVkZTQxOWYxMWVjMDUxODdmNjFh Zjk3MzE3OTcyNDI5ZGM0OWZhYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vz cy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCisrKyBiL1NvdXJjZS9XZWJL aXQvR1BVUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCkBAIC01 ODYsMTAgKzU4Niw2IEBACiAoYWxsb3cgaXBjLXBvc2l4LXNobS1yZWFkKiBpcGMtcG9zaXgtc2ht LXdyaXRlLWRhdGEKICAgICAoaXBjLXBvc2l4LW5hbWUtcmVnZXggIyJeQXVkaW9JTyIpKQogCi07 OyBSZW1vdGUgV2ViIEluc3BlY3RvcgotKGFsbG93IG1hY2gtbG9va3VwCi0gICAgICAgKGdsb2Jh bC1uYW1lICJjb20uYXBwbGUud2ViaW5zcGVjdG9yIikpCi0KIChhbGxvdyBtYWNoLWxvb2t1cAog I2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwCiAgICAgKHdpdGgg cmVwb3J0KSAod2l0aCB0ZWxlbWV0cnkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291 cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiIGIvU291cmNl L1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQ VS5zYgppbmRleCBkNzgwMDY3YjliMDdkYzA5MmZmOTYyMDVmNjZhNWVjOWI0NmFkZTZmLi45MGVl MDQ5MzYyNjFlMTcxZGJjMDE0OTMyNGQzOWI2NDAwZGJmYWFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BV LnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29t LmFwcGxlLldlYktpdC5HUFUuc2IKQEAgLTg4MiwxMCArODgyLDYgQEAKIAogKG1lZGlhLWFjY2Vz c2liaWxpdHktc3VwcG9ydCkKIAotOzsgUmVtb3RlIFdlYiBJbnNwZWN0b3IKLShhbGxvdyBtYWNo LWxvb2t1cAotICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndlYmluc3BlY3RvciIpKQot CiA7OyBWYXJpb3VzIHNlcnZpY2VzIHJlcXVpcmVkIGJ5IENGTmV0d29yayBhbmQgb3RoZXIgZnJh bWV3b3JrcwogKGFsbG93IG1hY2gtbG9va3VwCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUu UG93ZXJNYW5hZ2VtZW50LmNvbnRyb2wiKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9SZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2Ig Yi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuV2ViQ29udGVudC5zYgppbmRleCA5MmUyZmZmNzA4YzNiZGY3MjliN2YxNmRjNjZlZDgx ZmUxZWYyMjA2Li44ZWI2YWY5NjM0MWFkMDg3NGY2NDc3NTE1NWI1ZTkwYmY5NzBjMjQ2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5h cHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgpAQCAtODI4 LDEwICs4MjgsNiBAQAogCiAobWVkaWEtYWNjZXNzaWJpbGl0eS1zdXBwb3J0KQogCi07OyBSZW1v dGUgV2ViIEluc3BlY3RvcgotKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHJlcG9ydCkgKHdpdGgg dGVsZW1ldHJ5KQotICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndlYmluc3BlY3RvciIp KQotCiAoYWxsb3cgbWFjaC1sb29rdXAgKHdpdGggdGVsZW1ldHJ5LWJhY2t0cmFjZSkKICAgICAo Z2xvYmFsLW5hbWUgImNvbS5hcHBsZS5Qb3dlck1hbmFnZW1lbnQuY29udHJvbCIpKQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2Iu aW4gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4K aW5kZXggOWZjNDkwNTgwOWRmYWQ4NTExMzY1YmY0Y2E0NDIwZTI2NDQ2MGMwMy4uYWU4MGNkYmEz ZmE3MWM5OTY0NjYyN2Y5ZmMxY2I4ZDdiMzM5ZjE3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCisrKyBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgpAQCAtNjM1LDEwICs2MzUs NiBAQAogKGFsbG93IGlwYy1wb3NpeC1zaG0tcmVhZCogaXBjLXBvc2l4LXNobS13cml0ZS1kYXRh CiAgICAgKGlwYy1wb3NpeC1uYW1lLXJlZ2V4ICMiXkF1ZGlvSU8iKSkKIAotOzsgUmVtb3RlIFdl YiBJbnNwZWN0b3IKLShhbGxvdyBtYWNoLWxvb2t1cAotICAgICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLndlYmluc3BlY3RvciIpKQotCiAoYWxsb3cgbWFjaC1sb29rdXAKICNpZiBfX01BQ19P U19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTUwMAogICAgICh3aXRoIHJlcG9ydCkgKHdp dGggdGVsZW1ldHJ5KQo= 394648 2020-03-26 13:09:58 -0700 2020-03-26 13:33:42 -0700 Patch for landing bug-207170-20200326130957.patch text/plain 3135 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVlNjM4M2Q0MWNmZTE0OTdm ODNmNjQwMWU1NGU1ZTZmYjhlMzEyYjQuLjZkNDY2MWZhNzFhZTgzZjRjZTczYzM5YmNhNzRmNGY3 OWIyZDE5NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDMtMjYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRGVueSBtYWNoIGxv b2t1cCB0byAnY29tLmFwcGxlLndlYmluc3BlY3RvcicgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2Vz cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzE3 MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkxMzQwMzg+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgUGVyIEFybmUgVm9sbGFuLgorCisgICAgICAgIFdlIG5vdyBkeW5hbWljYWxseSBhZGQgYWNj ZXNzIHRvIHRoZSAnY29tLmFwcGxlLndlYmluc3BlY3Rvcicgc2VydmljZSwgc28gd2Ugc2hvdWxk IHJlbW92ZSB0aGUgYmxhbmtldAorICAgICAgICBhbGxvdyBydWxlIGZyb20gdGhlIHNhbmRib3gu CisKKyAgICAgICAgKiBHUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Mu c2IuaW46CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxl LldlYktpdC5HUFUuc2I6CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiOgorCiAyMDIwLTAzLTI2ICBEYXZpZCBRdWVz YWRhICA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFNQSSB0byBzcGVj aWZ5IHdoZXRoZXIgZmlsZSB1cGxvYWQgcGFuZWxzIGFyZSB1cGxvYWRpbmcgdG8gYW4gZW50ZXJw cmlzZS1tYW5hZ2VkIGRlc3RpbmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVBy b2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9XZWJL aXQvR1BVUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCmluZGV4 IDRhYWY1NTYxZDI4ZmJhMmJjNTI4NGQwZWZlMWZkNDg4YTY5YWQxMTMuLjU2MGM0ZjQ4YTEwN2Zl NGIxYzdhMmM5MWIyZjU4YWMwMWY3MGRhNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BV UHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCisrKyBiL1NvdXJj ZS9XZWJLaXQvR1BVUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmlu CkBAIC01ODUsMTAgKzU4NSw2IEBACiAoYWxsb3cgaXBjLXBvc2l4LXNobS1yZWFkKiBpcGMtcG9z aXgtc2htLXdyaXRlLWRhdGEKICAgICAoaXBjLXBvc2l4LW5hbWUtcmVnZXggIyJeQXVkaW9JTyIp KQogCi07OyBSZW1vdGUgV2ViIEluc3BlY3RvcgotKGFsbG93IG1hY2gtbG9va3VwCi0gICAgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUud2ViaW5zcGVjdG9yIikpCi0KIChhbGxvdyBtYWNoLWxv b2t1cAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNTAwCiAgICAg KHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0cnkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiIGIv U291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2Vi S2l0LkdQVS5zYgppbmRleCA0OWE3ODQ1OTM0ZTVlMWVhNzAwYjIwNjQ1MjJhOWVkZGRkODJiNjc1 Li5mZDVhYjUyZTdjMjNlZGU3Y2ZiNmJmMGIyZTdiNDY0MWQ4YTcwOTc2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJL aXQuR1BVLnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5HUFUuc2IKQEAgLTg3OSwxMCArODc5LDYgQEAKIAogKG1lZGlh LWFjY2Vzc2liaWxpdHktc3VwcG9ydCkKIAotOzsgUmVtb3RlIFdlYiBJbnNwZWN0b3IKLShhbGxv dyBtYWNoLWxvb2t1cAotICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndlYmluc3BlY3Rv ciIpKQotCiA7OyBWYXJpb3VzIHNlcnZpY2VzIHJlcXVpcmVkIGJ5IENGTmV0d29yayBhbmQgb3Ro ZXIgZnJhbWV3b3JrcwogKGFsbG93IG1hY2gtbG9va3VwCiAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuUG93ZXJNYW5hZ2VtZW50LmNvbnRyb2wiKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5h cHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgppbmRleCBkZDQwMWRiNmY4ZTk1MDE2ZWI3MmY0YWFi NzIxZDUwZDFkMTcwNTliLi5jMDdhYjM2OWY2NjdjOGRiYjBlMTQxNjIxZmYxNjU3ZGM2MDFiYTFl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9z L2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0L1Jlc291 cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgpA QCAtODI5LDEwICs4MjksNiBAQAogCiAobWVkaWEtYWNjZXNzaWJpbGl0eS1zdXBwb3J0KQogCi07 OyBSZW1vdGUgV2ViIEluc3BlY3RvcgotKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHJlcG9ydCkg KHdpdGggdGVsZW1ldHJ5KQotICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndlYmluc3Bl Y3RvciIpKQotCiAoZGVueSBtYWNoLWxvb2t1cCAod2l0aCB0ZWxlbWV0cnktYmFja3RyYWNlKQog ICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlBvd2VyTWFuYWdlbWVudC5jb250cm9sIikpCiAK