207148 2020-02-03 14:36:45 -0800 Make Bugzilla._find_select_element_for_flag more robust 2020-02-03 17:33:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Enhancement --- 1 ashvayka ashvayka commit-queue ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1614172 0 ashvayka 2020-02-03 14:36:45 -0800 Make Bugzilla._find_select_element_for_flag more robust 1614175 1 389571 ashvayka 2020-02-03 14:38:52 -0800 Created attachment 389571 Patch 1614309 2 389571 commit-queue 2020-02-03 17:32:11 -0800 Comment on attachment 389571 Patch Clearing flags on attachment: 389571 Committed r255622: <https://trac.webkit.org/changeset/255622> 1614310 3 commit-queue 2020-02-03 17:32:12 -0800 All reviewed patches have been landed. Closing bug. 1614311 4 webkit-bug-importer 2020-02-03 17:33:18 -0800 <rdar://problem/59133831> 389571 2020-02-03 14:38:52 -0800 2020-02-03 17:32:11 -0800 Patch bug-207148-20200204003851.patch text/plain 2872 ashvayka U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzkxMjIxYWI1ZGZmMWQyYmJkOWY1NWJiNGQ0ZjNiNjlk NGFkYTAyZi4uMmM3MTcxZDBiZGU0MTVmMTIzNzFkMzM2NDQ3NDIzMWQ0ZDc4ODMxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTAyLTAzICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4K KworICAgICAgICBNYWtlIEJ1Z3ppbGxhLl9maW5kX3NlbGVjdF9lbGVtZW50X2Zvcl9mbGFnIG1v cmUgcm9idXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDcxNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIHBhdGNoIHJlc29sdmVzIHR3byBGSVhNRXM6CisgICAgICAgIDEuIF9maW5kX3NlbGVj dF9lbGVtZW50X2Zvcl9mbGFnKCkgaXMgbm93IHVzZWQgaW4gX2ZpbGxfYXR0YWNobWVudF9mb3Jt KCkgbWV0aG9kLgorICAgICAgICAyLiBfZmluZF9zZWxlY3RfZWxlbWVudF9mb3JfZmxhZygpIG5v dyBkb2VzIG5vdCByZWx5IG9uIG9yZGVyIG9mIDxzZWxlY3Q+IGVsZW1lbnRzLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5OgorICAg ICAgICAoQnVnemlsbGEuX2ZpbGxfYXR0YWNobWVudF9mb3JtKToKKyAgICAgICAgKEJ1Z3ppbGxh Ll9maW5kX3NlbGVjdF9lbGVtZW50X2Zvcl9mbGFnKToKKwogMjAyMC0wMi0wMyAgWmFuIERvYmVy c2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVXNlIHN0ZDo6aHlwb3QoKSB3 aGVyZSBwb3NzaWJsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v bmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v bmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CmluZGV4IDQxYzllMWU4ZTgwM2MwZTFjZDJiNjY3MmJl Y2M1YmNjMmZmNWI0ZTkuLmVmYTNmNjNhOGM2NjcwNzVhZThkNWE4MGVmMGMxNjc5ZDAzYmM2MTkg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9i dWd6aWxsYS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemls bGEvYnVnemlsbGEucHkKQEAgLTYyNCw5ICs2MjQsOCBAQCBjbGFzcyBCdWd6aWxsYShvYmplY3Qp OgogICAgICAgICBzZWxmLmJyb3dzZXJbJ2Rlc2NyaXB0aW9uJ10gPSBkZXNjcmlwdGlvbgogICAg ICAgICBpZiBpc19wYXRjaDoKICAgICAgICAgICAgIHNlbGYuYnJvd3NlclsnaXNwYXRjaCddID0g KCIxIiwpCi0gICAgICAgICMgRklYTUU6IFNob3VsZCB0aGlzIHVzZSBzZWxmLl9maW5kX3NlbGVj dF9lbGVtZW50X2Zvcl9mbGFnPwotICAgICAgICBzZWxmLmJyb3dzZXJbJ2ZsYWdfdHlwZS0xJ10g PSAoJz8nLCkgaWYgbWFya19mb3JfcmV2aWV3IGVsc2UgKCdYJywpCi0gICAgICAgIHNlbGYuYnJv d3NlclsnZmxhZ190eXBlLTMnXSA9IChzZWxmLl9jb21taXRfcXVldWVfZmxhZyhjb21taXRfZmxh ZyksKQorICAgICAgICBzZWxmLl9maW5kX3NlbGVjdF9lbGVtZW50X2Zvcl9mbGFnKCJyZXZpZXci KS52YWx1ZSA9ICgiPyIsKSBpZiBtYXJrX2Zvcl9yZXZpZXcgZWxzZSAoIlgiLCkKKyAgICAgICAg c2VsZi5fZmluZF9zZWxlY3RfZWxlbWVudF9mb3JfZmxhZygiY29tbWl0LXF1ZXVlIikudmFsdWUg PSAoc2VsZi5fY29tbWl0X3F1ZXVlX2ZsYWcoY29tbWl0X2ZsYWcpLCkKIAogICAgICAgICBmaWxl bmFtZSA9IGZpbGVuYW1lIG9yICIlcy5wYXRjaCIgJSB0aW1lc3RhbXAoKQogICAgICAgICBpZiBu b3QgbWltZXR5cGU6CkBAIC03ODIsMTIgKzc4MSwxNiBAQCBjbGFzcyBCdWd6aWxsYShvYmplY3Qp OgogICAgICAgICByZXR1cm4gYnVnX2lkCiAKICAgICBkZWYgX2ZpbmRfc2VsZWN0X2VsZW1lbnRf Zm9yX2ZsYWcoc2VsZiwgZmxhZ19uYW1lKToKLSAgICAgICAgIyBGSVhNRTogVGhpcyB3aWxsIGJy ZWFrIGlmIHdlIGV2ZXIgcmUtb3JkZXIgYXR0YWNobWVudCBmbGFncwogICAgICAgICBpZiBmbGFn X25hbWUgPT0gInJldmlldyI6Ci0gICAgICAgICAgICByZXR1cm4gc2VsZi5icm93c2VyLmZpbmRf Y29udHJvbCh0eXBlPSdzZWxlY3QnLCBucj0wKQorICAgICAgICAgICAgY2xhc3NfbmFtZSA9ICJm bGFnX3R5cGUtMSIKICAgICAgICAgZWxpZiBmbGFnX25hbWUgPT0gImNvbW1pdC1xdWV1ZSI6Ci0g ICAgICAgICAgICByZXR1cm4gc2VsZi5icm93c2VyLmZpbmRfY29udHJvbCh0eXBlPSdzZWxlY3Qn LCBucj0xKQotICAgICAgICByYWlzZSBFeGNlcHRpb24oIkRvbid0IGtub3cgaG93IHRvIGZpbmQg ZmxhZyBuYW1lZCBcIiVzXCIiICUgZmxhZ19uYW1lKQorICAgICAgICAgICAgY2xhc3NfbmFtZSA9 ICJmbGFnX3R5cGUtMyIKKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlv bigiRG9uJ3Qga25vdyBob3cgdG8gZmluZCBmbGFnIG5hbWVkIFwiJXNcIiIgJSBmbGFnX25hbWUp CisKKyAgICAgICAgcmV0dXJuIHNlbGYuYnJvd3Nlci5maW5kX2NvbnRyb2woCisgICAgICAgICAg ICB0eXBlPSJzZWxlY3QiLAorICAgICAgICAgICAgcHJlZGljYXRlPWxhbWJkYSBjb250cm9sOiBj bGFzc19uYW1lIGluIChjb250cm9sLmF0dHJzLmdldCgiY2xhc3MiKSBvciAiIikpCiAKICAgICBk ZWYgY2xlYXJfYXR0YWNobWVudF9mbGFncyhzZWxmLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGF0dGFjaG1lbnRfaWQsCg==