207144 2020-02-03 13:55:45 -0800 Stop relying on ResponsivenessTimer to keep the WebProcess from suspending during initialization 2021-02-25 08:30:08 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222392 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer youennf oldest_to_newest 1614139 0 cdumez 2020-02-03 13:55:45 -0800 Stop relying on ResponsivenessTimer to keep the WebProcess from suspending during initialization. Instead, make the WebProcess::InitializeWebProcess IPC async with a reply and take a process assertion on behalf of the WebContent process until we get a response back. This avoids sending an extra PING IPC to the WebProcess for no reason (since we're already sending the WebProcess::InitializeWebProcess IPC) and this is also more reliable since the ResponsivenessTimer can actually time out and cause the process to get suspended during initialization still. 1614143 1 389563 cdumez 2020-02-03 13:57:51 -0800 Created attachment 389563 Patch 1614403 2 389563 commit-queue 2020-02-03 21:47:02 -0800 Comment on attachment 389563 Patch Clearing flags on attachment: 389563 Committed r255662: <https://trac.webkit.org/changeset/255662> 1614404 3 commit-queue 2020-02-03 21:47:03 -0800 All reviewed patches have been landed. Closing bug. 1614406 4 webkit-bug-importer 2020-02-03 21:48:15 -0800 <rdar://problem/59139367> 1614557 5 cdumez 2020-02-04 08:30:04 -0800 Follow-up fix for assertions on bots: <https://trac.webkit.org/changeset/255679> 1614775 6 cdumez 2020-02-04 15:11:05 -0800 (In reply to Chris Dumez from comment #5) > Follow-up fix for assertions on bots: > <https://trac.webkit.org/changeset/255679> Improved follow up fix: https://trac.webkit.org/changeset/255705/webkit 1615048 7 cdumez 2020-02-05 08:28:13 -0800 Follow-up fix: <https://trac.webkit.org/changeset/255814> 1617757 8 cdumez 2020-02-11 16:31:28 -0800 Committed r256396: <https://trac.webkit.org/changeset/256396> 389563 2020-02-03 13:57:51 -0800 2020-02-03 21:47:02 -0800 Patch bug-207144-20200203135751.patch text/plain 5825 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhZWU5ZWM0NTJmNDdhMGY1 MzRkN2IwNWNkMmZhNTM5ZWFlODZmNDIuLjg0OTdlMGI1ODA3YjA4MDNkMzI3N2QxMGMyZWZlZmI0 ZWNkOTE4YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjAtMDItMDMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9wIHJlbHlpbmcgb24gUmVzcG9u c2l2ZW5lc3NUaW1lciB0byBrZWVwIHRoZSBXZWJQcm9jZXNzIGZyb20gc3VzcGVuZGluZyBkdXJp bmcgaW5pdGlhbGl6YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNzE0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFN0b3AgcmVseWluZyBvbiBSZXNwb25zaXZlbmVzc1RpbWVyIHRvIGtlZXAgdGhl IFdlYlByb2Nlc3MgZnJvbSBzdXNwZW5kaW5nIGR1cmluZyBpbml0aWFsaXphdGlvbi4gSW5zdGVh ZCwgbWFrZSB0aGUKKyAgICAgICAgV2ViUHJvY2Vzczo6SW5pdGlhbGl6ZVdlYlByb2Nlc3MgSVBD IGFzeW5jIHdpdGggYSByZXBseSBhbmQgdGFrZSBhIHByb2Nlc3MgYXNzZXJ0aW9uIG9uIGJlaGFs ZiBvZiB0aGUgV2ViQ29udGVudAorICAgICAgICBwcm9jZXNzIHVudGlsIHdlIGdldCBhIHJlc3Bv bnNlIGJhY2suCisKKyAgICAgICAgVGhpcyBhdm9pZHMgc2VuZGluZyBhbiBleHRyYSBXZWJQcm9j ZXNzOjpNYWluVGhyZWFkUGluZyBJUEMgdG8gdGhlIFdlYlByb2Nlc3MgZm9yIG5vIHJlYXNvbiAo c2luY2Ugd2UncmUgYWxyZWFkeQorICAgICAgICBzZW5kaW5nIHRoZSBXZWJQcm9jZXNzOjpJbml0 aWFsaXplV2ViUHJvY2VzcyBJUEMpIGFuZCB0aGlzIGlzIGFsc28gbW9yZSByZWxpYWJsZSBzaW5j ZSB0aGUgUmVzcG9uc2l2ZW5lc3NUaW1lciBjYW4KKyAgICAgICAgYWN0dWFsbHkgdGltZSBvdXQg YW5kIGNhdXNlIHRoZSBwcm9jZXNzIHRvIGdldCBzdXNwZW5kZWQgZHVyaW5nIGluaXRpYWxpemF0 aW9uIHN0aWxsLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OmluaXRpYWxpemVOZXdXZWJQcm9jZXNzKToK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzOjppbml0aWFsaXplV2ViUHJvY2Vzcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQcm9jZXNzLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLm1lc3NhZ2VzLmlu OgorCiAyMDIwLTAyLTAzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgog CiAgICAgICAgIFttYWNPU10gQWlyUGxheSBzb21ldGltZXMgc3RvcHMgYWZ0ZXIgNjAgbWludXRl cyBvZiBwbGF5YmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Bvb2wuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3Bw CmluZGV4IGUxY2UzYTE3ZDVjNmQzOGExMmU1NGNjMWY0NWY5NTFjMTZiMjkwZDYuLmVlN2Q1MzI5 ZDhjZTA4ZTk2OThmMDVlZDQ0ODBiYmVhOWYzZDg5YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKQEAgLTk2MywxMiArOTYzLDYgQEAgV2ViUHJvY2Vzc0Rh dGFTdG9yZVBhcmFtZXRlcnMgV2ViUHJvY2Vzc1Bvb2w6OndlYlByb2Nlc3NEYXRhU3RvcmVQYXJh bWV0ZXJzKFdlYlAKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OmluaXRpYWxpemVOZXdXZWJQcm9jZXNz KFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcywgV2Vic2l0ZURhdGFTdG9yZSogd2Vic2l0ZURhdGFT dG9yZSwgV2ViUHJvY2Vzc1Byb3h5OjpJc1ByZXdhcm1lZCBpc1ByZXdhcm1lZCkKIHsKICAgICBh dXRvIGluaXRpYWxpemF0aW9uQWN0aXZpdHkgPSBwcm9jZXNzLnRocm90dGxlcigpLmJhY2tncm91 bmRBY3Rpdml0eSgiV2ViUHJvY2VzcyBpbml0aWFsaXphdGlvbiJfcyk7Ci0gICAgYXV0byBzY29w ZUV4aXQgPSBtYWtlU2NvcGVFeGl0KFsmcHJvY2VzcywgaW5pdGlhbGl6YXRpb25BY3Rpdml0eSA9 IFdURk1vdmUoaW5pdGlhbGl6YXRpb25BY3Rpdml0eSldKCkgbXV0YWJsZSB7Ci0gICAgICAgIC8v IFJvdW5kLXRyaXAgdG8gdGhlIFdlYiBDb250ZW50IHByb2Nlc3MgYmVmb3JlIHJlbGVhc2luZyB0 aGUKLSAgICAgICAgLy8gaW5pdGlhbGl6YXRpb24gYWN0aXZpdHksIHNvIHRoYXQgd2UncmUgc3Vy ZSB0aGF0IGFsbAotICAgICAgICAvLyBtZXNzYWdlcyBzZW50IGZyb20gdGhpcyBmdW5jdGlvbiBo YXZlIGJlZW4gaGFuZGxlZC4KLSAgICAgICAgcHJvY2Vzcy5pc1Jlc3BvbnNpdmUoW2luaXRpYWxp emF0aW9uQWN0aXZpdHkgPSBXVEZNb3ZlKGluaXRpYWxpemF0aW9uQWN0aXZpdHkpXSAoYm9vbCkg eyB9KTsKLSAgICB9KTsKIAogICAgIGVuc3VyZU5ldHdvcmtQcm9jZXNzKCk7CiAKQEAgLTEwNTMs NyArMTA0Nyw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OmluaXRpYWxpemVOZXdXZWJQcm9jZXNz KFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcywgV2Vic2l0ZURhCiAgICAgaWYgKHdlYnNpdGVEYXRh U3RvcmUpCiAgICAgICAgIHBhcmFtZXRlcnMud2Vic2l0ZURhdGFTdG9yZVBhcmFtZXRlcnMgPSB3 ZWJQcm9jZXNzRGF0YVN0b3JlUGFyYW1ldGVycyhwcm9jZXNzLCAqd2Vic2l0ZURhdGFTdG9yZSk7 CiAKLSAgICBwcm9jZXNzLnNlbmQoTWVzc2FnZXM6OldlYlByb2Nlc3M6OkluaXRpYWxpemVXZWJQ cm9jZXNzKHBhcmFtZXRlcnMpLCAwKTsKKyAgICBwcm9jZXNzLnNlbmRXaXRoQXN5bmNSZXBseShN ZXNzYWdlczo6V2ViUHJvY2Vzczo6SW5pdGlhbGl6ZVdlYlByb2Nlc3MocGFyYW1ldGVycyksIFtp bml0aWFsaXphdGlvbkFjdGl2aXR5ID0gV1RGTW92ZShpbml0aWFsaXphdGlvbkFjdGl2aXR5KV0g eyB9KTsKIAogI2lmIFBMQVRGT1JNKENPQ09BKQogICAgIHByb2Nlc3Muc2VuZChNZXNzYWdlczo6 V2ViUHJvY2Vzczo6U2V0UU9TKHdlYlByb2Nlc3NMYXRlbmN5UU9TKCksIHdlYlByb2Nlc3NUaHJv dWdocHV0UU9TKCkpLCAwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcApp bmRleCBmMzA3NTI0OTg2OTI5YjhmMzFhMGY3NmNmYjFkYmJiMGZlMmEzNGExLi4zNzkzNWM1N2Rj ZTcyMmMwMDQ2Y2JhMDMyOGQ4MmFmMzQzMmFmYzUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1dlYlByb2Nlc3MuY3BwCkBAIC0yOTMsNyArMjkzLDcgQEAgdm9pZCBXZWJQcm9jZXNzOjppbml0 aWFsaXplQ29ubmVjdGlvbihJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiAjZW5kaWYKIH0K IAotdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzJiYgcGFyYW1ldGVycykKK3ZvaWQgV2ViUHJvY2Vzczo6aW5pdGlhbGl6ZVdl YlByb2Nlc3MoV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYmIHBhcmFtZXRlcnMsIENvbXBs ZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKIHsgICAgCiAgICAgVHJh Y2VTY29wZSB0cmFjZVNjb3BlKEluaXRpYWxpemVXZWJQcm9jZXNzU3RhcnQsIEluaXRpYWxpemVX ZWJQcm9jZXNzRW5kKTsKIApAQCAtNDU4LDYgKzQ1OCw3IEBAIHZvaWQgV2ViUHJvY2Vzczo6aW5p dGlhbGl6ZVdlYlByb2Nlc3MoV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYmIHBhcmFtZXRl cnMpCiAjZW5kaWYKIAogICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoUHJvY2VzcywgImluaXRp YWxpemVXZWJQcm9jZXNzOiBQcmVzZW50aW5nIHByb2Nlc3MgPSAlZCIsIFdlYkNvcmU6OnByZXNl bnRpbmdBcHBsaWNhdGlvblBJRCgpKTsKKyAgICBjb21wbGV0aW9uSGFuZGxlcigpOwogfQogCiB2 b2lkIFdlYlByb2Nlc3M6OnNldFdlYnNpdGVEYXRhU3RvcmVQYXJhbWV0ZXJzKFdlYlByb2Nlc3NE YXRhU3RvcmVQYXJhbWV0ZXJzJiYgcGFyYW1ldGVycykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UHJvY2Vzcy5oCmluZGV4IDQ5M2IyYjdhMDU5YWFhZmY3OWQzZWVhZmJlNzVlM2E4ZGFjM2Y3Y2Yu LjEzMTU5YWRlYmEyNDI5MDcyZjVkM2ZmNzA1MzhlMDA3NzRlZDg4NjkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlByb2Nlc3MuaApAQCAtMzI3LDcgKzMyNyw3IEBAIHByaXZhdGU6CiAgICAg V2ViUHJvY2VzcygpOwogICAgIH5XZWJQcm9jZXNzKCk7CiAKLSAgICB2b2lkIGluaXRpYWxpemVX ZWJQcm9jZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmJik7CisgICAgdm9pZCBpbml0 aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiYsIENvbXBsZXRp b25IYW5kbGVyPHZvaWQoKT4mJik7CiAgICAgdm9pZCBwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9j ZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmKTsKICAgICB2b2lkIHNldFdlYnNpdGVE YXRhU3RvcmVQYXJhbWV0ZXJzKFdlYlByb2Nlc3NEYXRhU3RvcmVQYXJhbWV0ZXJzJiYpOwogICAg IHZvaWQgcGxhdGZvcm1TZXRXZWJzaXRlRGF0YVN0b3JlUGFyYW1ldGVycyhXZWJQcm9jZXNzRGF0 YVN0b3JlUGFyYW1ldGVycyYmKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQcm9jZXNzLm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBy b2Nlc3MubWVzc2FnZXMuaW4KaW5kZXggMTUzZmMzYmMwMDgwYmU0YTI4NzE1MWU3MjczZjkwYTNm MDMzMmY5ZS4uN2FiMWZhNTNlOGRmYzRmMGI0NjY5YTNmYjVlNzg3MWU0MDFiNmJkMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MubWVzc2FnZXMuaW4KKysr IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MubWVzc2FnZXMuaW4KQEAgLTIx LDcgKzIxLDcgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQ T1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogbWVzc2FnZXMgLT4gV2ViUHJvY2VzcyBMZWdh Y3lSZWNlaXZlciBOb3RSZWZDb3VudGVkIHsKLSAgICBJbml0aWFsaXplV2ViUHJvY2VzcyhzdHJ1 Y3QgV2ViS2l0OjpXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzIHByb2Nlc3NDcmVhdGlvblBh cmFtZXRlcnMpCisgICAgSW5pdGlhbGl6ZVdlYlByb2Nlc3Moc3RydWN0IFdlYktpdDo6V2ViUHJv Y2Vzc0NyZWF0aW9uUGFyYW1ldGVycyBwcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzKSAtPiAoKSBB c3luYwogICAgIFNldFdlYnNpdGVEYXRhU3RvcmVQYXJhbWV0ZXJzKHN0cnVjdCBXZWJLaXQ6Oldl YlByb2Nlc3NEYXRhU3RvcmVQYXJhbWV0ZXJzIHBhcmFtZXRlcnMpCiAKICAgICAjIENyZWF0ZSBh IG5ldyBwYWdlLgo=