207083 2020-01-31 18:16:29 -0800 [JSC] DFG::CommonData::shrinkToFit called before DFG::Plan::reallyAdd is called 2020-01-31 19:37:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam simon.fraser tzagallo webkit-bug-importer oldest_to_newest 1613685 0 ysuzuki 2020-01-31 18:16:29 -0800 DFG::Plan::reallyAdd adds a lot of entries to DFG::CommonData. 1613688 1 389450 ysuzuki 2020-01-31 19:27:01 -0800 Created attachment 389450 Patch 1613689 2 ysuzuki 2020-01-31 19:27:51 -0800 Simon's Vector capacity tracking patch reveals this :) 1613690 3 389450 mark.lam 2020-01-31 19:34:23 -0800 Comment on attachment 389450 Patch r=me 1613691 4 ysuzuki 2020-01-31 19:36:47 -0800 Committed r255540: <https://trac.webkit.org/changeset/255540> 1613692 5 webkit-bug-importer 2020-01-31 19:37:41 -0800 <rdar://problem/59083683> 389450 2020-01-31 19:27:01 -0800 2020-01-31 19:34:23 -0800 Patch bug-207083-20200131192701.patch text/plain 6679 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MTQ5ZjBlZTBmNTU0OWU1MmJkMDc4ZGY0ZmM3NDFjOWU0MTMzMTBmLi41Yjk1NzM4NzYwNzU4YzA5 MDYyY2I1ZmUwNmVmZWFkZjNmYzJiNWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMiBAQAorMjAyMC0wMS0zMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIERGRzo6Q29tbW9uRGF0YTo6c2hyaW5rVG9GaXQgY2FsbGVkIGJl Zm9yZSBERkc6OlBsYW46OnJlYWxseUFkZCBpcyBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzA4MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGFyZSBjYWxsaW5nIERGRzo6Q29tbW9uRGF0 YTo6c2hyaW5rVG9GaXQsIGJ1dCBjYWxsaW5nIHRoaXMgdG9vIGVhcmx5OiB3ZSBleGVjdXRlCisg ICAgICAgIERGRzo6UGxhbjo6cmVhbGx5QWRkKERGRzo6Q29tbW9uRGF0YSopIGFmdGVyIHRoYXQs IGFuZCB0aGlzIGFkZHMgbWFueSBlbnRyaWVzIHRvCisgICAgICAgIERGRzo6Q29tbW9uRGF0YSou IFdlIHNob3VsZCBjYWxsIERGRzo6Q29tbW9uRGF0YTo6c2hyaW5rVG9GaXQgYWZ0ZXIgY2FsbGlu ZyBERkc6OlBsYW46OnJlYWxseUFkZC4KKworICAgICAgICBUbyBpbXBsZW1lbnQgaXQsIHdlIG1h a2UgREZHOjpKSVRDb2RlOjpzaHJpbmtUb0ZpdCB2aXJ0dWFsIGZ1bmN0aW9uIGluIEpTQzo6SklU Q29kZS4gVGhlbiwgd2UKKyAgICAgICAgY2FuIGFsc28gaW1wbGVtZW50IEZUTDo6SklUQ29kZTo6 c2hyaW5rVG9GaXQgd2hpY2ggd2FzIHByZXZpb3VzbHkgbm90IGltcGxlbWVudGVkLgorCisgICAg ICAgICogZGZnL0RGR0pJVENvZGUuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvZGU6OnNo cmlua1RvRml0KToKKyAgICAgICAgKiBkZmcvREZHSklUQ29kZS5oOgorICAgICAgICAqIGRmZy9E RkdKSVRDb21waWxlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6SklUQ29tcGlsZXI6OmNvbXBp bGUpOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjpjb21waWxlRnVuY3Rpb24pOgor ICAgICAgICAqIGRmZy9ERkdQbGFuLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpQbGFuOjpmaW5h bGl6ZVdpdGhvdXROb3RpZnlpbmdDYWxsYmFjayk6CisgICAgICAgICogZnRsL0ZUTEpJVENvZGUu Y3BwOgorICAgICAgICAoSlNDOjpGVEw6OkpJVENvZGU6OnNocmlua1RvRml0KToKKyAgICAgICAg KiBmdGwvRlRMSklUQ29kZS5oOgorICAgICAgICAqIGppdC9KSVRDb2RlLmNwcDoKKyAgICAgICAg KEpTQzo6SklUQ29kZTo6c2hyaW5rVG9GaXQpOgorICAgICAgICAqIGppdC9KSVRDb2RlLmg6CisK IDIwMjAtMDEtMzEgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAg R2V0QnV0dGVyZmx5IHNob3VsZCBjaGVjayBpZiB0aGUgaW5wdXQgdmFsdWUgaXMgYW4gb2JqZWN0 IGluIHNhZmUgdG8gZXhlY3V0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdKSVRDb2RlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZS5j cHAKaW5kZXggMmRlOWYxYTE5OWNmYjUwZTc0MDJhOTVkN2ExZjU1NGJhN2QwNTFjMy4uMDYyOGE2 MjE0OWYwNTljNzI0ZmEzMDY1NDA4MWQ4YWRkYzYxMzMzZiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0pJVENvZGUuY3BwCkBAIC01OCw3ICs1OCw3IEBAIEpJVENvZGUqIEpJVENvZGU6 OmRmZygpCiAgICAgcmV0dXJuIHRoaXM7CiB9CiAKLXZvaWQgSklUQ29kZTo6c2hyaW5rVG9GaXQo KQordm9pZCBKSVRDb2RlOjpzaHJpbmtUb0ZpdChjb25zdCBDb25jdXJyZW50SlNMb2NrZXImKQog ewogICAgIGNvbW1vbi5zaHJpbmtUb0ZpdCgpOwogICAgIG9zckVudHJ5LnNocmlua1RvRml0KCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGUuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZS5oCmluZGV4IGEwMDAwMmI2ODIwYjQy MzlkNmYyZDNhYzIwYzZlZDkwM2FhOWY3MjguLmNkOTc0NjQ1NzE5OTFkM2Q1ZTEzZWJmODE2NzM4 MDkzM2Q5YjE4MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklU Q29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZS5oCkBAIC0x MTUsNyArMTE1LDcgQEAgY2xhc3MgSklUQ29kZSA6IHB1YmxpYyBEaXJlY3RKSVRDb2RlIHsKICAg ICAKICAgICB2b2lkIHZhbGlkYXRlUmVmZXJlbmNlcyhjb25zdCBUcmFja2VkUmVmZXJlbmNlcyYp IG92ZXJyaWRlOwogICAgIAotICAgIHZvaWQgc2hyaW5rVG9GaXQoKTsKKyAgICB2b2lkIHNocmlu a1RvRml0KGNvbnN0IENvbmN1cnJlbnRKU0xvY2tlciYpIG92ZXJyaWRlOwogCiAgICAgUmVnaXN0 ZXJTZXQgbGl2ZVJlZ2lzdGVyc1RvUHJlc2VydmVBdEV4Y2VwdGlvbkhhbmRsaW5nQ2FsbFNpdGUo Q29kZUJsb2NrKiwgQ2FsbFNpdGVJbmRleCkgb3ZlcnJpZGU7CiAjaWYgRU5BQkxFKEZUTF9KSVQp CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCmluZGV4IDRm NjFjYzFhOTNiNjEyNzA1ZGM5MGIxYTM2M2JkZTk4MTQ5MWY0ZGEuLmI1N2ZlZDliODY4MTRiMjM1 MDMzNGVlMTY4YWUxMDhiOGY0NDViZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHSklUQ29tcGlsZXIuY3BwCkBAIC0zOTIsNyArMzkyLDYgQEAgdm9pZCBKSVRDb21waWxlcjo6 Y29tcGlsZSgpCiAgICAgbGluaygqbGlua0J1ZmZlcik7CiAgICAgbV9zcGVjdWxhdGl2ZS0+bGlu a09TUkVudHJpZXMoKmxpbmtCdWZmZXIpOwogCi0gICAgbV9qaXRDb2RlLT5zaHJpbmtUb0ZpdCgp OwogICAgIGNvZGVCbG9jaygpLT5zaHJpbmtUb0ZpdChDb2RlQmxvY2s6OkxhdGVTaHJpbmspOwog CiAgICAgZGlzYXNzZW1ibGUoKmxpbmtCdWZmZXIpOwpAQCAtNDk0LDcgKzQ5Myw2IEBAIHZvaWQg SklUQ29tcGlsZXI6OmNvbXBpbGVGdW5jdGlvbigpCiAgICAgbGluaygqbGlua0J1ZmZlcik7CiAg ICAgbV9zcGVjdWxhdGl2ZS0+bGlua09TUkVudHJpZXMoKmxpbmtCdWZmZXIpOwogICAgIAotICAg IG1faml0Q29kZS0+c2hyaW5rVG9GaXQoKTsKICAgICBjb2RlQmxvY2soKS0+c2hyaW5rVG9GaXQo Q29kZUJsb2NrOjpMYXRlU2hyaW5rKTsKIAogICAgIGlmIChyZXF1aXJlc0FyaXR5Rml4dXApCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAppbmRleCA3YjViYWVjOGRkOTg5OGM0MWU5 ZWI1OTIyYWQyNjA1ZDc5NWRmMTVlLi45MzM0MmRhZWZkOGFiNGEzOTAyMzZlYTJkMTBlMGY1OTAz ZWI5N2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5jcHAKQEAgLTYxNCw2ICs2 MTQsMTAgQEAgQ29tcGlsYXRpb25SZXN1bHQgUGxhbjo6ZmluYWxpemVXaXRob3V0Tm90aWZ5aW5n Q2FsbGJhY2soKQogICAgICAgICB9CiAKICAgICAgICAgcmVhbGx5QWRkKG1fY29kZUJsb2NrLT5q aXRDb2RlKCktPmRmZ0NvbW1vbigpKTsKKyAgICAgICAgeworICAgICAgICAgICAgQ29uY3VycmVu dEpTTG9ja2VyIGxvY2tlcihtX2NvZGVCbG9jay0+bV9sb2NrKTsKKyAgICAgICAgICAgIG1fY29k ZUJsb2NrLT5qaXRDb2RlKCktPnNocmlua1RvRml0KGxvY2tlcik7CisgICAgICAgIH0KIAogICAg ICAgICBpZiAodmFsaWRhdGlvbkVuYWJsZWQoKSkgewogICAgICAgICAgICAgVHJhY2tlZFJlZmVy ZW5jZXMgdHJhY2tlZFJlZmVyZW5jZXM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTEpJVENvZGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExKSVRD b2RlLmNwcAppbmRleCBmYTQ3YmUzZjA3ZTVmNTFhNTA0ZDM1ZmI2ZmU5NzZlMTY4ZmY3MDkyLi5m OGI2ZjU1MmM4ODczNTg1M2VlMjY4OWE5OTVmZjZmNDQyMjg3NGIzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEpJVENvZGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9mdGwvRlRMSklUQ29kZS5jcHAKQEAgLTEzMSw2ICsxMzEsMTQgQEAgREZHOjpDb21t b25EYXRhKiBKSVRDb2RlOjpkZmdDb21tb24oKQogICAgIHJldHVybiAmY29tbW9uOwogfQogCit2 b2lkIEpJVENvZGU6OnNocmlua1RvRml0KGNvbnN0IENvbmN1cnJlbnRKU0xvY2tlciYpCit7Cisg ICAgY29tbW9uLnNocmlua1RvRml0KCk7CisgICAgb3NyRXhpdC5zaHJpbmtUb0ZpdCgpOworICAg IG9zckV4aXREZXNjcmlwdG9ycy5zaHJpbmtUb0ZpdCgpOworICAgIGxhenlTbG93UGF0aHMuc2hy aW5rVG9GaXQoKTsKK30KKwogdm9pZCBKSVRDb2RlOjp2YWxpZGF0ZVJlZmVyZW5jZXMoY29uc3Qg VHJhY2tlZFJlZmVyZW5jZXMmIHRyYWNrZWRSZWZlcmVuY2VzKQogewogICAgIGNvbW1vbi52YWxp ZGF0ZVJlZmVyZW5jZXModHJhY2tlZFJlZmVyZW5jZXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExKSVRDb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTEpJVENvZGUuaAppbmRleCAwMTgwODM5YmQ4ZDk2MzAyMGUxYjU2OWFhMTJiMGRlYTkyZjVm OWY3Li4wMGJhYTJjYjg3MjgxMzIwODA4ZGFmMzQ0YjBjZjA2NmJhMjNhMjViIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEpJVENvZGUuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZnRsL0ZUTEpJVENvZGUuaApAQCAtNjcsNiArNjcsNyBAQCBjbGFzcyBKSVRD b2RlIDogcHVibGljIEpTQzo6SklUQ29kZSB7CiAgICAgSklUQ29kZSogZnRsKCkgb3ZlcnJpZGU7 CiAgICAgREZHOjpDb21tb25EYXRhKiBkZmdDb21tb24oKSBvdmVycmlkZTsKICAgICBzdGF0aWMg cHRyZGlmZl90IGNvbW1vbkRhdGFPZmZzZXQoKSB7IHJldHVybiBPQkpFQ1RfT0ZGU0VUT0YoSklU Q29kZSwgY29tbW9uKTsgfQorICAgIHZvaWQgc2hyaW5rVG9GaXQoY29uc3QgQ29uY3VycmVudEpT TG9ja2VyJikgb3ZlcnJpZGU7CiAgICAgCiAgICAgREZHOjpDb21tb25EYXRhIGNvbW1vbjsKICAg ICBTZWdtZW50ZWRWZWN0b3I8T1NSRXhpdCwgOD4gb3NyRXhpdDsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29kZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0pJVENvZGUuY3BwCmluZGV4IGUzZTBlNjljZmY2NWRhNTVhMzM2Yjc3MjExN2FmYTk4MDU0 Yzc4MDYuLmE4NTAwNzMyYTk3Y2UwMjU2NDUxMDZkY2ZmMmU2Nzc3NjIyYzljMmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29kZS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9KSVRDb2RlLmNwcApAQCAtOTMsNiArOTMsMTAgQEAgRlRMOjpGb3JP U1JFbnRyeUpJVENvZGUqIEpJVENvZGU6OmZ0bEZvck9TUkVudHJ5KCkKICAgICByZXR1cm4gMDsK IH0KIAordm9pZCBKSVRDb2RlOjpzaHJpbmtUb0ZpdChjb25zdCBDb25jdXJyZW50SlNMb2NrZXIm KQoreworfQorCiBKSVRDb2RlV2l0aENvZGVSZWY6OkpJVENvZGVXaXRoQ29kZVJlZihKSVRUeXBl IGppdFR5cGUpCiAgICAgOiBKSVRDb2RlKGppdFR5cGUpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUQ29kZS5oCmluZGV4IDRkZDAwZWVmYWIwNjA4MDUwMjk4ZDJjZjlhNjY5MmU4OGQ3MzZmYmMu LjAzMThmYjBkYmFjZWFiYWFmMTZkOTJhMGMxMzlhMTkwNDBhMWIxZWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQ29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUQ29kZS5oCkBAIC0xOTIsNiArMTkyLDcgQEAgY2xhc3MgSklUQ29kZSA6IHB1 YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxKSVRDb2RlPiB7CiAgICAgdmlydHVhbCBERkc6OkpJ VENvZGUqIGRmZygpOwogICAgIHZpcnR1YWwgRlRMOjpKSVRDb2RlKiBmdGwoKTsKICAgICB2aXJ0 dWFsIEZUTDo6Rm9yT1NSRW50cnlKSVRDb2RlKiBmdGxGb3JPU1JFbnRyeSgpOworICAgIHZpcnR1 YWwgdm9pZCBzaHJpbmtUb0ZpdChjb25zdCBDb25jdXJyZW50SlNMb2NrZXImKTsKICAgICAKICAg ICB2aXJ0dWFsIHZvaWQgdmFsaWRhdGVSZWZlcmVuY2VzKGNvbnN0IFRyYWNrZWRSZWZlcmVuY2Vz Jik7CiAgICAgCg==