207052 2020-01-31 09:38:01 -0800 REGRESSION (r251511): [iOS] HDR Playback broken 2020-01-31 10:08:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham eric.carlson jer.noble mjs pvollan webkit-bug-importer oldest_to_newest 1613423 0 bfulgham 2020-01-31 09:38:01 -0800 I missed an XPC service in Bug 203318 when I stopped importing the 'common.sb' sandbox so that we could use tighter rules. This broke some aspects of HDR playback for certain clients. I also noticed a preference file that is needed by AVF code, so I'm unblocking that as well. 1613424 1 bfulgham 2020-01-31 09:38:34 -0800 <rdar://problem/58975614> 1613429 2 389365 bfulgham 2020-01-31 09:45:52 -0800 Created attachment 389365 Patch 1613437 3 389365 mjs 2020-01-31 09:51:32 -0800 Comment on attachment 389365 Patch r=me 1613443 4 bfulgham 2020-01-31 09:54:31 -0800 Committed r255503: <https://trac.webkit.org/changeset/255503> 1613458 5 389365 pvollan 2020-01-31 10:08:27 -0800 Comment on attachment 389365 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389365&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:146 > + (global-name "com.apple.coremedia.cpe.xpc") ; Needed for HDR playback. It does not seem like this service is part of common.sb. Maybe it is sufficient with the preference changes to fix this bug? 389365 2020-01-31 09:45:52 -0800 2020-01-31 09:51:32 -0800 Patch bug-207052-20200131094552.patch text/plain 3900 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFiNjUxODYyYWU2MzM0MjRm NDc4NmJlZmQxNmE0YTViNmFhNWQ0MWYuLjBhMmFhNzk0NjI2ZWZiNDRlNTk3NmFjNjgwZmJmMGRl Mjc1YTY3ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDEtMzEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1MTUx MSk6IFtpT1NdIEhEUiBQbGF5YmFjayBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzA1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg5 NzU2MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SSBtaXNzZWQgYW4gWFBDIHNlcnZpY2UgaW4gQnVnIDIwMzMxOCB3aGVuIEkgc3RvcHBlZCBpbXBv cnRpbmcgdGhlICdjb21tb24uc2InIHNhbmRib3guIFRoaXMgYnJva2Ugc29tZQorICAgICAgICBh c3BlY3RzIG9mIEhEUiBwbGF5YmFjayBmb3IgY2VydGFpbiBjbGllbnRzLgorCisgICAgICAgIFRo aXMgcGF0Y2ggcmV0dXJucyB0aGUgWFBDIHNlcnZpY2UsIGFuZCB1bmJsb2NrcyBhY2Nlc3MgdG8g YSBuZXR3b3JrIHByZWZlcmVuY2UgZmlsZSB0aGF0IEFWRm91bmRhdGlvbgorICAgICAgICBuZWVk cyB0byByZWFkIHRvIHN1cHBvcnQgc29tZSBtZWRpYSBwbGF5YmFjayBmZWF0dXJlcy4KKworICAg ICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BV LnNiOgorICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuV2ViQ29udGVudC5zYjoKKwogMjAyMC0wMS0zMSAgQWxlamFuZHJvIEcuIENhc3RybyAg PGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBDb21waWxhdGlvbiBicm9rZW4gd2l0aG91dCBz ZXJ2aWNlIHdvcmtlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRi b3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5HUFUuc2IgYi9Tb3VyY2UvV2ViS2l0L1Jl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiCmluZGV4 IDRlZjNjMGFlZmJmZjhhMmM2YThiOWE2YzJjZWM3YWQ2NzNhMjgxZDMuLjQzZDFkODZhNzRkZmE0 M2JiMDE5NjhjMzNiNTMwMmE0ZjU1OWNiMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUmVz b3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5HUFUuc2IKKysrIGIv U291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2Vi S2l0LkdQVS5zYgpAQCAtMTQzLDYgKzE0Myw3IEBACiAgICAgICAgICAgIChnbG9iYWwtbmFtZSAi Y29tLmFwcGxlLmNvcmVtZWRpYS5hdWRpb3Byb2Nlc3Npbmd0YXAueHBjIikKICAgICAgICAgICAg KGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlhLmNhcHR1cmVzZXNzaW9uIikgICAgICA7 IEFjdHVhbGx5IGZvciB2aWRlbyBjYXB0dXJlCiAgICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLmNvcmVtZWRpYS5jYXB0dXJlc291cmNlIikgICAgICAgOyBBbHNvIGZvciB2aWRlbyBj YXB0dXJlICg8cmRhcjovL3Byb2JsZW0vMTU3OTQyOTE+KS4KKyAgICAgICAgICAgKGdsb2JhbC1u YW1lICJjb20uYXBwbGUuY29yZW1lZGlhLmNwZS54cGMiKSA7IE5lZWRlZCBmb3IgSERSIHBsYXli YWNrLgogICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuY3VzdG9t dXJsbG9hZGVyLnhwYyIpIDsgTmVlZGVkIGZvciBjdXN0b20gbWVkaWEgbG9hZGluZwogICAgICAg ICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuZm9ybWF0cmVhZGVyLnhwYyIp CiAgICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5wbGF5ZXIueHBj IikKQEAgLTE3NCw2ICsxNzUsMTAgQEAKICAgICAgICAgImNvbS5hcHBsZS5hdWRpby52aXJ0dWFs YXVkaW8iIDsgPHJkYXI6Ly9wcm9ibGVtLzU3MTcwMzMzPgogICAgICkKIAorICAgIDs7IEFWRiBu ZWVkcyB0byBzZWUgdGhlc2UgbmV0d29yayBwcmVmZXJlbmNlczoKKyAgICAoYWxsb3cgZmlsZS1y ZWFkKgorICAgICAgICAobGl0ZXJhbCAiL3ByaXZhdGUvdmFyL3ByZWZlcmVuY2VzL2NvbS5hcHBs ZS5uZXR3b3JrZC5wbGlzdCIpKQorCiAgICAgOzsgUmVxdWlyZWQgYnkgdGhlIE1lZGlhUGxheWVy IGZyYW1ld29yay4KICAgICAoYWxsb3cgbWFjaC1sb29rdXAKICAgICAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUuYXVkaW8uQXVkaW9TZXNzaW9uIikpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29u dGVudC5zYiBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29t LmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCmluZGV4IGNkNWQzMmE4ODdlMDI1ZWQ0ZWY2MTg5 OTc0Y2M4NjE3YmMwZjYyM2YuLmE1Njk4YzRiYjI2MTE2MWE4YmMzMWFmMDM0NDc1MDdjOTg1Mjdm MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVz b3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNi CkBAIC0xNTcsNiArMTU3LDcgQEAKICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUu Y29yZW1lZGlhLmF1ZGlvcHJvY2Vzc2luZ3RhcC54cGMiKQogICAgICAgICAgICAoZ2xvYmFsLW5h bWUgImNvbS5hcHBsZS5jb3JlbWVkaWEuY2FwdHVyZXNlc3Npb24iKSAgICAgIDsgQWN0dWFsbHkg Zm9yIHZpZGVvIGNhcHR1cmUKICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29y ZW1lZGlhLmNhcHR1cmVzb3VyY2UiKSAgICAgICA7IEFsc28gZm9yIHZpZGVvIGNhcHR1cmUgKDxy ZGFyOi8vcHJvYmxlbS8xNTc5NDI5MT4pLgorICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5h cHBsZS5jb3JlbWVkaWEuY3BlLnhwYyIpIDsgTmVlZGVkIGZvciBIRFIgcGxheWJhY2suCiAgICAg ICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5jdXN0b211cmxsb2FkZXIu eHBjIikgOyBOZWVkZWQgZm9yIGN1c3RvbSBtZWRpYSBsb2FkaW5nCiAgICAgICAgICAgIChnbG9i YWwtbmFtZSAiY29tLmFwcGxlLmNvcmVtZWRpYS5mb3JtYXRyZWFkZXIueHBjIikKICAgICAgICAg ICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29yZW1lZGlhLnBsYXllci54cGMiKQpAQCAtMTg4 LDYgKzE4OSwxMCBAQAogICAgICAgICAiY29tLmFwcGxlLmF1ZGlvLnZpcnR1YWxhdWRpbyIgOyA8 cmRhcjovL3Byb2JsZW0vNTcxNzAzMzM+CiAgICAgKQogCisgICAgOzsgQVZGIG5lZWRzIHRvIHNl ZSB0aGVzZSBuZXR3b3JrIHByZWZlcmVuY2VzOgorICAgIChhbGxvdyBmaWxlLXJlYWQqCisgICAg ICAgIChsaXRlcmFsICIvcHJpdmF0ZS92YXIvcHJlZmVyZW5jZXMvY29tLmFwcGxlLm5ldHdvcmtk LnBsaXN0IikpCisKICAgICA7OyBSZXF1aXJlZCBieSB0aGUgTWVkaWFQbGF5ZXIgZnJhbWV3b3Jr LgogICAgIChhbGxvdyBtYWNoLWxvb2t1cAogICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBs ZS5hdWRpby5BdWRpb1Nlc3Npb24iKSkK