207044 2020-01-31 07:19:08 -0800 [Web Animations] [WK1] REGRESSION: opacity doesn't animate 2020-01-31 09:58:29 -0800 1 1 1 Unclassified WebKit Animations Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207054 InRadar P2 Normal --- 1 graouts graouts dino simon.fraser webkit-bug-importer oldest_to_newest 1613347 0 graouts 2020-01-31 07:19:08 -0800 We fail to animate opacity in WK1 because we make the assumption that just because an animation targets only accelerated properties it will be accelerated and won't need to be updated as it runs in WebAnimation::timeToNextTick(). This is incorrect, an animation may fail to start or may fail to get a composited layer, the latter being the case on WK1 because usesCompositing() is false in RenderLayerCompositor::requiresCompositingForAnimation(). 1613348 1 webkit-bug-importer 2020-01-31 07:19:19 -0800 <rdar://problem/59061225> 1613378 2 389353 graouts 2020-01-31 08:38:15 -0800 Created attachment 389353 Patch 1613399 3 389353 simon.fraser 2020-01-31 09:20:02 -0800 Comment on attachment 389353 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389353&action=review > Source/WebCore/animation/WebAnimation.cpp:1448 > + if (!isCompletelyAccelerated() || !isRunningAccelerated()) This would be clearers as hasAnyNonAcceleratedProperties or something, I think. > LayoutTests/webanimations/opacity-animation.html:15 > + setTimeout(() => testRunner.notifyDone(), 100); 100ms is a really long test. Would setting the current time and pausing test the same way? Why didn't requestAnimationFrame work? 1613442 4 graouts 2020-01-31 09:54:23 -0800 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 389353 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389353&action=review > > > Source/WebCore/animation/WebAnimation.cpp:1448 > > + if (!isCompletelyAccelerated() || !isRunningAccelerated()) > > This would be clearers as hasAnyNonAcceleratedProperties or something, I > think. I'll switch the code around to have a condition that starts with `if (isCompletelyAccelerated() && isRunningAccelerated())` instead. This covers the case of animations that don't need to be updated while running. > > LayoutTests/webanimations/opacity-animation.html:15 > > + setTimeout(() => testRunner.notifyDone(), 100); > > 100ms is a really long test. Would setting the current time and pausing test > the same way? Alas, no, because at that point it would no longer be running an accelerated animation, which is precisely what we're trying to test. > Why didn't requestAnimationFrame work? Alas, I'm not sure. I'll try to improve this in bug 207054. 1613445 5 graouts 2020-01-31 09:58:29 -0800 Committed r255504: <https://trac.webkit.org/changeset/255504> 389353 2020-01-31 08:38:15 -0800 2020-01-31 09:20:02 -0800 Patch bug-207044-20200131173814.patch text/plain 4477 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDc5MDczOWM3YjMzNDcy OTIzY2RlYTUyYWM5MzdmMzhjODJhMTIxMS4uNzBmOGVkMWMxOGYxNWM0ZDliMjk5OWYyZWJjYzE2 NmNlNDM0NmVkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAxLTMxICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBbV0sxXSBSRUdSRVNTSU9OOiBvcGFjaXR5IGRvZXNuJ3QgYW5pbWF0ZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MDQ0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81OTA2MTIyNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0OiB3ZWJhbmltYXRpb25zL29wYWNpdHktYW5pbWF0aW9uLmh0bWwK KworICAgICAgICBXZSBmYWlsZWQgdG8gYW5pbWF0ZSBvcGFjaXR5IGluIFdLMSBiZWNhdXNlIHdl IG1hZGUgdGhlIGFzc3VtcHRpb24gdGhhdCBqdXN0IGJlY2F1c2UgYW4gYW5pbWF0aW9uIHRhcmdl dHMgb25seSBhY2NlbGVyYXRlZCBwcm9wZXJ0aWVzIGl0IHdvdWxkIGJlIGFjY2VsZXJhdGVkCisg ICAgICAgIGFuZCB3b3VsZG4ndCBuZWVkIHRvIGJlIHVwZGF0ZWQgYXMgaXQgcnVucyBpbiBXZWJB bmltYXRpb246OnRpbWVUb05leHRUaWNrKCkuIFRoaXMgaXMgaW5jb3JyZWN0LCBhbiBhbmltYXRp b24gbWF5IGZhaWwgdG8gc3RhcnQgb3IgbWF5IGZhaWwgdG8gZ2V0IGEgY29tcG9zaXRlZAorICAg ICAgICBsYXllciwgdGhlIGxhdHRlciBiZWluZyB0aGUgY2FzZSBvbiBXSzEgYmVjYXVzZSB1c2Vz Q29tcG9zaXRpbmcoKSBpcyBmYWxzZSBpbiBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVz Q29tcG9zaXRpbmdGb3JBbmltYXRpb24oKS4KKworICAgICAgICBXZSBub3cgY2hlY2sgdGhhdCBh biBhbmltYXRpb24gaXMgYm90aCBvbmx5IGFuaW1hdGluZyBhY2NlbGVyYXRlZCBwcm9wZXJ0aWVz IGFuZCBydW5uaW5nIGFjY2VsZXJhdGVkIHRvIGRldGVybWluZSB0aGF0IGFuIGFuaW1hdGlvbiB3 b24ndCBuZWVkIHRvIGJlIHVwZGF0ZWQKKyAgICAgICAgdW50aWwgaXQgY29tcGxldGVzLgorCisg ICAgICAgICogYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX ZWJBbmltYXRpb246OnRpbWVUb05leHRUaWNrIGNvbnN0KToKKwogMjAyMC0wMS0zMSAgQW50dGkg S29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVncmVzc2lvbihyMjU1MzU5 KTogaW1wb3J0ZWQvbW96aWxsYS9zdmcvc3ZnLWludGVncmF0aW9uL2NsaXBQYXRoLWh0bWwtMDYu eGh0bWwgaXMgZmFpbGluZyBjb25zaXN0ZW50bHkgb24gd2luZG93cwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9h bmltYXRpb24vV2ViQW5pbWF0aW9uLmNwcAppbmRleCBiZjc3ZWRiM2JkNWQ5MWIzZWYwMzhlOTRi OTdlYTM1ZjIwNGM4MTllLi4yNWE2MGNhZThhOTQwMmQ3MGM0NDY0ZGNkODFhN2ZmYTEyODJkMTNm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2ViQW5pbWF0aW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2ViQW5pbWF0aW9uLmNwcApAQCAtMTQ0NSw3 ICsxNDQ1LDcgQEAgU2Vjb25kcyBXZWJBbmltYXRpb246OnRpbWVUb05leHRUaWNrKCkgY29uc3QK ICAgICAgICAgcmV0dXJuIChlZmZlY3QuZGVsYXkoKSAtIHRpbWluZy5sb2NhbFRpbWUudmFsdWUo KSkgLyBwbGF5YmFja1JhdGU7CiAgICAgY2FzZSBBbmltYXRpb25FZmZlY3RQaGFzZTo6QWN0aXZl OgogICAgICAgICAvLyBOb24tYWNjZWxlcmF0ZWQgYW5pbWF0aW9ucyBpbiB0aGUgImFjdGl2ZSIg cGhhc2Ugd2lsbCBuZWVkIHRvIHVwZGF0ZSB0aGVpciBhbmltYXRlZCB2YWx1ZSBhdCB0aGUgaW1t ZWRpYXRlIG5leHQgb3Bwb3J0dW5pdHkuCi0gICAgICAgIGlmICghaXNDb21wbGV0ZWx5QWNjZWxl cmF0ZWQoKSkKKyAgICAgICAgaWYgKCFpc0NvbXBsZXRlbHlBY2NlbGVyYXRlZCgpIHx8ICFpc1J1 bm5pbmdBY2NlbGVyYXRlZCgpKQogICAgICAgICAgICAgcmV0dXJuIDBfczsKICAgICAgICAgLy8g QWNjZWxlcmF0ZWQgQ1NTIEFuaW1hdGlvbnMgbmVlZCB0byB0cmlnZ2VyICJhbmltYXRpb25pdGVy YXRpb24iIGV2ZW50cywgaW4gdGhpcyBjYXNlIHdlIGNhbiB3YWl0IHVudGlsIHRoZSBuZXh0IGl0 ZXJhdGlvbi4KICAgICAgICAgaWYgKGlzQ1NTQW5pbWF0aW9uKCkpIHsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkN2I5M2M1 OGUxMThkNTg1Y2VhOWZmYjE0OThjYzY5ZGNhNjcwODQ4Li5jNzUxMDgxMzczMDUzMzgwNWI2NzBh Yjc2ZDNlOWYwNTVlZjkzZGQyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDEtMzEgIEFu dG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViIEFuaW1hdGlv bnNdIFtXSzFdIFJFR1JFU1NJT046IG9wYWNpdHkgZG9lc24ndCBhbmltYXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcwNDQKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU5MDYxMjI1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd2ViYW5pbWF0aW9ucy9vcGFjaXR5LWFuaW1hdGlvbi1leHBlY3Rl ZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiB3ZWJhbmltYXRpb25zL29wYWNpdHktYW5pbWF0aW9u Lmh0bWw6IEFkZGVkLgorCiAyMDIwLTAxLTMwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJFR1JFU1NJT046IFtNYWMgd2sxXSBpbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL21hdGhtbC9wcmVzZW50YXRpb24tbWFya3VwL3NjcmlwdHMvdW5kZXJvdmVy LXBhcmFtZXRlcnMtMy5odG1sIGlzIGEgZmxha2V5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3dlYmFuaW1hdGlvbnMvb3BhY2l0eS1hbmltYXRpb24tZXhwZWN0ZWQuaHRtbCBiL0xh eW91dFRlc3RzL3dlYmFuaW1hdGlvbnMvb3BhY2l0eS1hbmltYXRpb24tZXhwZWN0ZWQuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5jNzg4YWQzYzI2OTdmOWY4OGZhMDdmY2YyOGFjMGFlYThlMzVjMjRkCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvd2ViYW5pbWF0aW9ucy9vcGFjaXR5LWFuaW1hdGlv bi1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEgQEAKKzxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNv bHV0ZTsgdG9wOiAwOyBsZWZ0OiAwOyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IGJhY2tn cm91bmQtY29sb3I6IGJsYWNrOyBvcGFjaXR5OiAwLjU7Ij48L2Rpdj4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3dlYmFuaW1hdGlvbnMvb3BhY2l0eS1hbmltYXRpb24uaHRtbCBiL0xheW91dFRl c3RzL3dlYmFuaW1hdGlvbnMvb3BhY2l0eS1hbmltYXRpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYWNh MTgyNTE3MjI3M2JhMTk2NTQ0YTE5YWY5ZWYyNWIzNzRjMGQ5Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvd2ViYW5pbWF0aW9ucy9vcGFjaXR5LWFuaW1hdGlvbi5odG1sCkBAIC0wLDAg KzEsMTkgQEAKKzxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAwOyBsZWZ0OiAw OyB3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IGJhY2tncm91bmQtY29sb3I6IGJsYWNrOyI+ PC9kaXY+Cis8c2NyaXB0PgorCitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5l ci53YWl0VW50aWxEb25lKCk7CisKK2NvbnN0IGFuaW1hdGlvbiA9IGRvY3VtZW50LnF1ZXJ5U2Vs ZWN0b3IoImRpdiIpLmFuaW1hdGUoWworICAgIHsgb3BhY2l0eTogMCB9LAorICAgIHsgb3BhY2l0 eTogMC41LCBvZmZzZXQ6IDAuMDAxIH0sCisgICAgeyBvcGFjaXR5OiAwLjUgfQorXSwgMTAwMCk7 CisKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIGFuaW1hdGlvbi5yZWFkeS50aGVuKCgp ID0+IHsKKyAgICAgICAgc2V0VGltZW91dCgoKSA9PiB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKSwg MTAwKTsKKyAgICB9KTsKK30KKworPC9zY3JpcHQ+Cg==