207042 2020-01-31 07:11:52 -0800 [WK1] hiddenPageCSSAnimationSuspensionEnabled should be enabled by default for Cocoa platforms 2020-01-31 08:45:12 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207014 https://bugs.webkit.org/show_bug.cgi?id=112308 InRadar P2 Normal --- 1 graouts graouts cdumez koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1613344 0 graouts 2020-01-31 07:11:52 -0800 [WK1] hiddenPageCSSAnimationSuspensionEnabled should be enabled by default for Cocoa platforms 1613346 1 389346 graouts 2020-01-31 07:13:26 -0800 Created attachment 389346 Patch 1613351 2 graouts 2020-01-31 07:35:14 -0800 Committed r255494: <https://trac.webkit.org/changeset/255494> 1613352 3 webkit-bug-importer 2020-01-31 07:36:16 -0800 <rdar://problem/59061483> 1613370 4 389346 cdumez 2020-01-31 08:18:01 -0800 Comment on attachment 389346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389346&action=review > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. 1613371 5 cdumez 2020-01-31 08:18:47 -0800 (In reply to Chris Dumez from comment #4) > Comment on attachment 389346 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > > + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > > Could you point me to the place where this setting is actually being used? I > grep'd it and it looks like dead code to me. Nevermind, found it (bad case sensitivity check) 1613372 6 389346 cdumez 2020-01-31 08:22:16 -0800 Comment on attachment 389346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389346&action=review >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, >> >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > Nevermind, found it (bad case sensitivity check) However, this only does something if Page::setActivityState() gets called (so that Page::setIsVisibleInternal() gets called). I don't see Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am I missing something? 1613374 7 graouts 2020-01-31 08:34:22 -0800 (In reply to Chris Dumez from comment #6) > Comment on attachment 389346 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > >> > >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > > > Nevermind, found it (bad case sensitivity check) > > However, this only does something if Page::setActivityState() gets called > (so that Page::setIsVisibleInternal() gets called). I don't see > Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am > I missing something? It's called via Page::setIsVisible(). 1613379 8 cdumez 2020-01-31 08:38:16 -0800 (In reply to Antoine Quint from comment #7) > (In reply to Chris Dumez from comment #6) > > Comment on attachment 389346 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > > > >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > > >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > > >> > > >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > > > > > Nevermind, found it (bad case sensitivity check) > > > > However, this only does something if Page::setActivityState() gets called > > (so that Page::setIsVisibleInternal() gets called). I don't see > > Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am > > I missing something? > > It's called via Page::setIsVisible(). Oh, I missed that. Thanks! 1613383 9 graouts 2020-01-31 08:45:12 -0800 (In reply to Chris Dumez from comment #8) > (In reply to Antoine Quint from comment #7) > > (In reply to Chris Dumez from comment #6) > > > Comment on attachment 389346 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > > > > > >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > > > >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > > > >> > > > >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > > > > > > > Nevermind, found it (bad case sensitivity check) > > > > > > However, this only does something if Page::setActivityState() gets called > > > (so that Page::setIsVisibleInternal() gets called). I don't see > > > Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am > > > I missing something? > > > > It's called via Page::setIsVisible(). > > Oh, I missed that. Thanks! Easy when you've been staring at stack traces all day :) 389346 2020-01-31 07:13:26 -0800 2020-01-31 07:16:40 -0800 Patch bug-207042-20200131161324.patch text/plain 2120 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggZDI3NzcwMDg5YzM2OTg2Y2M2NmYxMWRmMGRkZjIyYjQyZDc3OTI1Yi4uMGQ5MzcyMDk4Mzcy NGZjOWU2MjQ2ODM4Mzg5M2U0NTgyNWNmNTM4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTMxICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0Bh cHBsZS5jb20+CisKKyAgICAgICAgW1dLMV0gaGlkZGVuUGFnZUNTU0FuaW1hdGlvblN1c3BlbnNp b25FbmFibGVkIHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQgZm9yIENvY29hIHBsYXRmb3Jt cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MDQy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpbGUg SGlkZGVuUGFnZUNTU0FuaW1hdGlvblN1c3BlbnNpb25FbmFibGVkIGlzIHNwZWNpZmllZCBpbiBX ZWJQcmVmZXJlbmNlcy55YW1sIHRvIGRlZmF1bHQgdG8gREVGQVVMVF9ISURERU5fUEFHRV9DU1Nf QU5JTUFUSU9OX1NVU1BFTlNJT05fRU5BQkxFRCwKKyAgICAgICAgd2hpY2ggaXMgZGVmaW5lZCB0 byBiZSB0cnVlIG9uIENvY29hIHBsYXRmb3JtcyBpbiBXZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1 ZXMuaCwgaXQgaXMgaGFyZC1jb2RlZCB0byBATk8gaW4gV0sxIGFsdGhvdWdoIGNsZWFybHkgdGhl IGludGVudCBpcyBmb3IKKyAgICAgICAgdGhpcyBwcmVmZXJlbmNlIHRvIGJlIGVuYWJsZWQuIFNv IHdlIHN3aXRjaCB0aGF0IGRlZmF1bHQgdmFsdWUgaW4gV0sxIGFzIHdlbGwuCisKKyAgICAgICAg KiBXZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tOgorICAgICAgICAoK1tXZWJQcmVmZXJlbmNlcyBp bml0aWFsaXplXSk6CisKIDIwMjAtMDEtMzAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgV0tOYXZpZ2F0aW9uRGVsZWdhdGUgU1BJIHRv IGRpc2FibGUgVExTIDEuMCBhbmQgMS4xCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv V2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbQppbmRleCBiNGEwMTRiN2NkZWI2NDUzYTM5YWZjMzQ2 ZGNhNDY1ZjNjZWUxNjE4Li40ZjllNzU1M2Y1ZTI3ZTJkOGY3MGJmNWU4N2M3NDhjMDJjMDVlMWM4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlByZWZlcmVu Y2VzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5j ZXMubW0KQEAgLTU5Miw3ICs1OTIsNyBAQCArICh2b2lkKWluaXRpYWxpemUKICAgICAgICAgW05T TnVtYmVyIG51bWJlcldpdGhMb25nTG9uZzpBcHBsaWNhdGlvbkNhY2hlU3RvcmFnZTo6bm9RdW90 YSgpXSwgV2ViS2l0QXBwbGljYXRpb25DYWNoZVRvdGFsUXVvdGEsCiAgICAgICAgIFtOU051bWJl ciBudW1iZXJXaXRoTG9uZ0xvbmc6QXBwbGljYXRpb25DYWNoZVN0b3JhZ2U6Om5vUXVvdGEoKV0s IFdlYktpdEFwcGxpY2F0aW9uQ2FjaGVEZWZhdWx0T3JpZ2luUXVvdGEsCiAgICAgICAgIEBOTywg V2ViS2l0SGlkZGVuUGFnZURPTVRpbWVyVGhyb3R0bGluZ0VuYWJsZWRQcmVmZXJlbmNlS2V5LAot ICAgICAgICBATk8sIFdlYktpdEhpZGRlblBhZ2VDU1NBbmltYXRpb25TdXNwZW5zaW9uRW5hYmxl ZFByZWZlcmVuY2VLZXksCisgICAgICAgIEBZRVMsIFdlYktpdEhpZGRlblBhZ2VDU1NBbmltYXRp b25TdXNwZW5zaW9uRW5hYmxlZFByZWZlcmVuY2VLZXksCiAgICAgICAgIEBZRVMsIFdlYktpdFJl bmRlcmluZ1VwZGF0ZVRocm90dGxpbmdFbmFibGVkUHJlZmVyZW5jZUtleSwKICAgICAgICAgQE5P LCBXZWJLaXRMb3dQb3dlclZpZGVvQXVkaW9CdWZmZXJTaXplRW5hYmxlZFByZWZlcmVuY2VLZXks CiAgICAgICAgIAo=