<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>207037</bug_id>
          
          <creation_ts>2020-01-31 03:36:26 -0800</creation_ts>
          <short_desc>Compilation broken without service workers</short_desc>
          <delta_ts>2020-01-31 08:39:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alejandro G. Castro">alex</reporter>
          <assigned_to name="Alejandro G. Castro">alex</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1613326</commentid>
    <comment_count>0</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2020-01-31 03:36:26 -0800</bug_when>
    <thetext>The commit added some code that depends on variables defined inside SERVICE_WORKER. Not sure if there is something else in the patch we should protect even if it compiles just avoiding the m_swServers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613327</commentid>
    <comment_count>1</comment_count>
      <attachid>389340</attachid>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2020-01-31 03:39:43 -0800</bug_when>
    <thetext>Created attachment 389340
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613380</commentid>
    <comment_count>2</comment_count>
      <attachid>389340</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-31 08:38:34 -0800</bug_when>
    <thetext>Comment on attachment 389340
Patch

Clearing flags on attachment: 389340

Committed r255498: &lt;https://trac.webkit.org/changeset/255498&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613381</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-31 08:38:36 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613382</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-01-31 08:39:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/59062666&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>389340</attachid>
            <date>2020-01-31 03:39:43 -0800</date>
            <delta_ts>2020-01-31 08:38:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-207037-20200131123941.patch</filename>
            <type>text/plain</type>
            <size>1462</size>
            <attacher name="Alejandro G. Castro">alex</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAxZmIyYWQzYzQ0NTg5ZjNm
Nzg2ZDY1NTY4NGFhMTI1M2FmNDQ1NGIuLjRiMDI1YjllYmZjMzMwYTFkOTQ0YjU4NmM5MzFjNmEz
NGM0NDFlYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMzEgIEFsZWphbmRy
byBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgQ29tcGlsYXRpb24gYnJv
a2VuIHdpdGhvdXQgc2VydmljZSB3b3JrZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDcwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBQcm90ZWN0IHRoZSB1c2Ugb2YgbV9zd1NlcnZlcnMsIGNoZWNr
IGlmIHRoZSBTRVJWSUNFX1dPUktFUiBpcworICAgICAgICBlbmFibGVkLgorCisgICAgICAgICog
TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3
b3JrUHJvY2Vzczo6bG93TWVtb3J5SGFuZGxlcik6CisKIDIwMjAtMDEtMzEgIFphbiBEb2JlcnNl
ayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIFRvdWNoLWJhc2VkIHNj
cm9sbGluZyByb3VuZHRyaXBzIHRocm91Z2ggdGhlIFdlYlByb2Nlc3MKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwIGIvU291cmNlL1dl
YktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXggMzU2NjU1NTgyYmY4
MzlkZDE1MDYyYzFhYjU2MjdjZTFmM2NhNjRhMy4uMGFlMjkxNjgzYmI3NTA2YWNkMmE3M2M5N2U0
NzAyNmRjZTQ2ZWY5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9O
ZXR3b3JrUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3
b3JrUHJvY2Vzcy5jcHAKQEAgLTI5Niw4ICsyOTYsMTAgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6
bG93TWVtb3J5SGFuZGxlcihDcml0aWNhbCBjcml0aWNhbCkKICAgICAgICAgbmV0d29ya1Nlc3Np
b24uY2xlYXJQcmVmZXRjaENhY2hlKCk7CiAgICAgfSk7CiAKKyNpZiBFTkFCTEUoU0VSVklDRV9X
T1JLRVIpCiAgICAgZm9yIChhdXRvJiBzd1NlcnZlciA6IG1fc3dTZXJ2ZXJzLnZhbHVlcygpKQog
ICAgICAgICBzd1NlcnZlci0+aGFuZGxlTG93TWVtb3J5V2FybmluZygpOworI2VuZGlmCiB9CiAK
IHZvaWQgTmV0d29ya1Byb2Nlc3M6OmluaXRpYWxpemVOZXR3b3JrUHJvY2VzcyhOZXR3b3JrUHJv
Y2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYmIHBhcmFtZXRlcnMpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>