207017 2020-01-30 14:07:21 -0800 Can still get stuck after swipe backwards with a slow server, even after r254552 2020-01-30 14:31:51 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton cdumez oldest_to_newest 1613132 0 thorton 2020-01-30 14:07:21 -0800 Can still get stuck after swipe backwards with a slow server, even after r254552 1613133 1 389287 thorton 2020-01-30 14:07:31 -0800 Created attachment 389287 Patch 1613135 2 thorton 2020-01-30 14:08:52 -0800 <rdar://problem/59016256> 1613137 3 389287 cdumez 2020-01-30 14:10:08 -0800 Comment on attachment 389287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389287&action=review > Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:391 > +void ProvisionalPageProxy::navigationGestureDidEnd() Can we call this something like: unfreezeLayerTreeDueToSwipeAnimation() ? Given that you're only calling this when the m_isLayerTreeFrozenDueToSwipeAnimation flag is set on the WebPageProxy. 1613143 4 thorton 2020-01-30 14:28:45 -0800 Heh, that was the first name I had for it. Sure! 1613144 5 thorton 2020-01-30 14:31:51 -0800 https://trac.webkit.org/changeset/255458/webkit 389287 2020-01-30 14:07:31 -0800 2020-01-30 14:10:08 -0800 Patch bug-207017-20200130140731.patch text/plain 3426 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ2OGUwZGYyOTZkMWU5Yzkx Y2ZiODIwYmIyZmMxODg2NTExZjhlMjUuLjhiNzY3M2FhZTM4ZWRlM2IyMTEwNGYxMTQyYjk1ZDM5 MGUxYWM2NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDEtMzAgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FuIHN0aWxsIGdldCBz dHVjayBhZnRlciBzd2lwZSBiYWNrd2FyZHMgd2l0aCBhIHNsb3cgc2VydmVyLCBldmVuIGFmdGVy IHIyNTQ1NTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNzAxNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkwMTYyNTY+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvUHJvdmlzaW9u YWxQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpQcm92aXNpb25hbFBhZ2VQcm94eTo6 bmF2aWdhdGlvbkdlc3R1cmVEaWRFbmQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9Qcm92aXNpb25h bFBhZ2VQcm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAg ICAgICBUaGVyZSdzIGEgc2Vjb25kIGNhc2Ugd2hlcmUgeW91IGNhbiBnZXQgc3R1Y2sgd2l0aCB0 aGUgInN3aXBlIGdlc3R1cmUiCisgICAgICAgIGxheWVyIHRyZWUgZnJlZXplIHJlYXNvbiBpbiB0 aGUgd2ViIHByb2Nlc3M6IHdoZW4gZG9pbmcgYSBjcm9zcy1vcmlnaW4KKyAgICAgICAgbmF2aWdh dGlvbiB3aGVyZSB0aGUgbG9hZCB0YWtlcyBtb3JlIHRoYW4gMyBzZWNvbmRzICh0aGUgc3dpcGUK KyAgICAgICAgc25hcHNob3QgdGltZW91dCkgdG8gY29tbWl0LCB0aGUgcHJvdmlzaW9uYWwgcGFn ZSB3aWxsIGhhdmUgbWlycm9yZWQKKyAgICAgICAgdGhlIG9yaWdpbmFsIHBhZ2UncyBmcm96ZW4g c3RhdGUgdXBvbiBjcmVhdGlvbiwgYnV0IHdpbGwgbm90IGV2ZXIKKyAgICAgICAgcmVjZWl2ZSB0 aGUgdW5mcmVlemUsIGJlY2F1c2UgaXQgaXMgc2VudCB3aGlsZSBzdGlsbCBwcm92aXNpb25hbC4K KworICAgICAgICBUbyBmaXggdGhpcywganVzdCBmb3J3YXJkIHRoZSB1bmZyZWV6ZSBtZXNzYWdl IHRvIHRoZSBwcm92aXNpb25hbCBwYWdlLgorCiAyMDIwLTAxLTMwICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJlbW92ZSByZXBvcnQgcnVsZSBm b3IgJ2NvbS5hcHBsZS5ydW5uaW5nYm9hcmQnIGZyb20gdGhlIE5ldHdvcmsgYW5kIEdQVSBwcm9j ZXNzIHNhbmRib3hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvdmlz aW9uYWxQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvdmlzaW9uYWxQ YWdlUHJveHkuY3BwCmluZGV4IDg5MjIzZDg1ODNhMmIxZWE4ZTljOWMwMWUyNDM1MjUxYTUyMDg4 YjguLjkzMWQ2YTc1MTIwMDA4YjgxMTg1YTE0YmFhYzBiNjQ0Mzk0YjYzZTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Byb3Zpc2lvbmFsUGFnZVByb3h5LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94eS5jcHAKQEAgLTM4OCw2 ICszODgsMTEgQEAgdm9pZCBQcm92aXNpb25hbFBhZ2VQcm94eTo6ZGlkQ3JlYXRlQ29udGV4dEZv clZpc2liaWxpdHlQcm9wYWdhdGlvbihMYXllckhvc3RpbmcKIH0KICNlbmRpZgogCit2b2lkIFBy b3Zpc2lvbmFsUGFnZVByb3h5OjpuYXZpZ2F0aW9uR2VzdHVyZURpZEVuZCgpCit7CisgICAgc2Vu ZChNZXNzYWdlczo6V2ViUGFnZTo6VW5mcmVlemVMYXllclRyZWVEdWVUb1N3aXBlQW5pbWF0aW9u KCkpOworfQorCiB2b2lkIFByb3Zpc2lvbmFsUGFnZVByb3h5OjpkaWRSZWNlaXZlTWVzc2FnZShJ UEM6OkNvbm5lY3Rpb24mIGNvbm5lY3Rpb24sIElQQzo6RGVjb2RlciYgZGVjb2RlcikKIHsKICAg ICBBU1NFUlQoZGVjb2Rlci5tZXNzYWdlUmVjZWl2ZXJOYW1lKCkgPT0gTWVzc2FnZXM6OldlYlBh Z2VQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1Byb3Zpc2lvbmFsUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94eS5oCmluZGV4IGNjOTcwYzUwMTU2Yjk4ODQxODFlN2U4 ZTRlMjJkYzFhMTRiMjkzYWMuLjY2ZGI5NmYyMDVjYjUwNTgzZmYzNWM0YmZhYmYzOGE5NDZlNmVj YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Byb3Zpc2lvbmFsUGFnZVBy b3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvdmlzaW9uYWxQYWdlUHJveHku aApAQCAtOTYsNiArOTYsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBnb1RvQmFja0ZvcndhcmRJdGVt KEFQSTo6TmF2aWdhdGlvbiYsIFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0mLCBPcHRpb25hbDxXZWJz aXRlUG9saWNpZXNEYXRhPiYmKTsKICAgICB2b2lkIGNhbmNlbCgpOwogCisgICAgdm9pZCBuYXZp Z2F0aW9uR2VzdHVyZURpZEVuZCgpOworCiAgICAgdm9pZCBwcm9jZXNzRGlkVGVybWluYXRlKCk7 CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRl eCBhNWUzNmU0YzBiMzM3NmIzOTU1ZDY0MDQ0ZDcyMWMwMmJmMjY5MjM3Li5lZGUyZmNlNzRlYjE0 ZGJkNzVhYjVkNmUyNmQ1Njk3MjU0YmM3N2Y5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKQEAgLTg1NTgsNiArODU1OCw5IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpu YXZpZ2F0aW9uR2VzdHVyZURpZEVuZChib29sIHdpbGxOYXZpZ2F0ZSwgV2ViQmFja0ZvcndhcmRM aXN0CiAgICAgaWYgKG1faXNMYXllclRyZWVGcm96ZW5EdWVUb1N3aXBlQW5pbWF0aW9uKSB7CiAg ICAgICAgIG1faXNMYXllclRyZWVGcm96ZW5EdWVUb1N3aXBlQW5pbWF0aW9uID0gZmFsc2U7CiAg ICAgICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OlVuZnJlZXplTGF5ZXJUcmVlRHVlVG9Td2lw ZUFuaW1hdGlvbigpKTsKKworICAgICAgICBpZiAobV9wcm92aXNpb25hbFBhZ2UpCisgICAgICAg ICAgICBtX3Byb3Zpc2lvbmFsUGFnZS0+bmF2aWdhdGlvbkdlc3R1cmVEaWRFbmQoKTsKICAgICB9 CiB9CiAK