207016 2020-01-30 13:55:57 -0800 [GTK] http/tests/misc/form-submit-file-cross-site-redirect.html fails with incomplete form data 2020-02-14 13:28:16 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply clopez commit-queue webkit-bug-importer oldest_to_newest 1613127 0 lmoura 2020-01-30 13:55:57 -0800 With b206517 fixed, this test submits the test file metadata correctly (like the non-redirect version) but no payload is sent. --- /home/lauro/dev/WebKit/layout-test-results/http/tests/misc/form-submit-file-cross-site-redirect-expected.txt +++ /home/lauro/dev/WebKit/layout-test-results/http/tests/misc/form-submit-file-cross-site-redirect-actual.txt @@ -2,6 +2,6 @@ This tests verifies the test file included in the multipart form data: PASS: File is present PASS: File upload was successful -PASS: File size is greater than 0 +FAIL: File size is 0 Payload with `var_dump($_FILES['data']);` in the PHP script: ``` array(5) { ["name"]=> string(8) "test.tmp" ["type"]=> string(24) "application/octet-stream" ["tmp_name"]=> string(14) "/tmp/php0dQ3qM" ["error"]=> int(0) ["size"]=> int(0) } ``` Using the original test from Julio in b201950[1] with Minibrowser it seems to work normally. [1] https://redirection-experiment.herokuapp.com/ 1613988 1 clopez 2020-02-03 09:10:30 -0800 (In reply to Lauro Moura from comment #0) > With b206517 fixed tips: - instead of " b206517 " use format: " bug 206517 " so bugzilla makes automatic links - if the bug its related to GTK or WPE releated, always CC the virtual user bugs-noreply@webkitgtk.org 1619136 2 390796 lmoura 2020-02-14 12:29:51 -0800 Created attachment 390796 Patch 1619163 3 commit-queue 2020-02-14 13:26:57 -0800 The commit-queue encountered the following flaky tests while processing attachment 390796: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1619164 4 390796 commit-queue 2020-02-14 13:27:38 -0800 Comment on attachment 390796 Patch Clearing flags on attachment: 390796 Committed r256638: <https://trac.webkit.org/changeset/256638> 1619165 5 commit-queue 2020-02-14 13:27:39 -0800 All reviewed patches have been landed. Closing bug. 1619166 6 webkit-bug-importer 2020-02-14 13:28:16 -0800 <rdar://problem/59469874> 390796 2020-02-14 12:29:51 -0800 2020-02-14 13:27:38 -0800 Patch bug-207016-20200214172950.patch text/plain 1559 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2NjMzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmIyOWU2ZGYyZDNmMDBiMTllOGE4 NWEwZmJhOWJkMTBhMzUwMDYxMy4uZjVkNTNjNTAxYmEzYzYxODBlOWVlMzUzNTY2NGUyMDJjYWMy Y2ViNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAyLTE0ICBMYXVybyBNb3VyYSAgPGxt b3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGh0dHAvdGVzdHMvbWlzYy9mb3JtLXN1 Ym1pdC1maWxlLWNyb3NzLXNpdGUtcmVkaXJlY3QuaHRtbCBmYWlscyB3aXRoIGluY29tcGxldGUg Zm9ybSBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDcwMTYKKworICAgICAgICBBZnRlciBidWcyMDY1MTcgd2FzIGZpeGVkLCB0aGlzIHRlc3Qg aGFzIGJlZW4gcGFzc2luZyBpbiBhbGwgR1RLIGJvdHMuCisKKyAgICAgICAgVW5yZXZpZXdlZCB0 ZXN0IGdhcmRlbmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDIwLTAyLTE0ICBDaHJpc3RvcGhlciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNvbT4K IAogICAgICAgICBbV2luXSBJbXBsZW1lbnQgTmV0d29ya0NhY2hlOjpEYXRhIGJ5IHVzaW5nIEZp bGVTeXN0ZW06Ok1hcHBlZEZpbGVEYXRhCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGMzZGI5Njk3OWIxZjQ1ZjZmODRmNDFlZmExN2I5MzBhNTllODQzOTAu LmVhZTJjYWU1MDM0OTdjYmY4NWQwZGRjYmIyNWU4NTAyYThhZDQxZmUgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC00MjMwLDggKzQyMzAsNiBAQCB3ZWJr aXQub3JnL2IvOTkwMzYgcG9pbnRlci1sb2NrL3BvaW50ZXJsb2NrY2hhbmdlLXBvaW50ZXJsb2Nr ZXJyb3ItZXZlbnRzLmh0bWwgWwogCiB3ZWJraXQub3JnL2IvMjA2MjY0IGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1tdWx0aWNvbC9tdWx0aWNvbC1nYXAtcGVyY2VudGFn ZS0wMDEuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMjA3MDE2IGh0dHAvdGVzdHMv bWlzYy9mb3JtLXN1Ym1pdC1maWxlLWNyb3NzLXNpdGUtcmVkaXJlY3QuaHRtbCBbIEZhaWx1cmUg XQotCiB3ZWJraXQub3JnL2IvMjA2NjkyIGZhc3QvY2FudmFzL2NhbnZhcy1maWxsUGF0aC1zaGFk b3cuaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMjA2ODg1IGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mb250cy9nZW5lcmljLWZhbWlseS1rZXl3b3Jkcy0w MDEuaHRtbCBbIEZhaWx1cmUgXQo=