207015 2020-01-30 12:37:52 -0800 Silence compiler warnings 2020-02-03 06:07:03 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro aboxhall apinheiro cfleizach commit-queue darin dmazzoni ews-watchlist hi jcraig jdiggs joepeck mcatanzaro samuel_white webkit-bug-importer zan oldest_to_newest 1613089 0 mcatanzaro 2020-01-30 12:37:52 -0800 Silence compiler warnings 1613098 1 389279 mcatanzaro 2020-01-30 12:41:27 -0800 Created attachment 389279 Patch 1613785 2 389279 commit-queue 2020-02-01 19:57:14 -0800 Comment on attachment 389279 Patch Clearing flags on attachment: 389279 Committed r255548: <https://trac.webkit.org/changeset/255548> 1613786 3 commit-queue 2020-02-01 19:57:16 -0800 All reviewed patches have been landed. Closing bug. 1613787 4 webkit-bug-importer 2020-02-01 19:58:15 -0800 <rdar://problem/59091972> 1613915 5 zan 2020-02-03 06:07:03 -0800 *** Bug 207092 has been marked as a duplicate of this bug. *** 389279 2020-01-30 12:41:27 -0800 2020-02-01 19:57:14 -0800 Patch bug-207015-20200130144126.patch text/plain 5928 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY4OWI0MmU0MjVkNDg5 Y2Q3OGZhODA5Mzg4ZTdhZjQ2ZTRhOTRjMS4uZmZmNzdiZmRjOTU2ZTZjOTAxNTNjNzk1ZWQ2NzY4 MTkzYTRjMjMxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAxLTMwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFNpbGVuY2Ug Y29tcGlsZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNzAxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmNoYXJhY3RlckZvckNoYXJhY3Rlck9mZnNldCk6IFVzZSBJR05PUkVfQ0xBTkdfV0FS TklOR1MgbWFjcm9zIHRvIGF2b2lkCisgICAgICAgIHdhcm5pbmdzIHdoZW4gdXNpbmcgR0NDLiBH Q0MgZnJlYWtzIG91dCB3aGVuIGl0IGRvZXNuJ3QgcmVjb2duaXplIGEgd2FybmluZyBwYXNzZWQg dG8KKyAgICAgICAgSUdOT1JFX1dBUk5JTkdTX0JFR0lOKCkuCisgICAgICAgICogaW5zcGVjdG9y L0luc3BlY3RvckNhbnZhcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDYW52YXM6 OmJ1aWxkT2JqZWN0Rm9yQ2FudmFzKTogRml4IC1XcmVkdW5kYW50LW1vdmUKKyAgICAgICAgKiBw bGF0Zm9ybS9QYXN0ZWJvYXJkSXRlbUluZm8uaDogRml4IC1XcmVkdW5kYW50LW1vdmUKKyAgICAg ICAgKFdlYkNvcmU6OlByZXNlbnRhdGlvblNpemU6OmRlY29kZSk6CisgICAgICAgIChXZWJDb3Jl OjpQYXN0ZWJvYXJkSXRlbUluZm86OmRlY29kZSk6CisKIDIwMjAtMDEtMjkgIFBlbmcgTGl1ICA8 cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAgICBBbHdheXMgZW5hYmxlIHNvbWUgbG9nIG1l c3NhZ2VzIHJlbGF0ZWQgdG8gYXVkaW8gdHJhY2tzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlmZWMyZGQzYWM2MzIx NjM5NDY4YzliZTZjMmFhNGE3MzY3YTU2ZDkuLmU1MGI5ZWI2MDk2Y2ZjZDg3ZDk5ZTBkNzAyY2Nm OTY3ZWE2MGIwYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMzAgIE1pY2hh ZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgU2lsZW5jZSBj b21waWxlciB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA3MDE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVXNlIFVOVVNFRF9WQVJJQUJMRSgpIGZvciB2YXJpYWJsZSB0aGF0IGlzIG9ubHkg dXNlZCBpbnNpZGUgUkVMRUFTRV9MT0coKSwgd2hpY2ggaXMKKyAgICAgICAgQXBwbGUtc3BlY2lm aWMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZEZhaWxMb2FkaW5n KToKKwogMjAyMC0wMS0yOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gTW92ZSB1bnNldGVudiB0byBXZWJQcm9jZXNzTWFp bi5jcHAgYWZ0ZXIgcjI1NTM0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9BWE9iamVjdENhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhP YmplY3RDYWNoZS5jcHAKaW5kZXggMzdkZGRjNjEyNWY1YWMzZmIzN2YyOWRjZjBjYTExNDhlNjFm MWE0Ni4uMzI4YTVlYjI0MDI5OWEzMjllNjA4NDBkY2ViZDA0ODYwYjJiOGIxNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC0yNTE1LDEw ICsyNTE1LDEwIEBAIHN0YXRpYyBVQ2hhcjMyIGNoYXJhY3RlckZvckNoYXJhY3Rlck9mZnNldChj b25zdCBDaGFyYWN0ZXJPZmZzZXQmIGNoYXJhY3Rlck9mZnNlCiAgICAgVUNoYXIzMiBjaCA9IDA7 CiAgICAgdW5zaWduZWQgb2Zmc2V0ID0gY2hhcmFjdGVyT2Zmc2V0LnN0YXJ0SW5kZXggKyBjaGFy YWN0ZXJPZmZzZXQub2Zmc2V0OwogICAgIGlmIChvZmZzZXQgPCBjaGFyYWN0ZXJPZmZzZXQubm9k ZS0+dGV4dENvbnRlbnQoKS5sZW5ndGgoKSkgewotLy8gRklYTUU6IFJlbW92ZSBJR05PUkVfV0FS TklOR1MgbWFjcm9zIG9uY2Ugb25lIG9mIDxyZGFyOi8vcHJvYmxlbS81ODYxNTQ4OSY1ODYxNTM5 MT4gaXMgZml4ZWQuCi1JR05PUkVfV0FSTklOR1NfQkVHSU4oImNvbmRpdGlvbmFsLXVuaW5pdGlh bGl6ZWQiKQorLy8gRklYTUU6IFJlbW92ZSBJR05PUkVfQ0xBTkdfV0FSTklOR1MgbWFjcm9zIG9u Y2Ugb25lIG9mIDxyZGFyOi8vcHJvYmxlbS81ODYxNTQ4OSY1ODYxNTM5MT4gaXMgZml4ZWQuCitJ R05PUkVfQ0xBTkdfV0FSTklOR1NfQkVHSU4oImNvbmRpdGlvbmFsLXVuaW5pdGlhbGl6ZWQiKQog ICAgICAgICBVMTZfTkVYVChjaGFyYWN0ZXJPZmZzZXQubm9kZS0+dGV4dENvbnRlbnQoKSwgb2Zm c2V0LCBjaGFyYWN0ZXJPZmZzZXQubm9kZS0+dGV4dENvbnRlbnQoKS5sZW5ndGgoKSwgY2gpOwot SUdOT1JFX1dBUk5JTkdTX0VORAorSUdOT1JFX0NMQU5HX1dBUk5JTkdTX0VORAogICAgIH0KICAg ICByZXR1cm4gY2g7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yQ2FudmFzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDYW52 YXMuY3BwCmluZGV4IDlkYzE1OWZhOThlN2RmY2M2MmExYTk1MmQzNjI4YWE4YzAxNmE3ZjYuLmQ0 N2EyMjNiNWFhNDRiMWEyYzliNzkwYmQwZjA0NDYyYmMwMDI5ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDYW52YXMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDYW52YXMuY3BwCkBAIC00OTMsNyArNDkzLDcgQEAgUmVm PEluc3BlY3Rvcjo6UHJvdG9jb2w6OkNhbnZhczo6Q2FudmFzPiBJbnNwZWN0b3JDYW52YXM6OmJ1 aWxkT2JqZWN0Rm9yQ2FudmFzKGIKICAgICAgICAgICAgICAgICBhdXRvIGNvbnRleHRBdHRyaWJ1 dGVzUGF5bG9hZCA9IEluc3BlY3Rvcjo6UHJvdG9jb2w6OkNhbnZhczo6Q29udGV4dEF0dHJpYnV0 ZXM6OmNyZWF0ZSgpCiAgICAgICAgICAgICAgICAgICAgIC5yZWxlYXNlKCk7CiAgICAgICAgICAg ICAgICAgY29udGV4dEF0dHJpYnV0ZXNQYXlsb2FkLT5zZXRBbHBoYShkb3duY2FzdDxJbWFnZUJp dG1hcFJlbmRlcmluZ0NvbnRleHQ+KGNvbnRleHQpLmhhc0FscGhhKCkpOwotICAgICAgICAgICAg ICAgIHJldHVybiBXVEZNb3ZlKGNvbnRleHRBdHRyaWJ1dGVzUGF5bG9hZCk7CisgICAgICAgICAg ICAgICAgcmV0dXJuIGNvbnRleHRBdHRyaWJ1dGVzUGF5bG9hZDsKICAgICAgICAgICAgIH0KIAog I2lmIEVOQUJMRShXRUJHTCkKQEAgLTUxOSw3ICs1MTksNyBAQCBSZWY8SW5zcGVjdG9yOjpQcm90 b2NvbDo6Q2FudmFzOjpDYW52YXM+IEluc3BlY3RvckNhbnZhczo6YnVpbGRPYmplY3RGb3JDYW52 YXMoYgogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICAgICAgY29udGV4dEF0dHJpYnV0ZXNQYXlsb2FkLT5zZXRGYWls SWZNYWpvclBlcmZvcm1hbmNlQ2F2ZWF0KGF0dHJpYnV0ZXMtPmZhaWxJZk1ham9yUGVyZm9ybWFu Y2VDYXZlYXQpOwotICAgICAgICAgICAgICAgICAgICByZXR1cm4gV1RGTW92ZShjb250ZXh0QXR0 cmlidXRlc1BheWxvYWQpOworICAgICAgICAgICAgICAgICAgICByZXR1cm4gY29udGV4dEF0dHJp YnV0ZXNQYXlsb2FkOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICNlbmRpZgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUGFzdGVib2FyZEl0ZW1JbmZvLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QYXN0ZWJvYXJkSXRlbUluZm8uaAppbmRleCAwOWVl OGY5NzY4MjEzOTI3ZThmM2M1NThlM2M5MDY1YjVjYjQ2ZjM5Li5hZGNiN2IxNmYyZjI1OGNhZjBk ZGI1YjFkYmJiNzBjZTlmM2ZjOWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9QYXN0ZWJvYXJkSXRlbUluZm8uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QYXN0 ZWJvYXJkSXRlbUluZm8uaApAQCAtNjEsNyArNjEsNyBAQCBPcHRpb25hbDxQcmVzZW50YXRpb25T aXplPiBQcmVzZW50YXRpb25TaXplOjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlcikKICAgICBpZiAo IWRlY29kZXIuZGVjb2RlKHJlc3VsdC5oZWlnaHQpKQogICAgICAgICByZXR1cm4gV1RGOjpudWxs b3B0OwogCi0gICAgcmV0dXJuIFdURk1vdmUocmVzdWx0KTsKKyAgICByZXR1cm4gcmVzdWx0Owog fQogCiBzdHJ1Y3QgUGFzdGVib2FyZEl0ZW1JbmZvIHsKQEAgLTE2MSw3ICsxNjEsNyBAQCBPcHRp b25hbDxQYXN0ZWJvYXJkSXRlbUluZm8+IFBhc3RlYm9hcmRJdGVtSW5mbzo6ZGVjb2RlKERlY29k ZXImIGRlY29kZXIpCiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZUVudW0ocmVzdWx0LnByZWZlcnJl ZFByZXNlbnRhdGlvblN0eWxlKSkKICAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKIAotICAg IHJldHVybiBXVEZNb3ZlKHJlc3VsdCk7CisgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2Fk ZXIuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2Fk ZXIuY3BwCmluZGV4IDhiODU3YzAzOWNmNzgxNjk2NGYyZmU4NTZkNTk0MTUzMzA3ZTliY2IuLjU4 NmQ5MGRjMzg0MTQ5Nzg3ZWEyMzkyOThiN2FkMjBlODkwYWM4MDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKQEAg LTY1MCw2ICs2NTAsNyBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkRmFpbExvYWRp bmcoY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IpCiAgICAgd2FzU2VydmljZVdvcmtlckxvYWQg PSAhIW1fc2VydmljZVdvcmtlckZldGNoVGFzazsKICNlbmRpZgogICAgIFJFTEVBU0VfTE9HX0VS Uk9SX0lGX0FMTE9XRUQoImRpZEZhaWxMb2FkaW5nOiAod2FzU2VydmljZVdvcmtlckxvYWQ9JWQs IGlzVGltZW91dD0lZCwgaXNDYW5jZWxsYXRpb249JWQsIGlzQWNjZXNzQ29udHJvbD0lZCwgZXJy b3JDb2RlPSVkKSIsIHdhc1NlcnZpY2VXb3JrZXJMb2FkLCBlcnJvci5pc1RpbWVvdXQoKSwgZXJy b3IuaXNDYW5jZWxsYXRpb24oKSwgZXJyb3IuaXNBY2Nlc3NDb250cm9sKCksIGVycm9yLmVycm9y Q29kZSgpKTsKKyAgICBVTlVTRURfVkFSSUFCTEUod2FzU2VydmljZVdvcmtlckxvYWQpOwogCiAg ICAgaWYgKHNob3VsZENhcHR1cmVFeHRyYU5ldHdvcmtMb2FkTWV0cmljcygpKQogICAgICAgICBt X2Nvbm5lY3Rpb24tPnJlbW92ZU5ldHdvcmtMb2FkSW5mb3JtYXRpb24oaWRlbnRpZmllcigpKTsK