207014 2020-01-30 12:29:23 -0800 [Web Animations] DocumentTimeline shouldn't suspend itself if hiddenPageCSSAnimationSuspensionEnabled is disabled 2020-01-31 08:18:05 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207042 InRadar P2 Normal --- 1 graouts graouts dino jonlee koivisto webkit-bug-importer oldest_to_newest 1613084 0 graouts 2020-01-30 12:29:23 -0800 [Web Animations] DocumentTimeline shouldn't suspend itself 1613085 1 389276 graouts 2020-01-30 12:31:33 -0800 Created attachment 389276 Patch 1613086 2 graouts 2020-01-30 12:31:38 -0800 <rdar://problem/58815952> 1613140 3 389276 jonlee 2020-01-30 14:18:12 -0800 Comment on attachment 389276 Patch it didn't work 1613303 4 389335 graouts 2020-01-31 00:50:47 -0800 Created attachment 389335 Patch 1613309 5 graouts 2020-01-31 02:20:23 -0800 Committed r255489: <https://trac.webkit.org/changeset/255489> 1613310 6 389335 koivisto 2020-01-31 02:27:55 -0800 Comment on attachment 389335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389335&action=review > Source/WebCore/animation/DocumentTimeline.cpp:70 > + if (page->settings().hiddenPageCSSAnimationSuspensionEnabled() && !page->isVisible()) Wonder why we need hiddenPageCSSAnimationSuspensionEnabled flag at all? What is the case where we wouldn't want to suspend non-visible pages? 389276 2020-01-30 12:31:33 -0800 2020-01-31 00:50:44 -0800 Patch bug-207014-20200130213132.patch text/plain 1759 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRiODBmMTVkZjA2OGQ5 NjU1NDJjNjNhNjMxZDJiZGNlMmU1NDFkOS4uZTdhYzg1MzAyZjA0MjM4ZTMxMTA3MzFiYTcyZTIw ZGE4N2NkZWM5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTMwICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBEb2N1bWVudFRpbWVsaW5lIHNob3VsZG4ndCBzdXNwZW5kIGl0c2VsZgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MDE0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS81ODgxNTk1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQYWdlIGFuZCBEb2N1bWVudCBhbHJlYWR5IGhhdmUgY2FsbHMgdG8gc3Vz cGVuZCBhbmQgcmVzdW1lIHRoZSBEb2N1bWVudFRpbWVsaW5lIGFzIG5lZWRlZCwgc28gd2UgZG9u J3QgbmVlZCB0byByZWFkIHdoZXRoZXIgdGhlIHBhZ2UgaXMgdmlzaWJsZSB1cG9uIGNyZWF0aW9u CisgICAgICAgIHRvIGRlY2lkZSB3aGV0aGVyIGFuaW1hdGlvbnMgc2hvdWxkIGJlIHN1c3BlbmRl ZC4gQWxzbywgQ1NTQW5pbWF0aW9uQ29udHJvbGxlciBoYXMgbm8gc2ltaWxhciBjYWxsLCBhbmQg YWxsIGNhbGwgc2l0ZXMgdG8gdGhlIENTU0FuaW1hdGlvbkNvbnRyb2xsZXIgc3VzcGVuZAorICAg ICAgICBhbmQgcmVzdW1lIGNhbGxzIGFyZSBzZXQgZm9yIERvY3VtZW50VGltZWxpbmUgYXMgd2Vs bC4KKworICAgICAgICAqIGFuaW1hdGlvbi9Eb2N1bWVudFRpbWVsaW5lLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50VGltZWxpbmU6OkRvY3VtZW50VGltZWxpbmUpOgorCiAyMDIwLTAx LTI5ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHU3RyZWFtZXJdIEZpeCBidWlsZCB3aXRoIEFDQ0VMRVJBVEVEXzJEX0NBTlZBUyBlbmFibGVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5jcHAKaW5kZXgg YWFiZDRjMTVhODA2OTBiN2Y5MTk3NzI1M2MwZGViN2U2ZjUxM2M2NS4uMjZhNDNhODVlYmEzMjc3 M2ZhMzI0NDBmMGZjY2I1MDA4NDM1ZmFlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYW5p bWF0aW9uL0RvY3VtZW50VGltZWxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlv bi9Eb2N1bWVudFRpbWVsaW5lLmNwcApAQCAtNjUsOCArNjUsNiBAQCBEb2N1bWVudFRpbWVsaW5l OjpEb2N1bWVudFRpbWVsaW5lKERvY3VtZW50JiBkb2N1bWVudCwgU2Vjb25kcyBvcmlnaW5UaW1l KQogewogICAgIGlmIChtX2RvY3VtZW50KQogICAgICAgICBtX2RvY3VtZW50LT5hZGRUaW1lbGlu ZSgqdGhpcyk7Ci0gICAgaWYgKG1fZG9jdW1lbnQgJiYgbV9kb2N1bWVudC0+cGFnZSgpICYmICFt X2RvY3VtZW50LT5wYWdlKCktPmlzVmlzaWJsZSgpKQotICAgICAgICBzdXNwZW5kQW5pbWF0aW9u cygpOwogfQogCiBEb2N1bWVudFRpbWVsaW5lOjp+RG9jdW1lbnRUaW1lbGluZSgpCg== 389335 2020-01-31 00:50:47 -0800 2020-01-31 02:12:59 -0800 Patch bug-207014-20200131095045.patch text/plain 2860 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRiODBmMTVkZjA2OGQ5 NjU1NDJjNjNhNjMxZDJiZGNlMmU1NDFkOS4uYzg0YWI2ZjcyMmVhNGQ4ODllYjZmNzVkMjJiZGJj NjNiMDVhMjNmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTAxLTMwICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBEb2N1bWVudFRpbWVsaW5lIHNob3VsZG4ndCBzdXNwZW5kIGl0c2VsZiBpZiBoaWRkZW5QYWdl Q1NTQW5pbWF0aW9uU3VzcGVuc2lvbkVuYWJsZWQgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNzAxNAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTg4MTU5NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2Ugc3VzcGVuZCBhIHRpbWVsaW5lIHVwb24gY29uc3V0cmN0aW9uIGlmIHdl IGtub3cgdGhhdCB0aGUgcGFnZSBpcyBub3QgdmlzaWJsZSBiZWNhdXNlLCB1bmxpa2UgQ1NTQW5p bWF0aW9uQ29udHJvbGxlciwgdGhlIERvY3VtZW50VGltZWxpbmUgaXMgbm90IGd1YXJhbnRlZWQK KyAgICAgICAgdG8gYmUgY3JlYXRlZCBieSB0aGUgdGltZSB0aGUgUGFnZSBzZXRzIHRoZSBpbml0 aWFsIHZpc2liaWxpdHkgc3RhdGUuIFRoaXMgaXMgYmVjYXVzZSBEb2N1bWVudFRpbWVsaW5lIGlz IGNyZWF0ZWQgYXMgbmVlZGVkIHdoZW4gdGhlcmUgYXJlIENTUyBBbmltYXRpb25zIG9yIENTUwor ICAgICAgICBUcmFuc2l0aW9ucyBjcmVhdGVkIGZvciB0aGUgcGFnZSwgb3IgaWYgdGhlIGNvbnRl bnQgdXNlcyBhbnkgb2YgdGhlIFdlYiBBbmltYXRpb25zIEFQSXMuCisKKyAgICAgICAgSG93ZXZl ciwgdGhlIFBhZ2U6OnNldElzVmlzaWJsZUludGVybmFsKCkgZnVuY3Rpb24gdGhhdCB3b3VsZCBj YWxsIERvY3VtZW50VGltZWxpbmU6OnJlc3VtZUFuaW1hdGlvbnMoKSBhdCBhIGxhdGVyIHRpbWUg Y2hlY2tzIHdoZXRoZXIgdGhlIGhpZGRlblBhZ2VDU1NBbmltYXRpb25TdXNwZW5zaW9uRW5hYmxl ZAorICAgICAgICBzZXR0aW5nIGlzIGVuYWJsZWQuIFNvIHdlIG11c3QgcmVzcGVjdCB0aGF0IHNl dHRpbmcgYWxzbyB3aGVuIHN1c3BlbmRpbmcgYW5pbWF0aW9ucyBpbiB0aGUgZmlyc3QgcGxhY2Ug b3Igd2UgcmlzayBlbmRpbmcgdXAgaW4gYSBzdGF0ZSB3aGVyZSB3ZSBzdXNwZW5kIGFuaW1hdGlv bnMKKyAgICAgICAgYmVjYXVzZSB0aGUgcGFnZSBpcyBub3QgdmlzaWJsZSB1cG9uIHRpbWVsaW5l IGNyZWF0aW9uLCBidXQgbmV2ZXIgcmVzdW1pbmcgYW5pbWF0aW9ucyBsYXRlciBkdWUgdG8gdGhl IGhpZGRlblBhZ2VDU1NBbmltYXRpb25TdXNwZW5zaW9uRW5hYmxlZCBzZXR0aW5nIGJlaW5nIGZh bHNlLgorCisgICAgICAgICogYW5pbWF0aW9uL0RvY3VtZW50VGltZWxpbmUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RG9jdW1lbnRUaW1lbGluZTo6RG9jdW1lbnRUaW1lbGluZSk6CisKIDIwMjAt MDEtMjkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dTdHJlYW1lcl0gRml4IGJ1aWxkIHdpdGggQUNDRUxFUkFURURfMkRfQ0FOVkFTIGVuYWJs ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1bWVudFRpbWVsaW5l LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1bWVudFRpbWVsaW5lLmNwcAppbmRl eCBhYWJkNGMxNWE4MDY5MGI3ZjkxOTc3MjUzYzBkZWI3ZTZmNTEzYzY1Li5iYmIzYjQwNGMxZDJh OTQ3ZmVkMjEzNzVjOGQ1YjNlY2I4NTMzODNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h bmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0 aW9uL0RvY3VtZW50VGltZWxpbmUuY3BwCkBAIC00Myw2ICs0Myw3IEBACiAjaW5jbHVkZSAiUmVu ZGVyRWxlbWVudC5oIgogI2luY2x1ZGUgIlJlbmRlckxheWVyLmgiCiAjaW5jbHVkZSAiUmVuZGVy TGF5ZXJCYWNraW5nLmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlIDxKYXZhU2Ny aXB0Q29yZS9WTS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC02MywxMCArNjQsMTMgQEAg RG9jdW1lbnRUaW1lbGluZTo6RG9jdW1lbnRUaW1lbGluZShEb2N1bWVudCYgZG9jdW1lbnQsIFNl Y29uZHMgb3JpZ2luVGltZSkKICAgICAsIG1fZG9jdW1lbnQoJmRvY3VtZW50KQogICAgICwgbV9v cmlnaW5UaW1lKG9yaWdpblRpbWUpCiB7Ci0gICAgaWYgKG1fZG9jdW1lbnQpCisgICAgaWYgKG1f ZG9jdW1lbnQpIHsKICAgICAgICAgbV9kb2N1bWVudC0+YWRkVGltZWxpbmUoKnRoaXMpOwotICAg IGlmIChtX2RvY3VtZW50ICYmIG1fZG9jdW1lbnQtPnBhZ2UoKSAmJiAhbV9kb2N1bWVudC0+cGFn ZSgpLT5pc1Zpc2libGUoKSkKLSAgICAgICAgc3VzcGVuZEFuaW1hdGlvbnMoKTsKKyAgICAgICAg aWYgKGF1dG8qIHBhZ2UgPSBtX2RvY3VtZW50LT5wYWdlKCkpIHsKKyAgICAgICAgICAgIGlmIChw YWdlLT5zZXR0aW5ncygpLmhpZGRlblBhZ2VDU1NBbmltYXRpb25TdXNwZW5zaW9uRW5hYmxlZCgp ICYmICFwYWdlLT5pc1Zpc2libGUoKSkKKyAgICAgICAgICAgICAgICBzdXNwZW5kQW5pbWF0aW9u cygpOworICAgICAgICB9CisgICAgfQogfQogCiBEb2N1bWVudFRpbWVsaW5lOjp+RG9jdW1lbnRU aW1lbGluZSgpCg==