<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>206982</bug_id>
          
          <creation_ts>2020-01-29 19:48:56 -0800</creation_ts>
          <short_desc>REGRESSION(r254389): High Sierra build is broken</short_desc>
          <delta_ts>2020-02-01 10:18:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>206723</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          <cc>ap</cc>
    
    <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1612838</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2020-01-29 19:48:56 -0800</bug_when>
    <thetext>REGRESSION(r254389): High Sierra build is broken</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612839</commentid>
    <comment_count>1</comment_count>
      <attachid>389222</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2020-01-29 19:50:04 -0800</bug_when>
    <thetext>Created attachment 389222
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612840</commentid>
    <comment_count>2</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2020-01-29 19:50:07 -0800</bug_when>
    <thetext>&lt;rdar://problem/59005412&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612842</commentid>
    <comment_count>3</comment_count>
      <attachid>389223</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2020-01-29 20:06:53 -0800</bug_when>
    <thetext>Created attachment 389223
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612856</commentid>
    <comment_count>4</comment_count>
      <attachid>389223</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-01-29 21:02:28 -0800</bug_when>
    <thetext>Comment on attachment 389223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389223&amp;action=review

r- for changing Mojave code path. Please also see my comment in Radar.

&gt; Source/WTF/wtf/PlatformHave.h:578
&gt; +#if (PLATFORM(MAC) &amp;&amp; __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101500) || PLATFORM(IOS_FAMILY)

High Sierra is 10.13
Mojave is 10.14
Catalina is 10.15</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613018</commentid>
    <comment_count>5</comment_count>
      <attachid>389263</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-01-30 10:08:15 -0800</bug_when>
    <thetext>Created attachment 389263
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613020</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-01-30 10:19:22 -0800</bug_when>
    <thetext>I didn&apos;t verify whether this fix was sufficient. It is unusual that it&apos;s enough to ifdef out includes, but no actual implementation code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613029</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-01-30 10:32:18 -0800</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #6)
&gt; I didn&apos;t verify whether this fix was sufficient. It is unusual that it&apos;s
&gt; enough to ifdef out includes, but no actual implementation code.

I think we are fine because the following gets declared after the #endif:
@interface NSLocale ()
+ (nonnull NSArray&lt;NSString *&gt; *)minimizedLanguagesFromLanguages:(nonnull NSArray&lt;NSString *&gt; *)languages;
@end</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613031</commentid>
    <comment_count>8</comment_count>
      <attachid>389263</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-01-30 10:33:53 -0800</bug_when>
    <thetext>Comment on attachment 389263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389263&amp;action=review

&gt; Source/WTF/wtf/spi/cocoa/NSLocaleSPI.h:30
&gt; +#if HAVE(NSLOCALE_INTERNATIONALSUPPORTEXTENSIONS)

I guess we could have used __has_include(&lt;InternationalSupport/NSLocale+InternationalSupportExtensions.h&gt;) too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613062</commentid>
    <comment_count>9</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2020-01-30 11:30:43 -0800</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #4)
&gt; Comment on attachment 389223 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=389223&amp;action=review
&gt; 
&gt; r- for changing Mojave code path. Please also see my comment in Radar.
&gt; 
&gt; &gt; Source/WTF/wtf/PlatformHave.h:578
&gt; &gt; +#if (PLATFORM(MAC) &amp;&amp; __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101500) || PLATFORM(IOS_FAMILY)
&gt; 
&gt; High Sierra is 10.13
&gt; Mojave is 10.14
&gt; Catalina is 10.15

This doesn&apos;t change the Mojave code path. The relevant code is already hidden behind a respondsToSelector: check. The selector only exists in Catalina. Therefore, previous OSes don&apos;t need the #include at all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613097</commentid>
    <comment_count>10</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-01-30 12:41:11 -0800</bug_when>
    <thetext>(In reply to Myles C. Maxfield from comment #9)
&gt; (In reply to Alexey Proskuryakov from comment #4)
&gt; &gt; Comment on attachment 389223 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=389223&amp;action=review
&gt; &gt; 
&gt; &gt; r- for changing Mojave code path. Please also see my comment in Radar.
&gt; &gt; 
&gt; &gt; &gt; Source/WTF/wtf/PlatformHave.h:578
&gt; &gt; &gt; +#if (PLATFORM(MAC) &amp;&amp; __MAC_OS_X_VERSION_MIN_REQUIRED &gt;= 101500) || PLATFORM(IOS_FAMILY)
&gt; &gt; 
&gt; &gt; High Sierra is 10.13
&gt; &gt; Mojave is 10.14
&gt; &gt; Catalina is 10.15
&gt; 
&gt; This doesn&apos;t change the Mojave code path. The relevant code is already
&gt; hidden behind a respondsToSelector: check. 

As mentioned on your other bug, I cannot find minimizedLanguagesFromLanguages: in my very recent macOS SDK in the &lt;InternationalSupport/NSLocale+InternationalSupportExtensions.h&gt; header. Is this expected?
I only have it in my iOS SDK.

&gt; The selector only exists in
&gt; Catalina. Therefore, previous OSes don&apos;t need the #include at all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1613743</commentid>
    <comment_count>11</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-02-01 10:18:03 -0800</bug_when>
    <thetext>After more investigation, we determined that a better fix for this was already landed. 

It does look like the code is wrong for macOS, but it builds now.

*** This bug has been marked as a duplicate of bug 206723 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>389222</attachid>
            <date>2020-01-29 19:50:04 -0800</date>
            <delta_ts>2020-01-29 20:06:51 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206982-20200129205003.patch</filename>
            <type>text/plain</type>
            <size>4029</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDI4MmYxNWE0NWJkODJkOTA0MzgzOTQx
MTUxN2VhMTNlNDJiMzhmMWYuLjcyYTRmMDRjZGU1YWU0YTRjNjNlNTk0OWE4YmY1YzNhZDE5ZDRm
OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMjkgIE15bGVzIEMuIE1heGZpZWxkICA8
bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBIaWdo
IFNpZXJyYSBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIwNjk4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkwMDU0MTI+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGhl
YWRlciBkb2Vzbid0IGV4aXN0IG9uIG9sZCBPU2VzLgorCisgICAgICAgICogd3RmL1BsYXRmb3Jt
SGF2ZS5oOgorICAgICAgICAqIHd0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaDoKKwogMjAyMC0w
MS0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg
ICAgW0dUS10gU2hvdWxkIHVzZSBsaWdodCB0aGVtZSB1bmxlc3Mgd2Vic2l0ZSBkZWNsYXJlcyBz
dXBwb3J0IGZvciBkYXJrIHRoZW1lcyBpbiBjb2xvci1zY2hlbWVzIHByb3BlcnR5CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm
b3JtSGF2ZS5oCmluZGV4IGQxMzc3MmFjM2IzNmRlMDAyZTgwZTAxZTE0OGM4YmNhODgyMDMxN2Yu
LjZhOTYzM2ZkYzBhM2YzNjFjZTgxZDQ2NDRiZTdmN2NhNGJhOTQwY2QgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt
SGF2ZS5oCkBAIC01NzQsMyArNTc0LDcgQEAKICNpZiBQTEFURk9STShDT0NPQSkgJiYgIShQTEFU
Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE0MDApICYm
ICFQTEFURk9STShXQVRDSE9TKSAmJiAhUExBVEZPUk0oQVBQTEVUVikKICNkZWZpbmUgSEFWRV9D
R19QQVRIX1VORVZFTl9DT1JORVJTX1JPVU5ERURSRUNUIDEKICNlbmRpZgorCisjaWYgKFBMQVRG
T1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8
IFBMQVRGT1JNKElPU19GQU1JTFkpCisjZGVmaW5lIEhBVkVfTlNMT0NBTEVfSU5URVJOQVRJT05B
TFNVUFBPUlRFWFRFTlNJT05TIDEKKyNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv
c3BpL2NvY29hL05TTG9jYWxlU1BJLmggYi9Tb3VyY2UvV1RGL3d0Zi9zcGkvY29jb2EvTlNMb2Nh
bGVTUEkuaAppbmRleCA1Y2VmMTY0MDMxNmI0NzNhNzFiZTdiYmE2MWE4ODI3NGYyODEwNjIxLi5h
YmFlMjRmYTdiZjNkNjk5NDMyNTgzYmZiMjAxZjE3MWE2ZDY5ZjI2IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV1RGL3d0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9z
cGkvY29jb2EvTlNMb2NhbGVTUEkuaApAQCAtMjcsNyArMjcsOSBAQAogCiAjaWYgVVNFKEFQUExF
X0lOVEVSTkFMX1NESykKIAorI2lmIEhBVkUoTlNMT0NBTEVfSU5URVJOQVRJT05BTFNVUFBPUlRF
WFRFTlNJT05TKQogI2ltcG9ydCA8SW50ZXJuYXRpb25hbFN1cHBvcnQvTlNMb2NhbGUrSW50ZXJu
YXRpb25hbFN1cHBvcnRFeHRlbnNpb25zLmg+CisjZW5kaWYKIAogI2VuZGlmCiAKZGlmZiAtLWdp
dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZGZjODQxZmRmMjhh
NTMyNmI5NzkyOTMzOWYxNGE2NTA1MGMyMTk2Li45ZTE5NmZmZTU5N2Y4OWNkMjQ5MGE5ODhiYzc5
YmQwMTZjNjczNDcxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDEtMjkgIE15bGVzIEMuIE1heGZpZWxkICA8
bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBIaWdo
IFNpZXJyYSBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIwNjk4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkwMDU0MTI+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp
cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX29zX3Zl
cnNpb25fY2hlY2tzKToKKwogMjAyMC0wMS0yOSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBh
cHBsZS5jb20+CiAKICAgICAgICAgcnVuLXNhZmFyaSAvIHJ1bi13ZWJraXQtdGVzdHMgLS1pb3Mt
c2ltdWxhdG9yIG5vdCB3b3JraW5nIHdpdGggWENvZGUgMTMuMy4xICgxMUM1MDQpCmRpZmYgLS1n
aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xz
L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IGMzOGZjNzFkOWFj
ZmJmY2UyMTExMmIwNDRmYjQ2ZTQxMTA5MjhlMDEuLjcwMGUyOGNhODI3ZDcwNTc0MTNlOWViY2Q1
OTY4Y2MzYjRkZDAzNGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv
Y2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl
cnMvY3BwLnB5CkBAIC0xMTc4LDExICsxMTc4LDExIEBAIGRlZiBjaGVja19vc192ZXJzaW9uX2No
ZWNrcyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAg
ICAgICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL3ZlcnNpb25fY2hlY2snLCA1LCAnSW5jb3Jy
ZWN0IE9TIHZlcnNpb24gY2hlY2suIFZFUlNJT05fTUlOX1JFUVVJUkVEIHZhbHVlcyBuZXZlciBp
bmNsdWRlIGEgbWlub3IgdmVyc2lvbi4gWW91IG1heSBiZSBsb29raW5nIGZvciBhIGNvbWJpbmF0
aW9uIG9mIFZFUlNJT05fTUlOX1JFUVVJUkVEIGZvciB0YXJnZXQgT1MgdmVyc2lvbiBjaGVjayBh
bmQgVkVSU0lPTl9NQVhfQUxMT1dFRCBmb3IgU0RLIGNoZWNrLicpCiAgICAgICAgICAgICBicmVh
awogCi0gICAgaWYgZmlsZW5hbWUgPT0gJ1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgnIG9yIGZp
bGVuYW1lID09ICdTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oJzoKKyAgICBpZiBmaWxl
bmFtZSA9PSAnU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCcgb3IgZmlsZW5hbWUgPT0gJ1NvdXJj
ZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgnIG9yIGZpbGVuYW1lID09ICdTb3VyY2UvV1RGL3d0
Zi9QbGF0Zm9ybUhhdmUuaCc6CiAgICAgICAgIHJldHVybgogCiAgICAgaWYgX1JFX1BBVFRFUk5f
WENPREVfVkVSU0lPTl9NQUNSTy5tYXRjaChsaW5lKToKLSAgICAgICAgZXJyb3IobGluZV9udW1i
ZXIsICdidWlsZC92ZXJzaW9uX2NoZWNrJywgNSwgJ01pc3BsYWNlZCBPUyB2ZXJzaW9uIGNoZWNr
LiBQbGVhc2UgdXNlIGEgbmFtZWQgbWFjcm8gaW4gd3RmL1BsYXRmb3JtLmgsIHd0Zi9GZWF0dXJl
RGVmaW5lcy5oLCBvciBhbiBhcHByb3ByaWF0ZSBpbnRlcm5hbCBmaWxlLicpCisgICAgICAgIGVy
cm9yKGxpbmVfbnVtYmVyLCAnYnVpbGQvdmVyc2lvbl9jaGVjaycsIDUsICdNaXNwbGFjZWQgT1Mg
dmVyc2lvbiBjaGVjay4gUGxlYXNlIHVzZSBhIG5hbWVkIG1hY3JvIGluIHd0Zi9QbGF0Zm9ybS5o
LCB3dGYvRmVhdHVyZURlZmluZXMuaCwgd3RmL1BsYXRmb3JtSGF2ZS5oLCBvciBhbiBhcHByb3By
aWF0ZSBpbnRlcm5hbCBmaWxlLicpCiAKIGNsYXNzIF9DbGFzc0luZm8ob2JqZWN0KToKICAgICAi
IiJTdG9yZXMgaW5mb3JtYXRpb24gYWJvdXQgYSBjbGFzcy4iIiIK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>389223</attachid>
            <date>2020-01-29 20:06:53 -0800</date>
            <delta_ts>2020-01-30 10:08:14 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206982-20200129210652.patch</filename>
            <type>text/plain</type>
            <size>1872</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDI4MmYxNWE0NWJkODJkOTA0MzgzOTQx
MTUxN2VhMTNlNDJiMzhmMWYuLjcyYTRmMDRjZGU1YWU0YTRjNjNlNTk0OWE4YmY1YzNhZDE5ZDRm
OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMjkgIE15bGVzIEMuIE1heGZpZWxkICA8
bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBIaWdo
IFNpZXJyYSBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIwNjk4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkwMDU0MTI+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGhl
YWRlciBkb2Vzbid0IGV4aXN0IG9uIG9sZCBPU2VzLgorCisgICAgICAgICogd3RmL1BsYXRmb3Jt
SGF2ZS5oOgorICAgICAgICAqIHd0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaDoKKwogMjAyMC0w
MS0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg
ICAgW0dUS10gU2hvdWxkIHVzZSBsaWdodCB0aGVtZSB1bmxlc3Mgd2Vic2l0ZSBkZWNsYXJlcyBz
dXBwb3J0IGZvciBkYXJrIHRoZW1lcyBpbiBjb2xvci1zY2hlbWVzIHByb3BlcnR5CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm
b3JtSGF2ZS5oCmluZGV4IGQxMzc3MmFjM2IzNmRlMDAyZTgwZTAxZTE0OGM4YmNhODgyMDMxN2Yu
LjZhOTYzM2ZkYzBhM2YzNjFjZTgxZDQ2NDRiZTdmN2NhNGJhOTQwY2QgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt
SGF2ZS5oCkBAIC01NzQsMyArNTc0LDcgQEAKICNpZiBQTEFURk9STShDT0NPQSkgJiYgIShQTEFU
Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE0MDApICYm
ICFQTEFURk9STShXQVRDSE9TKSAmJiAhUExBVEZPUk0oQVBQTEVUVikKICNkZWZpbmUgSEFWRV9D
R19QQVRIX1VORVZFTl9DT1JORVJTX1JPVU5ERURSRUNUIDEKICNlbmRpZgorCisjaWYgKFBMQVRG
T1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8
IFBMQVRGT1JNKElPU19GQU1JTFkpCisjZGVmaW5lIEhBVkVfTlNMT0NBTEVfSU5URVJOQVRJT05B
TFNVUFBPUlRFWFRFTlNJT05TIDEKKyNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv
c3BpL2NvY29hL05TTG9jYWxlU1BJLmggYi9Tb3VyY2UvV1RGL3d0Zi9zcGkvY29jb2EvTlNMb2Nh
bGVTUEkuaAppbmRleCA1Y2VmMTY0MDMxNmI0NzNhNzFiZTdiYmE2MWE4ODI3NGYyODEwNjIxLi5h
YmFlMjRmYTdiZjNkNjk5NDMyNTgzYmZiMjAxZjE3MWE2ZDY5ZjI2IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV1RGL3d0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9z
cGkvY29jb2EvTlNMb2NhbGVTUEkuaApAQCAtMjcsNyArMjcsOSBAQAogCiAjaWYgVVNFKEFQUExF
X0lOVEVSTkFMX1NESykKIAorI2lmIEhBVkUoTlNMT0NBTEVfSU5URVJOQVRJT05BTFNVUFBPUlRF
WFRFTlNJT05TKQogI2ltcG9ydCA8SW50ZXJuYXRpb25hbFN1cHBvcnQvTlNMb2NhbGUrSW50ZXJu
YXRpb25hbFN1cHBvcnRFeHRlbnNpb25zLmg+CisjZW5kaWYKIAogI2VuZGlmCiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>389263</attachid>
            <date>2020-01-30 10:08:15 -0800</date>
            <delta_ts>2020-01-30 10:15:18 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206982-20200130100814.patch</filename>
            <type>text/plain</type>
            <size>1872</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDI4MmYxNWE0NWJkODJkOTA0MzgzOTQx
MTUxN2VhMTNlNDJiMzhmMWYuLjUzZDYyYTBiY2IwMWU3YjljZTQwZjIwYTFiM2I0NDBjYTNlNzZi
OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMzAgIE15bGVzIEMuIE1heGZpZWxkICA8
bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBIaWdo
IFNpZXJyYSBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIwNjk4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkwMDU0MTI+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGhl
YWRlciBkb2Vzbid0IGV4aXN0IG9uIG9sZCBPU2VzLgorCisgICAgICAgICogd3RmL1BsYXRmb3Jt
SGF2ZS5oOgorICAgICAgICAqIHd0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaDoKKwogMjAyMC0w
MS0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg
ICAgW0dUS10gU2hvdWxkIHVzZSBsaWdodCB0aGVtZSB1bmxlc3Mgd2Vic2l0ZSBkZWNsYXJlcyBz
dXBwb3J0IGZvciBkYXJrIHRoZW1lcyBpbiBjb2xvci1zY2hlbWVzIHByb3BlcnR5CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm
b3JtSGF2ZS5oCmluZGV4IGQxMzc3MmFjM2IzNmRlMDAyZTgwZTAxZTE0OGM4YmNhODgyMDMxN2Yu
LjBhMDM4NzEwNmFkNjM2NDEwZGViYmU2MTBkZWUzZjg2MTY5NjYzM2EgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt
SGF2ZS5oCkBAIC01NzQsMyArNTc0LDcgQEAKICNpZiBQTEFURk9STShDT0NPQSkgJiYgIShQTEFU
Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE0MDApICYm
ICFQTEFURk9STShXQVRDSE9TKSAmJiAhUExBVEZPUk0oQVBQTEVUVikKICNkZWZpbmUgSEFWRV9D
R19QQVRIX1VORVZFTl9DT1JORVJTX1JPVU5ERURSRUNUIDEKICNlbmRpZgorCisjaWYgKFBMQVRG
T1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDApIHx8
IFBMQVRGT1JNKElPU19GQU1JTFkpCisjZGVmaW5lIEhBVkVfTlNMT0NBTEVfSU5URVJOQVRJT05B
TFNVUFBPUlRFWFRFTlNJT05TIDEKKyNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv
c3BpL2NvY29hL05TTG9jYWxlU1BJLmggYi9Tb3VyY2UvV1RGL3d0Zi9zcGkvY29jb2EvTlNMb2Nh
bGVTUEkuaAppbmRleCA1Y2VmMTY0MDMxNmI0NzNhNzFiZTdiYmE2MWE4ODI3NGYyODEwNjIxLi5h
YmFlMjRmYTdiZjNkNjk5NDMyNTgzYmZiMjAxZjE3MWE2ZDY5ZjI2IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV1RGL3d0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9z
cGkvY29jb2EvTlNMb2NhbGVTUEkuaApAQCAtMjcsNyArMjcsOSBAQAogCiAjaWYgVVNFKEFQUExF
X0lOVEVSTkFMX1NESykKIAorI2lmIEhBVkUoTlNMT0NBTEVfSU5URVJOQVRJT05BTFNVUFBPUlRF
WFRFTlNJT05TKQogI2ltcG9ydCA8SW50ZXJuYXRpb25hbFN1cHBvcnQvTlNMb2NhbGUrSW50ZXJu
YXRpb25hbFN1cHBvcnRFeHRlbnNpb25zLmg+CisjZW5kaWYKIAogI2VuZGlmCiAK
</data>
<flag name="review"
          id="404956"
          type_id="1"
          status="+"
          setter="ap"
    />
          </attachment>
      

    </bug>

</bugzilla>