206981 2020-01-29 19:08:32 -0800 Fix bad assertion in InternalFunctionAllocationProfile::createAllocationStructureFromBase(). 2020-01-29 21:52:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1612820 0 mark.lam 2020-01-29 19:08:32 -0800 <rdar://problem/58985736> 1612821 1 389219 mark.lam 2020-01-29 19:15:47 -0800 Created attachment 389219 proposed patch. 1612822 2 389219 keith_miller 2020-01-29 19:18:08 -0800 Comment on attachment 389219 proposed patch. r=me 1612860 3 mark.lam 2020-01-29 21:52:38 -0800 Thanks for the review. Landed in r255416: <http://trac.webkit.org/r255416>. 389219 2020-01-29 19:15:47 -0800 2020-01-29 19:18:08 -0800 proposed patch. bug-206981.patch text/plain 3948 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTU0MTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggYmFkIGFzc2VydGlvbiBpbiBJbnRlcm5hbEZ1bmN0aW9uQWxsb2Nh dGlvblByb2ZpbGU6OmNyZWF0ZUFsbG9jYXRpb25TdHJ1Y3R1cmVGcm9tQmFzZSgpLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2OTgxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81ODk4NTczNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9JbnRlcm5hbEZ1bmN0aW9uQWxsb2NhdGlvblBy b2ZpbGUtY3JlYXRlQWxsb2NhdGlvblN0cnVjdHVyZUZyb21CYXNlLXNob3VsZC1hbGxvdy1mb3It c2FtZS1jbGFzc0luZm8tZnJvbS1kaWZmZXJlbnQtZ2xvYmFscy5qczogQWRkZWQuCisKIDIwMjAt MDEtMjkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCB1cGRhdGUgdGVzdHMKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL0ludGVybmFsRnVuY3Rp b25BbGxvY2F0aW9uUHJvZmlsZS1jcmVhdGVBbGxvY2F0aW9uU3RydWN0dXJlRnJvbUJhc2Utc2hv dWxkLWFsbG93LWZvci1zYW1lLWNsYXNzSW5mby1mcm9tLWRpZmZlcmVudC1nbG9iYWxzLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL0ludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uUHJv ZmlsZS1jcmVhdGVBbGxvY2F0aW9uU3RydWN0dXJlRnJvbUJhc2Utc2hvdWxkLWFsbG93LWZvci1z YW1lLWNsYXNzSW5mby1mcm9tLWRpZmZlcmVudC1nbG9iYWxzLmpzCShub25leGlzdGVudCkKKysr IEpTVGVzdHMvc3RyZXNzL0ludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uUHJvZmlsZS1jcmVhdGVB bGxvY2F0aW9uU3RydWN0dXJlRnJvbUJhc2Utc2hvdWxkLWFsbG93LWZvci1zYW1lLWNsYXNzSW5m by1mcm9tLWRpZmZlcmVudC1nbG9iYWxzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNiBA QAorZ2xvYmFsMSA9IGNyZWF0ZUdsb2JhbE9iamVjdCgpOworZ2xvYmFsMiA9IGNyZWF0ZUdsb2Jh bE9iamVjdCgpOworCitmdW5jdGlvbiBiYXIoKSB7fQorUmVmbGVjdC5jb25zdHJ1Y3QoZ2xvYmFs MS5PYmplY3QsIHt9LCBiYXIpOworUmVmbGVjdC5jb25zdHJ1Y3QoZ2xvYmFsMi5PYmplY3QsIHt9 LCBiYXIpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTUzOTMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjggQEAKKzIwMjAtMDEtMjkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisg ICAgICAgIEZpeCBiYWQgYXNzZXJ0aW9uIGluIEludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uUHJv ZmlsZTo6Y3JlYXRlQWxsb2NhdGlvblN0cnVjdHVyZUZyb21CYXNlKCkuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY5ODEKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzU4OTg1NzM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uUHJvZmlsZTo6Y3JlYXRlQWxs b2NhdGlvblN0cnVjdHVyZUZyb21CYXNlKCkgaXMgb25seQorICAgICAgICBjYWxsZWQgZnJvbSBG dW5jdGlvblJhcmVEYXRhOjpjcmVhdGVJbnRlcm5hbEZ1bmN0aW9uQWxsb2NhdGlvblN0cnVjdHVy ZUZyb21CYXNlKCksCisgICAgICAgIHdoaWNoIGluIHR1cm4gaXMgb25seSBjYWxsZWQgZnJvbSBJ bnRlcm5hbEZ1bmN0aW9uOjpjcmVhdGVTdWJjbGFzc1N0cnVjdHVyZVNsb3coKS4KKworICAgICAg ICBJbnRlcm5hbEZ1bmN0aW9uOjpjcmVhdGVTdWJjbGFzc1N0cnVjdHVyZVNsb3coKSBvbmx5IGFs bG93cyBhIGNhbGwgdG8KKyAgICAgICAgRnVuY3Rpb25SYXJlRGF0YTo6Y3JlYXRlSW50ZXJuYWxG dW5jdGlvbkFsbG9jYXRpb25TdHJ1Y3R1cmVGcm9tQmFzZSgpIHVuZGVyCisgICAgICAgIGNlcnRh aW4gY29uZGl0aW9ucy4gIE9uZSBvZiB0aGVzZSBjb25kaXRpb25zIGlzIHRoYXQgdGhlIGJhc2VH bG9iYWxPYmplY3QgaXMKKyAgICAgICAgZGlmZmVyZW50IHRoYW4gdGhlIG5ld1RhcmdldCdzIGds b2JhbE9iamVjdC4KKworICAgICAgICBJbnRlcm5hbEZ1bmN0aW9uQWxsb2NhdGlvblByb2ZpbGU6 OmNyZWF0ZUFsbG9jYXRpb25TdHJ1Y3R1cmVGcm9tQmFzZSgpIGhhcyBhbgorICAgICAgICBBU1NF UlQgb24gdGhlIHNhbWUgc2V0IG9mIGNvbmRpdGlvbnMsIHdpdGggb25lIG9tbWlzc2lvbjogdGhl IG9uZSBhYm92ZS4gIFRoaXMKKyAgICAgICAgcGF0Y2ggZml4ZXMgdGhlIEFTU0VSVCBieSBhZGRp bmcgdGhlIG1pc3NpbmcgY29uZGl0aW9uIHRvIG1hdGNoIHRoZSBjaGVjayBpbgorICAgICAgICBJ bnRlcm5hbEZ1bmN0aW9uOjpjcmVhdGVTdWJjbGFzc1N0cnVjdHVyZVNsb3coKS4KKworICAgICAg ICAqIGJ5dGVjb2RlL0ludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uUHJvZmlsZS5oOgorICAgICAg ICAoSlNDOjpJbnRlcm5hbEZ1bmN0aW9uQWxsb2NhdGlvblByb2ZpbGU6OmNyZWF0ZUFsbG9jYXRp b25TdHJ1Y3R1cmVGcm9tQmFzZSk6CisKIDIwMjAtMDEtMjkgIEp1c3RpbiBNaWNoYXVkICA8anVz dGluX21pY2hhdWRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBzbWFsbCBtZW1vcnkgcmVncmVz c2lvbiBjYXVzZWQgYnkgcjIwNjM2NQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL0ludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uUHJvZmlsZS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9JbnRlcm5hbEZ1bmN0aW9uQWxsb2NhdGlvblBy b2ZpbGUuaAkocmV2aXNpb24gMjU1MzkzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL0ludGVybmFsRnVuY3Rpb25BbGxvY2F0aW9uUHJvZmlsZS5oCSh3b3JraW5nIGNvcHkpCkBA IC00Nyw3ICs0Nyw3IEBAIHByaXZhdGU6CiAKIGlubGluZSBTdHJ1Y3R1cmUqIEludGVybmFsRnVu Y3Rpb25BbGxvY2F0aW9uUHJvZmlsZTo6Y3JlYXRlQWxsb2NhdGlvblN0cnVjdHVyZUZyb21CYXNl KFZNJiB2bSwgSlNHbG9iYWxPYmplY3QqIGJhc2VHbG9iYWxPYmplY3QsIEpTQ2VsbCogb3duZXIs IEpTT2JqZWN0KiBwcm90b3R5cGUsIFN0cnVjdHVyZSogYmFzZVN0cnVjdHVyZSkKIHsKLSAgICBB U1NFUlQoIW1fc3RydWN0dXJlIHx8IG1fc3RydWN0dXJlLmdldCgpLT5jbGFzc0luZm8oKSAhPSBi YXNlU3RydWN0dXJlLT5jbGFzc0luZm8oKSk7CisgICAgQVNTRVJUKCFtX3N0cnVjdHVyZSB8fCBt X3N0cnVjdHVyZS5nZXQoKS0+Y2xhc3NJbmZvKCkgIT0gYmFzZVN0cnVjdHVyZS0+Y2xhc3NJbmZv KCkgfHwgbV9zdHJ1Y3R1cmUtPmdsb2JhbE9iamVjdCgpICE9IGJhc2VHbG9iYWxPYmplY3QpOwog ICAgIEFTU0VSVChiYXNlU3RydWN0dXJlLT5oYXNNb25vUHJvdG8oKSk7CiAKICAgICBTdHJ1Y3R1 cmUqIHN0cnVjdHVyZTsK