206978 2020-01-29 18:11:04 -0800 REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location 2020-01-29 20:47:47 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue wenson_hsieh oldest_to_newest 1612798 0 thorton 2020-01-29 18:11:04 -0800 REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location 1612800 1 389212 thorton 2020-01-29 18:13:44 -0800 Created attachment 389212 Patch 1612801 2 thorton 2020-01-29 18:14:25 -0800 <rdar://problem/59011906> 1612850 3 commit-queue 2020-01-29 20:47:06 -0800 The commit-queue encountered the following flaky tests while processing attachment 389212: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1612853 4 389212 commit-queue 2020-01-29 20:47:45 -0800 Comment on attachment 389212 Patch Clearing flags on attachment: 389212 Committed r255415: <https://trac.webkit.org/changeset/255415> 1612854 5 commit-queue 2020-01-29 20:47:47 -0800 All reviewed patches have been landed. Closing bug. 389212 2020-01-29 18:13:44 -0800 2020-01-29 20:47:45 -0800 Patch bug-206978-20200129181343.patch text/plain 7052 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDExNjNhYzM0OWRjZTk2 MzZkYTRlY2RmMTc0NGYxMzM4Yzc2OGRjNy4uNDk3ZjA3YTQ2ODQ0MGIwZDM4YmUxYjQ2ZmUzMDk1 YmRiM2M1OTFlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTI5ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyNTUzMjIpOiBtYWNDYXRhbHlzdDogVGFwcGluZyBpbiBhbiBpbnB1dCBmaWVsZCBkb2Vzbid0 IGNoYW5nZSB0aGUgc2VsZWN0aW9uIGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY5NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6CisgICAgICAgIChX ZWJDb3JlOjpDaHJvbWVDbGllbnQ6OnNob3VsZFVzZU1vdXNlRXZlbnRGb3JTZWxlY3Rpb24pOgor ICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50OjpzaG91bGRVc2VNb3VzZUV2ZW50c0ZvclNl bGVjdGlvbik6IERlbGV0ZWQuCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpjYW5Nb3VzZURvd25TdGFydFNlbGVjdCk6Cisg ICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUHJlc3NFdmVudCk6Cisg ICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuaDoKKyAgICAgICAgUGx1bWIgdGhlIGV2ZW50IHRo cm91Z2ggdG8gdGhlIENocm9tZUNsaWVudCBzbyBpdCBjYW4gdXNlIGl0IHRvIG1ha2UgZGVjaXNp b25zLgorCiAyMDIwLTAxLTI5ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAK ICAgICAgICAgW1dlYiBBbmltYXRpb25zXSBgRGVjbGFyYXRpdmVBbmltYXRpb25gIGZvciBDU1Mg QW5pbWF0aW9uIGlzIG5vdCBhbHdheXMgZGVzdHJveWVkIHdoZW4gY2xhc3MgdGhhdCBhcHBsaWVz IGBhbmltYXRpb24tbmFtZWAgaXMgcmVtb3ZlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAyMjk3ZGU1NzJhMDk0NzVk ZTQ2M2Q4MGVlNDBiMTFlZTgzMjU5NGEyLi5mNGRkZmM1YjUyOGNjZmYxY2MxMzI5MzJhOTU2ZTIw ZjY4YjE4MTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAxLTI5ICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIy NTUzMjIpOiBtYWNDYXRhbHlzdDogVGFwcGluZyBpbiBhbiBpbnB1dCBmaWVsZCBkb2Vzbid0IGNo YW5nZSB0aGUgc2VsZWN0aW9uIGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY5NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21l Q2xpZW50Lmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3MvV2ViQ2hy b21lQ2xpZW50SU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVDbGllbnQ6OnNob3Vs ZFVzZU1vdXNlRXZlbnRGb3JTZWxlY3Rpb24pOgorICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVD bGllbnQ6OnNob3VsZFVzZU1vdXNlRXZlbnRzRm9yU2VsZWN0aW9uKTogRGVsZXRlZC4KKyAgICAg ICAgQWxsb3cgc2luZ2xlLWNsaWNrIGV2ZW50cyB0byBjaGFuZ2UgdGhlIHNlbGVjdGlvbjsgdGhp cyBpcyByZXF1aXJlZAorICAgICAgICBpbiBvcmRlciB0byBhbGxvdyBXZWJDb3JlIHRvIHNldCB0 aGUgc2VsZWN0aW9uIGluIHRoZSBjYXNlIHRoYXQKKyAgICAgICAgdGhlIFVJVGV4dEludGVyYWN0 aW9uIGdlc3R1cmVzIGhhdmVuJ3QgeWV0IGJlZW4gaW5zdGFsbGVkLiBDb250aW51ZQorICAgICAg ICB0byBub3QgYWxsb3cgbXVsdGktY2xpY2sgZXZlbnRzIHRvIGNoYW5nZSB0aGUgc2VsZWN0aW9u LCBiZWNhdXNlCisgICAgICAgIHRoZXNlIGFyZSB0aGUgb25lcyB0aGF0IGNvbmZsaWN0IHdpdGgg VUlLaXQncyBiZWhhdmlvcnMuCisKIDIwMjAtMDEtMjkgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hh bUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI1NTIxNyBh bmQgcjI1NTIxNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50 LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCmluZGV4IDliOWM4MzU1ZWQw MzQ1NDAyNzhkMTNjMDM4NmMxM2U0MTVmNzYyMWYuLjk4OWJhZjRhN2Q3ZjMzNTQ1OTMyYmQ5MzA0 M2VmNDNiYTdhYTUxMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xp ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaApAQCAtMTkzLDcg KzE5Myw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q3Vyc29ySGlkZGVuVW50aWxN b3VzZU1vdmVzKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNTZXR0aW5nQ3Vy c29yKCkgeyByZXR1cm4gdHJ1ZTsgfQogCi0gICAgdmlydHVhbCBib29sIHNob3VsZFVzZU1vdXNl RXZlbnRzRm9yU2VsZWN0aW9uKCkgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHZpcnR1YWwgYm9vbCBz aG91bGRVc2VNb3VzZUV2ZW50Rm9yU2VsZWN0aW9uKGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYp IHsgcmV0dXJuIHRydWU7IH0KIAogICAgIHZpcnR1YWwgRmxvYXRTaXplIHNjcmVlblNpemUoKSBj b25zdCB7IHJldHVybiBjb25zdF9jYXN0PENocm9tZUNsaWVudCY+KCp0aGlzKS53aW5kb3dSZWN0 KCkuc2l6ZSgpOyB9CiAgICAgdmlydHVhbCBGbG9hdFNpemUgYXZhaWxhYmxlU2NyZWVuU2l6ZSgp IGNvbnN0IHsgcmV0dXJuIGNvbnN0X2Nhc3Q8Q2hyb21lQ2xpZW50Jj4oKnRoaXMpLndpbmRvd1Jl Y3QoKS5zaXplKCk7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCA1OWJl NTUzMjg5ZTNkZmY3MmM5YjU4YTE0MDU3MDNhZDM5MWU1ZWU2Li41MjNhZDM5MTllZjE1YjMxMjdk MmE0OGE3ZDg5MTcyNWQ2MTljYzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CkBAIC03MzEsMTAgKzczMSwxMiBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVz c0V2ZW50U2luZ2xlQ2xpY2soY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UgogICAgIHJldHVy biBoYW5kbGVkOwogfQogCi1ib29sIEV2ZW50SGFuZGxlcjo6Y2FuTW91c2VEb3duU3RhcnRTZWxl Y3QoTm9kZSogbm9kZSkKK2Jvb2wgRXZlbnRIYW5kbGVyOjpjYW5Nb3VzZURvd25TdGFydFNlbGVj dChjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBldmVudCkKIHsKKyAgICBhdXRv KiBub2RlID0gZXZlbnQudGFyZ2V0Tm9kZSgpOworCiAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBtX2Zy YW1lLnBhZ2UoKSkgewotICAgICAgICBpZiAoIXBhZ2UtPmNocm9tZSgpLmNsaWVudCgpLnNob3Vs ZFVzZU1vdXNlRXZlbnRzRm9yU2VsZWN0aW9uKCkpCisgICAgICAgIGlmICghcGFnZS0+Y2hyb21l KCkuY2xpZW50KCkuc2hvdWxkVXNlTW91c2VFdmVudEZvclNlbGVjdGlvbihldmVudC5ldmVudCgp KSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAgICAgCkBAIC03NjgsNyArNzcw LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUHJlc3NFdmVudChjb25zdCBNb3Vz ZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBldmUKIAogICAgIC8vIElmIHdlIGdvdCB0aGUgZXZl bnQgYmFjaywgdGhhdCBtdXN0IG1lYW4gaXQgd2Fzbid0IHByZXZlbnRlZCwKICAgICAvLyBzbyBp dCdzIGFsbG93ZWQgdG8gc3RhcnQgYSBkcmFnIG9yIHNlbGVjdGlvbiBpZiBpdCB3YXNuJ3QgaW4g YSBzY3JvbGxiYXIuCi0gICAgbV9tb3VzZURvd25NYXlTdGFydFNlbGVjdCA9IGNhbk1vdXNlRG93 blN0YXJ0U2VsZWN0KGV2ZW50LnRhcmdldE5vZGUoKSkgJiYgIWV2ZW50LnNjcm9sbGJhcigpOwor ICAgIG1fbW91c2VEb3duTWF5U3RhcnRTZWxlY3QgPSBjYW5Nb3VzZURvd25TdGFydFNlbGVjdChl dmVudCkgJiYgIWV2ZW50LnNjcm9sbGJhcigpOwogICAgIAogI2lmIEVOQUJMRShEUkFHX1NVUFBP UlQpCiAgICAgLy8gQ2FyZWZ1bCB0aGF0IHRoZSBkcmFnIHN0YXJ0aW5nIGxvZ2ljIHN0YXlzIGlu IHN5bmMgd2l0aCBldmVudE1heVN0YXJ0RHJhZygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu aAppbmRleCAxNGU5NWVlZDU1ODQ0ZmQwN2ZlMGEzZjQwNzc0OGNmYjM3MDAyMjBiLi5lYTI0NzJk ODk1YzY3NjQyOTQ4MjcyNmMxNDNkMDdmMTAxNzU1OTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI YW5kbGVyLmgKQEAgLTUwMCw3ICs1MDAsNyBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBzaG91bGRT ZW5kTW91c2VFdmVudHNUb0luYWN0aXZlV2luZG93cygpIGNvbnN0OwogCi0gICAgYm9vbCBjYW5N b3VzZURvd25TdGFydFNlbGVjdChOb2RlKik7CisgICAgYm9vbCBjYW5Nb3VzZURvd25TdGFydFNl bGVjdChjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJik7CiAKICAgICBGcmFtZSYg bV9mcmFtZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L1dlYkNocm9tZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5oCmluZGV4IDlhMDNmN2ZkOTFkY2YyMGFhNjY5Nzg5 MDNmYmVlNTUxMWI5YjQ3MjAuLmU3NDY3NTNiZDgxMDczNDQ4N2JiMmY4Y2ZjYTJiMzI4Mzc0NDkz MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJDaHJvbWVDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmgKQEAgLTE4Miw3ICsxODIsNyBAQCBwcml2YXRlOgogICAg IHZvaWQgZGlkQ3JlYXRlRWRpdGFibGVJbWFnZShXZWJDb3JlOjpHcmFwaGljc0xheWVyOjpFbWJl ZGRlZFZpZXdJRCkgZmluYWw7CiAgICAgdm9pZCBkaWREZXN0cm95RWRpdGFibGVJbWFnZShXZWJD b3JlOjpHcmFwaGljc0xheWVyOjpFbWJlZGRlZFZpZXdJRCkgZmluYWw7CiAKLSAgICBib29sIHNo b3VsZFVzZU1vdXNlRXZlbnRzRm9yU2VsZWN0aW9uKCkgZmluYWw7CisgICAgYm9vbCBzaG91bGRV c2VNb3VzZUV2ZW50Rm9yU2VsZWN0aW9uKGNvbnN0IFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVu dCYpIGZpbmFsOwogI2VuZGlmCiAKICNpZiBFTkFCTEUoT1JJRU5UQVRJT05fRVZFTlRTKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2lvcy9XZWJD aHJvbWVDbGllbnRJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvaW9zL1dlYkNocm9tZUNsaWVudElPUy5tbQppbmRleCAzYTg2NWMzNmUwYjMzMTkwNDkwOTAx MmNlMzkxNTMxZDAyYWUxMTQ0Li4xYzVhYTI4ZmNmMzAwNTQ4MGIxNGUyMmIyNGRiNTgwOTBiMjkx NDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv aW9zL1dlYkNocm9tZUNsaWVudElPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvaW9zL1dlYkNocm9tZUNsaWVudElPUy5tbQpAQCAtNDAsNiArNDAsNyBA QAogI2ltcG9ydCA8V2ViQ29yZS9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaD4KICNpbXBvcnQgPFdl YkNvcmUvSWNvbi5oPgogI2ltcG9ydCA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5oPgorI2ltcG9y dCA8V2ViQ29yZS9QbGF0Zm9ybU1vdXNlRXZlbnQuaD4KICNpbXBvcnQgPHd0Zi9SZWZQdHIuaD4K IAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC0xODEsMTEgKzE4MiwxMiBAQCB2b2lkIFdlYkNocm9t ZUNsaWVudDo6ZGlkRGVzdHJveUVkaXRhYmxlSW1hZ2UoR3JhcGhpY3NMYXllcjo6RW1iZWRkZWRW aWV3SUQgZW1iZQogI2VuZGlmCiB9CiAKLWJvb2wgV2ViQ2hyb21lQ2xpZW50OjpzaG91bGRVc2VN b3VzZUV2ZW50c0ZvclNlbGVjdGlvbigpCitib29sIFdlYkNocm9tZUNsaWVudDo6c2hvdWxkVXNl TW91c2VFdmVudEZvclNlbGVjdGlvbihjb25zdCBXZWJDb3JlOjpQbGF0Zm9ybU1vdXNlRXZlbnQm IGV2ZW50KQogewogICAgIC8vIEluIG1hY0NhdGFseXN0LCBkZXNwaXRlIGdldHRpbmcgbW91c2Ug ZXZlbnRzLCB3ZSBzdGlsbCB3YW50IFVJVGV4dEludGVyYWN0aW9uIGFuZCBmcmllbmRzIHRvIG93 biBzZWxlY3Rpb24gZ2VzdHVyZXMuCisgICAgLy8gSG93ZXZlciwgd2UgbmVlZCB0byBhbGxvdyBz aW5nbGUtY2xpY2tzIHRvIHNldCB0aGUgc2VsZWN0aW9uLCBiZWNhdXNlIHRoYXQgaXMgaG93IFVJ VGV4dEludGVyYWN0aW9uIGlzIGFjdGl2YXRlZC4KICNpZiBIQVZFKEhPVkVSX0dFU1RVUkVfUkVD T0dOSVpFUikKLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIGV2ZW50LmNsaWNrQ291bnQo KSA8PSAxOwogI2Vsc2UKICAgICByZXR1cm4gdHJ1ZTsKICNlbmRpZgo=