206954 2020-01-29 11:44:24 -0800 [curl] PublicSuffixCurl should skip leading dots 2020-02-06 14:32:20 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid chris.reid basuke commit-queue don.olmstead ews-watchlist fujii galpeter ross.kirsling takashi.komori webkit-bug-importer oldest_to_newest 1612594 0 chris.reid 2020-01-29 11:44:24 -0800 This test case is failing: EXPECT_EQ(String("test.com"), topPrivatelyControlledDomain(".test.com")); 1612596 1 389168 chris.reid 2020-01-29 11:50:54 -0800 Created attachment 389168 patch 1613850 2 389168 fujii 2020-02-02 18:52:30 -0800 Comment on attachment 389168 patch View in context: https://bugs.webkit.org/attachment.cgi?id=389168&action=review > Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:73 > + while (domainUTF8.data()[position] == '.') Do you really need to skip multiple leading dots? I know you copied the implementation of PublicSuffixSoup.cpp. 1614075 3 chris.reid 2020-02-03 12:01:18 -0800 (In reply to Fujii Hironori from comment #2) > Comment on attachment 389168 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389168&action=review > > > Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:73 > > + while (domainUTF8.data()[position] == '.') > > Do you really need to skip multiple leading dots? > I know you copied the implementation of PublicSuffixSoup.cpp. Right, the main reason to keep the multiple skip in is to not diverge from Mac/Soup implementations for cases like "..test.com". I'm not sure if we have a case like that in practice though. 1615817 4 389168 commit-queue 2020-02-06 14:31:46 -0800 Comment on attachment 389168 patch Clearing flags on attachment: 389168 Committed r255983: <https://trac.webkit.org/changeset/255983> 1615818 5 commit-queue 2020-02-06 14:31:48 -0800 All reviewed patches have been landed. Closing bug. 1615822 6 webkit-bug-importer 2020-02-06 14:32:20 -0800 <rdar://problem/59237548> 389168 2020-01-29 11:50:54 -0800 2020-02-06 14:31:46 -0800 patch 206954.diff text/plain 1999 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNzEzMWQ2NjVjZi4uMTk1NzdmNzdhMWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMS0yOSAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW2N1cmxdIFB1YmxpY1N1ZmZpeEN1cmwgc2hvdWxkIHNraXAgbGVh ZGluZyBkb3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDY5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgIE1hdGNoaW5nIFB1YmxpY1N1 ZmZpeFNvdXAuY3BwIGJlaGF2aW9yIHRvIHNraXAgbGVhZGluZyBkb3RzLgorCisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9jdXJsL1B1YmxpY1N1ZmZpeEN1cmwuY3BwOgorCiAyMDIwLTAxLTE0 ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbUGxh eVN0YXRpb25dIEFkZCBzdGFuZGFyZFVzZXJBZ2VudEZvclVSTCBzdHViCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUHVibGljU3VmZml4Q3VybC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUHVibGljU3VmZml4Q3VybC5j cHAKaW5kZXggNWY0ZDFmZDRiOTguLmI3OWE0NzMxNWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUHVibGljU3VmZml4Q3VybC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1B1YmxpY1N1ZmZpeEN1cmwuY3BwCkBA IC01NCw2ICs1NCw4IEBAIHN0YXRpYyBTdHJpbmcgdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFp bkludGVybmFsKGNvbnN0IHBzbF9jdHhfdCogcHNsLCBjb25zdCBjCiAKIFN0cmluZyB0b3BQcml2 YXRlbHlDb250cm9sbGVkRG9tYWluKGNvbnN0IFN0cmluZyYgZG9tYWluKQogeworICAgIGlmIChk b21haW4uaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgaWYgKFVSTDo6 aG9zdElzSVBBZGRyZXNzKGRvbWFpbikgfHwgIWRvbWFpbi5pc0FsbEFTQ0lJKCkpCiAgICAgICAg IHJldHVybiBkb21haW47CiAKQEAgLTY0LDkgKzY2LDE5IEBAIFN0cmluZyB0b3BQcml2YXRlbHlD b250cm9sbGVkRG9tYWluKGNvbnN0IFN0cmluZyYgZG9tYWluKQogICAgIGlmIChpc1B1YmxpY1N1 ZmZpeChsb3dlcmNhc2VEb21haW4pKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAKKyAgICAv LyBUaGlzIGZ1bmN0aW9uIGlzIGV4cGVjdGVkIHRvIHdvcmsgd2l0aCB0aGUgZm9ybWF0IHVzZWQg YnkgY29va2llcywgc28gc2tpcCBhbnkgbGVhZGluZyBkb3RzLgorICAgIGF1dG8gZG9tYWluVVRG OCA9IGxvd2VyY2FzZURvbWFpbi51dGY4KCk7CisKKyAgICB1bnNpZ25lZCBwb3NpdGlvbiA9IDA7 CisgICAgd2hpbGUgKGRvbWFpblVURjguZGF0YSgpW3Bvc2l0aW9uXSA9PSAnLicpCisgICAgICAg IHBvc2l0aW9uKys7CisKKyAgICBpZiAocG9zaXRpb24gPT0gZG9tYWluVVRGOC5sZW5ndGgoKSkK KyAgICAgICAgcmV0dXJuIFN0cmluZygpOworCiAgICAgY29uc3QgcHNsX2N0eF90KiBwc2wgPSBw c2xfYnVpbHRpbigpOwogICAgIEFTU0VSVChwc2wpOwotICAgIHJldHVybiB0b3BQcml2YXRlbHlD b250cm9sbGVkRG9tYWluSW50ZXJuYWwocHNsLCBsb3dlcmNhc2VEb21haW4udXRmOCgpLmRhdGEo KSk7CisgICAgcmV0dXJuIHRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW5JbnRlcm5hbChwc2ws IGRvbWFpblVURjguZGF0YSgpICsgcG9zaXRpb24pOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCg==