20695 2008-09-07 01:22:57 -0700 Inspector should display Array lengths in the property lists 2010-02-16 18:28:50 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 oliver jberlin bweinstein jberlin joepeck rik timothy oldest_to_newest 90392 0 oliver 2008-09-07 01:22:57 -0700 When looking at arrays in the scope pane their contents are sorted lexically rather than numerically. Would also be helpful to have length info presented early. 147163 1 joepeck 2009-09-14 13:33:35 -0700 The array sorting was fixed in: https://bugs.webkit.org/show_bug.cgi?id=27329 However, listing the "length" doesn't currently happen. Is this still wanted? 147170 2 timothy 2009-09-14 13:44:01 -0700 I think we should show length, but not mixed with the number properties. But as a number next to the object name. We could/should do this for anythign with a length I think, so NodeLists, etc. So it would look like this: forBar: Array (2) 0: "def" 1: "abc" Or: myElement: HTMLDivElement childNodes: NodeList (2) 0: HTMLDivElement 1: HTMLDivElement ... 159527 3 bweinstein 2009-10-30 17:14:23 -0700 Do we show the name anymore? This would be straightforward, but with some tests I'm not sure the best place to put it: > a [5, 4, 3, 2, 3, 3, 3] Should it look something like: > a Length: 5 [5, 4, 3, 2, 3, 3, 3] or > a 5 Items [5, 4, 3, 2, 3, 3, 3] I'm just not sure the best way to put this in the UI, now that we don't explicitly state Array - however, we could do that. 159529 4 timothy 2009-10-30 17:23:18 -0700 For property lists we still show the name (Array), or we should. So my proposal would still stand: Array (2), etc. You are thinking of logging. I don't think we need to show the lenght when logging an array like you did. Only if you do: dir(a) would we show what I mention and what this bug is about. 190333 5 48729 jberlin 2010-02-14 10:53:30 -0800 Created attachment 48729 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists 190335 6 bweinstein 2010-02-14 11:03:52 -0800 (In reply to comment #5) > Created an attachment (id=48729) [details] > Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the > Inspector property lists There arensome inspector layout tests that can test the console output (and output of console.dir). Does this break any tests/could this be tested? 190340 7 48729 jberlin 2010-02-14 12:09:27 -0800 Comment on attachment 48729 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists I need to make sure that the length doesn't get appended to the description in the console as well. 190343 8 timothy 2010-02-14 13:27:00 -0800 I think length in console would be useful. 190345 9 48731 jberlin 2010-02-14 13:54:02 -0800 Created attachment 48731 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists (and not in the console as well) 190346 10 jberlin 2010-02-14 13:55:56 -0800 (In reply to comment #8) > I think length in console would be useful. Same format as in the properties list? 190349 11 timothy 2010-02-14 14:02:51 -0800 I guess we don't have a good place in the console to show it. Nevermind for now. 190350 12 48731 timothy 2010-02-14 14:07:49 -0800 Comment on attachment 48731 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists (and not in the console as well) > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > + if (result.type == "array") Use ===. > + if (this.property.value.propertyLength !== undefined) Should be: typeof this.property.value.propertyLength !== "undefined" 190364 13 48738 jberlin 2010-02-14 18:50:32 -0800 Created attachment 48738 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists (Fixed issues cited in comments) 190848 14 jberlin 2010-02-16 18:28:50 -0800 Thanks for the review! Committed in r54856: http://trac.webkit.org/changeset/54856 48729 2010-02-14 10:53:30 -0800 2010-02-14 12:09:26 -0800 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists addLengthsToArraysInWebInspector.patch text/plain 1190 jberlin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDk2MWNmMC4uYjUwYjIzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0xNCAgSmVzc2llIEJlcmxp biAgPGpiZXJsaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbnNwZWN0b3Igc2hvdWxkIGRpc3BsYXkgQXJyYXkgbGVuZ3RocyBp biB0aGUgcHJvcGVydHkgbGlzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDY5NQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Jbmpl Y3RlZFNjcmlwdC5qczoKKyAgICAgICAgRm9yIG9iamVjdHMgb2YgdHlwZSAnYXJyYXknICh3aGlj aCBpbmNsdWRlcyBBcnJheXMsIE5vZGVMaXN0cywgYW5kIEhUTUxDb2xsZWN0aW9ucyksIGFwcGVu ZCBhIChsZW5ndGgpIHRvIHRoZSBkZXNjcmlwdGlvbi4KKwogMjAxMC0wMi0xMyAgS2VudCBUYW11 cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3Jp cHQuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5k ZXggOTU4NjdjNC4uYWM4Zjc3ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0luamVjdGVkU2NyaXB0LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9J bmplY3RlZFNjcmlwdC5qcwpAQCAtMTI4Niw4ICsxMjg2LDkgQEAgSW5qZWN0ZWRTY3JpcHQuX2Rl c2NyaWJlID0gZnVuY3Rpb24ob2JqLCBhYmJyZXZpYXRlZCkKICAgICBzd2l0Y2ggKHR5cGUxKSB7 CiAgICAgY2FzZSAib2JqZWN0IjoKICAgICBjYXNlICJub2RlIjoKLSAgICBjYXNlICJhcnJheSI6 CiAgICAgICAgIHJldHVybiB0eXBlMjsKKyAgICBjYXNlICJhcnJheSI6CisgICAgICAgIHJldHVy biB0eXBlMiArICIgKCIgKyBvYmoubGVuZ3RoICsgIikiOwogICAgIGNhc2UgInN0cmluZyI6CiAg ICAgICAgIGlmICghYWJicmV2aWF0ZWQpCiAgICAgICAgICAgICByZXR1cm4gb2JqOwo= 48731 2010-02-14 13:54:02 -0800 2010-02-14 14:07:47 -0800 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists (and not in the console as well) addLengthsToArraysInWebInspectorPropertiesPanel.patch text/plain 2377 jberlin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDk2MWNmMC4uZTQ4NmVhMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMi0xNCAgSmVzc2llIEJlcmxp biAgPGpiZXJsaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbnNwZWN0b3Igc2hvdWxkIGRpc3BsYXkgQXJyYXkgbGVuZ3RocyBp biB0aGUgcHJvcGVydHkgbGlzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDY5NQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Jbmpl Y3RlZFNjcmlwdC5qczoKKyAgICAgICAgKGluamVjdGVkU2NyaXB0Q29uc3RydWN0b3IpOgorICAg ICAgICBGb3Igb2JqZWN0cyBvZiB0eXBlICdhcnJheScgKHdoaWNoIGluY2x1ZGVzIEFycmF5cywg Tm9kZUxpc3RzLCBhbmQgSFRNTENvbGxlY3Rpb25zKSwgbWFrZSB0aGUgbGVuZ3RoIG9mIHRoZSBv YmplY3QgYXZhaWxhYmxlIHZpYSBwcm9wZXJ0eUxlbmd0aCBvbiB0aGUgcHJveHkgb2JqZWN0Lgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0UHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5 cGUudXBkYXRlKToKKyAgICAgICAgRm9yIHByb3BlcnRpZXMgdGhhdCBoYXZlIHByb3BlcnR5TGVu Z3RoIGRlZmluZWQsIGFwcGVuZCBpdCB0byB0aGUgZGlzcGxheWVkIGRlc2NyaXB0aW9uLgorCiAy MDEwLTAyLTEzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9J bmplY3RlZFNjcmlwdC5qcwppbmRleCA5NTg2N2M0Li4zZTkyMzAyIDEwMDY0NAotLS0gYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCkBAIC0xMTM2LDYgKzExMzYsOCBA QCBJbmplY3RlZFNjcmlwdC5jcmVhdGVQcm94eU9iamVjdCA9IGZ1bmN0aW9uKG9iamVjdCwgb2Jq ZWN0SWQsIGFiYnJldmlhdGUpCiAgICAgcmVzdWx0LmluamVjdGVkU2NyaXB0SWQgPSBpbmplY3Rl ZFNjcmlwdElkOwogICAgIHJlc3VsdC5vYmplY3RJZCA9IG9iamVjdElkOwogICAgIHJlc3VsdC50 eXBlID0gSW5qZWN0ZWRTY3JpcHQuX3R5cGUob2JqZWN0KTsKKyAgICBpZiAocmVzdWx0LnR5cGUg PT0gImFycmF5IikKKyAgICAgICAgcmVzdWx0LnByb3BlcnR5TGVuZ3RoID0gb2JqZWN0Lmxlbmd0 aDsKIAogICAgIHZhciB0eXBlID0gdHlwZW9mIG9iamVjdDsKICAgICBpZiAoKHR5cGUgPT09ICJv YmplY3QiICYmIG9iamVjdCAhPT0gbnVsbCkgfHwgdHlwZSA9PT0gImZ1bmN0aW9uIikgewpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3BlcnRpZXNTZWN0 aW9uLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3BlcnRpZXNTZWN0 aW9uLmpzCmluZGV4IDZkNzEwOTAuLmZjMmE4ODIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2VjdGlvbi5qcworKysgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMKQEAgLTE3Myw2ICsx NzMsOCBAQCBXZWJJbnNwZWN0b3IuT2JqZWN0UHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUg PSB7CiAgICAgICAgIHRoaXMudmFsdWVFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi c3BhbiIpOwogICAgICAgICB0aGlzLnZhbHVlRWxlbWVudC5jbGFzc05hbWUgPSAidmFsdWUiOwog ICAgICAgICB0aGlzLnZhbHVlRWxlbWVudC50ZXh0Q29udGVudCA9IHRoaXMucHJvcGVydHkudmFs dWUuZGVzY3JpcHRpb247CisgICAgICAgIGlmICh0aGlzLnByb3BlcnR5LnZhbHVlLnByb3BlcnR5 TGVuZ3RoICE9PSB1bmRlZmluZWQpCisgICAgICAgICAgICB0aGlzLnZhbHVlRWxlbWVudC50ZXh0 Q29udGVudCArPSAiICgiICsgdGhpcy5wcm9wZXJ0eS52YWx1ZS5wcm9wZXJ0eUxlbmd0aCArICIp IjsKICAgICAgICAgaWYgKHRoaXMucHJvcGVydHkuaXNHZXR0ZXIpCiAgICAgICAgICAgIHRoaXMu dmFsdWVFbGVtZW50LmFkZFN0eWxlQ2xhc3MoImRpbW1lZCIpOwogCg== 48738 2010-02-14 18:50:32 -0800 2010-02-14 21:47:02 -0800 Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists (Fixed issues cited in comments) addLengthsToArraysInWebInspectorPropertiesPanel2.patch text/plain 2387 jberlin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDk2MWNmMC4uZTQ4NmVhMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMi0xNCAgSmVzc2llIEJlcmxp biAgPGpiZXJsaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbnNwZWN0b3Igc2hvdWxkIGRpc3BsYXkgQXJyYXkgbGVuZ3RocyBp biB0aGUgcHJvcGVydHkgbGlzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDY5NQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Jbmpl Y3RlZFNjcmlwdC5qczoKKyAgICAgICAgKGluamVjdGVkU2NyaXB0Q29uc3RydWN0b3IpOgorICAg ICAgICBGb3Igb2JqZWN0cyBvZiB0eXBlICdhcnJheScgKHdoaWNoIGluY2x1ZGVzIEFycmF5cywg Tm9kZUxpc3RzLCBhbmQgSFRNTENvbGxlY3Rpb25zKSwgbWFrZSB0aGUgbGVuZ3RoIG9mIHRoZSBv YmplY3QgYXZhaWxhYmxlIHZpYSBwcm9wZXJ0eUxlbmd0aCBvbiB0aGUgcHJveHkgb2JqZWN0Lgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0UHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5 cGUudXBkYXRlKToKKyAgICAgICAgRm9yIHByb3BlcnRpZXMgdGhhdCBoYXZlIHByb3BlcnR5TGVu Z3RoIGRlZmluZWQsIGFwcGVuZCBpdCB0byB0aGUgZGlzcGxheWVkIGRlc2NyaXB0aW9uLgorCiAy MDEwLTAyLTEzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9J bmplY3RlZFNjcmlwdC5qcwppbmRleCA5NTg2N2M0Li5jNDJhODZkIDEwMDY0NAotLS0gYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCkBAIC0xMTM2LDYgKzExMzYsOCBA QCBJbmplY3RlZFNjcmlwdC5jcmVhdGVQcm94eU9iamVjdCA9IGZ1bmN0aW9uKG9iamVjdCwgb2Jq ZWN0SWQsIGFiYnJldmlhdGUpCiAgICAgcmVzdWx0LmluamVjdGVkU2NyaXB0SWQgPSBpbmplY3Rl ZFNjcmlwdElkOwogICAgIHJlc3VsdC5vYmplY3RJZCA9IG9iamVjdElkOwogICAgIHJlc3VsdC50 eXBlID0gSW5qZWN0ZWRTY3JpcHQuX3R5cGUob2JqZWN0KTsKKyAgICBpZiAocmVzdWx0LnR5cGUg PT09ICJhcnJheSIpCisgICAgICAgIHJlc3VsdC5wcm9wZXJ0eUxlbmd0aCA9IG9iamVjdC5sZW5n dGg7CiAKICAgICB2YXIgdHlwZSA9IHR5cGVvZiBvYmplY3Q7CiAgICAgaWYgKCh0eXBlID09PSAi b2JqZWN0IiAmJiBvYmplY3QgIT09IG51bGwpIHx8IHR5cGUgPT09ICJmdW5jdGlvbiIpIHsKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2Vj dGlvbi5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2Vj dGlvbi5qcwppbmRleCA2ZDcxMDkwLi4yMGRkNWQ2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3BlcnRpZXNTZWN0aW9uLmpzCkBAIC0xNzMsNiAr MTczLDggQEAgV2ViSW5zcGVjdG9yLk9iamVjdFByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBl ID0gewogICAgICAgICB0aGlzLnZhbHVlRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo InNwYW4iKTsKICAgICAgICAgdGhpcy52YWx1ZUVsZW1lbnQuY2xhc3NOYW1lID0gInZhbHVlIjsK ICAgICAgICAgdGhpcy52YWx1ZUVsZW1lbnQudGV4dENvbnRlbnQgPSB0aGlzLnByb3BlcnR5LnZh bHVlLmRlc2NyaXB0aW9uOworICAgICAgICBpZiAodHlwZW9mIHRoaXMucHJvcGVydHkudmFsdWUu cHJvcGVydHlMZW5ndGggIT09ICJ1bmRlZmluZWQiKQorICAgICAgICAgICAgdGhpcy52YWx1ZUVs ZW1lbnQudGV4dENvbnRlbnQgKz0gIiAoIiArIHRoaXMucHJvcGVydHkudmFsdWUucHJvcGVydHlM ZW5ndGggKyAiKSI7CiAgICAgICAgIGlmICh0aGlzLnByb3BlcnR5LmlzR2V0dGVyKQogICAgICAg ICAgICB0aGlzLnZhbHVlRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJkaW1tZWQiKTsKIAo=