206920 2020-01-28 23:00:19 -0800 Web Inspector: Some cookie table column headers should not be localizable 2020-02-05 19:36:10 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1612331 0 nvasilyev 2020-01-28 23:00:19 -0800 Some of the localized headers should always be in English because they match cookie directives. Only "Name", "Value", and "Size" should be localized. https://github.com/WebKit/webkit/blob/2764480713d1f2b46b8f239eae5a99a6fcc3b6d9/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js#L169-L225 <rdar://57857579> 1612332 1 389107 nvasilyev 2020-01-28 23:04:25 -0800 Created attachment 389107 Patch 1615489 2 commit-queue 2020-02-05 18:46:33 -0800 The commit-queue encountered the following flaky tests while processing attachment 389107: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1615492 3 commit-queue 2020-02-05 18:46:55 -0800 The commit-queue encountered the following flaky tests while processing attachment 389107: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1615508 4 389107 commit-queue 2020-02-05 19:36:08 -0800 Comment on attachment 389107 Patch Clearing flags on attachment: 389107 Committed r255896: <https://trac.webkit.org/changeset/255896> 1615509 5 commit-queue 2020-02-05 19:36:10 -0800 All reviewed patches have been landed. Closing bug. 389107 2020-01-28 23:04:25 -0800 2020-02-05 19:36:08 -0800 Patch patch.txt text/plain 2829 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA0YjE2NWNjYWQ3Li4xYjNjZDcxM2M0YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMjggIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU29tZSBjb29raWUgdGFibGUgY29sdW1uIGhlYWRlcnMgc2hvdWxkIG5vdCBiZSBsb2NhbGl6 YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 OTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgS2Vl cCBoZWFkZXJzIHRoYXQgbWF0Y2ggY29va2llIGRpcmVjdGl2ZXMgYWx3YXlzIGluIEVuZ2xpc2gu CisKKyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanM6 CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcu anM6CisgICAgICAgIChXSS5Db29raWVTdG9yYWdlQ29udGVudFZpZXcucHJvdG90eXBlLmluaXRp YWxMYXlvdXQpOgorCiAyMDIwLTAxLTIxICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNv bT4KIAogICAgICAgICBGaXggdHZPUyB2YWx1ZXMgaW4gU1VQUE9SVEVEX1BMQVRGT1JNUwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9j YWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2Vu Lmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggMDM4ZTA2NTkzOTcuLmU5YjgyN2RhOTc5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJv ai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6 YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKQEAgLTUxNiw3ICs1MTYsNiBAQCBs b2NhbGl6ZWRTdHJpbmdzWyJFeHBhbmQgQWxsIl0gPSAiRXhwYW5kIEFsbCI7CiBsb2NhbGl6ZWRT dHJpbmdzWyJFeHBhbmQgY29sdW1ucyJdID0gIkV4cGFuZCBjb2x1bW5zIjsKIGxvY2FsaXplZFN0 cmluZ3NbIkV4cGFuZGVkIl0gPSAiRXhwYW5kZWQiOwogbG9jYWxpemVkU3RyaW5nc1siRXhwZXJp bWVudGFsIl0gPSAiRXhwZXJpbWVudGFsIjsKLWxvY2FsaXplZFN0cmluZ3NbIkV4cGlyZXMiXSA9 ICJFeHBpcmVzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkV4cG9ydCJdID0gIkV4cG9ydCI7CiBsb2Nh bGl6ZWRTdHJpbmdzWyJFeHBvcnQgKCVzKSJdID0gIkV4cG9ydCAoJXMpIjsKIGxvY2FsaXplZFN0 cmluZ3NbIkV4cG9ydCBIQVIiXSA9ICJFeHBvcnQgSEFSIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVN0b3JhZ2VDb250ZW50Vmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVN0 b3JhZ2VDb250ZW50Vmlldy5qcwppbmRleCAxNDdmNmQxZTc5OS4uYzEwZjg1M2U5MTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVN0 b3JhZ2VDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanMKQEAgLTE4MCwxOSArMTgwLDE5 IEBAIFdJLkNvb2tpZVN0b3JhZ2VDb250ZW50VmlldyA9IGNsYXNzIENvb2tpZVN0b3JhZ2VDb250 ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWCiAgICAgICAgICAgICBoaWRlYWJsZTogZmFsc2Us CiAgICAgICAgIH0pOwogCi0gICAgICAgIHRoaXMuX2RvbWFpbkNvbHVtbiA9IG5ldyBXSS5UYWJs ZUNvbHVtbigiZG9tYWluIiwgV0kuVUlTdHJpbmcoIkRvbWFpbiIpLCB7CisgICAgICAgIHRoaXMu X2RvbWFpbkNvbHVtbiA9IG5ldyBXSS5UYWJsZUNvbHVtbigiZG9tYWluIiwgV0kudW5sb2NhbGl6 ZWRTdHJpbmcoIkRvbWFpbiIpLCB7CiAgICAgICAgICAgICBtaW5XaWR0aDogMTAwLAogICAgICAg ICAgICAgbWF4V2lkdGg6IDIwMCwKICAgICAgICAgICAgIGluaXRpYWxXaWR0aDogMTIwLAogICAg ICAgICB9KTsKIAotICAgICAgICB0aGlzLl9wYXRoQ29sdW1uID0gbmV3IFdJLlRhYmxlQ29sdW1u KCJwYXRoIiwgV0kuVUlTdHJpbmcoIlBhdGgiKSwgeworICAgICAgICB0aGlzLl9wYXRoQ29sdW1u ID0gbmV3IFdJLlRhYmxlQ29sdW1uKCJwYXRoIiwgV0kudW5sb2NhbGl6ZWRTdHJpbmcoIlBhdGgi KSwgewogICAgICAgICAgICAgbWluV2lkdGg6IDUwLAogICAgICAgICAgICAgbWF4V2lkdGg6IDMw MCwKICAgICAgICAgICAgIGluaXRpYWxXaWR0aDogMTAwLAogICAgICAgICB9KTsKIAotICAgICAg ICB0aGlzLl9leHBpcmVzQ29sdW1uID0gbmV3IFdJLlRhYmxlQ29sdW1uKCJleHBpcmVzIiwgV0ku VUlTdHJpbmcoIkV4cGlyZXMiKSwgeworICAgICAgICB0aGlzLl9leHBpcmVzQ29sdW1uID0gbmV3 IFdJLlRhYmxlQ29sdW1uKCJleHBpcmVzIiwgV0kudW5sb2NhbGl6ZWRTdHJpbmcoIkV4cGlyZXMi KSwgewogICAgICAgICAgICAgbWluV2lkdGg6IDEwMCwKICAgICAgICAgICAgIG1heFdpZHRoOiAy MDAsCiAgICAgICAgICAgICBpbml0aWFsV2lkdGg6IDE1MCwK