206913 2020-01-28 15:56:05 -0800 TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION) 2020-01-28 16:55:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard cdumez commit-queue thorton webkit-bug-importer oldest_to_newest 1612230 0 jbedard 2020-01-28 15:56:05 -0800 It doesn't make sense to attempt to run device orientation tests when on a platform that has DEVICE_ORIENTATION disabled. 1612231 1 webkit-bug-importer 2020-01-28 15:56:52 -0800 <rdar://problem/58973357> 1612233 2 389082 jbedard 2020-01-28 15:58:27 -0800 Created attachment 389082 Patch 1612236 3 389082 cdumez 2020-01-28 16:06:16 -0800 Comment on attachment 389082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389082&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:28 > +#if ENABLE(DEVICE_ORIENTATION) && PLATFORM(IOS_FAMILY) Please update this comment at the end of the file as well: #endif // PLATFORM(IOS_FAMILY) 1612240 4 389084 jbedard 2020-01-28 16:13:05 -0800 Created attachment 389084 Patch for landing 1612263 5 389084 commit-queue 2020-01-28 16:55:28 -0800 Comment on attachment 389084 Patch for landing Clearing flags on attachment: 389084 Committed r255328: <https://trac.webkit.org/changeset/255328> 1612264 6 commit-queue 2020-01-28 16:55:30 -0800 All reviewed patches have been landed. Closing bug. 389082 2020-01-28 15:58:27 -0800 2020-01-28 16:13:03 -0800 Patch bug-206913-20200128155826.patch text/plain 1112 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTMxOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBUZXN0V2ViS2l0QVBJOiBDb25kaXRpb25hbGl6ZSBkZXZpY2Ugb3JpZW50 YXRpb24gdGVzdHMgb24gRU5BQkxFKERFVklDRV9PUklFTlRBVElPTikKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjkxMworICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTg5NzMzNTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0RldmljZU9yaWVu dGF0aW9uLm1tOgorCiAyMDIwLTAxLTI4ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29t PgogCiAgICAgICAgIEluZGV4ZWREQjogc3BlZWQgdXAgaW5kZXggcmVjb3JkcyBkZWxldGlvbgpJ bmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9EZXZpY2VPcmllbnRh dGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL0RldmljZU9yaWVudGF0aW9uLm1tCShyZXZpc2lvbiAyNTUzMTQpCisrKyBUb29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0RldmljZU9yaWVudGF0aW9uLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBACiAKICNpbXBvcnQgImNvbmZpZy5oIgogCi0jaWYgUExB VEZPUk0oSU9TX0ZBTUlMWSkKKyNpZiBFTkFCTEUoREVWSUNFX09SSUVOVEFUSU9OKSAmJiBQTEFU Rk9STShJT1NfRkFNSUxZKQogCiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxpdGllcy5oIgogI2ltcG9y dCAiVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5oIgo= 389084 2020-01-28 16:13:05 -0800 2020-01-28 16:55:28 -0800 Patch for landing bug-206913-20200128161305.patch text/plain 1374 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTMyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBUZXN0V2ViS2l0QVBJOiBDb25kaXRpb25hbGl6ZSBkZXZpY2Ugb3JpZW50 YXRpb24gdGVzdHMgb24gRU5BQkxFKERFVklDRV9PUklFTlRBVElPTikKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjkxMworICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTg5NzMzNTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0RldmljZU9yaWVudGF0 aW9uLm1tOgorCiAyMDIwLTAxLTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KIAogICAgICAgICBUZXN0V2ViS2l0QVBJOiBDb25kaXRpb25hbGl6ZSBRdWlja0xvb2sgdGVz dHMgb24gVVNFKFFVSUNLX0xPT0spCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL0RldmljZU9yaWVudGF0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRGV2aWNlT3JpZW50YXRpb24ubW0JKHJldmlzaW9u IDI1NTMyMCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRGV2aWNl T3JpZW50YXRpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDcgQEAKIAogI2ltcG9y dCAiY29uZmlnLmgiCiAKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQorI2lmIEVOQUJMRShERVZJ Q0VfT1JJRU5UQVRJT04pICYmIFBMQVRGT1JNKElPU19GQU1JTFkpCiAKICNpbXBvcnQgIlBsYXRm b3JtVXRpbGl0aWVzLmgiCiAjaW1wb3J0ICJUZXN0TmF2aWdhdGlvbkRlbGVnYXRlLmgiCkBAIC00 MDIsNCArNDAyLDQgQEAgVEVTVChEZXZpY2VPcmllbnRhdGlvbiwgUGVybWlzc2lvblNlY3VyZQog ICAgIHJ1blBlcm1pc3Npb25TZWN1cmVDb250ZXh0Q2hlY2tUZXN0KFNob3VsZEVuYWJsZVNlY3Vy ZUNvbnRleHRDaGVja3M6Ok5vKTsKIH0KIAotI2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1JTFkp CisjZW5kaWYgLy8gRU5BQkxFKERFVklDRV9PUklFTlRBVElPTikgJiYgUExBVEZPUk0oSU9TX0ZB TUlMWSkK