206907 2020-01-28 14:33:50 -0800 TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK) 2020-01-28 16:07:07 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aestes ap commit-queue thorton webkit-bug-importer oldest_to_newest 1612178 0 jbedard 2020-01-28 14:33:50 -0800 It doesn't make sense to attempt to run QuickLook tests when on a platform that isn't using QuickLook. 1612179 1 webkit-bug-importer 2020-01-28 14:34:15 -0800 <rdar://problem/58969924> 1612182 2 389065 jbedard 2020-01-28 14:37:07 -0800 Created attachment 389065 Patch 1612192 3 389065 ap 2020-01-28 14:46:55 -0800 Comment on attachment 389065 Patch rs=me, please double-check that this macro actually leaves the code enabled for iOS. 1612204 4 jbedard 2020-01-28 15:11:03 -0800 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 389065 [details] > Patch > > rs=me, please double-check that this macro actually leaves the code enabled > for iOS. For reference sake, USE(QUICK_LOOK) is currently defined like so: #if PLATFORM(IOS) #define USE_QUICK_LOOK 1 #endif 1612217 5 389076 jbedard 2020-01-28 15:23:20 -0800 Created attachment 389076 Patch for landing 1612223 6 ap 2020-01-28 15:36:03 -0800 > For reference sake, USE(QUICK_LOOK) is currently defined like so: What I asked to verify was whether the definition was included in this file. 1612237 7 389076 commit-queue 2020-01-28 16:06:32 -0800 Comment on attachment 389076 Patch for landing Clearing flags on attachment: 389076 Committed r255320: <https://trac.webkit.org/changeset/255320> 1612238 8 commit-queue 2020-01-28 16:06:33 -0800 All reviewed patches have been landed. Closing bug. 1612239 9 jbedard 2020-01-28 16:07:07 -0800 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 389065 [details] > Patch > > rs=me, please double-check that this macro actually leaves the code enabled > for iOS. That would also be yes. config.h -> wtf/Platform.h -> wtf/PlatformUse.h 389065 2020-01-28 14:37:07 -0800 2020-01-28 15:23:18 -0800 Patch bug-206907-20200128143706.patch text/plain 1200 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTMxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBUZXN0V2ViS2l0QVBJOiBDb25kaXRpb25hbGl6ZSBRdWlja0xvb2sgdGVz dHMgb24gVVNFKFFVSUNLX0xPT0spCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDY5MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4OTY5OTI0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9RdWlja0xvb2subW06IENvbmRpdGlvbmFsaXplIG9u IFVTRShRVUlDS19MT09LKS4KKwogMjAyMC0wMS0yOCAgSmFtZXMgRGFycGluaWFuICA8amRhcnBp bmlhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUXVvdGUgZmlsZSBhcmd1bWVudCB0byBnaXQg Y2hlY2stYXR0cgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9R dWlja0xvb2subW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9RdWlja0xvb2subW0JKHJldmlzaW9uIDI1NTI2MikKKysrIFRvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUXVpY2tMb29rLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0y NSw3ICsyNSw3IEBACiAKICNpbXBvcnQgImNvbmZpZy5oIgogCi0jaWYgUExBVEZPUk0oSU9TX0ZB TUlMWSkKKyNpZiBVU0UoUVVJQ0tfTE9PSykKIAogI2ltcG9ydCAiUGxhdGZvcm1VdGlsaXRpZXMu aCIKICNpbXBvcnQgIlRlc3QuaCIKQEAgLTUzNiw0ICs1MzYsNCBAQCBURVNUKFF1aWNrTG9vaywg TG9hZEZyb21NZW1vcnlDYWNoZSkKICAgICBbVGVzdFByb3RvY29sIHVucmVnaXN0ZXJdOwogfQog Ci0jZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkKKyNlbmRpZiAvLyBVU0UoUVVJQ0tfTE9P SykK 389076 2020-01-28 15:23:20 -0800 2020-01-28 16:06:32 -0800 Patch for landing bug-206907-20200128152320.patch text/plain 1211 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTMxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBUZXN0V2ViS2l0QVBJOiBDb25kaXRpb25hbGl6ZSBRdWlja0xvb2sgdGVz dHMgb24gVVNFKFFVSUNLX0xPT0spCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDY5MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4OTY5OTI0Pgor CisgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAg ICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1F1aWNrTG9vay5tbTogQ29uZGl0 aW9uYWxpemUgb24gVVNFKFFVSUNLX0xPT0spLgorCiAyMDIwLTAxLTI4ICBKYW1lcyBEYXJwaW5p YW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBRdW90ZSBmaWxlIGFyZ3Vt ZW50IHRvIGdpdCBjaGVjay1hdHRyCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL1F1aWNrTG9vay5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL1F1aWNrTG9vay5tbQkocmV2aXNpb24gMjU1MjYyKQorKysgVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9RdWlja0xvb2subW0JKHdvcmtpbmcg Y29weSkKQEAgLTI1LDcgKzI1LDcgQEAKIAogI2ltcG9ydCAiY29uZmlnLmgiCiAKLSNpZiBQTEFU Rk9STShJT1NfRkFNSUxZKQorI2lmIFVTRShRVUlDS19MT09LKQogCiAjaW1wb3J0ICJQbGF0Zm9y bVV0aWxpdGllcy5oIgogI2ltcG9ydCAiVGVzdC5oIgpAQCAtNTM2LDQgKzUzNiw0IEBAIFRFU1Qo UXVpY2tMb29rLCBMb2FkRnJvbU1lbW9yeUNhY2hlKQogICAgIFtUZXN0UHJvdG9jb2wgdW5yZWdp c3Rlcl07CiB9CiAKLSNlbmRpZiAvLyBQTEFURk9STShJT1NfRkFNSUxZKQorI2VuZGlmIC8vIFVT RShRVUlDS19MT09LKQo=