206899 2020-01-28 11:54:35 -0800 [Web Animations] `DeclarativeAnimation` for CSS Animation is not always destroyed when class that applies `animation-name` is removed 2020-01-29 11:35:28 -0800 1 1 1 Unclassified WebKit Animations WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205434 InRadar P2 Normal --- 205434 1 hi graouts commit-queue dino graouts hi webkit-bug-importer oldest_to_newest 1612095 0 389045 hi 2020-01-28 11:54:35 -0800 Created attachment 389045 [HTML] Reduction Attached a reduction page. I encountered this when trying to debug 'LayoutTests/inspector/animation/lifecycle-css-animation.html', as the test would time out since Web Inspector would never get notified that the web animation had been destroyed, and only noticed it after adding logging inside WebCore. The issue doesn't always reproduce, but it happens fairly often. 1612096 1 webkit-bug-importer 2020-01-28 11:54:52 -0800 <rdar://problem/58963946> 1612394 2 389123 graouts 2020-01-29 05:08:52 -0800 Created attachment 389123 Patch 1612527 3 389123 hi 2020-01-29 10:10:15 -0800 Comment on attachment 389123 Patch r=me I realize I didn't provide an easily testable reduction, but is it possible to write a test for this? Would the `CSSAnimation` be retrievable from JavaScript somehow, so we could check that it no longer exists after this change? 1612532 4 graouts 2020-01-29 10:18:01 -0800 Getting a hold from JS would prevent it from being deref'd. The other option is to make this change in the patch you're working on which introduces a test. 1612573 5 commit-queue 2020-01-29 11:18:46 -0800 The commit-queue encountered the following flaky tests while processing attachment 389123: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1612578 6 commit-queue 2020-01-29 11:19:17 -0800 The commit-queue encountered the following flaky tests while processing attachment 389123: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 201481 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch. 1612588 7 389123 commit-queue 2020-01-29 11:35:27 -0800 Comment on attachment 389123 Patch Clearing flags on attachment: 389123 Committed r255371: <https://trac.webkit.org/changeset/255371> 1612589 8 commit-queue 2020-01-29 11:35:28 -0800 All reviewed patches have been landed. Closing bug. 389045 2020-01-28 11:54:35 -0800 2020-01-28 11:54:35 -0800 [HTML] Reduction reduction.html text/html 827 hi PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHN0eWxlPgpAa2V5ZnJhbWVzIGZhZGUtaW4g ewogICAgZnJvbSB7IGNvbG9yOiByZWQ7IH0KICAgIHRvIHsgY29sb3I6IGJsdWU7IH0KfQpkaXYj dGFyZ2V0LmFjdGl2ZSB7CiAgICBhbmltYXRpb24tbmFtZTogZmFkZS1pbjsKICAgIGFuaW1hdGlv bi1kdXJhdGlvbjogMTAwMHM7Cn0KPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KICAgIDxkaXYgaWQ9 InRhcmdldCI+PC9kaXY+CiAgICA8YnV0dG9uIG9uY2xpY2s9ImRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCd0YXJnZXQnKS5jbGFzc0xpc3QudG9nZ2xlKCdhY3RpdmUnKSI+Q2xpY2sgTWUhPC9idXR0 b24+CiAgICA8b2w+CiAgICAgICAgPGxpPmFkZCBhbnkgbG9nZ2luZyBzdGF0ZW1lbnQgKGUuZy4g PGNvZGU+V1RGUmVwb3J0QmFja3RyYWNlKCk8L2NvZGU+KSB0byA8Y29kZT5+V2ViQW5pbWF0aW9u KCk8L2NvZGU+LjwvbGk+CiAgICAgICAgPGxpPmJ1aWxkPC9saT4KICAgICAgICA8bGk+cmVsb2Fk IHRoaXMgcGFnZTwvbGk+CiAgICAgICAgPGxpPjwvbGk+CiAgICAgICAgPHVsPgogICAgICAgICAg ICA8bGk+Q2xpY2sgdHdpY2UgaW4gcmFwaWQgc3VjY2Vzc2lvbiA9PiBsb2dnaW5nIGZyb20gPGNv ZGU+fldlYkFuaW1hdGlvbigpPC9jb2RlPjwvbGk+CiAgICAgICAgICAgIDxsaT5DbGljayBvbmNl LCB3YWl0IGEgZmV3IHNlY29uZHMsIGNsaWNrIGFnYWluID0+IDxzdHJvbmc+bm88L3N0cm9uZz4g bG9nZ2luZyBmcm9tIDxjb2RlPn5XZWJBbmltYXRpb24oKTwvY29kZT48L2xpPgogICAgICAgIDwv dWw+CiAgICA8L29sPgo8L2JvZHk+CjwvaHRtbD4= 389123 2020-01-29 05:08:52 -0800 2020-01-29 11:35:27 -0800 Patch bug-206899-20200129140850.patch text/plain 1896 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAyZDU2MmJhMGUyNzI0 ODhiOGIyZDc1YzNmYTlmYWM0OGVlZTM5Ni4uNTJmODU0ZTA2MWU4MzdkMmY1MGNjZTVhZGFhMGIw Yjc4NjMyYTBmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTI5ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBgRGVjbGFyYXRpdmVBbmltYXRpb25gIGZvciBDU1MgQW5pbWF0aW9uIGlzIG5vdCBhbHdheXMg ZGVzdHJveWVkIHdoZW4gY2xhc3MgdGhhdCBhcHBsaWVzIGBhbmltYXRpb24tbmFtZWAgaXMgcmVt b3ZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 ODk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4g Y2FzZSBhZnRlciBwcm9jZXNzaW5nIHRoZSBuZXcgYW5pbWF0aW9uIHN0eWxlcyB3ZSBkb24ndCBo YXZlIGFueSBDU1NBbmltYXRpb24gb2JqZWN0cyBhbnltb3JlLCB3ZSBzaG91bGQgbWFrZSBzdXJl IHdlIHJlbW92ZSB0aGUgZW50cnkKKyAgICAgICAgZm9yIHRoaXMgZWxlbWVudCBmcm9tIG1fZWxl bWVudFRvQ1NTQW5pbWF0aW9uc0NyZWF0ZWRCeU1hcmt1cE1hcCBzbyBhcyB0byByZWxlYXNlIG93 bmVyc2hpcCBvZiBhbnkgcHJpb3IgYW5pbWF0aW9uLgorCisgICAgICAgICogYW5pbWF0aW9uL0Fu aW1hdGlvblRpbWVsaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFuaW1hdGlvblRpbWVsaW5l Ojp1cGRhdGVDU1NBbmltYXRpb25zRm9yRWxlbWVudCk6CisKIDIwMjAtMDEtMjggIEFudG9pbmUg UXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIFNl cGFyYXRlIHNldHRpbmcgYSB0aW1lbGluZSdzIGN1cnJlbnQgdGltZSBmcm9tIHVwZGF0aW5nIGl0 cyBhbmltYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQW5pbWF0 aW9uVGltZWxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0FuaW1hdGlvblRpbWVs aW5lLmNwcAppbmRleCAyOTA4NTIwMzgyMTEyZDAzM2Y1NjljMzFhMTdjYzEwNDI5NGJmMDRiLi42 YjlhNDI3MTRmN2RjNTExZGY2Yzk4OGVmMTZiM2RkYjJmNWVlYjUwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9hbmltYXRpb24vQW5pbWF0aW9uVGltZWxpbmUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2FuaW1hdGlvbi9BbmltYXRpb25UaW1lbGluZS5jcHAKQEAgLTMzOCw3ICszMzgsMTEg QEAgdm9pZCBBbmltYXRpb25UaW1lbGluZTo6dXBkYXRlQ1NTQW5pbWF0aW9uc0ZvckVsZW1lbnQo RWxlbWVudCYgZWxlbWVudCwgY29uc3QgUmUKICAgICAgICAgfQogICAgIH0KIAotICAgIG1fZWxl bWVudFRvQ1NTQW5pbWF0aW9uc0NyZWF0ZWRCeU1hcmt1cE1hcC5zZXQoJmVsZW1lbnQsIFdURk1v dmUobmV3QW5pbWF0aW9ucykpOworICAgIGlmIChuZXdBbmltYXRpb25zLmlzRW1wdHkoKSkKKyAg ICAgICAgbV9lbGVtZW50VG9DU1NBbmltYXRpb25zQ3JlYXRlZEJ5TWFya3VwTWFwLnJlbW92ZSgm ZWxlbWVudCk7CisgICAgZWxzZQorICAgICAgICBtX2VsZW1lbnRUb0NTU0FuaW1hdGlvbnNDcmVh dGVkQnlNYXJrdXBNYXAuc2V0KCZlbGVtZW50LCBXVEZNb3ZlKG5ld0FuaW1hdGlvbnMpKTsKKwog ICAgIGtleWZyYW1lRWZmZWN0U3RhY2suc2V0Q1NTQW5pbWF0aW9uTGlzdChjdXJyZW50QW5pbWF0 aW9uTGlzdCk7CiB9CiAK