206849 2020-01-27 16:12:20 -0800 Add WKWebView SPI equivalent of WKView.shouldClipToVisibleRect 2020-01-27 18:21:11 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen commit-queue simon.fraser thorton webkit-bug-importer oldest_to_newest 1611682 0 achristensen 2020-01-27 16:12:20 -0800 Add WKWebView SPI equivalent of WKView.shouldClipToVisibleRect 1611684 1 388934 achristensen 2020-01-27 16:15:16 -0800 Created attachment 388934 Patch 1611715 2 388934 simon.fraser 2020-01-27 17:11:33 -0800 Comment on attachment 388934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388934&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:518 > +@property (nonatomic, readwrite, setter=_setClipsToVisibleRect:) BOOL _clipsToVisibleRect WK_API_AVAILABLE(macos(WK_MAC_TBA)); Please add some explanatory comment in header doc style. I would suggest: _clipsToVisibleRect: When YES, the view will use its -visibleRect when determining which areas of the WKWebView to draw. This may improve performance for large WKWebViews which are mostly clipped out by enclosing views. Should we make this available for iOS too? 1611729 3 388947 achristensen 2020-01-27 17:22:02 -0800 Created attachment 388947 Patch 1611730 4 achristensen 2020-01-27 17:23:25 -0800 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 388934 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388934&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:518 > > +@property (nonatomic, readwrite, setter=_setClipsToVisibleRect:) BOOL _clipsToVisibleRect WK_API_AVAILABLE(macos(WK_MAC_TBA)); > > Please add some explanatory comment in header doc style. I would suggest: > > _clipsToVisibleRect: When YES, the view will use its -visibleRect when > determining which areas of the WKWebView to draw. This may improve > performance for large WKWebViews which are mostly clipped out by enclosing > views. Done! > Should we make this available for iOS too? The boolean value this sets is only used inside of #if PLATFORM(MAC). If requested, we could develop a conceptual equivalent, but this is sufficient for now. 1611769 5 commit-queue 2020-01-27 18:20:09 -0800 The commit-queue encountered the following flaky tests while processing attachment 388947: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1611770 6 388947 commit-queue 2020-01-27 18:20:46 -0800 Comment on attachment 388947 Patch Clearing flags on attachment: 388947 Committed r255220: <https://trac.webkit.org/changeset/255220> 1611771 7 commit-queue 2020-01-27 18:20:48 -0800 All reviewed patches have been landed. Closing bug. 1611773 8 webkit-bug-importer 2020-01-27 18:21:11 -0800 <rdar://problem/58942643> 388934 2020-01-27 16:15:16 -0800 2020-01-27 17:21:59 -0800 Patch bug-206849-20200127161515.patch text/plain 2763 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTUyMDgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAxLTI3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIFdLV2ViVmll dyBTUEkgZXF1aXZhbGVudCBvZiBXS1ZpZXcuc2hvdWxkQ2xpcFRvVmlzaWJsZVJlY3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjg0OQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTg4ODcwMDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQm9va3MgY3VycmVudGx5IHVzZXMgV0tWaWV3LnNldFNob3Vs ZENsaXBUb1Zpc2libGVSZWN0IGFuZCBuZWVkcyB0byBtaWdyYXRlIHRvIFdLV2ViVmlldywgYnV0 IGl0IG5lZWRzIHRvIGRvCisgICAgICAgIHNvIHdpdGhvdXQgbW9kaWZ5aW5nIHRoZSBvdGhlciBw cm9wZXJ0aWVzIGluIF9zZXRNaW5pbXVtTGF5b3V0V2lkdGgsIHdoaWNoIGlzIGN1cnJlbnRseSB0 aGUgb25seSBvdGhlciBjYWxsZXIKKyAgICAgICAgb2YgV2ViVmlld0ltcGw6OnNldENsaXBzVG9W aXNpYmxlUmVjdC4gIEV4cG9zZSBhbiBTUEkgdGhhdCBvbmx5IGNhbGxzIFdlYlZpZXdJbXBsOjpz ZXRDbGlwc1RvVmlzaWJsZVJlY3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld1ByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1dlYlZpZXdN YWMubW06CisgICAgICAgICgtW1dLV2ViVmlldyBfY2xpcHNUb1Zpc2libGVSZWN0XSk6CisgICAg ICAgICgtW1dLV2ViVmlldyBfc2V0Q2xpcHNUb1Zpc2libGVSZWN0Ol0pOgorCiAyMDIwLTAxLTI3 ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiB1bmFibGUgdG8gZXZhbHVhdGUgaW4gdGhlIGlzb2xhdGVkIHdvcmxkIG9mIGNvbnRlbnQg c2NyaXB0cyBpbmplY3RlZCBieSBzYWZhcmkgYXBwIGV4dGVuc2lvbnMKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAko cmV2aXNpb24gMjU1MDkyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld1ByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNTE1LDYgKzUxNSw3IEBAIHR5cGVk ZWYgTlNfT1BUSU9OUyhOU1VJbnRlZ2VyLCBfV0tSZWN0RWQKIEBwcm9wZXJ0eSAobm9uYXRvbWlj LCByZWFkb25seSkgV0tQYWdlUmVmIF9wYWdlUmVmRm9yVHJhbnNpdGlvblRvV0tXZWJWaWV3ICBX S19BUElfQVZBSUxBQkxFKG1hY29zKDEwLjEzLjQpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBy ZWFkb25seSkgQk9PTCBfaGFzQWN0aXZlVmlkZW9Gb3JDb250cm9sc01hbmFnZXIgV0tfQVBJX0FW QUlMQUJMRShtYWNvcygxMC4xMikpOwogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWR3cml0ZSwg c2V0dGVyPV9zZXRJZ25vcmVzTm9uV2hlZWxFdmVudHM6KSBCT09MIF9pZ25vcmVzTm9uV2hlZWxF dmVudHMgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygxMC4xMy40KSk7CitAcHJvcGVydHkgKG5vbmF0 b21pYywgcmVhZHdyaXRlLCBzZXR0ZXI9X3NldENsaXBzVG9WaXNpYmxlUmVjdDopIEJPT0wgX2Ns aXBzVG9WaXNpYmxlUmVjdCBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpKTsKIAog QHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU1ZpZXcgKl9zYWZlQnJvd3NpbmdXYXJu aW5nIFdLX0FQSV9BVkFJTEFCTEUobWFjb3MoMTAuMTQuNCkpOwogCkluZGV4OiBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvbWFjL1dLV2ViVmlld01hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvbWFjL1dLV2ViVmlld01hYy5tbQkocmV2aXNpb24gMjU1 MDkyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL21hYy9XS1dlYlZpZXdNYWMubW0J KHdvcmtpbmcgY29weSkKQEAgLTEzOTgsNiArMTM5OCwxNiBAQCAtICh2b2lkKV9zZXRNaW5pbXVt TGF5b3V0V2lkdGg6KENHRmxvYXQpCiAgICAgX2ltcGwtPnNldENsaXBzVG9WaXNpYmxlUmVjdChl eHBhbmRzVG9GaXQpOwogfQogCistIChCT09MKV9jbGlwc1RvVmlzaWJsZVJlY3QKK3sKKyAgICBy ZXR1cm4gX2ltcGwtPmNsaXBzVG9WaXNpYmxlUmVjdCgpOworfQorCistICh2b2lkKV9zZXRDbGlw c1RvVmlzaWJsZVJlY3Q6KEJPT0wpY2xpcHNUb1Zpc2libGVSZWN0Cit7CisgICAgX2ltcGwtPnNl dENsaXBzVG9WaXNpYmxlUmVjdChjbGlwc1RvVmlzaWJsZVJlY3QpOworfQorCiAtIChCT09MKV9h bHdheXNTaG93c0hvcml6b250YWxTY3JvbGxlcgogewogICAgIHJldHVybiBfcGFnZS0+YWx3YXlz U2hvd3NIb3Jpem9udGFsU2Nyb2xsZXIoKTsK 388947 2020-01-27 17:22:02 -0800 2020-01-27 18:20:46 -0800 Patch bug-206849-20200127172200.patch text/plain 3039 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTUyMTUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAxLTI3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIFdLV2ViVmll dyBTUEkgZXF1aXZhbGVudCBvZiBXS1ZpZXcuc2hvdWxkQ2xpcFRvVmlzaWJsZVJlY3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjg0OQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTg4ODcwMDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24g RnJhc2VyLgorCisgICAgICAgIEJvb2tzIGN1cnJlbnRseSB1c2VzIFdLVmlldy5zZXRTaG91bGRD bGlwVG9WaXNpYmxlUmVjdCBhbmQgbmVlZHMgdG8gbWlncmF0ZSB0byBXS1dlYlZpZXcsIGJ1dCBp dCBuZWVkcyB0byBkbworICAgICAgICBzbyB3aXRob3V0IG1vZGlmeWluZyB0aGUgb3RoZXIgcHJv cGVydGllcyBpbiBfc2V0TWluaW11bUxheW91dFdpZHRoLCB3aGljaCBpcyBjdXJyZW50bHkgdGhl IG9ubHkgb3RoZXIgY2FsbGVyCisgICAgICAgIG9mIFdlYlZpZXdJbXBsOjpzZXRDbGlwc1RvVmlz aWJsZVJlY3QuICBFeHBvc2UgYW4gU1BJIHRoYXQgb25seSBjYWxscyBXZWJWaWV3SW1wbDo6c2V0 Q2xpcHNUb1Zpc2libGVSZWN0LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXdQcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tXZWJWaWV3TWFj Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2NsaXBzVG9WaXNpYmxlUmVjdF0pOgorICAgICAg ICAoLVtXS1dlYlZpZXcgX3NldENsaXBzVG9WaXNpYmxlUmVjdDpdKToKKwogMjAyMC0wMS0yNyAg RGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogY29uc29saWRhdGUgVUlQcm9jZXNzL1dlYlByb2Nlc3MgZmlsZXMgaW50byBJbnNwZWN0b3Ig Zm9sZGVycwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3UHJpdmF0ZS5oCShyZXZpc2lvbiAyNTUwOTIpCisrKyBTb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBA IC01MTYsNiArNTE2LDExIEBAIHR5cGVkZWYgTlNfT1BUSU9OUyhOU1VJbnRlZ2VyLCBfV0tSZWN0 RWQKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQk9PTCBfaGFzQWN0aXZlVmlkZW9G b3JDb250cm9sc01hbmFnZXIgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygxMC4xMikpOwogQHByb3Bl cnR5IChub25hdG9taWMsIHJlYWR3cml0ZSwgc2V0dGVyPV9zZXRJZ25vcmVzTm9uV2hlZWxFdmVu dHM6KSBCT09MIF9pZ25vcmVzTm9uV2hlZWxFdmVudHMgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygx MC4xMy40KSk7CiAKKy8qISBAYWJzdHJhY3QgQSBCb29sZWFuIHZhbHVlIGluZGljYXRpbmcgd2hl dGhlciBkcmF3aW5nIGNsaXBzIHRvIHRoZSB2aXNpYmxlUmVjdC4KK0BkaXNjdXNzaW9uIFdoZW4g WUVTLCB0aGUgdmlldyB3aWxsIHVzZSBpdHMgLXZpc2libGVSZWN0IHdoZW4gZGV0ZXJtaW5pbmcg d2hpY2ggYXJlYXMgb2YgdGhlIFdLV2ViVmlldyB0byBkcmF3LiBUaGlzIG1heSBpbXByb3ZlIHBl cmZvcm1hbmNlIGZvciBsYXJnZSBXS1dlYlZpZXdzIHdoaWNoIGFyZSBtb3N0bHkgY2xpcHBlZCBv dXQgYnkgZW5jbG9zaW5nIHZpZXdzLiAgVGhlIGRlZmF1bHQgdmFsdWUgaXMgTk8uCisqLworQHBy b3BlcnR5IChub25hdG9taWMsIHJlYWR3cml0ZSwgc2V0dGVyPV9zZXRDbGlwc1RvVmlzaWJsZVJl Y3Q6KSBCT09MIF9jbGlwc1RvVmlzaWJsZVJlY3QgV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19N QUNfVEJBKSk7CisKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNWaWV3ICpfc2Fm ZUJyb3dzaW5nV2FybmluZyBXS19BUElfQVZBSUxBQkxFKG1hY29zKDEwLjE0LjQpKTsKIAogQHBy b3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBfV0tSZWN0RWRnZSBfcGlubmVkU3RhdGUgV0tf QVBJX0FWQUlMQUJMRShtYWNvcygxMC4xMy40KSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvbWFjL1dLV2ViVmlld01hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvbWFjL1dLV2ViVmlld01hYy5tbQkocmV2aXNpb24gMjU1MDkyKQorKysg U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL21hYy9XS1dlYlZpZXdNYWMubW0JKHdvcmtpbmcg Y29weSkKQEAgLTEzOTgsNiArMTM5OCwxNiBAQCAtICh2b2lkKV9zZXRNaW5pbXVtTGF5b3V0V2lk dGg6KENHRmxvYXQpCiAgICAgX2ltcGwtPnNldENsaXBzVG9WaXNpYmxlUmVjdChleHBhbmRzVG9G aXQpOwogfQogCistIChCT09MKV9jbGlwc1RvVmlzaWJsZVJlY3QKK3sKKyAgICByZXR1cm4gX2lt cGwtPmNsaXBzVG9WaXNpYmxlUmVjdCgpOworfQorCistICh2b2lkKV9zZXRDbGlwc1RvVmlzaWJs ZVJlY3Q6KEJPT0wpY2xpcHNUb1Zpc2libGVSZWN0Cit7CisgICAgX2ltcGwtPnNldENsaXBzVG9W aXNpYmxlUmVjdChjbGlwc1RvVmlzaWJsZVJlY3QpOworfQorCiAtIChCT09MKV9hbHdheXNTaG93 c0hvcml6b250YWxTY3JvbGxlcgogewogICAgIHJldHVybiBfcGFnZS0+YWx3YXlzU2hvd3NIb3Jp em9udGFsU2Nyb2xsZXIoKTsK