206840 2020-01-27 13:15:03 -0800 Python 3: generate-js-builtins hits SyntaxWarning for "is 0" 2020-01-27 15:24:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned bburg commit-queue ews-watchlist jbedard keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1611548 0 stephan.szabo 2020-01-27 13:15:03 -0800 After switching up to python 3.8, generate-js-builtins.py hits a SyntaxWarning for the use of "is 0". Apparently, per https://bugs.python.org/issue34850 this sort of usage happens to work on CPython by accident, but is not guaranteed to work on other python implementation or necessarily continue working in CPython. The warning suggests replacing is with == for such cases. 1611551 1 388892 stephan.szabo 2020-01-27 13:23:26 -0800 Created attachment 388892 Replace use of "is 0" with "== 0". 1611553 2 ews-watchlist 2020-01-27 13:24:09 -0800 This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`) 1611581 3 388892 bburg 2020-01-27 13:46:24 -0800 Comment on attachment 388892 Replace use of "is 0" with "== 0". rs=me 1611655 4 388892 commit-queue 2020-01-27 15:23:05 -0800 Comment on attachment 388892 Replace use of "is 0" with "== 0". Clearing flags on attachment: 388892 Committed r255186: <https://trac.webkit.org/changeset/255186> 1611656 5 commit-queue 2020-01-27 15:23:06 -0800 All reviewed patches have been landed. Closing bug. 1611657 6 webkit-bug-importer 2020-01-27 15:24:14 -0800 <rdar://problem/58936818> 388892 2020-01-27 13:23:26 -0800 2020-01-27 15:23:05 -0800 Replace use of "is 0" with "== 0". 206840.1.diff text/plain 1330 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUzYTc2YjA0NjVhLi4wZDNkYWFmZjA5MCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDEtMjcgIFN0ZXBo YW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQHNvbnkuY29tPgorCisgICAgICAgIFB5dGhvbiAzOiBn ZW5lcmF0ZS1qcy1idWlsdGlucyBoaXRzIFN5bnRheFdhcm5pbmcgZm9yICJpcyAwIgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2ODQwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2dlbmVy YXRlLWpzLWJ1aWx0aW5zLnB5OiBSZXBsYWNlIGlzIDAgd2l0aCA9PSAwCisKIDIwMjAtMDEtMjcg IEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBPcGVu U291cmNlIGlwaG9uZW9zIGFybTY0ZSBidWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL1NjcmlwdHMvZ2VuZXJhdGUtanMtYnVpbHRpbnMucHkgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvU2NyaXB0cy9nZW5lcmF0ZS1qcy1idWlsdGlucy5weQppbmRleCBkZGU3MjI0YWUyZi4u NTFjNmJlYWQzYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2dl bmVyYXRlLWpzLWJ1aWx0aW5zLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRz L2dlbmVyYXRlLWpzLWJ1aWx0aW5zLnB5CkBAIC0xMzksNyArMTM5LDcgQEAgaWYgX19uYW1lX18g PT0gJ19fbWFpbl9fJzoKICAgICBjbGlfcGFyc2VyLmFkZF9vcHRpb24oIi10IiwgIi0tdGVzdCIs IGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGhlbHA9IkVuYWJsZSB0ZXN0IG1vZGUuIikKIAogICAgIGFy Z19vcHRpb25zLCBhcmdfdmFsdWVzID0gY2xpX3BhcnNlci5wYXJzZV9hcmdzKCkKLSAgICBpZiBs ZW4oYXJnX3ZhbHVlcykgaXMgMCBhbmQgbm90IGFyZ19vcHRpb25zLmlucHV0X2RpcmVjdG9yeToK KyAgICBpZiBsZW4oYXJnX3ZhbHVlcykgPT0gMCBhbmQgbm90IGFyZ19vcHRpb25zLmlucHV0X2Rp cmVjdG9yeToKICAgICAgICAgcmFpc2UgUGFyc2VFeGNlcHRpb24oIkF0IGxlYXN0IG9uZSBpbnB1 dCBmaWxlIG9yIGRpcmVjdG9yeSBleHBlY3RlZC4iKQogCiAgICAgaWYgbm90IGFyZ19vcHRpb25z Lm91dHB1dF9kaXJlY3Rvcnk6Cg==