206833 2020-01-27 10:14:08 -0800 Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage 2020-01-31 11:31:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206389 1 rmorisset rmorisset commit-queue ddkilzer jbedard tuomas.webkit webkit-bug-importer oldest_to_newest 1611455 0 rmorisset 2020-01-27 10:14:08 -0800 https://bugs.webkit.org/show_bug.cgi?id=206389 introduced two options in Tools/Scripts/set-webkit-configuration, but did not adapt the check that at least one valid option is passed. So the following works: set-webkit-configuration --no-asan --no-coverage But the following is rejected: set-webkit-configuration --no-asan. The fix should be trivial. 1611467 1 388872 rmorisset 2020-01-27 10:24:15 -0800 Created attachment 388872 Patch 1611468 2 tuomas.webkit 2020-01-27 10:25:40 -0800 looks good. thank you! 1611511 3 388872 commit-queue 2020-01-27 12:18:49 -0800 Comment on attachment 388872 Patch Clearing flags on attachment: 388872 Committed r255160: <https://trac.webkit.org/changeset/255160> 1611512 4 commit-queue 2020-01-27 12:18:51 -0800 All reviewed patches have been landed. Closing bug. 1611513 5 webkit-bug-importer 2020-01-27 12:19:16 -0800 <rdar://problem/58929211> 388872 2020-01-27 10:24:15 -0800 2020-01-27 12:18:49 -0800 Patch patch206833 text/plain 1352 rmorisset ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZmRj MjYzMWY1NC4uMDYwOTFiZjAyNTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wMS0yNyAgUm9iaW4gTW9yaXNz ZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgorCisgICAgICAgIFRvb2xzL1NjcmlwdHMvc2V0LXdl YmtpdC1jb25maWd1cmF0aW9uIHNob3VsZCBhY2NlcHQgLS1jb3ZlcmFnZS8tLW5vLWNvdmVyYWdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY4MzMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKdXN0IGEg dHJpdmlhbCBmaXggdG8gdGhlIGFyZ3VtZW50cyB2YWxpZGF0aW9uIGNvZGUgb2YgdGhlIHNjcmlw dC4KKworICAgICAgICAqIFNjcmlwdHMvc2V0LXdlYmtpdC1jb25maWd1cmF0aW9uOgorCiAyMDIw LTAxLTIzICBUdW9tYXMgS2Fya2thaW5lbiAgPHR1b21hcy53ZWJraXRAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBtaXNzaW5nIGNvdmVyYWdlLnhjY29uZmlnCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3NldC13ZWJraXQtY29uZmlndXJhdGlvbiBiL1Rvb2xzL1NjcmlwdHMvc2V0LXdlYmtp dC1jb25maWd1cmF0aW9uCmluZGV4IDc2ZjQ2MTFkNGI3Li43MDJiMDE2ZjM1YiAxMDA3NTUKLS0t IGEvVG9vbHMvU2NyaXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24KKysrIGIvVG9vbHMvU2Ny aXB0cy9zZXQtd2Via2l0LWNvbmZpZ3VyYXRpb24KQEAgLTg2LDcgKzg2LDkgQEAgaWYgKGNoZWNr Rm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1yZXNldCIpKSB7CiAgICAgZXhpdCAwOwog fQogCi1pZiAoKCEkY29uZmlndXJhdGlvbiAmJiAhJGFyY2hpdGVjdHVyZSAmJiAhJGVuYWJsZUFT QU4gJiYgISRkaXNhYmxlQVNBTiAmJiAhJGx0b01vZGUgJiYgISRmb3JjZU9wdGltaXphdGlvbkxl dmVsKSB8fCAoJGVuYWJsZUFTQU4gJiYgJGRpc2FibGVBU0FOKSkgeworaWYgKCghJGNvbmZpZ3Vy YXRpb24gJiYgISRhcmNoaXRlY3R1cmUgJiYgISRlbmFibGVBU0FOICYmICEkZGlzYWJsZUFTQU4g JiYgISRlbmFibGVDb3ZlcmFnZSAmJiAhJGRpc2FibGVDb3ZlcmFnZSAmJiAhJGx0b01vZGUgJiYg ISRmb3JjZU9wdGltaXphdGlvbkxldmVsKQorICAgIHx8ICgkZW5hYmxlQVNBTiAmJiAkZGlzYWJs ZUFTQU4pCisgICAgfHwgKCRlbmFibGVDb3ZlcmFnZSAmJiAkZGlzYWJsZUNvdmVyYWdlKSkgewog ICAgIHByaW50IFNUREVSUiAkdXNhZ2U7CiAgICAgZXhpdCAxOwogfQo=