206825 2020-01-27 07:50:19 -0800 webkitpy: Replace StringIO.StringIO in statusserver.py 2020-03-27 15:21:06 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn webkit-bug-importer oldest_to_newest 1611403 0 jbedard 2020-01-27 07:50:19 -0800 This bug was brought to my attention in https://bugs.webkit.org/show_bug.cgi?id=206801, and is apparently not covered in our unit testing. 1611404 1 388858 jbedard 2020-01-27 07:51:50 -0800 Created attachment 388858 Patch 1611405 2 388858 aakash_jain 2020-01-27 07:56:54 -0800 Comment on attachment 388858 Patch This is actually dead code after https://trac.webkit.org/changeset/255123/webkit I plan to delete a lot of code of old EWS after moving commit-queue. But I am fine with fixing this issue meanwhile. 1611409 3 jbedard 2020-01-27 08:00:44 -0800 (In reply to Aakash Jain from comment #2) > Comment on attachment 388858 [details] > Patch > > This is actually dead code after > https://trac.webkit.org/changeset/255123/webkit > I plan to delete a lot of code of old EWS after moving commit-queue. > > But I am fine with fixing this issue meanwhile. Good to know. I'll land this now, but I look forward to the incoming deletion patches! 1611425 4 388858 commit-queue 2020-01-27 08:32:00 -0800 Comment on attachment 388858 Patch Clearing flags on attachment: 388858 Committed r255148: <https://trac.webkit.org/changeset/255148> 1611426 5 commit-queue 2020-01-27 08:32:01 -0800 All reviewed patches have been landed. Closing bug. 1611428 6 webkit-bug-importer 2020-01-27 08:32:13 -0800 <rdar://problem/58919230> 1635025 7 aakash_jain 2020-03-27 15:21:06 -0700 (In reply to Jonathan Bedard from comment #3) > I look forward to the incoming deletion patches! Bug 209683 deletes a lot of code. 388858 2020-01-27 07:51:50 -0800 2020-01-27 08:32:00 -0800 Patch bug-206825-20200127075149.patch text/plain 2045 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTE0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTAxLTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUmVwbGFjZSBTdHJpbmdJTy5TdHJpbmdJTyBpbiBzdGF0 dXNzZXJ2ZXIucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwNjgyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3N0YXR1c3NlcnZlci5weToKKyAgICAg ICAgKFN0YXR1c1NlcnZlci5fdXBsb2FkX2F0dGFjaG1lbnRfdG9fc2VydmVyKTogVGhlIFB5dGhv biAzIGNvbXBhdGlibGUgU3RyaW5nSU8KKyAgICAgICAgb2JqZWN0IGNhbm5vdCBiZSByZWZlcmVu Y2VkIGFzIFN0cmluZ0lPLlN0cmluZ0lPCisKIDIwMjAtMDEtMjYgIFNhaWQgQWJvdS1IYWxsYXdh ICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAgVGhyb3R0bGluZyByZXF1ZXN0QW5pbWF0aW9u RnJhbWUgc2hvdWxkIGJlIGNvbnRyb2xsZWQgYnkgUmVuZGVyaW5nVXBkYXRlU2NoZWR1bGVyCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvc3RhdHVzc2VydmVyLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9zdGF0dXNzZXJ2 ZXIucHkJKHJldmlzaW9uIDI1NTE0NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L25ldC9zdGF0dXNzZXJ2ZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTE0NCwxMCArMTQ0LDEwIEBA IGNsYXNzIFN0YXR1c1NlcnZlcjoKICAgICAgICAgc2VsZi5fYnJvd3Nlci5vcGVuKHVwbG9hZF9h dHRhY2htZW50X3VybCkKICAgICAgICAgc2VsZi5fYnJvd3Nlci5zZWxlY3RfZm9ybShuYW1lPSd1 cGxvYWRfYXR0YWNobWVudCcpCiAgICAgICAgIHNlbGYuX2Jyb3dzZXJbJ2F0dGFjaG1lbnRfaWQn XSA9IHVuaWNvZGUoYXR0YWNobWVudF9pZCkKLSAgICAgICAgc2VsZi5fYnJvd3Nlci5hZGRfZmls ZShTdHJpbmdJTy5TdHJpbmdJTyh1bmljb2RlKGF0dGFjaG1lbnRfbWV0YWRhdGEpKSwgJ2FwcGxp Y2F0aW9uL2pzb24nLCAnYXR0YWNobWVudC17fS1tZXRhZGF0YS5qc29uJy5mb3JtYXQoYXR0YWNo bWVudF9pZCksICdhdHRhY2htZW50X21ldGFkYXRhJykKKyAgICAgICAgc2VsZi5fYnJvd3Nlci5h ZGRfZmlsZShTdHJpbmdJTyh1bmljb2RlKGF0dGFjaG1lbnRfbWV0YWRhdGEpKSwgJ2FwcGxpY2F0 aW9uL2pzb24nLCAnYXR0YWNobWVudC17fS1tZXRhZGF0YS5qc29uJy5mb3JtYXQoYXR0YWNobWVu dF9pZCksICdhdHRhY2htZW50X21ldGFkYXRhJykKICAgICAgICAgaWYgaXNpbnN0YW5jZShhdHRh Y2htZW50X2RhdGEsIHVuaWNvZGUpOgogICAgICAgICAgICAgYXR0YWNobWVudF9kYXRhID0gYXR0 YWNobWVudF9kYXRhLmVuY29kZSgndXRmLTgnKQotICAgICAgICBzZWxmLl9icm93c2VyLmFkZF9m aWxlKFN0cmluZ0lPLlN0cmluZ0lPKGF0dGFjaG1lbnRfZGF0YSksICd0ZXh0L3BsYWluJywgJ2F0 dGFjaG1lbnQte30ucGF0Y2gnLmZvcm1hdChhdHRhY2htZW50X2lkKSwgJ2F0dGFjaG1lbnRfZGF0 YScpCisgICAgICAgIHNlbGYuX2Jyb3dzZXIuYWRkX2ZpbGUoU3RyaW5nSU8oYXR0YWNobWVudF9k YXRhKSwgJ3RleHQvcGxhaW4nLCAnYXR0YWNobWVudC17fS5wYXRjaCcuZm9ybWF0KGF0dGFjaG1l bnRfaWQpLCAnYXR0YWNobWVudF9kYXRhJykKICAgICAgICAgc2VsZi5fYnJvd3Nlci5zdWJtaXQo KQogCiAgICAgZGVmIHVwbG9hZF9hdHRhY2htZW50KHNlbGYsIGF0dGFjaG1lbnQpOgo=