206819 2020-01-26 23:49:09 -0800 [Web Animations] Update all DocumentTimeline objects when updating animations 2020-01-27 04:02:18 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts cdumez dbates dino esprehn+autocc ews-watchlist kangil.han koivisto simon.fraser webkit-bug-importer oldest_to_newest 1611317 0 graouts 2020-01-26 23:49:09 -0800 [Web Animations] Update all DocumentTimeline objects when updating animations 1611319 1 388835 graouts 2020-01-26 23:52:02 -0800 Created attachment 388835 Patch 1611345 2 388835 koivisto 2020-01-27 02:41:32 -0800 Comment on attachment 388835 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388835&action=review > Source/WebCore/dom/Document.h:2042 > + Vector<WeakPtr<DocumentTimeline>> m_timelines; You might want to use WeakHashSet instead if ordering doesn't matter. 1611357 3 graouts 2020-01-27 04:01:31 -0800 Committed r255141: <https://trac.webkit.org/changeset/255141> 1611358 4 webkit-bug-importer 2020-01-27 04:02:18 -0800 <rdar://problem/58914325> 388835 2020-01-26 23:52:02 -0800 2020-01-27 02:41:32 -0800 Patch bug-206819-20200127085201.patch text/plain 7316 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ5Mjg1NDUzNzk5NTM0 ZDY1YmM4NDk0NGEwNmM4YmRlMTQ5MDMwNy4uMTVhMzc1ZWU3NzRiYmQyZDUyYmU2YTQ3OGU5ODlh ZmY1MmNlZDhmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTAxLTI2ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBVcGRhdGUgYWxsIERvY3VtZW50VGltZWxpbmUgb2JqZWN0cyB3aGVuIHVwZGF0aW5nIGFuaW1h dGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NjgxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERl dmVsb3BlcnMgY2FuIGNyZWF0ZSBhZGRpdGlvbmFsIERvY3VtZW50VGltZWxpbmUgb2JqZWN0cyBp biBKYXZhU2NyaXB0IHVzaW5nIHRoYXQgY2xhc3MncyBjb25zdHJ1Y3RvciwgYW5kIGFuIGFuaW1h dGlvbiBjYW4gYmUKKyAgICAgICAgYXNzaWduZWQgdG8gdGhhdCB0aW1lbGluZSBhZnRlciBpdHMg Y3JlYXRpb24uIFVudGlsIG5vdyB3ZSB3b3VsZCBvbmx5IHVwZGF0ZSBhbiB0aW1lbGluZSBjcmVh dGVkIGJ5IGEgRG9jdW1lbnQgd2hlbiB0aGF0IGRvY3VtZW50J3MKKyAgICAgICAgYW5pbWF0aW9u cyB3ZXJlIHVwZGF0ZWQuIE5vdyB3ZSBrZWVwIHRyYWNrIG9mIGFsbCBEb2N1bWVudFRpbWVsaW5l IG9iamVjdHMgdGhhdCBhcmUgY3JlYXRlZCBmb3IgYSBnaXZlbiBEb2N1bWVudCBhcyBhIHZlY3Rv ciBvZiB3ZWFrCisgICAgICAgIHJlZmVyZW5jZXMsIGFuZCB3ZSB1cGRhdGUgYWxsIG9mIHRoZW0g d2hlbiB1cGRhdGluZyBhIGRvY3VtZW50J3MgYW5pbWF0aW9ucy4KKworICAgICAgICAqIGFuaW1h dGlvbi9Eb2N1bWVudFRpbWVsaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50VGlt ZWxpbmU6OkRvY3VtZW50VGltZWxpbmUpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRUaW1l bGluZTo6fkRvY3VtZW50VGltZWxpbmUpOgorICAgICAgICAqIGFuaW1hdGlvbi9Eb2N1bWVudFRp bWVsaW5lLmg6CisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkRvY3VtZW50Ojp1cGRhdGVBbmltYXRpb25zQW5kU2VuZEV2ZW50cyk6CisgICAgICAgIChXZWJD b3JlOjpEb2N1bWVudDo6YWRkVGltZWxpbmUpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6 OnJlbW92ZVRpbWVsaW5lKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKwogMjAyMC0wMS0y NCAgSmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBOdWxsIFB0 ciBEZXJlZiBSRUFEIEAgV2ViQ29yZTo6UmVuZGVyTXVsdGlDb2x1bW5GbG93OjpsYXN0TXVsdGlD b2x1bW5TZXQgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1 bWVudFRpbWVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1bWVudFRpbWVs aW5lLmNwcAppbmRleCAxOGRiMDkxZGFjMzk5ZTFmNDk4MzZlZGY4OGNlNGQyN2VjMGJkZjVkLi5i ZGNlMzZhYWZhNDZjZjkxY2NmZTliZDZmYzIyMTk4ZDk0YmY2ZGU4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9hbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYW5pbWF0aW9uL0RvY3VtZW50VGltZWxpbmUuY3BwCkBAIC02NSwxMSArNjUsMTcgQEAg RG9jdW1lbnRUaW1lbGluZTo6RG9jdW1lbnRUaW1lbGluZShEb2N1bWVudCYgZG9jdW1lbnQsIFNl Y29uZHMgb3JpZ2luVGltZSkKICAgICAsIG1fZG9jdW1lbnQoJmRvY3VtZW50KQogICAgICwgbV9v cmlnaW5UaW1lKG9yaWdpblRpbWUpCiB7CisgICAgaWYgKG1fZG9jdW1lbnQpCisgICAgICAgIG1f ZG9jdW1lbnQtPmFkZFRpbWVsaW5lKCp0aGlzKTsKICAgICBpZiAobV9kb2N1bWVudCAmJiBtX2Rv Y3VtZW50LT5wYWdlKCkgJiYgIW1fZG9jdW1lbnQtPnBhZ2UoKS0+aXNWaXNpYmxlKCkpCiAgICAg ICAgIHN1c3BlbmRBbmltYXRpb25zKCk7CiB9CiAKLURvY3VtZW50VGltZWxpbmU6On5Eb2N1bWVu dFRpbWVsaW5lKCkgPSBkZWZhdWx0OworRG9jdW1lbnRUaW1lbGluZTo6fkRvY3VtZW50VGltZWxp bmUoKQoreworICAgIGlmIChtX2RvY3VtZW50KQorICAgICAgICBtX2RvY3VtZW50LT5yZW1vdmVU aW1lbGluZSgqdGhpcyk7Cit9CiAKIHZvaWQgRG9jdW1lbnRUaW1lbGluZTo6ZGV0YWNoRnJvbURv Y3VtZW50KCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Eb2N1bWVu dFRpbWVsaW5lLmggYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRG9jdW1lbnRUaW1lbGluZS5o CmluZGV4IDJjMzVkMjQ1NjgyZmRiNTMzNzM3ZTA1Mzk5MTQ4NDZhNjA2ODU3NmEuLmZjN2M2YWYw ZmQzZTgwN2I0MWZiMTdjMTdiOGQxNjYzMTVmYjI1M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FuaW1hdGlvbi9Eb2N1bWVudFRpbWVsaW5lLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYW5p bWF0aW9uL0RvY3VtZW50VGltZWxpbmUuaApAQCAtMzEsMTMgKzMxLDE0IEBACiAjaW5jbHVkZSAi VGltZXIuaCIKICNpbmNsdWRlIDx3dGYvTWFya2FibGUuaD4KICNpbmNsdWRlIDx3dGYvUmVmLmg+ CisjaW5jbHVkZSA8d3RmL1dlYWtQdHIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFz cyBBbmltYXRpb25QbGF5YmFja0V2ZW50OwogY2xhc3MgUmVuZGVyRWxlbWVudDsKIAotY2xhc3Mg RG9jdW1lbnRUaW1lbGluZSBmaW5hbCA6IHB1YmxpYyBBbmltYXRpb25UaW1lbGluZQorY2xhc3Mg RG9jdW1lbnRUaW1lbGluZSBmaW5hbCA6IHB1YmxpYyBBbmltYXRpb25UaW1lbGluZSwgcHVibGlj IENhbk1ha2VXZWFrUHRyPERvY3VtZW50VGltZWxpbmU+CiB7CiBwdWJsaWM6CiAgICAgc3RhdGlj IFJlZjxEb2N1bWVudFRpbWVsaW5lPiBjcmVhdGUoRG9jdW1lbnQmKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCmluZGV4IGNlOWFhYmM1ZDkwNmE5ZWU2MGNlMWNlMmY4OGFhNTkwYzUyNTI5MmUuLjZi YTBlMjJmYTMxNzI1YWNkODlhYWFlNGNkNzI2Y2UzNWJhY2UxOWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcApAQCAtNjM1Miw4ICs2MzUyLDEwIEBAIHZvaWQgRG9jdW1lbnQ6OnJlc3VtZVNjcmlw dGVkQW5pbWF0aW9uQ29udHJvbGxlckNhbGxiYWNrcygpCiAKIHZvaWQgRG9jdW1lbnQ6OnVwZGF0 ZUFuaW1hdGlvbnNBbmRTZW5kRXZlbnRzKERPTUhpZ2hSZXNUaW1lU3RhbXAgdGltZXN0YW1wKQog ewotICAgIGlmIChtX3RpbWVsaW5lKQotICAgICAgICBtX3RpbWVsaW5lLT51cGRhdGVBbmltYXRp b25zQW5kU2VuZEV2ZW50cyh0aW1lc3RhbXApOworICAgIGZvciAoYXV0byYgdGltZWxpbmUgOiBt X3RpbWVsaW5lcykgeworICAgICAgICBpZiAodGltZWxpbmUpCisgICAgICAgICAgICB0aW1lbGlu ZS0+dXBkYXRlQW5pbWF0aW9uc0FuZFNlbmRFdmVudHModGltZXN0YW1wKTsKKyAgICB9CiB9CiAK IHZvaWQgRG9jdW1lbnQ6OnNlcnZpY2VSZXF1ZXN0QW5pbWF0aW9uRnJhbWVDYWxsYmFja3MoRE9N SGlnaFJlc1RpbWVTdGFtcCB0aW1lc3RhbXApCkBAIC04MDQxLDYgKzgwNDMsMTYgQEAgdm9pZCBE b2N1bWVudDo6c2V0Q29uc29sZU1lc3NhZ2VMaXN0ZW5lcihSZWZQdHI8U3RyaW5nQ2FsbGJhY2s+ JiYgbGlzdGVuZXIpCiAgICAgbV9jb25zb2xlTWVzc2FnZUxpc3RlbmVyID0gbGlzdGVuZXI7CiB9 CiAKK3ZvaWQgRG9jdW1lbnQ6OmFkZFRpbWVsaW5lKERvY3VtZW50VGltZWxpbmUmIHRpbWVsaW5l KQoreworICAgIG1fdGltZWxpbmVzLmFwcGVuZChtYWtlV2Vha1B0cigmdGltZWxpbmUpKTsKK30K Kwordm9pZCBEb2N1bWVudDo6cmVtb3ZlVGltZWxpbmUoRG9jdW1lbnRUaW1lbGluZSYgdGltZWxp bmUpCit7CisgICAgbV90aW1lbGluZXMucmVtb3ZlRmlyc3QoJnRpbWVsaW5lKTsKK30KKwogRG9j dW1lbnRUaW1lbGluZSYgRG9jdW1lbnQ6OnRpbWVsaW5lKCkKIHsKICAgICBpZiAoIW1fdGltZWxp bmUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDNhY2I2MjJjOWRmMjBhZTRiNjIyYjdkZjhjZTVm Y2Q5ODkxNTBmMzEuLmY2NzRmMzM5NTlmYjVjNTk1NTRhYzRhZjExZTJlYjI1M2UxYmE5ZTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0xNDcxLDYgKzE0NzEsOCBAQCBwdWJsaWM6CiAKICAgICBX RUJDT1JFX0VYUE9SVCB2b2lkIHNldENvbnNvbGVNZXNzYWdlTGlzdGVuZXIoUmVmUHRyPFN0cmlu Z0NhbGxiYWNrPiYmKTsgLy8gRm9yIHRlc3RpbmcuCiAKKyAgICB2b2lkIGFkZFRpbWVsaW5lKERv Y3VtZW50VGltZWxpbmUmKTsKKyAgICB2b2lkIHJlbW92ZVRpbWVsaW5lKERvY3VtZW50VGltZWxp bmUmKTsKICAgICBXRUJDT1JFX0VYUE9SVCBEb2N1bWVudFRpbWVsaW5lJiB0aW1lbGluZSgpOwog ICAgIERvY3VtZW50VGltZWxpbmUqIGV4aXN0aW5nVGltZWxpbmUoKSBjb25zdCB7IHJldHVybiBt X3RpbWVsaW5lLmdldCgpOyB9CiAgICAgVmVjdG9yPFJlZlB0cjxXZWJBbmltYXRpb24+PiBnZXRB bmltYXRpb25zKCk7CkBAIC0yMDM3LDYgKzIwMzksOCBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBi b29sIGhhc0V2ZXJDcmVhdGVkQW5BWE9iamVjdENhY2hlOwogCiAgICAgUmVmUHRyPERvY3VtZW50 VGltZWxpbmU+IG1fdGltZWxpbmU7CisgICAgVmVjdG9yPFdlYWtQdHI8RG9jdW1lbnRUaW1lbGlu ZT4+IG1fdGltZWxpbmVzOworCiAgICAgRG9jdW1lbnRJZGVudGlmaWVyIG1faWRlbnRpZmllcjsK IAogICAgIFJlZlB0cjxXaW5kb3dFdmVudExvb3A+IG1fZXZlbnRMb29wOwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy9DaGFuZ2VMb2cKaW5kZXggZTI2MzA0MmY3ZmE1YzkyZTlhNGQ0ZmFlZTVhOGUwN2NmNzZh NWVjNC4uODk0NzM1ZDFmY2Y4ZDFhNjIwMjQxNjkzODFkYTBkZmFlYzg5Zjk4NCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDEtMjYgIEFudG9p bmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViIEFuaW1hdGlvbnNd IFVwZGF0ZSBhbGwgRG9jdW1lbnRUaW1lbGluZSBvYmplY3RzIHdoZW4gdXBkYXRpbmcgYW5pbWF0 aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 ODE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFy ayBhIHNpbmdsZSBuZXcgV1BUIHByb2dyZXNzaW9uLgorCisgICAgICAgICogd2ViLXBsYXRmb3Jt LXRlc3RzL3dlYi1hbmltYXRpb25zL3RpbWluZy1tb2RlbC90aW1lbGluZXMvdXBkYXRlLWFuZC1z ZW5kLWV2ZW50cy1yZXBsYWNlbWVudC1leHBlY3RlZC50eHQ6CisKIDIwMjAtMDEtMjQgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBN ZWRpYVJlY29yZGVyLnJlcXVlc3REYXRhCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYi1hbmltYXRpb25zL3RpbWluZy1tb2RlbC90aW1l bGluZXMvdXBkYXRlLWFuZC1zZW5kLWV2ZW50cy1yZXBsYWNlbWVudC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYi1hbmltYXRpb25z L3RpbWluZy1tb2RlbC90aW1lbGluZXMvdXBkYXRlLWFuZC1zZW5kLWV2ZW50cy1yZXBsYWNlbWVu dC1leHBlY3RlZC50eHQKaW5kZXggZDc0OGI3YzgyYTU5YjY2Njc5N2ZjZTcwMGZmNzllMGRjZTBk NTlmMC4uOTRjNjYwZmM0NDVkODZjZGI4YWE2MzVjNzM3YzQyOTZlN2JhZGI0ZSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0 aW9ucy90aW1pbmctbW9kZWwvdGltZWxpbmVzL3VwZGF0ZS1hbmQtc2VuZC1ldmVudHMtcmVwbGFj ZW1lbnQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvd2ViLWFuaW1hdGlvbnMvdGltaW5nLW1vZGVsL3RpbWVsaW5lcy91cGRhdGUt YW5kLXNlbmQtZXZlbnRzLXJlcGxhY2VtZW50LWV4cGVjdGVkLnR4dApAQCAtMzgsNyArMzgsNyBA QCBQQVNTIERvZXMgTk9UIHJlbW92ZSBhbiBhbmltYXRpb24gYWZ0ZXIgbWFraW5nIGEgcmVkdW5k YW50IGNoYW5nZSB0byBhbm90aGVyIGFuaQogUEFTUyBEb2VzIE5PVCByZW1vdmUgYW4gYW5pbWF0 aW9uIGFmdGVyIG1ha2luZyBhIHJlZHVuZGFudCBjaGFuZ2UgdG8gaXRzIHRpbWVsaW5lIAogUEFT UyBEb2VzIE5PVCByZW1vdmUgYW4gYW5pbWF0aW9uIGFmdGVyIG1ha2luZyBhIHJlZHVuZGFudCBj aGFuZ2UgdG8gYW5vdGhlciBhbmltYXRpb24ncyBlZmZlY3QncyBwcm9wZXJ0aWVzIAogUEFTUyBE b2VzIE5PVCByZW1vdmUgYW4gYW5pbWF0aW9uIGFmdGVyIG1ha2luZyBhIHJlZHVuZGFudCBjaGFu Z2UgdG8gaXRzIGVmZmVjdCdzIHByb3BlcnRpZXMgCi1GQUlMIFVwZGF0ZXMgQUxMIHRpbWVsaW5l cyBiZWZvcmUgY2hlY2tpbmcgZm9yIHJlcGxhY2VtZW50IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVk ICJyZW1vdmVkIiBidXQgZ290ICJhY3RpdmUiCitQQVNTIFVwZGF0ZXMgQUxMIHRpbWVsaW5lcyBi ZWZvcmUgY2hlY2tpbmcgZm9yIHJlcGxhY2VtZW50IAogUEFTUyBEaXNwYXRjaGVzIHJlbW92ZSBl dmVudHMgYWZ0ZXIgZmluaXNoIGV2ZW50cyAKIFBBU1MgRmlyZXMgcmVtb3ZlIGV2ZW50IGJlZm9y ZSByZXF1ZXN0QW5pbWF0aW9uRnJhbWUgCiBQQVNTIFF1ZXVlcyBhbGwgcmVtb3ZlIGV2ZW50cyBi ZWZvcmUgcnVubmluZyB0aGVtIAo=