206815 2020-01-26 21:11:05 -0800 Move DOMCacheEngine::errorToException back out of header and into .cpp file 2020-01-26 22:28:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 darin darin commit-queue mark.lam webkit-bug-importer oldest_to_newest 1611276 0 darin 2020-01-26 21:11:05 -0800 Move DOMCacheEngine::errorToException back out of header and into .cpp file 1611277 1 388822 darin 2020-01-26 21:13:39 -0800 Created attachment 388822 Patch 1611279 2 388822 mark.lam 2020-01-26 21:16:41 -0800 Comment on attachment 388822 Patch r=me 1611301 3 commit-queue 2020-01-26 22:27:12 -0800 The commit-queue encountered the following flaky tests while processing attachment 388822: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1611302 4 388822 commit-queue 2020-01-26 22:27:43 -0800 Comment on attachment 388822 Patch Clearing flags on attachment: 388822 Committed r255136: <https://trac.webkit.org/changeset/255136> 1611303 5 commit-queue 2020-01-26 22:27:45 -0800 All reviewed patches have been landed. Closing bug. 1611304 6 webkit-bug-importer 2020-01-26 22:28:14 -0800 <rdar://problem/58909465> 388822 2020-01-26 21:13:39 -0800 2020-01-26 22:27:43 -0800 Patch bug-206815-20200126211333.patch text/plain 5771 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmE0ZDk3NDUxYjMyMzM1 ZDg3M2U1MzhmZjk1NTE4ZDQ3NDNlNjJiMS4uZDJmMjk1YTZmMDE2MGFmZDY0YTU1YjYyMWMzNTQ5 NThkMzRkZjZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTAxLTI2ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIERPTUNhY2hlRW5naW5l OjplcnJvclRvRXhjZXB0aW9uIGJhY2sgb3V0IG9mIGhlYWRlciBhbmQgaW50byAuY3BwIGZpbGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjgxNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMg YSBmb2xsb3ctdXAgdG8gYSByZWNlbnQgYnVpbGQgZml4IHRoYXQgbW92ZWQgYSBmdW5jdGlvbiwg ZXJyb3JUb0V4Y2VwdGlvbiwKKyAgICAgICAgb3V0IG9mIGEgLmNwcCBmaWxlIGFuZCBpbnRvIGEg aGVhZGVyIGZpbGUuIFRoaXMgcmV2ZXJzZXMgdGhhdCBzaW5jZSB3ZSBkb24ndCBuZWVkCisgICAg ICAgIHRoaXMgZnVuY3Rpb24gdG8gYmUgaW5saW5lZC4KKworICAgICAgICAqIE1vZHVsZXMvY2Fj aGUvRE9NQ2FjaGVFbmdpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NQ2FjaGVFbmdpbmU6 OmNvbnZlcnRUb0V4Y2VwdGlvbik6IE1vdmVkIHRoaXMgZnVuY3Rpb24gZnJvbSB0aGUgaGVhZGVy CisgICAgICAgIGFuZCByZW5hbWVkIGl0IGZyb20gZXJyb3JUb0V4Y2VwdGlvbiB0byBtYXRjaCB0 aGUgb3RoZXIgZnVuY3Rpb24gbW9yZSBjbG9zZWx5LiBBbHNvCisgICAgICAgIHVzZSB0aGUgcGF0 dGVybiB3aGVyZSB0aGUgc3dpdGNoIHN0YXRlbWVudCBoYXMgbm8gZGVmYXVsdCwgc28gd2UgZ2V0 IGEgd2FybmluZyBpZgorICAgICAgICB3ZSBkb24ndCBjb3ZlciBhbGwgdGhlIGVudW0gdmFsdWVz LgorICAgICAgICAoV2ViQ29yZTo6RE9NQ2FjaGVFbmdpbmU6OmNvbnZlcnRUb0V4Y2VwdGlvbkFu ZExvZyk6IFVwZGF0ZWQgZm9yIG5ldyBmdW5jdGlvbiBuYW1lLgorCisgICAgICAgICogTW9kdWxl cy9jYWNoZS9ET01DYWNoZUVuZ2luZS5oOiBSZW1vdmVkIHRoZSBkZWZpbml0aW9uIG9mIGVycm9y VG9FeGNlcHRpb24gYW5kCisgICAgICAgIHJlcGxhY2VkIGl0IHdpdGggdGhlIGRlY2xhcmF0aW9u IG9mIGl0IHVuZGVyIGl0cyBuZXcgbmFtZSwgY29udmVydFRvRXhjZXB0aW9uLgorCisgICAgICAg ICogTW9kdWxlcy9jYWNoZS9ET01DYWNoZVN0b3JhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RE9NQ2FjaGVTdG9yYWdlOjpyZXRyaWV2ZUNhY2hlcyk6IFVwZGF0ZWQgZm9yIG5ldyBmdW5jdGlv biBuYW1lLgorCiAyMDIwLTAxLTI1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAog ICAgICAgICBUaWdodGVuIHVwIHNvbWUgb2YgdGhlIGRyYWcgc3RhdGUgbWFjaGluZSBsb2dpYwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01DYWNoZUVuZ2luZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlRW5naW5lLmNwcAppbmRl eCBiN2IyZDgwMGQyNzE5NmJhMDQzMjM1NjFiYjM5MmNmZGVhYjQ2NjA2Li4wMjFkMTAzZTU2YTNk ZWM5ZDlkMDNmMjNiYjYwYjMwMzYwNjBmY2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2NhY2hlL0RPTUNhY2hlRW5naW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2NhY2hlL0RPTUNhY2hlRW5naW5lLmNwcApAQCAtMzUsOSArMzUsMjkgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogCiBuYW1lc3BhY2UgRE9NQ2FjaGVFbmdpbmUgewogCitFeGNlcHRpb24gY29u dmVydFRvRXhjZXB0aW9uKEVycm9yIGVycm9yKQoreworICAgIHN3aXRjaCAoZXJyb3IpIHsKKyAg ICBjYXNlIEVycm9yOjpOb3RJbXBsZW1lbnRlZDoKKyAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7 IE5vdFN1cHBvcnRlZEVycm9yLCAiTm90IGltcGxlbWVudGVkIl9zIH07CisgICAgY2FzZSBFcnJv cjo6UmVhZERpc2s6CisgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBUeXBlRXJyb3IsICJGYWls ZWQgcmVhZGluZyBkYXRhIGZyb20gdGhlIGZpbGUgc3lzdGVtIl9zIH07CisgICAgY2FzZSBFcnJv cjo6V3JpdGVEaXNrOgorICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgVHlwZUVycm9yLCAiRmFp bGVkIHdyaXRpbmcgZGF0YSB0byB0aGUgZmlsZSBzeXN0ZW0iX3MgfTsKKyAgICBjYXNlIEVycm9y OjpRdW90YUV4Y2VlZGVkOgorICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgUXVvdGFFeGNlZWRl ZEVycm9yLCAiUXVvdGEgZXhjZWVkZWQiX3MgfTsKKyAgICBjYXNlIEVycm9yOjpJbnRlcm5hbDoK KyAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IFR5cGVFcnJvciwgIkludGVybmFsIGVycm9yIl9z IH07CisgICAgY2FzZSBFcnJvcjo6U3RvcHBlZDoKKyAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7 IFR5cGVFcnJvciwgIkNvbnRleHQgaXMgc3RvcHBlZCJfcyB9OworICAgIH0KKyAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gRXhjZXB0aW9uIHsgVHlwZUVycm9yLCAiQ29ubmVj dGlvbiBzdG9wcGVkIl9zIH07Cit9CisKIEV4Y2VwdGlvbiBjb252ZXJ0VG9FeGNlcHRpb25BbmRM b2coU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgRXJyb3IgZXJyb3IpCiB7Ci0gICAg YXV0byBleGNlcHRpb24gPSBlcnJvclRvRXhjZXB0aW9uKGVycm9yKTsKKyAgICBhdXRvIGV4Y2Vw dGlvbiA9IGNvbnZlcnRUb0V4Y2VwdGlvbihlcnJvcik7CiAgICAgaWYgKGNvbnRleHQpCiAgICAg ICAgIGNvbnRleHQtPmFkZENvbnNvbGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6OkpTLCBNZXNzYWdl TGV2ZWw6OkVycm9yLCBtYWtlU3RyaW5nKCJDYWNoZSBBUEkgb3BlcmF0aW9uIGZhaWxlZDogIiwg ZXhjZXB0aW9uLm1lc3NhZ2UoKSkpOwogICAgIHJldHVybiBleGNlcHRpb247CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlRW5naW5lLmggYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlRW5naW5lLmgKaW5kZXggN2Q4ZThkZDAzMGYy Y2YxMzVkYTI5NTYyMTYwZDE1YTZkYzM4MDM3Yy4uNDk1OTRlNTgyYjgwMWM2NzFkYzViMjM5MDdh YTAwZjJjODRkMzFlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9E T01DYWNoZUVuZ2luZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2Fj aGVFbmdpbmUuaApAQCAtMzAsMTIgKzMwLDEzIEBACiAjaW5jbHVkZSAiRmV0Y2hPcHRpb25zLmgi CiAjaW5jbHVkZSAiUmVzb3VyY2VSZXF1ZXN0LmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VSZXNwb25z ZS5oIgotI2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCIKICNpbmNsdWRlICJTaGFy ZWRCdWZmZXIuaCIKICNpbmNsdWRlIDx3dGYvQ29tcGxldGlvbkhhbmRsZXIuaD4KIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCitjbGFzcyBTY3JpcHRFeGVjdXRpb25Db250ZXh0OworCiBzdHJ1Y3Qg Q2FjaGVRdWVyeU9wdGlvbnM7CiAKIG5hbWVzcGFjZSBET01DYWNoZUVuZ2luZSB7CkBAIC00OSwy NyArNTAsNyBAQCBlbnVtIGNsYXNzIEVycm9yIHsKICAgICBTdG9wcGVkCiB9OwogCi1zdGF0aWMg aW5saW5lIEV4Y2VwdGlvbiBlcnJvclRvRXhjZXB0aW9uKEVycm9yIGVycm9yKQotewotICAgIHN3 aXRjaCAoZXJyb3IpIHsKLSAgICBjYXNlIEVycm9yOjpOb3RJbXBsZW1lbnRlZDoKLSAgICAgICAg cmV0dXJuIEV4Y2VwdGlvbiB7IE5vdFN1cHBvcnRlZEVycm9yLCAiTm90IGltcGxlbWVudGVkIl9z IH07Ci0gICAgY2FzZSBFcnJvcjo6UmVhZERpc2s6Ci0gICAgICAgIHJldHVybiBFeGNlcHRpb24g eyBUeXBlRXJyb3IsICJGYWlsZWQgcmVhZGluZyBkYXRhIGZyb20gdGhlIGZpbGUgc3lzdGVtIl9z IH07Ci0gICAgY2FzZSBFcnJvcjo6V3JpdGVEaXNrOgotICAgICAgICByZXR1cm4gRXhjZXB0aW9u IHsgVHlwZUVycm9yLCAiRmFpbGVkIHdyaXRpbmcgZGF0YSB0byB0aGUgZmlsZSBzeXN0ZW0iX3Mg fTsKLSAgICBjYXNlIEVycm9yOjpRdW90YUV4Y2VlZGVkOgotICAgICAgICByZXR1cm4gRXhjZXB0 aW9uIHsgUXVvdGFFeGNlZWRlZEVycm9yLCAiUXVvdGEgZXhjZWVkZWQiX3MgfTsKLSAgICBjYXNl IEVycm9yOjpJbnRlcm5hbDoKLSAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IFR5cGVFcnJvciwg IkludGVybmFsIGVycm9yIl9zIH07Ci0gICAgY2FzZSBFcnJvcjo6U3RvcHBlZDoKLSAgICAgICAg cmV0dXJuIEV4Y2VwdGlvbiB7IFR5cGVFcnJvciwgIkNvbnRleHQgaXMgc3RvcHBlZCJfcyB9Owot ICAgIGRlZmF1bHQ6Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICByZXR1 cm4gRXhjZXB0aW9uIHsgVHlwZUVycm9yLCAiQ29ubmVjdGlvbiBzdG9wcGVkIl9zIH07Ci0gICAg fQotfQotCitFeGNlcHRpb24gY29udmVydFRvRXhjZXB0aW9uKEVycm9yKTsKIEV4Y2VwdGlvbiBj b252ZXJ0VG9FeGNlcHRpb25BbmRMb2coU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIEVycm9yKTsK IAogV0VCQ09SRV9FWFBPUlQgYm9vbCBxdWVyeUNhY2hlTWF0Y2goY29uc3QgUmVzb3VyY2VSZXF1 ZXN0JiByZXF1ZXN0LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIGNhY2hlZFJlcXVlc3QsIGNvbnN0 IFJlc291cmNlUmVzcG9uc2UmLCBjb25zdCBDYWNoZVF1ZXJ5T3B0aW9ucyYpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01DYWNoZVN0b3JhZ2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01DYWNoZVN0b3JhZ2UuY3BwCmluZGV4IGI1NDdj MzdlODY4OGE4Njc2NWE4MjgwYjkwNGU0OTc0YzUyYmI5MjMuLmI4ZmY0MWMyMzllYjNmODY5NmNi MWRhODE3OTEyYTdhNWQ2M2ZkNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv Y2FjaGUvRE9NQ2FjaGVTdG9yYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2Nh Y2hlL0RPTUNhY2hlU3RvcmFnZS5jcHAKQEAgLTE1MSw3ICsxNTEsNyBAQCB2b2lkIERPTUNhY2hl U3RvcmFnZTo6cmV0cmlldmVDYWNoZXMoQ29tcGxldGlvbkhhbmRsZXI8dm9pZChPcHRpb25hbDxF eGNlcHRpb24+JgogCiAgICAgbV9jb25uZWN0aW9uLT5yZXRyaWV2ZUNhY2hlcygqb3JpZ2luLCBt X3VwZGF0ZUNvdW50ZXIsIFt0aGlzLCBjYWxsYmFjayA9IFdURk1vdmUoY2FsbGJhY2spLCBwZW5k aW5nQWN0aXZpdHkgPSBtYWtlUGVuZGluZ0FjdGl2aXR5KCp0aGlzKV0oQ2FjaGVJbmZvc09yRXJy b3ImJiByZXN1bHQpIG11dGFibGUgewogICAgICAgICBpZiAobV9pc1N0b3BwZWQpIHsKLSAgICAg ICAgICAgIGNhbGxiYWNrKERPTUNhY2hlRW5naW5lOjplcnJvclRvRXhjZXB0aW9uKERPTUNhY2hl RW5naW5lOjpFcnJvcjo6U3RvcHBlZCkpOworICAgICAgICAgICAgY2FsbGJhY2soRE9NQ2FjaGVF bmdpbmU6OmNvbnZlcnRUb0V4Y2VwdGlvbihET01DYWNoZUVuZ2luZTo6RXJyb3I6OlN0b3BwZWQp KTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogICAgICAgICBpZiAoIXJlc3VsdC5o YXNfdmFsdWUoKSkgewo=